The variable authmode can be uninitialized. The danger would be if
it equals to _WPA_IE_ID_ (0xdd) or _WPA2_IE_ID_ (0x33). We can avoid
this by setting it to zero instead. This is the approach that was
used in the rtl8723bs driver.
Fixes: 7b464c9fa5cc ("staging: r8188eu: Add files for new driver -
On Tue, Jul 28, 2020 at 03:00:10AM +0530, Ankit wrote:
> From: Ankit Baluni
You need a ' ' before the '<' character.
>
> Fixed a coding style issue.
Be more descriptive of what you are doing, this is vague.
>
> Signed-off-by: Ankit Baluni
Same here with the ' '.
thanks,
greg k-h
__
On Tue, Jul 28, 2020 at 01:53:30PM +0530, Ankit wrote:
> From: Ankit Baluni
>
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
>
> Signed-off-by: Ankit Baluni
>
> ---
> drivers/staging/media/
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next
branch HEAD: 908e757daecf2120c3019fa630ae5d4c3cd7165b Merge 5.8-rc7 into
staging-next
elapsed time: 1294m
configs tested: 48
configs skipped: 1
The following configs have been built successfully.
Mor
From: Ankit Baluni
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deleti
Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Ankit Baluni
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
Added extra description and added space before '<' in above lines.
drivers/staging/media/atomis
On 09.07.20 11:32, Martin Kepplinger wrote:
> hi linux-media people,
>
> TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?
>
>
> I try to use the camera on our librem5-devkit (imx8mq): I try to use
> only mainline drivers except for "mxc-mipi-csi2_yav" taken from
> linux-imx (
On Mon, 2020-07-27 at 07:59 -0700, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> Hi--
>
> On 7/27/20 1:30 AM, Christian Gromm wrote:
> > This patch adds the usb driver source file most_usb.c and
> > modifies the Makefile and
A few tiny nitpicks:
The subject should have the dma-mapping prefix, this doesn't
really touch the device core.
> - rc = of_dma_get_range(np, &dma_addr, &paddr, &size);
> + rc = of_dma_get_range(np, &map);
> + rc = PTR_ERR_OR_ZERO(map);
I don't think you need the PTR_ERR_OR_ZERO line
Drivers using legacy power management .suspen()/.resume() callbacks
have to manage PCI states and device's PM states themselves. They also
need to take care of standard configuration registers.
Switch to generic power management framework using a single
"struct dev_pm_ops" variable to take the unn
This patch is compile-tested only
Thanks
Vaibhav Gupta
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch removes the dependency to NET as it is no longer needed.
Signed-off-by: Christian Gromm
---
drivers/staging/most/usb/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/most/usb/Kconfig b/drivers/staging/most/usb/Kconfig
index 75dc25c..a47a973
As per eudyptula challenge task 10 I had to fix coding styles. Thus I
used checkpatch.pl script and fixed a chunk of warnings and few errors.
Signed-off-by: Dhiraj Sharma
---
.../staging/media/usbvision/usbvision-video.c | 91 +++
1 file changed, 52 insertions(+), 39 deletions(-)
No I didn't intent to. I have sent another version.
Thank you very much, Dan.
Juan Antonio Aldea-Armenteros
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jul 28, 2020 at 08:00:04PM +0530, Dhiraj Sharma wrote:
> As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> used checkpatch.pl script and fixed a chunk of warnings and few errors.
>
> Signed-off-by: Dhiraj Sharma
> ---
> .../staging/media/usbvision/usbvision-video.c
On Tue, Jul 28, 2020 at 08:00:04PM +0530, Dhiraj Sharma wrote:
> As per eudyptula challenge task 10 I had to fix coding styles.
That is not needed in a changelog text.
> Thus I
> used checkpatch.pl script and fixed a chunk of warnings and few errors.
Neither is this, please be specific about wha
On Fri, Jul 24, 2020 at 2:45 PM Jim Quinlan wrote:
>
> The new field 'dma_range_map' in struct device is used to facilitate the
> use of single or multiple offsets between mapping regions of cpu addrs and
> dma addrs. It subsumes the role of "dev->dma_pfn_offset" which was only
> capable of holdi
Hi Dhiraj,
On 28/07/2020 16:30, Dhiraj Sharma wrote:
> As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> used checkpatch.pl script and fixed a chunk of warnings and few errors.
As both drivers/staging/media/usbvision/Kconfig and .../TODO say, this
driver is deprecated and wi
Sorry, I didn't realize that I committed a mistake by not replying to
all. It was an accidental mistake which will not be committed in
future now.
>
> That is not needed in a changelog text.
>
Alright Sir.
> Neither is this, please be specific about what you have fixed. My bot
> should kick in
Sorry I had committed a mistake by not replying to all.
> Hi Dhiraj,
>
> On 28/07/2020 16:30, Dhiraj Sharma wrote:
> > As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> > used checkpatch.pl script and fixed a chunk of warnings and few errors.
>
> As both drivers/staging/media
On Tue, Jul 28, 2020 at 09:14:24PM +0530, Dhiraj Sharma wrote:
> Sorry, I didn't realize that I committed a mistake by not replying to
> all. It was an accidental mistake which will not be committed in
> future now.
>
> >
> > That is not needed in a changelog text.
> >
>
> Alright Sir.
>
> > Nei
> As the bot said, only do one type of thing per patch, and "fix all
> checkpatch errors/warnings" is not one type of thing.
So should I send a fresh patch with minimal fixes? instead of replying
to this mail with [PATCH 01]
___
devel mailing list
de...@
On Tue, Jul 28, 2020 at 10:13:22PM +0530, Dhiraj Sharma wrote:
> > As the bot said, only do one type of thing per patch, and "fix all
> > checkpatch errors/warnings" is not one type of thing.
>
> So should I send a fresh patch with minimal fixes? instead of replying
> to this mail with [PATCH 01]
Alright sorry, I will ignore this patch and will commit the new patch
in another file.
On Tue, Jul 28, 2020 at 10:28 PM Greg KH wrote:
>
> On Tue, Jul 28, 2020 at 10:13:22PM +0530, Dhiraj Sharma wrote:
> > > As the bot said, only do one type of thing per patch, and "fix all
> > > checkpatch erro
Hi Dhiraj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on staging/staging-testing soc/for-next v5.8-rc7
next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch
Thanks Jann, the change LGTM, one question on the repro scenario that
wasn't immediately obvious to me:
On Mon, Jul 27, 2020 at 2:04 PM Jann Horn wrote:
> - task B opens /dev/binder once, creating binder_proc instance P3
> - P3 calls P2 (via magic handle 0) with (void*)1 as argument (two-way
>
I ran checkpatch.pl script which reported a warning to use const keyword
on line 370.Therefore I made this change.
Signed-off-by: Dhiraj Sharma
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/stag
On Tue, Jul 28, 2020 at 11:29:35PM +0530, Dhiraj Sharma wrote:
> I ran checkpatch.pl script which reported a warning to use const keyword
> on line 370.Therefore I made this change.
>
> Signed-off-by: Dhiraj Sharma
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+)
Inside function ql_get_dump comment statement had a repition of word
"to" which I removed and checkpatch.pl ouputs zero error or warnings
now.
Signed-off-by: Dhiraj Sharma
---
drivers/staging/qlge/qlge_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge
Alright, I have understood now that I should not trust on
checkpatch.pl script fully but partially it is indeed helpful. Please
don't criticize this script, it was my fault instead.
Before submitting code changes I would test them all, sorry for
wasting your time please ignore this patch changes n
Thanks a lot for the detailed explanation, I understood now.
Martijn
On Tue, Jul 28, 2020 at 4:50 PM Jann Horn wrote:
>
> On Tue, Jul 28, 2020 at 3:50 PM Martijn Coenen wrote:
> > On Mon, Jul 27, 2020 at 2:04 PM Jann Horn wrote:
> > > - task B opens /dev/binder once, creating binder_proc inst
On Sun, Jul 26, 2020 at 11:45 PM Aditya Jain
wrote:
>
> On Sun, Jul 26, 2020 at 10:45 PM Joe Perches wrote:
> >
> > On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote:
> > > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote:
> > > > Cleaning up messy multiline function declarations in hal
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-testing
branch HEAD: eea2c51f81df9df5123c042f07c7c6c33bf5fabb Merge 5.8-rc7 into
driver-core-next
elapsed time: 1776m
configs tested: 55
configs skipped: 1
The following configs have been built s
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/driv
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
branch HEAD: e82507d326d05747a5fdea6065e99f5332b63ecd debugfs: remove return
value of debugfs_create_devm_seqfile()
elapsed time: 1848m
configs tested: 48
configs skipped: 1
The following con
On Tue, Jul 28, 2020 at 11:05 AM Rob Herring wrote:
>
> On Fri, Jul 24, 2020 at 2:45 PM Jim Quinlan
> wrote:
> >
> > The new field 'dma_range_map' in struct device is used to facilitate the
> > use of single or multiple offsets between mapping regions of cpu addrs and
> > dma addrs. It subsumes
Hi Christoph,
On Tue, Jul 28, 2020 at 8:33 AM Christoph Hellwig wrote:
>
> A few tiny nitpicks:
>
> The subject should have the dma-mapping prefix, this doesn't
> really touch the device core.
>
> > - rc = of_dma_get_range(np, &dma_addr, &paddr, &size);
> > + rc = of_dma_get_range(np, &ma
On Tue, 2020-07-28 at 23:29 +0530, Dhiraj Sharma wrote:
> I ran checkpatch.pl script which reported a warning to use const keyword
> on line 370.Therefore I made this change.
checkpatch is a brainless script.
Not everything it suggests is appropriate.
> diff --git a/drivers/staging/android/ashmem
From: Ankit Baluni
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
Changes in v2:
-Added more description about the patch.
-Added space before the sy
Added a missing comma and changed 'it it useful' to 'it is useful'.
Signed-off-by: Ankit Baluni
---
drivers/staging/iio/Documentation/overview.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/Documentation/overview.txt
b/drivers/staging/iio/Documen
Hi Martin,
On Tue, Jul 28, 2020 at 12:36:58PM +0200, Martin Kepplinger wrote:
> On 09.07.20 11:32, Martin Kepplinger wrote:
> > hi linux-media people,
> >
> > TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?
> >
> >
> > I try to use the camera on our librem5-devkit (imx8mq):
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
branch HEAD: 11536442a3b4e1de6890ea5e805908debb74f94a Staging: rtl8188eu:
rtw_mlme: Fix uninitialized variable authmode
elapsed time: 1217m
configs tested: 48
configs skipped: 1
The following conf
Hello,
I know that I should ask for reviews etc after a week but the change
is for my eudyptula task and until it doesn't get merged little
penguin will not pass the task for me so please look at it.
Thank You
Dhiraj Sharma
On Tue, Jul 28, 2020 at 11:56 PM Dhiraj Sharma
wrote:
>
> Inside func
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
>
On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote:
> I started using devm_kcalloc() but at least two reviewers convinced me
> to just use kcalloc(). In addition, when I was using devm_kcalloc()
> it was awkward because 'dev' is not available to this function.
>
> It comes down to whethe
47 matches
Mail list logo
