[PATCH 1/2] staging: rtl8188eu: clear alignment style issues

2020-07-23 Thread Michael Straube
Clear checkpatch alignment style issues in rtl8188eu_recv.c. CHECK: Alignment should match open parenthesis The file is now checkpatch clean. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

[PATCH 2/2] staging: rtl8188eu: cleanup whitespace in declarations

2020-07-23 Thread Michael Straube
Replace tabs with spaces in declarations to cleanup whitespace in rtl8188eu_recv.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c b

Re: [PATCH] staging: octeon: Add the license identifier

2020-07-23 Thread Greg KH
On Wed, Jul 22, 2020 at 08:39:53PM +0500, Muhammad Usama Anjum wrote: > This patch fixes the checkpatch.pl warning: > WARNING: Missing or malformed SPDX-License-Identifier tag > > Add a the SPDX-License-Identifier tag on line 1 > > Signed-off-by: Muhammad Usama Anjum > --- > drivers/staging/oct

[PATCH] Staging: rtl8188eu: Fix a constant comparison coding style issue

2020-07-23 Thread Priti Chattopadhyay
Modify equality comparison involving constants by shifting the constant operand to the right side of the comparison as suggested by scripts/checkpatch.pl Signed-off-by: Priti Chattopadhyay --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH] staging: rtl8723bs: Cleanup open brace issues

2020-07-23 Thread Fox Chen
This cleans up open brace issues reported by checkpatch.pl Signed-off-by: Fox Chen --- .../staging/rtl8723bs/include/HalPwrSeqCmd.h | 6 +-- drivers/staging/rtl8723bs/include/HalVerDef.h | 18 +++ drivers/staging/rtl8723bs/include/drv_types.h | 6 +-- .../rtl8723bs/include/drv_types_sdio.

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-07-23 Thread Felipe Balbi
Nicolas Boichat writes: > trace_printk should not be used in production code, replace it > call with dev_dbg. > > Signed-off-by: Nicolas Boichat > > --- > > Unclear why a trace_printk was used in the first place, it's > possible that some rate-limiting is necessary here. > > drivers/usb/cdns3/g

[PATCH v2] staging: octeon: Indent with tabs instead of spaces

2020-07-23 Thread Muhammad Usama Anjum
Remove a coding style error. It makes code more readable. Signed-off-by: Muhammad Usama Anjum --- Changes in v2: - Aligned more lines with tabs drivers/staging/octeon/ethernet-defines.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/octeon/ether

[PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Rohit K Bharadwaj
Signed-off-by: Rohit K Bharadwaj --- drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..5d7b66719a39 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/stagi

Re: [PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Greg KH
On Thu, Jul 23, 2020 at 08:28:11PM +0530, Rohit K Bharadwaj wrote: > Signed-off-by: Rohit K Bharadwaj I can't take patches without any changelog text :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

[PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Rohit K Bharadwaj
changed usage of slave (deprecated) to secondary Signed-off-by: Rohit K Bharadwaj --- drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..5d7b66719a39 100644 ---

[PATCH] staging: unisys: visorhba: remove redundant initialization of variables scsicmd_id and rc

2020-07-23 Thread Colin King
From: Colin Ian King The variables scsicmd_id and rc is being initialized with a value that is never read and are being updated later with a new value. The initializations are redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/u

[PATCH] media: atomisp: Fix braces placement coding style errors

2020-07-23 Thread Aditya Jain
Fix braces placement errors as reported by checkpatch.pl Signed-off-by: Aditya Jain --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/ato

[PATCH v2] staging: octeon: Add the license identifier

2020-07-23 Thread Muhammad Usama Anjum
This patch fixes the checkpatch.pl warning: WARNING: Missing or malformed SPDX-License-Identifier tag Add a the SPDX-License-Identifier tag on line 1 Signed-off-by: Muhammad Usama Anjum --- Other files in this folder have GPL-2.0 license. So this file should have the same license which was missi

Re: [PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Greg KH
On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote: > changed usage of slave (deprecated) to secondary > > Signed-off-by: Rohit K Bharadwaj > --- > drivers/staging/nvec/nvec.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Odd subject line, you should follow

Re: [PATCH v2] staging: octeon: Add the license identifier

2020-07-23 Thread Greg KH
On Thu, Jul 23, 2020 at 09:31:50PM +0500, Muhammad Usama Anjum wrote: > This patch fixes the checkpatch.pl warning: > WARNING: Missing or malformed SPDX-License-Identifier tag > > Add a the SPDX-License-Identifier tag on line 1 > > Signed-off-by: Muhammad Usama Anjum > --- > Other files in this

[PATCH v3] staging: octeon: Add the license identifier

2020-07-23 Thread Muhammad Usama Anjum
This patch fixes the checkpatch.pl warning: WARNING: Missing or malformed SPDX-License-Identifier tag Add a the SPDX-License-Identifier tag on line 1 Other files in this folder have GPL-2.0 license. So this file should have the same license which was missing before and checkpatch.pl was giving th

[PATCH] staging: comedi: adl: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master (Actually lett

[PATCH] staging: comedi: adv: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master (Actually lett

[PATCH] staging: comedi: cb: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master (Actually lett

[PATCH] staging: comedi: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master (Actually lett

[staging:staging-testing] BUILD SUCCESS 032ae2fd3ce12e8aa538165b44dc129c355a1ee1

2020-07-23 Thread kernel test robot
allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a003-20200723 i386 randconfig-a005-20200723 i386 randconfig-a004-20200723 i386

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-07-23 Thread Nicolas Boichat
On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi wrote: > > Nicolas Boichat writes: > > > trace_printk should not be used in production code, replace it > > call with dev_dbg. > > > > Signed-off-by: Nicolas Boichat > > > > --- > > > > Unclear why a trace_printk was used in the first place, it's > >

[PATCH v3] staging: nvec: change usage of slave to secondary

2020-07-23 Thread Rohit K Bharadwaj
changed usage of slave (deprecated) to secondary Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject, add version history v2: add changelog text in body of mail v1: fix style issues by changing usage of slave to secondary drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed,

Re: [PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Rohit Bharadwaj
On 23/07/20 10:36 pm, Greg KH wrote: > On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote: >> changed usage of slave (deprecated) to secondary >> >> Signed-off-by: Rohit K Bharadwaj >> --- >> drivers/staging/nvec/nvec.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 delet