writes:
> From: Ajay Singh
>
> This patch series is to review and move wilc1000 driver out of staging.
> Most of the review comments received in [1] & [2] are addressed in the
> latest code.
> Please review and provide your inputs.
>
> [1].
> https://lore.kernel.org/linux-wireless/1537957525-11
On Tue, 2020-06-23 at 11:00 +, ajay.kat...@microchip.com wrote:
>
> +struct wilc_p2p_pub_act_frame {
> + u8 category;
> + u8 action;
> + u8 oui[3];
> + u8 oui_type;
> + u8 oui_subtype;
> + u8 dialog_token;
> + u8 elem[];
> +} __packed;
> +
> +struct wilc_vendor_spec
On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
> writes:
>
> > From: Ajay Singh
> >
> > This patch series is to review and move wilc1000 driver out of staging.
> > Most of the review comments received in [1] & [2] are addressed in the
> > latest code.
> > Please review and provide y
On 23/06/20 8:22 pm, kernel test robot wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> Hi,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on a15a20acc980342c97d804c5fae1cfc0cd7712a9]
>
> url:
>
Greg KH writes:
> On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
>> writes:
>>
>> > From: Ajay Singh
>> >
>> > This patch series is to review and move wilc1000 driver out of staging.
>> > Most of the review comments received in [1] & [2] are addressed in the
>> > latest code.
>> >
On Tue, 2020-06-23 at 15:11 -0700, Joe Perches wrote:
> On Tue, 2020-06-23 at 18:41 +0200, Nicolas Saenz Julienne wrote:
> > From: Dave Stevenson
> >
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues".
> []
> > diff --git a/drivers/stagin
On 24/04/2020 21:56, Guilherme Ricioli wrote:
> Fix checkpatch error "ERROR: Macros with complex values should be
> enclosed in parentheses" in soc_camera.c:241.
>
> Signed-off-by: Guilherme Ricioli
> ---
> drivers/staging/media/soc_camera/soc_camera.c | 4 ++--
> 1 file changed, 2 insertions(+)
On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote:
> @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service)
>
> int32_t vchi_service_open(struct vchiq_instance *instance,
> struct service_creation *setup,
> - struct vchi_service_handle **handl
On Wed, 2020-06-24 at 17:11 +0300, Dan Carpenter wrote:
> On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote:
> > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service)
> >
> > int32_t vchi_service_open(struct vchiq_instance *instance,
> > struct ser
On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote:
> Greg KH writes:
>
> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
> >> writes:
> >>
> >> > From: Ajay Singh
> >> >
> >> > This patch series is to review and move wilc1000 driver out of staging.
> >> > Most of the rev
Runtime PM is always available on Tegra nowadays since commit 40b2bb1b132a
("ARM: tegra: enforce PM requirement"), hence the case of unavailable RPM
doesn't need to be handled.
Signed-off-by: Dmitry Osipenko
---
drivers/staging/media/tegra-vde/vde.c | 16
1 file changed, 16 dele
The RPM's use-count is getting incremented regardless of the
pm_runtime_get_sync() success or fail. It's up to a driver how to
handle the failed RPM. In the case of VDE driver, the RPM's use-count
should be restored if runtime-resume fails. Use pm_runtime_put_noidle(),
which is the most straight-fo
Hello,
This small series addresses a Runtime PM issue that was discovered during
of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
failure. Secondly it fixes reboot on some Tegra devices due to bootloader
expecting VDE power partition to be ON at the boot time, which wasn't
h
VDE partition is left turned ON after bootloader on most devices, hence
let's ensure that it's turned OFF in order to lower power leakage while
hardware is idling by turning it ON and OFF during of the driver's probe.
Signed-off-by: Dmitry Osipenko
---
drivers/staging/media/tegra-vde/vde.c | 8 +
On some devices bootloader isn't ready to a clamped VDE power, and thus,
machine hangs on a warm reboot (CPU reset). The VDE power partition is
turned ON by default on a cold boot, hence VDE driver should keep power
partition enabled on system's reboot too. This fixes hang on a warm reboot
on a Teg
On 24/06/2020 17:08, Dmitry Osipenko wrote:
> Hello,
>
> This small series addresses a Runtime PM issue that was discovered during
> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
> failure. Secondly it fixes reboot on some Tegra devices due to bootloader
> expecting VDE p
24.06.2020 18:16, Hans Verkuil пишет:
> On 24/06/2020 17:08, Dmitry Osipenko wrote:
>> Hello,
>>
>> This small series addresses a Runtime PM issue that was discovered during
>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
>> failure. Secondly it fixes reboot on some Tegra
Fix "Alignment should match open parenthesis" issues reported by
checkpatch.pl for all files under drivers/staging/rtl8188eu/core.
Line rtw_mlme_ext.c:373 is left overlength for readability.
Signed-off-by: Peilin Ye
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 +--
drivers/staging/rt
Signed-off-by: Garrit Franke
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
ind
Hi Dan,
thanks for your review. Yes, this is supposed to be a cleanup. I didn't
make that clear. I removed the unnecessary parentheses, as suggested.
Regards,
Garrit Franke
Garrit Franke (2):
staging: vc04_services: vchiq_arm: replace bitshift with BIT macro
staging: vc04_services: vchiq_arm
This should prevent possible overflowing bits by using the BIT macro in
vchiq_core
Signed-off-by: Garrit Franke
---
.../interface/vchiq_arm/vchiq_core.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
21 matches
Mail list logo
