On Fri, Apr 17, 2020 at 05:00:13PM +0200, Daniel Vetter wrote:
> > No one ever notices "depreciated" things, they only notice if the code
> > is no longer there :)
> >
> > So I'm all for just deleting it and seeing who even notices...
>
> +1 on just deleting ion and watching if anyone notices. In
On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote:
> > On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote:
> > > > Only sync the sg-list
On 20/04/2020 06:44, Xiyu Yang wrote:
comedi_open() invokes comedi_dev_get_from_minor(), which returns a
reference of the COMEDI device to "dev" with increased refcount.
When comedi_open() returns, "dev" becomes invalid, so the refcount
should be decreased to keep refcount balanced.
The referen
Hello,
My name is Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum"
also "Minister of State for International Cooperation" in UAE. Kindly visit
this link for more understanding: https://en.wikipedia.org/wiki/Reem_Al_Hashimi
I write to solicit for your partnership in claiming o
Where is patch 1/2?
On Sun, Apr 19, 2020 at 10:21:22AM +0200, carlosteniswarr...@gmail.com wrote:
> From: porfavorde
^^
Fix your name.
>
> Fixed a checkpatch.pl warning: the constant should be in
> the right side of the comparison.
>
> Signed-off-by: porfavorde
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Sun, Apr 19, 2020 at 12:09:21PM +0200, Oscar Carter wrote:
> - for (i = RATE_11M;; i--) {
> - if (priv->basic_rates & (u16)(1 << i)) {
> - top_cck = i;
> - break;
> - }
> - if (i == RATE_1M)
> - b
On Mon, Apr 20, 2020 at 08:37:55PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
> correct pointer type argument for sizeof
>
> Signed-off-by: Jason Yan
> ---
> drivers/staging/mt7621-pinctrl/pinctrl-r
在 2020/4/20 20:19, Dan Carpenter 写道:
On Mon, Apr 20, 2020 at 08:37:55PM +0800, Jason Yan wrote:
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/stagi
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Mon, Apr 20, 2020 at 08:41:51PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
> correct pointer type argument for sizeof
>
> Signed-off-by: Jason Yan
> ---
> drivers/staging/mt7621-pinctrl/pinctrl-r
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
v2->v3: Add this description of v1->v2.
v1->v2: Use sizeof(*p->func) instead of sizeof(struct rt2880_pmx_func *)
在 2020/4/20 21:07, Greg KH 写道:
On Mon, Apr 20, 2020 at 08:41:51PM +0800, Jason Yan wrote:
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/staging/mt7
On Mon, Apr 20, 2020 at 03:10:59PM +0300, Dan Carpenter wrote:
> On Sun, Apr 19, 2020 at 12:09:21PM +0200, Oscar Carter wrote:
> > - for (i = RATE_11M;; i--) {
> > - if (priv->basic_rates & (u16)(1 << i)) {
> > - top_cck = i;
> > - break;
> > -
Replace the for loops of the vnt_update_top_rates function by the fls
function.
The purpose of the two for loops is to find the most significant bit set
in a range of bits. So, they can be replace by the fls function (find
last set) with a previous mask to define the range.
This way avoid the ite
From: Jérôme Pouiller
The callers of wfx_do_unjoin() already take care of vif state.
Therefore, it is not necessary to take care of the status of the
interface.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging
From: Jérôme Pouiller
Until now, the driver handled itself the connection loss. This series
allows to use ieee80211_beacon_loss() instead (patch 2/16). This change
allow a bunch of simplifications in many parts of the driver (most of
the patches 3 to 16). In particular it allows to drop the infam
BMW LOTTERY DEPARTMENT
610 North Main Street,Culpeper Virginia 22701 USA.
NOTE: If you received this message in your SPAM/JUNK folder, that is because of
the restrictions implemented by your Internet Service Provider, we (BMW) urge
you to treat it genuinely.
This is to inform you that you have b
From: Jérôme Pouiller
Dual CTS is only necessary when sending/receiving STBC data. However,
the chip does not support STBC, so it is never necessary to enable
double CTS.
We can simplify the code.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_mib.h | 6 --
drivers/stagin
From: Jérôme Pouiller
In wfx_remove_interface(), the current code differentiate AP and Station
cases. However, it is not necessary. In all cases, the only important
thing is the call to hif_reset(). We can use the same code to support
all cases.
Signed-off-by: Jérôme Pouiller
---
drivers/stagi
From: Jérôme Pouiller
Since wfx_bss_params_work() does not exist anymore, there is no more
reason to keep a copy of bss_params in struct wfx_dev. A local instance
in wfx_join_finalize() is sufficient.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 14 ++
drivers/sta
From: Jérôme Pouiller
In former code (before the inclusion of the driver in mainline kernel),
hif_join() could run asynchronously. When a join request was in
progress, it was forbidden to launch hif_scan().
Now, hif_join() is always run synchronously. There is no more reasons to
keep a protectio
From: Jérôme Pouiller
Keys sent to the firmware are never reset. So, it is not necessary to
re-upload them after hif_reset(). Thus, it is no more necessary to keep
a copy of the keys in struct wfx_dev.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/key.c | 58 ++
From: Jérôme Pouiller
Currently, events from firmware are handled in a work queue with a
complex event queue mechanism. It is probably overkill since there is
only two events to handle: bss_loss and CQM events. Handling these
events synchronously is sufficient.
Signed-off-by: Jérôme Pouiller
--
From: Jérôme Pouiller
The structure hif_req_set_bss_params come from hardware API. It is not
intended to be manipulated in upper layers of the driver.
In add, current code for hif_req_set_bss_params() is too dumb. It should
pack data with hardware representation instead of leaving all work to
th
From: Jérôme Pouiller
Basic Rates are already set by hif_join(). hif_join() is also able to
manage possible changes after association.
Firmware also allows to change the Basic Rates with
hif_set_association_mode() but it does not bring anything in our case.
Signed-off-by: Jérôme Pouiller
---
From: Jérôme Pouiller
In former code, the field wvif->state was more or less redundant with
vif->type. With the lasts change it has become unused. It is now time to
drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 13 -
drivers/staging/wfx/sta.h | 8
From: Jérôme Pouiller
Firmware dislikes the driver enables PS when it is not yet associated.
The current check for that condition is more complex than necessary.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
On Wed, Apr 15, 2020 at 06:25:41PM +0200, Oscar Carter wrote:
> On Tue, Apr 14, 2020 at 04:12:14PM +0300, Dan Carpenter wrote:
> > On Mon, Apr 13, 2020 at 04:02:09PM +0200, Oscar Carter wrote:
> > > diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> > > index 4f9aba0f21b0..3b2
From: Jérôme Pouiller
The field bss_params.operational_rate_set is ignore by the firmware. It
is not necessary to send it. This change greatly simplify
wfx_join_finalize(). It is no more necessary to get sta and it allow to
save a RCU.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta
From: Jérôme Pouiller
Current code skip some configuration during joining an IBSS network.
Indeed, it seems that this configuration is not used in IBSS. However,
it would be harmless to set them. In add, we would prefer to keep
association processes for ad-hoc and managed networks the closest as
From: Jérôme Pouiller
The field join_complete_status is never read. Drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 --
drivers/staging/wfx/wfx.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 1e43e3b6
From: Jérôme Pouiller
The firmware is able to filter beacons and send a notification if one or
multiple beacons are not received. Note that it send this notification
only once. Only if it receive beacons gain, it send a new notification.
Currently, the driver handle the connection loss itself (s
From: Jérôme Pouiller
Currently code handle WEP keys manually. It is far easier to use
the set_default_unicast_key() callback provided by mac80211.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/key.c | 10 --
drivers/staging/wfx/key.h | 1 -
drivers/staging/wfx/main.c |
building it with a random config causes a warning:
WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] &&
(ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n]
Selected by [y]:
- VIDEO_ROCKCHIP_ISP1 [=y] &&
When built with:
CONFIG_USB=m
CONFIG_VIDEO_USBVISION=y
It causes ld errors:
ld: drivers/staging/media/usbvision/usbvision-core.o: in function
`usbvision_write_reg_irq':
usbvision-core.c:(.text+0x8a4): undefined reference to `usb_submit_urb'
ld: drivers/staging/media/usbvision/usb
On 4/20/20 9:45 AM, Mauro Carvalho Chehab wrote:
> building it with a random config causes a warning:
>
> WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] &&
> (ARCH_ROCKCHIP || COMPILE_TEST [=y]) &&
On 4/20/20 9:50 AM, Mauro Carvalho Chehab wrote:
> When built with:
> CONFIG_USB=m
> CONFIG_VIDEO_USBVISION=y
>
> It causes ld errors:
>
> ld: drivers/staging/media/usbvision/usbvision-core.o: in function
> `usbvision_write_reg_irq':
> usbvision-core.c:(.text+0x8a4): undefined refere
On Mon, Apr 20, 2020 at 10:41:28AM -0700, Randy Dunlap wrote:
> On 4/20/20 9:50 AM, Mauro Carvalho Chehab wrote:
> > When built with:
> > CONFIG_USB=m
> > CONFIG_VIDEO_USBVISION=y
> >
> > It causes ld errors:
> >
> > ld: drivers/staging/media/usbvision/usbvision-core.o: in function
> > `
On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner
wrote:
> On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote:
> > > But I do think we can mark it as deprecated and let folks know that
> > > around the end of the year
drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function HalRxAggr8723BSdio:
drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
pregistrypriv set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/rtl8723bs/hal/sd
Hi Mauro, Randy,
On Mon, 20 Apr 2020 at 13:45, Mauro Carvalho Chehab
wrote:
>
> building it with a random config causes a warning:
>
> WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] &&
> (ARCH_ROC
42 matches
Mail list logo
