Hi Chen Zhou,
Thanks for the patch.
On Wed, Apr 01, 2020 at 11:00:17AM +0800, Chen Zhou wrote:
> In gb_lights_light_config(), 'light->name' is allocated by kstrndup().
> It returns NULL when fails, add check for it.
>
> Signed-off-by: Chen Zhou
Acked-by: Rui Miguel Silva
--
Cheers,
R
On Sun, 2020-03-29 at 14:44 +0200, Stefan Wahren wrote:
> Except of patch 2 all these patches tries to clean up the bcm2835-camera
> driver.
>
> Stefan Wahren (9):
> staging: bcm2835-camera: Drop PREVIEW_LAYER
> staging: bcm2835-camera: Activate V4L2_EXPOSURE_METERING_MATRIX
> handling
>
On Wed, Mar 25, 2020 at 04:36:31PM -0300, Helen Koike wrote:
> Hello,
>
> On 3/25/20 1:03 PM, Mauro Carvalho Chehab wrote:
> > That's the second part of media Kconfig changes. The entire series is
> > at:
> >
> > https://git.linuxtv.org/mchehab/experimental.git/log/?h=media-kconfig
>
> I mad
From: Jérôme Pouiller
When a new tx_policy has to be uploaded, it is necessary to avoid any
race between the frame and the policy. So, the driver stops the tx queue
during tx_policy upload. However, it is not necessary to stop mac80211
queuing.
Signed-off-by: Jérôme Pouiller
---
drivers/stagin
From: Jérôme Pouiller
Currently, the driver tracks power save state of the stations with the
variable sta_asleep_mask. Then, it takes care to not sent data to asleep
stations.
However, this work is already done by mac80211. Normally, there are no
frames for asleep stations in our queues. So, dri
From: Jérôme Pouiller
It is not necessary to return a skb. Just getting the information if
there is traffic to be sent after DTIM is sufficient.
In add, the acronym "cab" (Content After (DTIM) Beacon) is used in
mac80211 to designate this kind of traffic.
So, make wfx_tx_queues_get_after_dtim()
From: Jérôme Pouiller
Currently, wfx_pending_remove() (from queue.c) call wfx_skb_dtor()
(from data_tx.c) that forward the tx status to mac80211.
Moreover, there no purpose to retrieve a frame from the pending queue
without dequeuing it. So, the main purpose of wfx_pending_remove() is to
forward
From: Jérôme Pouiller
It is not used anymore.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 5 -
drivers/staging/wfx/data_tx.h | 1 -
drivers/staging/wfx/queue.h | 2 --
3 files changed, 8 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx
From: Jérôme Pouiller
Current code contains a weird hack to avoid switch from 54Mbps CTS to
1Mbps. However, we have not been able to reproduce the problem and
hardware team don't know any defect of this kind. So, it seems this hack
is no more necessary.
Signed-off-by: Jérôme Pouiller
---
drive
From: Jérôme Pouiller
raw_link_id can be retrieved by wfx_tx_get_raw_link_id(). So, it is not
necessary to keep it in struct wfx_tx_priv.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3 +--
drivers/staging/wfx/data_tx.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(
From: Jérôme Pouiller
There is no reason to keep the intermediate struct wfx_queue_stats.
Relocate its members to struct wfx_dev.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 36 +++-
drivers/staging/wfx/queue.h | 5 -
drivers/staging/wf
From: Jérôme Pouiller
The last argument of hif_handle_tx_data() was now unused. In add,
hif_handle_tx_data() has nothing to do with HIF layer and should be
renamed. Finally, it not convenient to pass a wfx_vif as parameter. It
is easier to let hif_handle_tx_data() find the interface itself.
Sign
From: Jérôme Pouiller
Following the remove of asleep_mask, the tx_allowed_mask argument passed
to various functions is now always the same. Drop this argument and
simplify the code.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 48 +
drive
From: Jérôme Pouiller
The current code computes itself the QoS policy to choose which frame
should be sent. However, firmware already do that job. Firmware would
prefer to have packets in every queues and be able to choose itself
which queue to use.
So, this patch sort the queues from the emptie
From: Jérôme Pouiller
Since concept of "raw_link_id" does not exist anymore, rename
wfx_tx_get_raw_link_id() in wfx_tx_get_link_id().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/
From: Jérôme Pouiller
This counter will be useful to know which queue is least full in a
further patch.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 15 +++
drivers/staging/wfx/queue.h | 2 ++
2 files changed, 17 insertions(+)
diff --git a/drivers/staging/wfx/
From: Jérôme Pouiller
wfx_flush() exited once all frames are retrieved from the device.
However, it did not ensure they were processed by driver before to
return. Therefore, some frame may be processed after the interface has
disappear.
Change the place we signal that the queue is empty to fix t
From: Jérôme Pouiller
__wfx_flush() wait for all queues to be empty. In current code,
wait_link_id_empty is wake up each time there is no more data for a
station. We can simplify the processing and avoid some wake-up by
raising this event only when the queue is empty.
Signed-off-by: Jérôme Pouil
From: Jérôme Pouiller
Until now, wfx_flush() flushed queue for while device instead of only
the queue of the intended vif. It sometime failed with a timeout, but
this error was not reported.
Moreover, if the device was frozen, wfx_flush didn't do anything and it
results a potential warning (and
From: Jérôme Pouiller
The queue used for wfx_tx_queue_put() can be deducted from the content
of the skb. So drop this parameter from call to wfx_tx_queues_put().
In add, this change uniformizes usage of functions wfx_tx_queues_*.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.
From: Jérôme Pouiller
Since we do not rely in QoS parameters to choose which frame to send, it
is no more necessary to keep a copy of EDCA parameters.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 1 -
drivers/staging/wfx/wfx.h | 1 -
2 files changed, 2 deletions(-)
diff --gi
From: Jérôme Pouiller
In a next commit, we would like to mark wfx_skb_dtor as static and stop
to declare it in data_tx.h.
Relocate wfx_skb_dtor() prior its callers to avoid compile error.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 72 ++-
From: Jérôme Pouiller
When driver has Content After DTIM Beacon (CAB) in queue, it wait for an
indication from the firmware. However, when we stop to send beacons,
this indication may never happen.
Solve this issue by simply simulate this indication. Firmware will send
data that probably nobody
From: Jérôme Pouiller
Thanks to skb_queue_empty_lockless(), it is not necessary to acquire the
spin_lock before to check if the queue is empty.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 16 +---
drivers/staging/wfx/queue.h | 2 +-
drivers/staging/wfx/sta.c
From: Jérôme Pouiller
The field queue_id is no more used.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 4 +---
drivers/staging/wfx/queue.h | 1 -
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
index 71
From: Jérôme Pouiller
This current implementation of the Tx queue is far more complex than
necessary and its behavior is dubious on some corner cases. This series
rework the Tx queue:
- Simplify support for QoS (since device already do the job)
- Simplify support for Power Saving stations (si
From: Jérôme Pouiller
tx_info->hw_queue contains "vif.hw_queue[skb_get_queue_mapping(skb)]".
For now, it is equivalent of "skb_get_queue_mapping(skb)". However, it
is not the same semantic. In wfx_tx_inner(), we want to get the mac80211
queue index, not the hardware queue index.
Signed-off-by: J
From: Jérôme Pouiller
In the old days, the driver tried to reorder frames in order to send
frames from the same queue grouped to the firmware. However, the
firmware is able to do the job internally for a long time. There is no
reasons to keep this mechanism.
Signed-off-by: Jérôme Pouiller
---
From: Jérôme Pouiller
Instead of maintaining stop status for each queue, we can just maintain
a global status for all queues.
In add, wfx_tx_queues_{lock/unlock} are only used when no more
tx_policies are available. Therefore, the counter of recursive locks
("tx_locked_cnt") is useless.
So, wfx
From: Jérôme Pouiller
wfx_tx_flush() wait there are no more frame in device buffer. However,
this event may never happens since wfx_tx_flush() don't forbid to
enqueue new frames.
Note that wfx_tx_flush() should only ensure that all frames currently in
hardware queues are sent. So the current cod
From: Jérôme Pouiller
Add a few check on start of hif_join().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index 77bca43aca42..445906035e9d 100644
--- a/drivers/
From: Jérôme Pouiller
Since we do not track power save status of the stations anymore,
link_map_cache is now only used to track "Content After (DTIM) Beacon".
We prefer to rely on flags from tx_info. So we will be able to drop
link_map_cache.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/
From: Jérôme Pouiller
The argument "total" is not used anymore since commit a3c529a83589
("staging: wfx: simplify handling of IEEE80211_TX_CTL_SEND_AFTER_DTIM").
Fixes: a3c529a83589 ("staging: wfx: simplify handling of
IEEE80211_TX_CTL_SEND_AFTER_DTIM")
Signed-off-by: Jérôme Pouiller
---
driv
From: Jérôme Pouiller
It is far simpler to return a pointer instead of an error. Thus, it is
no more necessary to pass a pointer reference as argument.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --g
From: Jérôme Pouiller
link_id was expected to contain identifier of a station. It was also
used to mark frames that has to sent after dtim. We do not use the
further purpose. For the last purpose, we can directly check the flag
value in tx_info.
Signed-off-by: Jérôme Pouiller
---
drivers/stagi
From: Jérôme Pouiller
Driver does not use link_map_cache anymore. So we can drop it. In add,
we do not have to keep this counter in sync with skb_queue item, so we
can drop explicit spin_locks.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 60
This change adds the iio_device_attach_kfifo_buffer() helper/short-hand,
which groups the simple routine of allocating a kfifo buffers via
devm_iio_kfifo_allocate() and calling iio_device_attach_buffer().
The mode_flags parameter is required. The setup_ops parameter is optional.
This function wil
This driver calls iio_kfifo_allocate() vs devm_iio_kfifo_allocate(). But
the conversion is still simpler here, and cleans-up/reduces some error
paths.
Signed-off-by: Alexandru Ardelean
---
.../staging/iio/impedance-analyzer/ad5933.c | 28 ---
1 file changed, 5 insertions(+), 23
All drivers that already call devm_iio_kfifo_allocate() &
iio_device_attach_buffer() are simple to convert to
iio_device_attach_kfifo_buffer() in a single go/patch/.
This change does that.
For drivers max30100 & max30102 this helper is called after indio_dev has
been populated. This doesn't make
On Tue, Mar 31, 2020 at 01:41:30PM +0300, Dan Carpenter wrote:
> On Thu, Mar 26, 2020 at 06:10:43PM +0100, Oscar Carter wrote:
> > I will make these changes and i will send and incremental patch with the
> > "Fixes:" tag due to the this patch has already been added to the
> > staging-next
> > bran
On Mon, Mar 30, 2020 at 02:27:14PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Mar 27, 2020 at 05:58:02PM +0100, Oscar Carter wrote:
> > Define the EnCFG_BBType_MASK bit as an OR operation between two previous
> > defines instead of using the OR between two new BIT macros. Thus, the
> > code is more
Dear friend.
It's my pleasure to have contact with you, based on the critical
condition I find myself, though, it's not financial problem, but my
health, you might have know that cancer is not what to talk about at
home I have been in the hospital for 5 months now I am married to Mr.
Abaulkarim B
On Tue, Mar 31, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter wrote:
> > Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0
> > registers to can use them in the calls to vnt_mac_reg_bits_on and
> > vnt_mac_reg_bits_off function
Dear Sir,
I am from a UK Based Investment Group. We are expanding our global presence by
investing in viable projects across the globe. We will be willing to inject
from $3,000,000 to $250 million and more in a viable project(s)
We grant our funding at a 3% ROI per annum for 10 years and 12 mon
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Signed-off-by: Helen Koike
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename {drivers/staging/media/rkisp1/Documentation =>
Documentation}/devicetree/
From: Shunqian Zheng
RK3399 has two ISPs, but only ISP0 was tested at present.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-
Move the bindings out of drivers/staging and place them in
Documentation/devicetree/bindings instead.
Also, add DT nodes for RK3399 and verify with make ARCH=arm64 dtbs_check
Tested by verifying images streamed from RockPi 4 board with imx219
module.
Helen Koike (2):
dt-bindings: phy: phy-rock
From: Shunqian Zheng
Designware MIPI D-PHY, used for ISP0 in rk3399.
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen Koike
---
This patc
Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy
Signed-off-by: Helen Koike
---
.../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename {drivers/staging/media/phy-rockchip-dphy-rx0/Documentation =>
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
drivers/staging/android/ion/ion_page_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_page_pool.c
b/drivers/staging/android/ion/ion_page
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
drivers/staging/android/ion/ion_page_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_page_pool.c
b/drivers/staging/android/ion/ion_page
On Wed, 1 Apr 2020 18:25:15 -0700
"John B. Wyatt IV" wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
Reviewed-by: Stefano Brivio
--
Stefano
___
devel mailing list
de...@linuxdriverpro
Remove unused code surrounded by an #if 0 block.
Code has not been altered since 2014 as reported by git blame.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
drivers/staging/emxx_udc/emxx_udc.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
in
Cache long enums as local variables to fit under 80 characters. Fix a
comment character limit warning. The goal is to comply with the kernel
style guide. All style issues were identified by checkpatch.
John B. Wyatt IV (2):
staging: gasket: Fix 4 over 80 char warnings
staging: gasket: Fix comm
Fix 75 character limit warning in comment reported by checkpatch.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
drivers/staging/gasket/apex_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c
b/drivers/staging/gask
Fix 4 over 80 char warnings by caching long enum values into local
variables.
All enums are only used once inside each function (and once inside
the entire file).
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
drivers/staging/gasket/apex_driver.c | 13 +
1 file changed
Buenos días
Os informamos que se encuentra abierto el plazo de inscripción para la
Convocatoria de Cursos Bonificables para empleados (ABRIL 2020).
Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación
2020 que disponen las empresas.
Dada la situación en la que nos e
On Wed, 2020-04-01 at 22:36 -0700, John B. Wyatt IV wrote:
> Fix 4 over 80 char warnings by caching long enum values into local
> variables.
>
> All enums are only used once inside each function (and once inside
> the entire file).
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
59 matches
Mail list logo
