Re: [PATCH] staging: vt6656: add error code handling to unused variable

On Sat, 28 Mar 2020, John B. Wyatt IV wrote: > Add error code handling to unused 'ret' variable that was never used. > Return an error code from functions called within vnt_radio_power_on. > > Issue reported by coccinelle (coccicheck). > > Suggested-by: Quentin Deslandes > Suggested-by: Stefan

[PATCH v2] staging: vt6656: add error code handling to unused variable

Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Signed-off-by: John B. Wyatt IV --- v2: Replace go

[PATCH v3] staging: vt6656: add error code handling to unused variable

Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Signed-off-by: John B. Wyatt IV --- v3: Forgot to

[PATCH] staging: fbtft: Replace udelay with preferred usleep_range

Fix style issue with usleep_range being reported as preferred over udelay. Issue reported by checkpatch. Please review. As written in Documentation/timers/timers-howto.rst udelay is the generally preferred API. hrtimers, as noted in the docs, may be too expensive for this short timer. Are the d

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Sun, 29 Mar 2020, John B. Wyatt IV wrote: > Fix style issue with usleep_range being reported as preferred over > udelay. > > Issue reported by checkpatch. > > Please review. > > As written in Documentation/timers/timers-howto.rst udelay is the > generally preferred API. hrtimers, as noted in

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote: > > On Sun, 29 Mar 2020, John B. Wyatt IV wrote: > > > Fix style issue with usleep_range being reported as preferred over > > udelay. > > > > Issue reported by checkpatch. > > > > Please review. > > > > As written in Documentation/timers/t

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Sun, 29 Mar 2020, John Wyatt wrote: > On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote: > > > > On Sun, 29 Mar 2020, John B. Wyatt IV wrote: > > > > > Fix style issue with usleep_range being reported as preferred over > > > udelay. > > > > > > Issue reported by checkpatch. > > > > > > P

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Sun, 29 Mar 2020, Soumyajit Deb wrote: > I had the same doubt the other day about the replacement of udelay() with > usleep_range(). The corresponding range for the single argument value of > udelay() is quite confusing as I couldn't decide the range. But as much as I > noticed checkpatch.pl

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote: > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > > I had the same doubt the other day about the replacement of udelay() with > > usleep_range(). The corresponding range for the single argument value of > > udelay() is quite confusing as I co

[PATCH] staging: rtl8188eu: refactor Efuse_GetCurrentSize()

Refactor while loop in Efuse_GetCurrentSize() to reduce indentation level and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 33 +++--- 1 file changed, 16 insertions(+), 17 deletions(-) diff --gi

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Sun, Mar 29, 2020 at 2:23 PM Sam Muhammed wrote: > On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote: > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > First of all, let's stop topposting. > > > I had the same doubt the other day about the replacement of udelay() with > > > usleep_range()

[PATCH 2/9] staging: bcm2835-camera: Activate V4L2_EXPOSURE_METERING_MATRIX handling

I don't see any reason to keep this TODO, so activate the V4L2_EXPOSURE_METERING_MATRIX handling. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vc04_service

[PATCH 7/9] staging: bcm2835-camera: return early in mmal_setup_components

We can reduce the indentation in mmal_setup_components further by returning early in error case. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 60 +++--- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/drivers/staging/vc04_s

[PATCH 9/9] staging: bcm2835-camera: reduce indentation in ctrl_set_image_effect

We can reduce the indentation in the loop by using continue in case the effect doesn't match. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/controls.c| 63 +++--- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/drivers/staging/vc04_serv

[PATCH 1/9] staging: bcm2835-camera: Drop PREVIEW_LAYER

This define is used only once. So drop the define and init the layer directly. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 2 +- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions

[PATCH 0/9] staging: bcm2835-camera: Clean up driver

Except of patch 2 all these patches tries to clean up the bcm2835-camera driver. Stefan Wahren (9): staging: bcm2835-camera: Drop PREVIEW_LAYER staging: bcm2835-camera: Activate V4L2_EXPOSURE_METERING_MATRIX handling staging: bcm2835-camera: Make struct indentation consistent staging:

[PATCH 4/9] staging: bcm2835-camera: Simplify set_framerate_params

This simplifies set_framerate_params and avoids the multiple assignment in one line by moving the fps_high handling out of the if statement. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions

[PATCH 8/9] staging: bcm2835-camera: reduce multiline statements

There are a lot of multiline statements which can be reduced. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 57 +- .../vc04_services/bcm2835-camera/controls.c| 3 +- 2 files changed, 23 insertions(+), 37 deletions(-) diff --gi

[PATCH 3/9] staging: bcm2835-camera: Make struct indentation consistent

The indentation of struct members wasn't consistent over the whole driver. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/bcm2835-camera.h | 60 +++--- .../vc04_services/bcm2835-camera/controls.c| 4 +- .../vc04_services/bcm2835-camera/mmal-common.h

[PATCH 6/9] staging: bcm2835-camera: Move video component setup in its own function

The function mmal_setup_components has to many indention levels. So move the setup code for video component in its own function. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 88 -- 1 file changed, 48 insertions(+), 40 deletions(-) dif

[PATCH 5/9] staging: bcm2835-camera: Move encode component setup in its own function

The function mmal_setup_components has to many indention levels. So move the setup code for encode component in its own function. Signed-off-by: Stefan Wahren --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 185 ++--- 1 file changed, 91 insertions(+), 94 deletions(-) di

Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/SandeshKenjanaAshok/staging-android-ashmem-Declared-file-operation-with-const-keyword/20200329-014353 bas

Re: mmotm 2020-03-28-22-17 uploaded (staging/octeon/)

On 3/28/20 10:18 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2020-03-28-22-17 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -

[PATCH v3 1/5] staging: rtl8712: fix checkpatch long-line warning

This patch fixes these two long-line checkpatch warnings in rtl871x_xmit.c: WARNING: line over 80 characters \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74: + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, WARNING: line over 80 characters \#79: FILE: dri

[PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements

Make several improvements to code style of rtl871x_xmit.c and rtl871x_xmit.h. v1 -> v2: changes * Break up single pach into patchset of small patches v2 -> v3 changes: * [PATCH 4/5]: Applied suggestions by Joe to improve overall code quality (thanks Joe!) Aiman Najjar (5): staging: rtl8712:

[PATCH v3 3/5] staging: rtl8712: fix checkpatch warnings

This patch fixes multiline dereference warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrptxmickey' 379: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:379: + psecuritypriv-> +

[PATCH v3 4/5] staging:rtl8712: code improvements to make_wlanhdr

1. Refactor make_wlanhdr to improve code style. 2. Use ether_addr_copy instead of memcpy to copy addresses. Suggested-by: Joe Perches Signed-off-by: Aiman Najjar --- drivers/staging/rtl8712/rtl871x_xmit.c | 123 - drivers/staging/rtl8712/rtl871x_xmit.h | 2 +- 2 files

[PATCH v3 2/5] staging: rtl8712: fix long-line checkpatch warning

This patch fixes the following warning in rtl871x_xmit.c: WARNING: line over 80 characters 130: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:130: + pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, Signed-off-by: Aiman Najjar --- drivers/staging/rtl8712/rtl87

[PATCH v3 5/5] staging: rtl8712:fix multiline derefernce warnings

This patch fixes remaining checkpatch warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->PrivacyKeyIndex' 636: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:636: + (u8)psecuritypriv-> +

[PATCH 01/01] staging: gasket: Fix incongruency in handling of sysfs entries creation

Fix incongruency in handling of sysfs entries creation. This issue could cause invalid memory accesses, by not properly detecting the end of the sysfs attributes array. Signed-off-by: Luis Mendes --- gasket_sysfs.c |3 +-- gasket_sysfs.h |4 2 files changed, 1 insertion(+), 6 delet

[PATCH] staging: uwb: Fix missing blank space coding style issue

This patch adds a blank space before the switch argument parenthesis to silence checkpatch.pl errors. Signed-off-by: Iulian Olaru --- drivers/staging/uwb/drp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/uwb/drp.c b/drivers/staging/uwb/drp.c index

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unnecessary braces for single statements

On Wed, 25 Mar 2020 19:32:45 +0530 Simran Singhal wrote: > Clean up unnecessary braces around single statement blocks. > Issues reported by checkpatch.pl as: > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Simran Singhal > --- > drivers/staging/rtl8723bs/c

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove multiple assignments

On Wed, 25 Mar 2020 19:52:26 +0530 Simran Singhal wrote: > Remove multiple assignments by factorizing them. > Problem found using checkpatch.pl:- > CHECK: multiple assignments should be avoided > > Signed-off-by: Simran Singhal > --- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +-- > 1

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Add line after variable declarations

Hi Simran, On Wed, 25 Mar 2020 22:14:52 +0530 Simran Singhal wrote: > Add whiteline after variable declarations to remove the checkpatch.pl > warning: > WARNING: Missing a blank line after declarations > > Signed-off-by: Simran Singhal Sorry for the late review. This patch introduces similar

Re: [Outreachy kernel] [PATCH v2] Staging: rtl8188eu: hal: Add space around operators

On Wed, 25 Mar 2020 21:31:42 +0530 Shreeya Patel wrote: > Add space around operators for improving the code > readability. > Reported by checkpatch.pl > > git diff -w shows no difference. > diff of the .o files before and after the changes shows no difference. > > Signed-off-by: Shreeya Patel

Reply For More Details.

-- My dear, I am Mrs Maryalice Williams, I want to send you donation of two million seven hundred thousand Dollars ($2.7M) for volunteer projects in your country due to my ill health that could not permit me. Kindly reply for more details, and also send me the following details, as per below, you

Re: mmotm 2020-03-28-22-17 uploaded (staging/octeon/)

Hi Randy, On Sun, 29 Mar 2020 09:12:31 -0700 Randy Dunlap wrote: > > On 3/28/20 10:18 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2020-03-28-22-17 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-o

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: rtw_efuse: Compress lines for immediate return

On Thu, 26 Mar 2020 02:24:18 +0530 Simran Singhal wrote: > Compress two lines into a single line if immediate return statement is found. Same as your patches for issues reported by checkpatch, I think you should post these ones as a patchset. -- Stefano ___

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: rtw_cmd: Compress lines for immediate return

On Thu, 26 Mar 2020 02:52:53 +0530 Simran Singhal wrote: > Compress two lines into a single line if immediate return statement is found. > It also removes variable cmd_obj as it is no longer needed. > > It is done using script Coccinelle. This should be consistent. What does "it" refer to, now?