Dearly Beloved.

2020-03-28 Thread Mrs. Iris Stobbs
Dearly Beloved, Greeting to you. firstly, I got your email address from a mail directory and decided to mail you for a permission to go ahead. I am Mrs. Iris J. Stobbs from Sao Tome and Principe, I was married to late Mr. Patrick Stobbs the CEO of PATCAT Oil Mining & Exploration, I am 58 years ol

[PATCH] staging: vt6656: Use defines in vnt_mac_reg_bits_* functions

2020-03-28 Thread Oscar Carter
Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0 registers to can use them in the calls to vnt_mac_reg_bits_on and vnt_mac_reg_bits_off functions. In this way, avoid the use of BIT() macros and clarify the code. Fixes: 3017e587e368 ("staging: vt6656: Use BIT() macro in vnt_mac_reg_

[PATCH] staging: vt6656: Use defines in preamble_type variables

2020-03-28 Thread Oscar Carter
Use the PREAMBLE_SHORT and PREAMBLE_LONG defines present in the file "baseband.h" to assign values to preamble_type variables. Also, use the same defines to make comparisons against this variables. In this way, avoid the use of numerical literals or boolean values and make the code more clear. Si

[PATCH v2] staging: vt6656: Use defines in preamble_type variables

2020-03-28 Thread Oscar Carter
Use the PREAMBLE_SHORT and PREAMBLE_LONG defines present in the file "baseband.h" to assign values to preamble_type variables. Also, use the same defines to make comparisons against these variables. In this way, avoid the use of numerical literals or boolean values and make the code more clear. S

[PATCH] staging: android: ashmem: Declared file operation with const keyword

2020-03-28 Thread SandeshKenjanaAshok
Warning found by checkpatch.pl script. Signed-off-by: SandeshKenjanaAshok --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index 8044510d8ec6..fbb6ac9ba1ab 100644 --- a/dri

[PATCH v2 0/5] staging: rtl8712: fix rtl871x_xmit.c warnings

2020-03-28 Thread aimannajjar
This v2 of the patch breaks up the previous patch into a patchset of smaller patches. Overall, the patchset fixes the remaining 9 warnings in rtl871x_xmit.c. aimannajjar (5): staging: rtl8712: fix checkpatch long-line warning staging: rtl8712: fix long-line checkpatch warning staging: rtl87

[PATCH v2 3/5] staging: rtl8712: fix checkpatch warnings

2020-03-28 Thread aimannajjar
This patch fixes multiline dereference warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrptxmickey' 379: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:379: + psecuritypriv-> +

[PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning

2020-03-28 Thread aimannajjar
This patch fixes the following checkpatch warning in rtl8712x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psta->sta_xmitpriv.txseq_tid[pattrib->priority]' 544: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:544: + pattrib->seqnum = psta->sta_xmitpriv. +

[PATCH v2 1/5] staging: rtl8712: fix checkpatch long-line warning

2020-03-28 Thread aimannajjar
This patch fixes these two long-line checkpatch warnings in rtl871x_xmit.c: WARNING: line over 80 characters \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74: + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, WARNING: line over 80 characters \#79: FILE: dri

[PATCH v2 5/5] staging: rtl8712:fix multiline derefernce warnings

2020-03-28 Thread aimannajjar
This patch fixes remaining checkpatch warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->PrivacyKeyIndex' 636: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:636: + (u8)psecuritypriv-> +

[PATCH v2 2/5] staging: rtl8712: fix long-line checkpatch warning

2020-03-28 Thread aimannajjar
This patch fixes the following warning in rtl871x_xmit.c: WARNING: line over 80 characters 130: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:130: + pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, Signed-off-by: aimannajjar --- drivers/staging/rtl8712/rtl871

[PATCH] staging: vt6656: Refactor the vnt_update_pre_ed_threshold function

2020-03-28 Thread Oscar Carter
Create three arrays with the threshold data use in the switch statement of the vnt_update_pre_ed_threshold function. These three arrays contains elements of struct vnt_threshold new type. Create a for loop in the vnt_update_pre_ed_threshold function to do exactly the same that the if-elseif-else s

Re: [PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning

2020-03-28 Thread Joe Perches
On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote: > This patch fixes the following checkpatch warning in > rtl8712x_xmit.c: > > WARNING: Avoid multiple line dereference - prefer > 'psta->sta_xmitpriv.txseq_tid[pattrib->priority]' > 544: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:544: > +

Re: [PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning

2020-03-28 Thread Aiman Najjar
On Sat, Mar 28, 2020 at 12:17:19PM -0700, Joe Perches wrote: > On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote: > > This patch fixes the following checkpatch warning in > > rtl8712x_xmit.c: > > > > WARNING: Avoid multiple line dereference - prefer > > 'psta->sta_xmitpriv.txseq_tid[pattrib->p

[PATCH] staging: vt6656: add error code handling to unused variable

2020-03-28 Thread John B. Wyatt IV
Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Signed-off-by: John B. Wyatt IV --- drivers/stagi

Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

2020-03-28 Thread Greg Kroah-Hartman
On Sat, Mar 28, 2020 at 04:15:23PM +0100, SandeshKenjanaAshok wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: SandeshKenjanaAshok > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c