[PATCH] staging: wlan-ng: fix ODEBUG bug in prism2sta_disconnect_usb

2020-03-25 Thread Qiujun Huang
We should cancel hw->usb_work before kfree(hw). Reported-by: syzbot+6d2e7f6fa90e27be9...@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang --- drivers/staging/wlan-ng/prism2usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-n

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread Qiujun Huang
#syz test: https://github.com/google/kasan.git e17994d1 On Sat, Mar 21, 2020 at 3:28 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:e17994d1 usb: core: kcov: collect coverage from usb comple.. > git tree: https://github.com/google/kasan.git usb-fuzz

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in hfa384x_usbin_callback == BUG: KASAN: use-after-free in memcpy include/linux/string.h:381 [inline] BUG: KASAN: use-af

Re: [PATCH v2] staging: vt6656: Use ARRAY_SIZE instead of hardcoded size

2020-03-25 Thread Quentin Deslandes
On 03/24/20 16:18:30, Dan Carpenter wrote: > That's a bit over engineering something which is pretty trivial. > Normally, we would just make the size a define instead of a magic number > 14. My bad, I meant "define", not "macro". > If people change the size in the future (unlikely) and it causes

BUSINESS PROPOSAL !!!

2020-03-25 Thread Abdul Kareem
Dearest Friend I am Mr Abdul Kareem working with Emirate NBD Bank Dubai,United Arab Emirate as Finance Manager. I have a very profitable Business that relate to you and will benefit both of us after completion. Kindly get back to me for more details. Awaiting your response. Regards Abdul Kareem

[PATCH v2] staging: kpc2000: Removing a blank line

2020-03-25 Thread Simran Singhal
This patch fixes the checkpatch warning by removing a blank line. CHECK: Please don't use multiple blank lines Signed-off-by: Simran Singhal --- Changes in v2: - Make the subject and commit message correct by mentioning that this patch specifically removes a blank line. drivers/staging/kp

Re: [Outreachy kernel] [PATCH v2] staging: kpc2000: Removing a blank line

2020-03-25 Thread Julia Lawall
On Wed, 25 Mar 2020, Simran Singhal wrote: > This patch fixes the checkpatch warning by removing a blank > line. > CHECK: Please don't use multiple blank lines The subject line and the log message should be written in the imperative. So that would be Remove, rather than Removing for the subject l

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread Hillf Danton
On Wed, 25 Mar 2020 01:58:03 -0700 > syzbot has tested the proposed patch but the reproducer still triggered crash: > KASAN: use-after-free Read in hfa384x_usbin_callback > > == > BUG: KASAN: use-after-free in memcpy include/linux/s

Funds

2020-03-25 Thread Ms. Reem E Alhashimy
Hello, My name is Ms. Reem Al-Hashimi. I found your contact from an email database from your country while i was looking for someone to handle a huge financial transaction for me in confidence. Please reply for more details if you are interested. Regards, Ms. Reem Al-Hashimy

[PATCH] staging: rtl8723bs: Remove unnecessary braces for single statements

2020-03-25 Thread Simran Singhal
Clean up unnecessary braces around single statement blocks. Issues reported by checkpatch.pl as: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Simran Singhal --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletio

[PATCH] staging: rtl8723bs: Remove multiple assignments

2020-03-25 Thread Simran Singhal
Remove multiple assignments by factorizing them. Problem found using checkpatch.pl:- CHECK: multiple assignments should be avoided Signed-off-by: Simran Singhal --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging

Re: [PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter

2020-03-25 Thread Bastien Nocera
On Tue, 2020-03-24 at 20:35 +0300, Dan Carpenter wrote: > On Tue, Mar 24, 2020 at 04:21:47PM +0100, Bastien Nocera wrote: > > On Tue, 2020-03-24 at 16:20 +0100, Greg Kroah-Hartman wrote: > > > On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote: > > > > Make it possible to disable the LE

[Outreachy kernel] [PATCH v2] Staging: rtl8188eu: hal: Add space around operators

2020-03-25 Thread Shreeya Patel
Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~staging$ git diff -w drivers/staging/rtl8188eu

[PATCH 0/4] media Kconfig reorg - part 2

2020-03-25 Thread Mauro Carvalho Chehab
That's the second part of media Kconfig changes. The entire series is at: https://git.linuxtv.org/mchehab/experimental.git/log/?h=media-kconfig It addresses some issues I noticed when reviewing the series, and do some changes on how things will be displayed. It also simplify dependencenc

[PATCH 2/4] media: Kconfig files: use select for V4L2 subdevs and MC

2020-03-25 Thread Mauro Carvalho Chehab
There are lots of drivers that only work when the media controller and/or the V4L2 subdev APIs are present. Right now, someone need to first enable those APIs before using those drivers. Well, ideally, drivers, should, instead *optionally* depend on it, in order for PC camera drivers to be able t

[PATCH] staging: wilc1000: remove label from examples in DT binding documentation

2020-03-25 Thread Ajay.Kathat
From: Ajay Singh Remove labels and not relevant property from DT binding documentation examples as suggested in [1]. 1. https://patchwork.ozlabs.org/patch/1252837 Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/microchip,wilc1000.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 delet

[PATCH] staging: rtl8723bs: Add line after variable declarations

2020-03-25 Thread Simran Singhal
Add whiteline after variable declarations to remove the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Simran Singhal --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/rtl

[driver-core:driver-core-testing] BUILD SUCCESS be6ca6a7ec4c8d6dd9fe712a798d32a7c19cb04a

2020-03-25 Thread kbuild test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: be6ca6a7ec4c8d6dd9fe712a798d32a7c19cb04a nvmem: core: use device_register and device_unregister elapsed time: 1396m configs tested: 158 configs skipped: 0 The following confi

[PATCH] staging: rtl8723bs: Remove blank line before '}' brace

2020-03-25 Thread Simran Singhal
Remove unneeded blank line before a close brace '}'. Issue found by checkpatch.pl: CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Simran Singhal --- drivers/staging/rtl8723bs/core/rtw_security.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/stagi

Re: [PATCH 0/4] media Kconfig reorg - part 2

2020-03-25 Thread Helen Koike
Hello, On 3/25/20 1:03 PM, Mauro Carvalho Chehab wrote: > That's the second part of media Kconfig changes. The entire series is > at: > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=media-kconfig I made a quick experiment (using this branch) with someone who works with the ker

Please Help The needy

2020-03-25 Thread Ms. Reem
My name is Reem E. Al-Hashimi, the Emirates Minister of State and Managing Director of United Arab Emirates (Dubai) World Expo 2020 Committee. I am writing you to stand as my partner to receive my share of gratification from foreign companies whom I helped during the bidding exercise towards the

[PATCH] staging: rtl8723bs: rtw_efuse: Compress lines for immediate return

2020-03-25 Thread Simran Singhal
Compress two lines into a single line if immediate return statement is found. It is done using script Coccinelle. And coccinelle uses following semantic patch for this compression function: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; Signed-off-by: Simran Singha

[PATCH] staging: rtl8723bs: rtw_cmd: Compress lines for immediate return

2020-03-25 Thread Simran Singhal
Compress two lines into a single line if immediate return statement is found. It also removes variable cmd_obj as it is no longer needed. It is done using script Coccinelle. And coccinelle uses following semantic patch for this compression function: @@ expression ret; identifier f; @@ -ret = +re

Re: [PATCH 0/4] media Kconfig reorg - part 2

2020-03-25 Thread Mauro Carvalho Chehab
Em Wed, 25 Mar 2020 16:36:31 -0300 Helen Koike escreveu: > Hello, > > On 3/25/20 1:03 PM, Mauro Carvalho Chehab wrote: > > That's the second part of media Kconfig changes. The entire series is > > at: > > > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=media-kconfig > > I mad

[PATCH] staging: rtl8723bs: hal: Compress return logic

2020-03-25 Thread Simran Singhal
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Simran Singhal --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +--- 1 file changed, 1 i

[PATCH] staging: rtl8188eu: cleanup long line in odm.c

2020-03-25 Thread Michael Straube
Cleanup line over 80 characters by removing unnecessary parentheses. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index a6eb979

Re: [PATCH 0/4] media Kconfig reorg - part 2

2020-03-25 Thread Laurent Pinchart
Hi Mauro, On Wed, Mar 25, 2020 at 10:38:20PM +0100, Mauro Carvalho Chehab wrote: > Em Wed, 25 Mar 2020 16:36:31 -0300 Helen Koike escreveu: > > On 3/25/20 1:03 PM, Mauro Carvalho Chehab wrote: > > > That's the second part of media Kconfig changes. The entire series is > > > at: > > > > > > http

[PATCH] staging: rtl8723bs: Clean up tests if NULL returned on failure

2020-03-25 Thread Simran Singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: Simran Singhal --- driver

Please Help The needy

2020-03-25 Thread Ms. Reem
My name is Reem E. Al-Hashimi, the Emirates Minister of State and Managing Director of United Arab Emirates (Dubai) World Expo 2020 Committee. I am writing you to stand as my partner to receive my share of gratification from foreign companies whom I helped during the bidding exercise towards the

Re: [PATCH] staging: rtl8188eu: cleanup long line in odm.c

2020-03-25 Thread Joe Perches
On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote: > Cleanup line over 80 characters by removing unnecessary parentheses. [] > diff --git a/drivers/staging/rtl8188eu/hal/odm.c > b/drivers/staging/rtl8188eu/hal/odm.c [] > @@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_st

[driver-core:driver-core-next] BUILD SUCCESS c442a0d18744d4a5857d513f171d68ed6a54df5b

2020-03-25 Thread kbuild test robot
onfig-a002-20200324 x86_64 randconfig-a003-20200324 i386 randconfig-a001-20200324 i386 randconfig-a002-20200324 i386 randconfig-a003-20200324 x86_64 randconfig-a001-20200325 x86_64 randconfig-a002-20200

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread Qiujun Huang
On Wed, Mar 25, 2020 at 9:13 PM Hillf Danton wrote: > > > On Wed, 25 Mar 2020 01:58:03 -0700 > > syzbot has tested the proposed patch but the reproducer still triggered > > crash: > > KASAN: use-after-free Read in hfa384x_usbin_callback > > > >

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread Qiujun Huang
#syz test: https://github.com/google/kasan.git e17994d1 forgot to trigger:( On Thu, Mar 26, 2020 at 10:22 AM Qiujun Huang wrote: > > On Wed, Mar 25, 2020 at 9:13 PM Hillf Danton wrote: > > > > > > On Wed, 25 Mar 2020 01:58:03 -0700 > > > syzbot has tested the proposed patch but the reproducer

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+7d42d68643a35f71a...@syzkaller.appspotmail.com Tested on: commit: e17994d1 usb: core: kcov: collect coverage from usb comple.. git tree: https://github.com/google/k

[staging:staging-testing] BUILD SUCCESS f1a49bb9c8197170a1e3f645c4e73ec7fe7ddefb

2020-03-25 Thread kbuild test robot
fig x86_64 randconfig-a001-20200326 x86_64 randconfig-a002-20200326 x86_64 randconfig-a003-20200326 i386 randconfig-a001-20200326 i386 randconfig-a002-20200326 i386 randconfig-a003-20200326 alpharandconfig-a001-202

Re: KASAN: use-after-free Read in hfa384x_usbin_callback

2020-03-25 Thread Qiujun Huang
#syz test: https://github.com/google/kasan.git e17994d1 On Mon, Mar 23, 2020 at 8:39 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:e17994d1 usb: core: kcov: collect coverage from usb comple.. > git tree: https://github.com/google/kasan.git usb-fuzz