On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
> This helps to make code cleaner a tad.
Please don't start the commit message in the middle of a sentence.
It looks like this for some of us:
https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2
I generally read the subje
There are a few static checker warnings from Friday's linux-next. Only
the first one is important. (Not all these Smatch warnings have been
published).
drivers/staging/wilc1000/hif.c:804 wilc_hif_pack_sta_param() warn:
'¶ms->ht_capa' sometimes too small '8' size = 29
drivers/staging/wilc1000/h
If statement does not affect results when updating directory entry in
ffsMapCluster().
Signed-off-by: Tetsuhiro Kohada
---
drivers/staging/exfat/exfat_super.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/e
Clean up d_entry rebuilding in exfat_rename_file() and move_file().
-Replace memcpy of d_entry with structure copy.
-Change to use the value already stored in fid.
Signed-off-by: Tetsuhiro Kohada
---
drivers/staging/exfat/exfat_core.c | 25 ++---
1 file changed, 10 insertion
On Mon, 02 Mar 2020 18:57:15 +0900, Tetsuhiro Kohada said:
> Clean up d_entry rebuilding in exfat_rename_file() and move_file().
>
> -Replace memcpy of d_entry with structure copy.
Those look OK.
> -Change to use the value already stored in fid.
> - if (exfat_get_entry_type(epnew) ==
Hi Alex,
Thanks for your patch!
On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen
wrote:
> Not sure if all variants of the Salvator board have the HDMI decoder
> chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on
> Salvator-X ES1, so the the ADV7482 endpoint and connection definitions
Buenos días
Os informamos que se encuentra abierto el plazo de inscripción para la presente
Convocatoria de Cursos Bonificables para empleados (Marzo 2020)
Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación
2020 que disponen las empresas.
Deseáis que os mandemos
On Mon, 2020-03-02 at 14:04 +0100, gli...@google.com wrote:
> Certain copy_from_user() invocations in binder.c are known to
> unconditionally initialize locals before their first use, like e.g. in
> the following case:
[]
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
[]
> @@ -3
Geert Uytterhoeven, Mon, Mar 02, 2020 13:28:13 +0100:
> Hi Alex,
>
> Thanks for your patch!
>
> On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen
> wrote:
> > Not sure if all variants of the Salvator board have the HDMI decoder
> > chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on
> >
Hi Alex,
On Mon, Mar 2, 2020 at 2:40 PM Alex Riesen wrote:
> Geert Uytterhoeven, Mon, Mar 02, 2020 13:28:13 +0100:
> > On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen
> > wrote:
> > > Not sure if all variants of the Salvator board have the HDMI decoder
> > > chip (the ADV7482) connected to the SSI4
On Mon, Mar 02, 2020 at 02:25:51PM +0100, Alexander Potapenko wrote:
> On Mon, Mar 2, 2020 at 2:11 PM Joe Perches wrote:
> >
> > On Mon, 2020-03-02 at 14:04 +0100, gli...@google.com wrote:
> > > Certain copy_from_user() invocations in binder.c are known to
> > > unconditionally initialize locals b
On Mon, 2020-03-02 at 14:25 +0100, Alexander Potapenko wrote:
> On Mon, Mar 2, 2020 at 2:11 PM Joe Perches wrote:
> > On Mon, 2020-03-02 at 14:04 +0100, gli...@google.com wrote:
> > > Certain copy_from_user() invocations in binder.c are known to
> > > unconditionally initialize locals before their
02.03.2020 11:04, Dan Carpenter пишет:
> On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
>> This helps to make code cleaner a tad.
>
> Please don't start the commit message in the middle of a sentence.
Could you please clarify what do you mean by the "middle of a sentence"?
The c
Geert Uytterhoeven, Mon, Mar 02, 2020 14:47:46 +0100:
> On Mon, Mar 2, 2020 at 2:40 PM Alex Riesen
> wrote:
> > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > > @@ -322,6 +322,10 @@
> > > > clock-frequency =
On Mon, Mar 02, 2020 at 06:04:20PM +0300, Dmitry Osipenko wrote:
> 02.03.2020 11:04, Dan Carpenter пишет:
> > On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
> >> This helps to make code cleaner a tad.
> >
> > Please don't start the commit message in the middle of a sentence.
>
>
Hi Alex,
On Mon, Mar 2, 2020 at 4:07 PM Alex Riesen wrote:
> Geert Uytterhoeven, Mon, Mar 02, 2020 14:47:46 +0100:
> > On Mon, Mar 2, 2020 at 2:40 PM Alex Riesen
> > wrote:
> > > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > > > +++ b/arch/arm64/boot/dts/renesas/salvator-comm
On Sun, Mar 01, 2020 at 12:26:20PM +0100, Oscar Carter wrote:
> These include module parameters.
>
> Signed-off-by: Oscar Carter
> ---
> drivers/staging/vt6656/main_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c
> b/drivers/
On Sun, Mar 01, 2020 at 02:50:28PM +0100, Oscar Carter wrote:
> Don't initialize variables that are then set a few lines later.
>
> Signed-off-by: Oscar Carter
> ---
> drivers/staging/vt6656/main_usb.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/s
Hi Geert,
Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100:
> > And this absence of documentation also means that whatever clocks (both
> > input
> > in "clocks=" and output in "#clock-cells") listed in a specific .dts are
> > just
> > an integration detail?
>
> No, the absence probably mea
Hi Alex,
On Mon, Mar 2, 2020 at 5:09 PM Alex Riesen wrote:
> Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100:
> > > And this absence of documentation also means that whatever clocks (both
> > > input
> > > in "clocks=" and output in "#clock-cells") listed in a specific .dts are
> > > just
From: Ajay Singh
Use flexible-array member introduced in C99 instead of zero-length
array. Most of zero-length array was already taken care in previous
patch [1]. Now modified few more cases which were not handled earlier.
[1]. https://patchwork.kernel.org/patch/11394197/
Signed-off-by: Ajay Si
From: Ajay Singh
Use correct data for memcpy in wilc_hif_pack_sta_param(). Its
reported by Smatch static code analyser tool as discussed in [1].
[1]. https://lore.kernel.org/linux-wireless/20200302092346.GA24308@kadam/
Suggested-by: Dan Carpenter
Signed-off-by: Ajay Singh
---
drivers/staging
From: Ajay Singh
Remove the unnecessary always true 'if' conditions and simiplifed the
logic as suggested in [1].
[1]. https://lore.kernel.org/linux-wireless/20200302092346.GA24308@kadam/
Suggested-by: Dan Carpenter
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/cfg80211.c | 26 +
From: Ajay Singh
This patch series contains changes to address few Smatch static checker
reported warnings. Also added one patch to make use of flexible-array
member instead of zero-length array for few cases which were missed
earlier.
Ajay Singh (3):
staging: wilc1000: use correct data for me
From: Ajay Singh
Moved 'drivers/staging/wilc1000/cfg80211.h' to
'drivers/net/wireless/microchip/wilc1000/cfg80211.h'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/cfg80211.h| 29 +++
1 file changed, 29 insertions(+)
create mode 100644 drivers/net/wireless/
From: Ajay Singh
Moved 'drivers/staging/wilc1000/mon.c' to
'drivers/net/wireless/microchip/wilc1000/mon.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/mon.c | 260 ++
1 file changed, 260 insertions(+)
create mode 100644 drivers/net/wireless/microchip
From: Ajay Singh
Moved 'drivers/staging/wilc1000/hif.c' to
'drivers/net/wireless/microchip/wilc1000/hif.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/hif.c | 1959 +
1 file changed, 1959 insertions(+)
create mode 100644 drivers/net/wireless/microchi
From: Ajay Singh
This patch series is to review and move wilc1000 driver out of staging.
Most of the review comments received in [1] & [2] are addressed in the
latest code. Please review and provide your inputs.
[1].
https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_if.h' to
'drivers/net/wireless/microchip/wilc1000/wlan_if.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan_if.h | 803 ++
1 file changed, 803 insertions(+)
create mode 100644 drivers/net/wireless/m
From: Ajay Singh
Moved 'drivers/staging/wilc1000/fw.h' to
'drivers/net/wireless/microchip/wilc1000/fw.h'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/fw.h | 119 +++
1 file changed, 119 insertions(+)
create mode 100644 drivers/net/wireless/microchip/w
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_cfg.c' to
'drivers/net/wireless/microchip/wilc1000/wlan_cfg.c'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/wlan_cfg.c| 413 ++
1 file changed, 413 insertions(+)
create mode 100644 drivers/net/wireless
From: Ajay Singh
Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip,wilc1000,sdio.yaml | 68 +++
1 file changed, 68 insertions(
From: Ajay Singh
Moved 'drivers/staging/wilc1000/hif.h' to
'drivers/net/wireless/microchip/wilc1000/hif.h'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/hif.h | 214 ++
1 file changed, 214 insertions(+)
create mode 100644 drivers/net/wireless/microchip
From: Ajay Singh
Moved 'drivers/staging/wilc1000/sdio.c' to
'drivers/net/wireless/microchip/wilc1000/sdio.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/sdio.c| 1030 +
1 file changed, 1030 insertions(+)
create mode 100644 drivers/net/wireless/microc
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_cfg.h' to
'drivers/net/wireless/microchip/wilc1000/wlan_cfg.h'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/wlan_cfg.h| 54 +++
1 file changed, 54 insertions(+)
create mode 100644 drivers/net/wireless/
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan.h' to
'drivers/net/wireless/microchip/wilc1000/wlan.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan.h| 398 ++
1 file changed, 398 insertions(+)
create mode 100644 drivers/net/wireless/microch
From: Ajay Singh
Moved 'drivers/staging/wilc1000/netdev.c' to
'drivers/net/wireless/microchip/wilc1000/netdev.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/netdev.c | 940 ++
1 file changed, 940 insertions(+)
create mode 100644 drivers/net/wireless/mic
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan.c' to
'drivers/net/wireless/microchip/wilc1000/wlan.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan.c| 1238 +
1 file changed, 1238 insertions(+)
create mode 100644 drivers/net/wireless/microc
From: Ajay Singh
Moved 'drivers/staging/wilc1000/netdev.h' to
'drivers/net/wireless/microchip/wilc1000/netdev.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/netdev.h | 295 ++
1 file changed, 295 insertions(+)
create mode 100644 drivers/net/wireless/mic
From: Ajay Singh
Moved '/drivers/staging/wilc1000//microchip,wilc1000,spi.yaml' to
'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip,wilc1000,spi.yaml | 61 +++
1 file changed, 61 insertions(+
From: Ajay Singh
Added Makefile and Kconfig files for compiling wilc1000 module from
'drivers/net/wireless/microchip/'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/Kconfig | 1 +
drivers/net/wireless/Makefile | 1 +
drivers/net/wireless/microchip/Kconf
From: Ajay Singh
Moved 'drivers/staging/wilc1000/cfg80211.c' to
'drivers/net/wireless/microchip/wilc1000/cfg80211.c'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/cfg80211.c| 1850 +
1 file changed, 1850 insertions(+)
create mode 100644 drivers/net/wireles
From: Ajay Singh
Moved 'drivers/staging/wilc1000/spi.c' to
'drivers/net/wireless/microchip/wilc1000/spi.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/spi.c | 1001 +
1 file changed, 1001 insertions(+)
create mode 100644 drivers/net/wireless/microchi
Hi Dan,
On 02/03/20 2:53 pm, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> There are a few static checker warnings from Friday's linux-next. Only
> the first one is important. (Not all these Smatch warnings have been
>
There is a new devm_platform_ioremap_resource_byname() helper in the
kernel now, which helps to make code cleaner a tad by replacing few
"boilerplate" lines of code with a single line. Let's utilize that
new helper in the VDE driver.
Signed-off-by: Dmitry Osipenko
---
Changelog:
v2: Updated com
On Mon, Mar 02, 2020 at 02:04:29PM +0100, gli...@google.com wrote:
> Certain copy_from_user() invocations in binder.c are known to
> unconditionally initialize locals before their first use, like e.g. in
> the following case:
>
> struct binder_transaction_data tr;
> if (copy_from_user(
On Mon, Mar 02, 2020 at 07:03:19PM +0100, Alexander Potapenko wrote:
> > > case BINDER_SET_MAX_THREADS: {
> > > - int max_threads;
> > > + int max_threads __no_initialize;
> >
> > Is this really needed? A single integer in a rarely called ioctl()
> > being initia
On Mon, Mar 2, 2020 at 6:38 PM Greg KH wrote:
>
> On Mon, Mar 02, 2020 at 02:04:29PM +0100, gli...@google.com wrote:
> > Certain copy_from_user() invocations in binder.c are known to
> > unconditionally initialize locals before their first use, like e.g. in
> > the following case:
> >
> > st
This formed part of the legacy driver and potentially multi
users.
The driver now has only one user mac80211 remove this lock.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/int.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging
call vnt_start_interrupt_urb directly from vnt_start.
Move debug message to vnt_start_interrupt_urb.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/int.c | 11 ---
drivers/staging/vt6656/int.h | 1 -
drivers/staging/vt6656/main_usb.c | 2 +-
drivers/staging/vt66
Move functions vnt_int_process_data and vnt_int_report_rate to
usbpipe.c and vnt_interrupt_data to usbpipe.h
These form part of the USB structure.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/Makefile | 3 +-
drivers/staging/vt6656/int.c | 110 ---
On Mon, 2020-03-02 at 19:17 +0100, Alexander Potapenko wrote:
> On Mon, Mar 2, 2020 at 3:00 PM Joe Perches wrote:
> > On Mon, 2020-03-02 at 14:25 +0100, Alexander Potapenko wrote:
> > > On Mon, Mar 2, 2020 at 2:11 PM Joe Perches wrote:
> > > > On Mon, 2020-03-02 at 14:04 +0100, gli...@google.com
On Mon, Mar 02, 2020 at 04:34:40PM +, ajay.kat...@microchip.com wrote:
> From: Ajay Singh
>
> Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
> 'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
>
> Signed-off-by: Ajay Singh
> ---
> .../net/wir
On Mon, Mar 02, 2020 at 04:34:40PM +, ajay.kat...@microchip.com wrote:
> From: Ajay Singh
>
> Moved '/drivers/staging/wilc1000//microchip,wilc1000,spi.yaml' to
> 'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml'.
Not a useful changelog.
I think this should be comb
Thanks for your comment.
> Are you sure this is OK to do? exfat_get_entry_type() does a lot of
> mapping between values, using a file_dentry_t->type, while
> fid->type is a file_id_t->type.
The fid argument of exfat_rename_file()/move_file()from old_dentry->fid of
exfat_rename().
* exfat_renam
On Tue, 03 Mar 2020 03:07:51 +,
"kohada.tetsuh...@dc.mitsubishielectric.co.jp" said:
> > Are you sure this is OK to do? exfat_get_entry_type() does a lot of
> > mapping between values, using a file_dentry_t->type, while
> > fid->type is a file_id_t->type.
> The value that vfs sets to the old
Good day,
My name is Reem E. Hashimy, the Emirates Minister of State and Managing
Director of the United Arab Emirates (Dubai) World Expo 2020 Committee.
I am writing you to manage my funds I received as financial gratification from
various foreign companies I assisted to receive participati
Thanks!
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
58 matches
Mail list logo
