Re: [PATCH] staging: vc04_services: Fix wrong early return in next_service_by_instance()

2020-02-17 Thread Dan Carpenter
On Thu, Feb 13, 2020 at 02:40:01PM -0500, Marcelo Diop-Gonzalez wrote: > If kref_get_unless_zero() fails, we should keep looking for the > next service, since the callers of this function expect that a NULL > return value means there are no more. > > Signed-off-by: Marcelo Diop-Gonzalez > --- Pl

Re: [PATCH] staging: vc04_services: Fix wrong early return in next_service_by_instance()

2020-02-17 Thread Nicolas Saenz Julienne
On Thu Feb 13, 2020 at 2:40 PM, Marcelo Diop-Gonzalez wrote: > If kref_get_unless_zero() fails, we should keep looking for the > next service, since the callers of this function expect that a NULL > return value means there are no more. > > Signed-off-by: Marcelo Diop-Gonzalez Reviewed-by: Nicola

Re: [PATCH] Staging: comedi: drivers: fixed errors warning coding style issue

2020-02-17 Thread Greg KH
On Sun, Feb 16, 2020 at 06:16:56PM +0530, Sunny Pranay wrote: > > Before the patch were created there were few warnings indicating the > statements were bigger than 80 characters and some of them were not > properly commented like having extra space. So I created a patch for that > reducing comment

Re: staging: board: disabled driver

2020-02-17 Thread Dan Carpenter
On Fri, Feb 14, 2020 at 12:22:05AM +0530, Kaaira Gupta wrote: > I made some changes in board.h and other files under board to remove the > MACRO using conditions. I did git log --oneline "file path" to get the logs, > but turned out the driver was disabled. Hence on seeing it's KConfig file I >