[PATCH v2 19/21] staging: vc04_services: Delete vchiq_platform_check_suspend()

The function does nothing. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 15 --- .../interface/vchiq_arm/vchiq_core.c | 3 --- .../interface/vchiq_arm/vchiq_core.h | 3 --- 3 files changed, 21 deletions(-) d

[PATCH v2 14/21] staging: vc04_services: Delete vc_suspend_complete completion

Nobody is waiting on it. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq

[PATCH v2 03/21] staging: vc04_services: Get rid of resume_blocker completion in struct vchiq_arm_state

Nobody is waiting on it, so delete all relevant code. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 11 --- .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 4 2 files changed, 15 deletions(-) diff --git a/drivers/staging/

[PATCH v2 00/21] staging: vc04_services: suspend/resume cleanup

While in the process of preparing vchiq to support the Raspberry Pi 4, I stumbled upon a bunch of dead code in it. Which this series deletes. Ultimately the idea is to clean up vchiq_bcm2835_arm.c up to a point where it'll be easy to join it with vchiq_arm.c, which IIRC the TODO file states, shoul

[PATCH v2 09/21] staging: vc04_services: Get rid of vchiq_platform_videocore_wanted()

The function always returns true, which makes a whole bunch of code useless. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_2835_arm.c | 5 --- .../interface/vchiq_arm/vchiq_arm.c | 34 +++ .../interface/vchiq_arm/vchiq_arm.h |

[PATCH v2 07/21] staging: vc04_services: Get rid of vchiq_platform_paused/resumed()

vchiq_platform_paused() and vchiq_platform_resumed() do nothing. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 -- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 3 --- .../vc04_services/interface/vchiq_arm/vchiq_core.h

[PATCH v2 11/21] staging: vc04_services: Get rid of vchiq_on_remote_use_active()

Function does nothing. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 -- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_

[PATCH v2 04/21] staging: vc04_services: get rid of blocked_blocker completion in struct vchiq_arm_state

Nobody is waiting on it, so delete it. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 5 - .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.h| 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/vc04_services

[PATCH v2 02/21] staging: vc04_services: Get rid of resume_blocked in struct vchiq_arm_state

The boolean value is never set to true, hence remove it and all the code that depends on it. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 51 +-- .../interface/vchiq_arm/vchiq_arm.h | 1 - 2 files changed, 2 insertions(+), 5

[PATCH v2 12/21] staging: vc04_services: Get rid of vchiq_arm_vcsuspend()

It's not used. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 51 --- .../interface/vchiq_arm/vchiq_arm.h | 3 -- 2 files changed, 54 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/

[PATCH v2 17/21] staging: vc04_services: Get rid of the rest of suspend/resume state handling

The only remaining state doesn't provide any information anymore nor the completion that depends on it, which is set to complete_all() before any user may wait on it. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 52 --- .../interface/v

[PATCH v2 21/21] staging: vc04_services: vchiq_arm: Get rid of unused defines

They aren't used anywhere. Get rid of them. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_servic

[PATCH v2 06/21] staging: vc04_services: get rid of vchiq_platform_use_suspend_timer()

The function always returns 0, delete the function and all code conditional to it, namely the suspend timer. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Don't delete vchiq_dump_service_use_state() .../interface/vchiq_arm/vchiq_2835_arm.c | 11 --- .../interface/vchiq_ar

[PATCH v2 16/21] staging: vc04_services: Get of even more suspend/resume states

After the first states cleanup pass some set_suspend/resume_state() calls disappeared which opened up even more opportunities for deletions. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 100 +- .../interface/vchiq_arm/vchiq_arm.h

[PATCH v2 05/21] staging: vc04_services: Delete blocked_count in struct vchiq_arm_state

The variable is always 0. So delete it an all the code conditional to it. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 -- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 2 -- 2 files changed, 4 deletions(-) diff --

[PATCH v2 10/21] staging: vc04_services: Get rid of vchiq_platform_handle_timeout()

The function does nothing. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 5 - .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 - .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 3 --- 3 files chang

[PATCH v2 18/21] staging: vc04_services: Get rid of USE_TYPE_SERVICE_NO_RESUME

It's not used anywhere. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vc

[PATCH v2 20/21] staging: vc04_services: Get rid of vchiq_arm_vcresume()'s signature

The function implementation does not exist. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services

[PATCH v2 08/21] staging: vc04_services: Get rid of vchiq_platform_suspend/resume()

vchiq_platform_suspend() and vchiq_platform_resume() do nothing, get rid of them. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_2835_arm.c | 12 .../vc04_services/interface/vchiq_arm/vchiq_arm.c| 8 +--- .../vc04_services/interface/vchi

[PATCH v2 15/21] staging: vc04_services: Get rid of unused suspend/resume states

It's impossible to get into them, so simply delete them. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 55 --- .../interface/vchiq_arm/vchiq_arm.h | 7 --- 2 files changed, 62 deletions(-) diff --git a/drivers/staging/vc04_s

[PATCH v2 01/21] staging: vc04_services: Remove unused variables in struct vchiq_arm_state

There are not being used, so we're better off without them. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/sta

[PATCH v2 13/21] staging: vc04_services: Get rid of vchiq_check_resume()

Nobody calls this function. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 23 --- .../interface/vchiq_arm/vchiq_arm.h | 3 --- 2 files changed, 26 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/v