[PATCH] staging: greybus: fix fw is NULL but dereferenced.

2020-01-26 Thread Saurav Girepunje
Fix the warning reported by cocci check. Changes: In queue_work fw dereference before it actually get assigned. move queue_work before gb_bootrom_set_timeout. As gb_bootrom_get_firmware () return NEXT_REQ_READY_TO_BOOT only when there is no error and offset + size is actually equal to fw->size.

Re: binderfs interferes with syzkaller?

2020-01-26 Thread Greg Kroah-Hartman
On Sat, Jan 25, 2020 at 06:49:49PM +0100, Dmitry Vyukov wrote: > Hi binder maintainers, > > It seems that something has happened and now syzbot has 0 coverage in > drivers/android/binder.c: > https://storage.googleapis.com/syzkaller/cover/ci-upstream-kasan-gce-root.html > It covered at least somet

Re: binderfs interferes with syzkaller?

2020-01-26 Thread Christian Brauner
On Sun, Jan 26, 2020 at 09:55:35AM +0100, Greg Kroah-Hartman wrote: > On Sat, Jan 25, 2020 at 06:49:49PM +0100, Dmitry Vyukov wrote: > > Hi binder maintainers, > > > > It seems that something has happened and now syzbot has 0 coverage in > > drivers/android/binder.c: > > https://storage.googleapis

Re: binderfs interferes with syzkaller?

2020-01-26 Thread Christian Brauner
On Sat, Jan 25, 2020 at 07:13:03PM +0100, Dmitry Vyukov wrote: > On Sat, Jan 25, 2020 at 6:49 PM Dmitry Vyukov wrote: > > > > Hi binder maintainers, > > > > It seems that something has happened and now syzbot has 0 coverage in > > drivers/android/binder.c: > > https://storage.googleapis.com/syzkal

[RESEND PATCH] staging: exfat: Fix alignment warnings

2020-01-26 Thread Pragat Pandya
Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat_blkdev.c | 4 ++-- drivers/staging/exfat/exfat_core.c | 29 ++-- drivers/staging/exfat/exfat_super.c | 2 +- 3 files changed, 18 insertions(

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced.

2020-01-26 Thread Johan Hovold
On Sun, Jan 26, 2020 at 02:01:30PM +0530, Saurav Girepunje wrote: > Fix the warning reported by cocci check. > > Changes: > > In queue_work fw dereference before it actually get assigned. > move queue_work before gb_bootrom_set_timeout. Nope. As I said yesterday, you need to verify the output of

[driver-core:driver-core-testing] BUILD INCOMPLETE 85db1cde825344cc1419d3adadaf4187154ad687

2020-01-26 Thread kbuild test robot
sparc defconfig sparc64 allnoconfig sparc64 defconfig x86_64 randconfig-f003-20200126 x86_64 randconfig-f001-20200126 x86_64 randconfig-f002-20200126 i386 randconfig-f002-20200126

[PATCH] staging: bcm2835-audio: fix warning of no space is necessary

2020-01-26 Thread Valery Ivanov
This patch fixes "No space is necessary after a cast". Issue found by checkpatch.pl Signed-off-by: Valery Ivanov --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-p

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced.

2020-01-26 Thread Greg KH
On Sun, Jan 26, 2020 at 02:01:30PM +0530, Saurav Girepunje wrote: > Fix the warning reported by cocci check. What is "cocci check"? > Changes: > Why add that line? > In queue_work fw dereference before it actually get assigned. > move queue_work before gb_bootrom_set_timeout. > > As gb_bootro

[RFC PATCH] staging: vc04_services: vchiq_dump_service_use_state can be static

2020-01-26 Thread kbuild test robot
Fixes: fc2dd7f28276 ("staging: vc04_services: get rid of vchiq_platform_use_suspend_timer()") Signed-off-by: kbuild test robot --- vchiq_arm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging

Re: [PATCH 06/22] staging: vc04_services: get rid of vchiq_platform_use_suspend_timer()

2020-01-26 Thread kbuild test robot
Hi Nicolas, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on linux/master linus/master v5.5-rc7 next-20200121] [cannot apply to anholt/for-next] [if your patch is applied to the wrong git tree, please drop us a note

[PATCH] staging: rtl8723bs: fix copy of overlapping memory

2020-01-26 Thread Colin King
From: Colin Ian King Currently the rtw_sprintf prints the contents of thread_name onto thread_name and this can lead to a potential copy of a string over itself. Avoid this by printing the literal string RTWHALXT instread of the contents of thread_name. Addresses-Coverity: ("copy of overlapping

Peter Joe

2020-01-26 Thread Peter Joe
Dear, Did you receive the message i sent to you? Regards, Peter Joe ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] staging: exfat: remove fs_func struct.

2020-01-26 Thread Dan Carpenter
Looks good to me. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: wilc1000: return zero on success and non-zero on function failure

2020-01-26 Thread Dan Carpenter
Looks good. Reviewed-by: Dan Carpenter On Thu, Jan 23, 2020 at 12:50:47PM +, ajay.kat...@microchip.com wrote: > @@ -384,19 +378,18 @@ static int wilc_sdio_write_reg(struct wilc *wilc, u32 > addr, u32 data) > cmd.address = addr; > cmd.data = data; >