Re: staging: Add MA USB Host driver

2020-01-21 Thread Dan Carpenter
On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: > +int mausb_enqueue_event_from_user(uint8_t madev_addr, uint32_t all_events) > +{ > + unsigned long flags; > + uint16_t num_of_completed, > + num_of_events; > + struct mausb_device *dev; > + > + spin_l

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Michael Tretter
On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > v4l2_ctrl_new* calls. > Add checks and error handlers to fix the problems. > > Signed-off-by: Chuhong Yuan > --- > Changes in v3: > - Make code cleaner. > - Add a ch

[PATCH] staging: axis-fifo: replace spinlock with mutex

2020-01-21 Thread Quentin Deslandes
Following the device's documentation guidance, reading a packet from the device or writing a packet to it must be atomic. Previously, only reading device's vacancy (before writing on it) or occupancy (before reading from it) was locked. Hence, effectively reading the packet or writing the packet wa

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Chuhong Yuan
On Tue, Jan 21, 2020 at 4:23 PM Michael Tretter wrote: > > On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > > v4l2_ctrl_new* calls. > > Add checks and error handlers to fix the problems. > > > > Signed-off-by: Chuhong

[PATCH] staging: mt7621-pinctrl: Align to fix warnings of line over 80 characters

2020-01-21 Thread Sandesh Kenjana Ashok
Issue found by checkpatch. Signed-off-by: Sandesh Kenjana Ashok --- drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c i

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Michael Tretter
On Tue, 21 Jan 2020 19:59:46 +0800, Chuhong Yuan wrote: > On Tue, Jan 21, 2020 at 4:23 PM Michael Tretter > wrote: > > > > On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > > > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > > > v4l2_ctrl_new* calls. > > > Add check

Re: [PATCH] staging: mt7621-pinctrl: Align to fix warnings of line over 80 characters

2020-01-21 Thread Greg Kroah-Hartman
On Tue, Jan 21, 2020 at 02:47:05PM +0100, Sandesh Kenjana Ashok wrote: > Issue found by checkpatch. > > Signed-off-by: Sandesh Kenjana Ashok > --- > drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/stagi

[PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines

2020-01-21 Thread Sandesh Kenjana Ashok
Cleanup lines over 80 characters in pinctrl-rt2880.c. Issue found by checkpatch.pl Signed-off-by: Sandesh Kenjana Ashok --- drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/d

Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: > MA-USB Host driver provides USB connectivity over an available > network, allowing host device to access remote USB devices attached > to one or more MA USB devices (accessible via network). > > This driver has been developed to

Re: [External] Re: staging: Add MA USB Host driver

2020-01-21 Thread Vladimir Stankovic
Hi Greg, Our intention was to follow Linux kernel development process and add our driver to staging first. Will resubmit patch with TODO added. Regards, Vladimir On 22.1.20. 08:03, gre...@linuxfoundation.org wrote: > On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: >> MA-USB H

Re: [External] Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Wed, Jan 22, 2020 at 07:40:59AM +, Vladimir Stankovic wrote: > Hi Greg, > > Our intention was to follow Linux kernel development process and add our > driver to staging first. That's not the "normal" development process at all, where did you read that? staging is only for code that needs