On 15/12/2019 01:33, Navid Emamdoost wrote:
In the implementation of gsc_hpdi_auto_attach(), the allocated dma
description is leaks in case of alignment error, or failure of
gsc_hpdi_setup_dma_descriptors() or comedi_alloc_subdevices(). Release
devpriv->dma_desc via dma_free_coherent().
Signed-o
The "auto-attach" handler function `gsc_hpdi_auto_attach()` calls
`dma_alloc_coherent()` in a loop to allocate some DMA data buffers, and
also calls it to allocate a buffer for a DMA descriptor chain. However,
it does not check the return value of any of these calls. Change
`gsc_hpdi_auto_attach(
MONEY GRAM.
AROPORT INTL DE COTONOU COTONOU.
Office of Mrs. ALAN UDE.
Attn,Dear Funds beneficiary.
I am Mrs. ALAN UDE., Official Director.Money Gram-Benin
Confirm to us urgent,
Why did you authorized Mrs. Lyndia Paulson to receive your funds
$4.800.000 us dollars from this office?, I need your u
Fix spelling mistakes in exfat_core.c and exfat_super.c.
Co-developed-by: Johannes Weidner
Signed-off-by: Johannes Weidner
Signed-off-by: Julian Preis
---
Changes in v2:
- Add email recipients according to get_maintainer.pl
- Add patch versions
- Use in-reply-to
drivers/staging/exfat/exfat_co
Rename every instance of to
in file exfat_super.c. Fix resulting overlong lines.
Co-developed-by: Johannes Weidner
Signed-off-by: Johannes Weidner
Signed-off-by: Julian Preis
---
Changes in v2:
- Add email recipients according to get_maintainer.pl
- Add patch versions
- Use in-reply-to
driv
On Sun, Dec 15, 2019 at 08:42:47PM -0600, Navid Emamdoost wrote:
> Hi Johan,
>
> On Sun, Dec 15, 2019 at 7:23 AM Johan Hovold wrote:
> >
> > On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote:
> > > In the implementation of alloc_rtllib() the allocated dev is leaked in
> > > case of
15.12.2019 21:30, Dmitry Osipenko пишет:
> Hello,
>
> I was investigating why CPU hangs during of GPIO driver suspend and in
> the end it turned out that it is a Broadcom WiFi driver problem because
> it keeps OOB wake-interrupt enabled while WLAN interface is DOWN and this
> may cause a bit weird
Hi Jack,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.5-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to spec
From: Jérôme Pouiller
There is no reason for a trace to change any bit of the argument. So,
let's make sure that is the case by declaring the arguments constant.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/traces.h | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
From: Jérôme Pouiller
Currently, number of available tx retry policies is checked two times.
Only one is sufficient.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/st
From: Jérôme Pouiller
Obviously, current code can be replaced by IS_ERR_OR_NULL().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index 3b47b6c21ea1..cf4bc
From: Jérôme Pouiller
This new naming allows to save a comment.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bus_spi.c | 2 ++
drivers/staging/wfx/fwio.c| 2 +-
drivers/staging/wfx/hwio.h| 15 +--
3 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/d
From: Jérôme Pouiller
The original name did not make any sense.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers/staging/wfx/hif_api_cmd.h
index 3e77fbe3d5ff..4c
From: Jérôme Pouiller
The driver checks that the number of retries made by the device is
coherent with the rate policy. However, this check make sense only if
the device has returned RETRY_EXCEEDED.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 4 +++-
1 file changed, 3 in
From: Jérôme Pouiller
When driver receives an unexpected answer from the device, it shows
"unsupported HIF ID". That message does not represent the real error.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --gi
From: Jérôme Pouiller
Attribute "aborted" and argument "aborted" are both booleans.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c
index 35fcf9119f96..a6c9
From: Jérôme Pouiller
There are no real reason to modify the data received from device. So,
let's mark the arguments constant.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_rx.c | 8 ++-
drivers/staging/wfx/data_rx.h | 4 +-
drivers/staging/wfx/data_tx.c | 2 +-
dr
From: Jérôme Pouiller
In fact "mode" is a boolean that indicates if IBSS mode is used. This
patch fixes the name and uses a more adapted memory representation.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 8 ++--
drivers/staging/wfx/sta.c | 2 +-
2 files c
From: Jérôme Pouiller
In wfx driver, when a function is used as a struct member, its name is
the name of the member prefixed with "wfx_".
This patch apply this rule to wfx_spi_remove().
Also remove the useless comment above the function.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx
From: Jérôme Pouiller
The script that has imported API header has made a mistake "num_i_es".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 2 +-
drivers/staging/wfx/hif_tx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx
From: Jérôme Pouiller
During chip probing, if error does not come from secure boot (for
exemple when firmware has been found), others errors probably appears.
It is not necessary to say to user that the error does not come from
secure boot. So, drop the message saying "no error reported by secur
From: Jérôme Pouiller
We prefer series of simple boolean conditions than computing bitmasks.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/stagin
From: Jérôme Pouiller
hif_tx.c does not use any struct skb.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index cb7cddcb9815..e8c2bd1efbac 100644
--- a/drivers/stagi
From: Jérôme Pouiller
The script that has imported API headers has made a mistake in
"num_of_ssi_ds".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 4 ++--
drivers/staging/wfx/hif_tx.c | 10 +-
drivers/staging/wfx/scan.c| 2 +-
3 files changed, 8
From: Jérôme Pouiller
It is easier to manipulate a int than an array of booleans.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 17 +++--
drivers/staging/wfx/sta.h | 2 +-
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/
From: Jérôme Pouiller
Error management of wfx_conf_tx() can be simplified.
In add, the hardware command "hif_set_edca_queue_params" never returns
any error.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 42 ++-
1 file changed, 15 insertions
From: Jérôme Pouiller
It is useless to keep uapsd_info in struct wfx_vif. This structure can
be rebuilt just before to be sent.
In add, the struct hif_mib_set_uapsd_information comes from hardware
API. It is not intended to be manipulated in upper layers of the driver.
So, this patch relocates t
From: Jérôme Pouiller
The struct hif_req_set_pm_mode comes from hardware API. It is not
intended to be manipulated in upper layers of the driver. So, this patch
relocate the handling of this struct to hif_set_pm() (the low level
function).
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx
From: Jérôme Pouiller
Intermediate structure wfx_edca_params does not help. This patch
relocates its members directly in struct wfx_vif.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 4 ++--
drivers/staging/wfx/sta.c | 18 +-
drivers/staging/wfx/sta.h |
From: Jérôme Pouiller
The device is not allowed to enter in sleep mode during scan. However,
this is already handled by the device. So driver does not have to care
about it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 3 +--
drivers/staging/wfx/scan.c | 3 ---
drivers/stagi
From: Jérôme Pouiller
The structure hif_mib_template_frame come from hardware API. It is not
intended to be manipulated in upper layers of the driver.
In add, the current code for hif_set_template_frame() is dumb. All the
difficult task is left to the caller. So, there is code to factorize
here.
From: Jérôme Pouiller
The structures hif_req_start_scan and hif_ssid_def come from hardware
API. It is not intended to be manipulated in upper layers of the driver.
So, this patch relocate handling of theses structures to hif_scan()
(the low level function). This change also allows to drop struc
From: Jérôme Pouiller
Since wfx_scan_complete() is now only called from
wfx_scan_complete_cb(), it make sense to merge the both functions.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/
From: Jérôme Pouiller
The struct hif_req_edca_queue_params comes from hardware API. It is not
intended to be manipulated in upper layers of the driver.
So, this patch:
1. relocate the handling of this struct in hif_set_edca_queue_params()
(the low level function)
2. replace it in wfx_vi
From: Jérôme Pouiller
If scan fails, status is returned in hif_ind_scan_cmpl. hif_scan
always return a success. So, we can simplify the code.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 20 ++--
drivers/staging/wfx/scan.h | 1 -
2 files changed, 2 insertion
From: Jérôme Pouiller
mac80211 already call wfx_conf_tx() on every VIF instanciation. So, the
driver does not need to do it.
Note that current code did dirty things with wvif->edca_params. This
struct was initialized, but only 'queue_id' was really used. The other
members are only used to store
From: Jérôme Pouiller
Simplify wfx_hw_scan() by splitting out the update of the probe request.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 57 --
1 file changed, 30 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/wfx/scan.c b
From: Jérôme Pouiller
A tx_retry_policy (the equivalent of a list of ieee80211_tx_rate in
hardware API) is not able to include a rate multiple time. So currently,
the driver merges the identical rates from the policy provided by
minstrel (and it try to do the best choice it can in the associated
From: Jérôme Pouiller
Hello all,
This pull request continue to clean up the wfx driver. It can be more or
less divided in four parts:
- 0001 to 0009 fix some issues (should be included in 5.5?)
- 0010 to 0028 mostly contains cosmetics changes
- 0029 to 0043 re-work power save (in station m
From: Jérôme Pouiller
When not using HT mode, minstrel always includes 1Mbps as fallback rate.
But, when using HT mode, this fallback is not included. Yet, it seems
that it could save some frames. So, this patch add it unconditionally.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/dat
From: Jérôme Pouiller
Some weird behaviors were observed when connection is really good and
packets are small. It appears that sometime, number of packets in queues
can exceed 255 and generate an overflow in field usage_count.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.h |
From: Jérôme Pouiller
In some rare cases, driver may not have any available tx_retry_policies.
In this case, the driver asks to mac80211 to stop sending data. However,
it seems that a race is possible and a few frames can be sent to the
driver. In this case, driver can't wait for free tx_retry_po
From: Jérôme Pouiller
The chip has now proven that it can run at 50MHz on any boards without
any problem.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bus_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus
From: Jérôme Pouiller
The sum of all retries for a Tx frame cannot be superior to 32.
There are 4 rates at most. So this patch limits number of retries per
rate to 8.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
From: Jérôme Pouiller
Current code has a special case to handle association with WEP. Before
to rework the tx data handling, let's try to detect any possible misuse
of this code.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
From: Jérôme Pouiller
Argument to wfx_set_pm() is always wvif->powersave_mode. So, we can
simplify it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/w
From: Jérôme Pouiller
Original code allows to detect an BSS loss during a scan and delaying
the handling of BSS loss. However, there it is no real problem to just
make these two events mutually exclusive (there is just a performance
penalty).
Signed-off-by: Jérôme Pouiller
---
drivers/staging/
From: Jérôme Pouiller
When user try to launch scan while connected, it is necessary to notify
the AP that we cannot receive data (using power save mode).
Firmware already handles this automatically so the code in the driver is
redundant and can be dropped.
By edge effect, hack of scan status in
From: Jérôme Pouiller
In the old days, wfx_do_join() could be called from different contexts.
Now that wfx_do_join() is called only from one place, it is cleaner to
keep lock and unlock of data inside the function.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 9 -
1 f
From: Jérôme Pouiller
HIF_PREAMBLE_SHORT_LONG12 is never used. So it is possible to change
"preamble_type" into a boolean and drop "enum hif_preamble".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 16 ++--
drivers/staging/wfx/hif_api_mib.h | 5 +++--
driv
From: Jérôme Pouiller
Current name "mixed_or_greenfield_type" does not allow to know if
"true" means "mixed" of "greenfield". It is possible to use a better
name and drop "enum hif_tx_mode".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_mib.h | 8 ++--
drivers/staging/wfx/
From: Jérôme Pouiller
Power save status is already available in bss_conf. So there is no
reason to keep information duplicated in wvif->powersave_mode.
In add, type of wvif->powersave_mode is low level struct made to
communicate with device. We would like to limit usage of this kind of
struct in
From: Jérôme Pouiller
Original code allows to detect an unjoin request during a scan and
delaying the unjoin request. However, it is far easier to just block the
unjoin request until the end of the scan request.
In fact, it is already the case since scan and unjoin are protected by
conf_mutex. S
From: Jérôme Pouiller
Current code try to not exchange data with device if it is not
necessary. However, it seems that the additional code does not provide
any gain. So, we prefer to keep a simpler code.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 7 +--
1 file changed,
From: Jérôme Pouiller
The device provides an API to abort a scan request. Expose this feature
to mac80211.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 1 +
drivers/staging/wfx/scan.c | 13 +
drivers/staging/wfx/scan.h | 1 +
drivers/staging/wfx/wfx.h | 1 +
From: Jérôme Pouiller
mac80211 specification does not forbid hw_scan() to call
ieee80211_scan_completed(). However, from userspace point of view, not
all applications support this behavior. In particular, the code of iw
contains a big fat warning:
/*
* This code has a bug, which requires
On 2019-12-16 18:03, Jérôme Pouiller wrote:
> From: Jérôme Pouiller
>
> When not using HT mode, minstrel always includes 1Mbps as fallback rate.
> But, when using HT mode, this fallback is not included. Yet, it seems
> that it could save some frames. So, this patch add it unconditionally.
>
> Si
From: Jérôme Pouiller
The field 'uploaded' is used as a boolean, so call it a boolean.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 4 ++--
drivers/staging/wfx/data_tx.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b
From: Jérôme Pouiller
struct hif_mib_protected_mgmt_policy is an array of u8. There is no
reason to swap its bytes.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wfx/hif_tx_mib.h b/drivers/staging/wfx/hif_
From: Jérôme Pouiller
Device and driver maintain a cache of rate policies (aka.
tx_retry_policy in hardware API).
When hif_reset() is sent to hardware, device resets its cache of rate
policies. In order to keep driver in sync, it is necessary to do the
same on driver.
Note, when driver tries to
From: Jérôme Pouiller
Condition about wvif->state and wvif->bss_params.aid is already checked
at beginning of wfx_update_pm().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/
From: Jérôme Pouiller
wfx_set_pm() is now only used by sta.c. It can be declared static.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 57 ---
drivers/staging/wfx/sta.h | 1 -
2 files changed, 30 insertions(+), 28 deletions(-)
diff --git a
From: Jérôme Pouiller
Maximum request time (how long a request wait for the medium) is set in
firmware to 512TU
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
From: Jérôme Pouiller
Update the TODO list of wfx driver with a more precise list of items.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/TODO | 78
1 file changed, 64 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/wfx/TODO b/driv
From: Jérôme Pouiller
Scan requests from mac80211 must be splitted in a few hardware requests
(it is necessary to split channels with active scan and channels with
passive scan). Current code schedules a work_struct for each hardware
request and one delayed_work to handle scan timeout.
It is far
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: b3bb164aa56018ad8476dd2953b654491b7fb468
commit: f59aba2f75795e5b6a4f1aa31f3e20d7b71ca804 [26/27] isdn: capi: dead code
removal
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-g
Ian, thanks for your feedback.
On Mon, Dec 16, 2019 at 4:36 AM Ian Abbott wrote:
>
> On 15/12/2019 01:33, Navid Emamdoost wrote:
> > In the implementation of gsc_hpdi_auto_attach(), the allocated dma
> > description is leaks in case of alignment error, or failure of
> > gsc_hpdi_setup_dma_descrip
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
device_h_splitup
head: 3faaa7db6e6cb1d64da7778d1a4076b923277558
commit: c0ff8d9b83c875831cb030576dc9a087202c3f41 [3/7] device.h: move devtmpfs
prototypes out of the file
config: ia64-allmodconfig (attached as .config
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
device_h_splitup
head: 3faaa7db6e6cb1d64da7778d1a4076b923277558
commit: c0ff8d9b83c875831cb030576dc9a087202c3f41 [3/7] device.h: move devtmpfs
prototypes out of the file
config: ia64-allmodconfig (attached as .config
Hi.
Who can I speak to in your company regarding more clients / b2b leads for your
company?
We are selling a database of more than 886 thousand companies in South Africa.
Over 319 Thousand emails, 155 Thousand cells, and 801 thousand phones.
It is categorized into 2204 different industries.
I
70 matches
Mail list logo
