Hello!
On 11.12.2019 21:12, Scott Schafer wrote:
chage udelay() to usleep_range()
Change?
Signed-off-by: Scott Schafer
---
drivers/staging/qlge/qlge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge
On Tue, 2019-12-10 at 15:13 +0100, Takashi Iwai wrote:
> Clean up the driver with the new managed buffer allocation API.
> The hw_params and hw_free callbacks became superfluous and dropped.
>
> Signed-off-by: Takashi Iwai
Reviewed-by: Nicolas Saenz Julienne
Thanks!
signature.asc
Descriptio
On Tue, 2019-12-10 at 15:13 +0100, Takashi Iwai wrote:
> PCM core deals the empty ioctl field now as default.
> Let's kill the redundant lines.
>
> Signed-off-by: Takashi Iwai
Reviewed-by: Nicolas Saenz Julienne
Thanks!
signature.asc
Description: This is a digitally signed message part
On Thu, Dec 12, 2019 at 01:45:57PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 11.12.2019 21:12, Scott Schafer wrote:
>
> > chage udelay() to usleep_range()
>
>Change?
>
> > Signed-off-by: Scott Schafer
> > ---
> > drivers/staging/qlge/qlge_main.c | 2 +-
> > 1 file changed, 1 inserti
On Thu, Dec 12, 2019 at 01:45:57PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 11.12.2019 21:12, Scott Schafer wrote:
>
> > chage udelay() to usleep_range()
>
>Change?
>
> > Signed-off-by: Scott Schafer
> > ---
> > drivers/staging/qlge/qlge_main.c | 2 +-
> > 1 file changed, 1 inserti
On Thu, Dec 12, 2019 at 05:00:57AM -0600, Scott Schafer wrote:
> On Thu, Dec 12, 2019 at 01:45:57PM +0300, Sergei Shtylyov wrote:
> > Hello!
> >
> > On 11.12.2019 21:12, Scott Schafer wrote:
> >
> > > chage udelay() to usleep_range()
> >
> >Change?
> >
> > > Signed-off-by: Scott Schafer
>
Steve, Philipp,
I'd like one (or both) of you to look over this first.
It looks as if the subdev_notifier field of struct csi_state is never used,
except by the existing v4l2_async_notifier_unregister() call.
If I am right, then the real issue is that that field should be removed.
Regards,
On 12/10/19 4:15 AM, Chuhong Yuan wrote:
> allegro_open() misses a check for v4l2_m2m_ctx_init().
> Add a check and error handling code to fix it.
>
> Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver")
> Signed-off-by: Chuhong Yuan
> ---
> Changes in v2:
> - Fix the us
On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote:
> All drivers in imx call v4l2_async_notifier_cleanup() after unregistering
> the notifier except this driver.
> This should be a miss and we need to add the call to fix it.
>
> Signed-off-by: Chuhong Yuan
> ---
> drivers/staging/medi
On Thu, 2019-12-12 at 14:51 +0300, Dan Carpenter wrote:
> On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote:
> > All drivers in imx call v4l2_async_notifier_cleanup() after unregistering
> > the notifier except this driver.
> > This should be a miss and we need to add the call to fix it.
On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
> @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct
> mbox_params *mbcp)
> mbcp->out_count = 6;
>
> status = ql_get_mb_sts(qdev, mbcp);
> - if (status)
> + if (status) {
> ne
On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct
> > mbox_params *mbcp)
> > mbcp->out_count = 6;
> >
> > status = ql_get_mb_sts(qd
On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote:
> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
> > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
> > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev,
> > > struct mbox_params *mbc
On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote:
> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
> > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
> > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev,
> > > struct mbox_params *mbc
Hi Dan,
Thanks for the inputs.
On Thu, Dec 12, 2019 at 02:51:34PM +0300, Dan Carpenter wrote:
> On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote:
> > All drivers in imx call v4l2_async_notifier_cleanup() after
> > unregistering the notifier except this driver. This should be a
> > miss
It was defined a notifier in the csi_state structure that is never
allocated. And besides that it's unregister in the remove, even though
it is a no-op, just remove both.
Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for
i.MX7")
Reported-by: Hans Verkuil
Suggested-by:
From: Scott Schafer
Date: Thu, 12 Dec 2019 09:02:00 -0600
> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
>> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
>> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct
>> > mbox_params *mbcp)
>>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_remove_return_value
head: ccebb9244d66f0fe7d7fd6a6fe45d0d5a812bd60
commit: ccebb9244d66f0fe7d7fd6a6fe45d0d5a812bd60 [2/2] debugfs: remove return
value of debugfs_create_regset32()
config: x86_64-allyesconfig
On 12/12/19 11:08 AM, Rui Miguel Silva wrote:
Hi Dan,
Thanks for the inputs.
On Thu, Dec 12, 2019 at 02:51:34PM +0300, Dan Carpenter wrote:
On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote:
All drivers in imx call v4l2_async_notifier_cleanup() after
unregistering the notifier exc
On 12/12/19 11:17 AM, Rui Miguel Silva wrote:
It was defined a notifier in the csi_state structure that is never
allocated. And besides that it's unregister in the remove, even though
it is a no-op, just remove both.
Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev fo
On Thu, Dec 5, 2019 at 9:06 AM Sergey Senozhatsky
wrote:
>
> On (19/12/04 14:11), Colin King wrote:
> [..]
> > diff --git a/drivers/staging/media/meson/vdec/vdec.c
> > b/drivers/staging/media/meson/vdec/vdec.c
> > index 0a1a04fd5d13..8dd1396909d7 100644
> > --- a/drivers/staging/media/meson/vdec/
On 12/12/19 8:17 PM, Rui Miguel Silva wrote:
> It was defined a notifier in the csi_state structure that is never
> allocated. And besides that it's unregister in the remove, even though
> it is a no-op, just remove both.
>
> Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subde
22 matches
Mail list logo
