Re: [PATCH] staging: qlge: Fix multiple WARNING and CHECK relating to formatting

On Wed, Dec 11, 2019 at 08:31:36AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 10, 2019 at 07:47:59PM -0600, Scott Schafer wrote: > > CHECK: Please don't use multiple blank lines > > CHECK: Blank lines aren't necessary before a close brace '}' > > CHECK: Blank lines aren't necessary after an ope

Re: [PATCH] staging: qlge: Fix multiple WARNING and CHECK relating to formatting

On Wed, Dec 11, 2019 at 02:28:39AM -0600, Scott Schafer wrote: > On Wed, Dec 11, 2019 at 08:31:36AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 10, 2019 at 07:47:59PM -0600, Scott Schafer wrote: > > > CHECK: Please don't use multiple blank lines > > > CHECK: Blank lines aren't necessary before

Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

On Wed, Dec 11, 2019 at 04:57:28PM +0800, Jack Ping CHNG wrote: > This driver enables the Intel's LGM SoC GSWIP block. > GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions. > It allows CPUs and other accelerators connected to the SoC datapath > to enqueue and dequeue packets

Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

On Wed, Dec 11, 2019 at 04:57:28PM +0800, Jack Ping CHNG wrote: > - Added TODO (upstream plan) Wait, your TODO file references things not even in this patch: > --- > drivers/staging/Kconfig| 2 + > drivers/staging/Makefile | 1 + > drivers/stagin

Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

This should just be sent to netdev. I spotted a couple bugs. 1) enable/disable we flipped xgmac_set_xgmii_2500_speed() 2) retries wasn't reset in a couple places. I had a few tiny style nits as well but there is no reason to send it to staging. regards, dan carpenter On Wed, Dec 11, 2019 at 04

Re: [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove

Hi Chuhong, Thanks for the patch. On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote: > All drivers in imx call v4l2_async_notifier_cleanup() after unregistering > the notifier except this driver. > This should be a miss and we need to add the call to fix it. > > Signed-off-by: Chuhong

Re: FW: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

On Wed, Dec 11, 2019 at 06:37:42PM +0800, Chng, Jack Ping wrote: > Hi Greg, > > > -Original Message- > > From: Greg KH > > Sent: Wednesday, December 11, 2019 5:28 PM > > To: Chng, Jack Ping > > Cc: de...@driverdev.osuosl.org; Kim, Cheol Yong ; > > Shevchenko, Andriy ; net...@vger.kernel

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

On Wed, Dec 11, 2019 at 08:10:34AM +0100, Krzysztof Hałasa wrote: > Arnd, > > Arnd Bergmann writes: > > > - Most other supported HDLC hardware that we supoprt is for the ISA or > > PCI buses. > > I would be surprised if there is anybody left with ISA sync serial > stuff, but the PCI hardware

[PATCH AUTOSEL 5.4 107/134] Drivers: hv: vmbus: Fix crash handler reset of Hyper-V synic

From: Michael Kelley [ Upstream commit 7a1323b5dfe44a9013a2cc56ef2973034a00bf88 ] The crash handler calls hv_synic_cleanup() to shutdown the Hyper-V synthetic interrupt controller. But if the CPU that calls hv_synic_cleanup() has a VMbus channel interrupt assigned to it (which is likely the cas

Re: FW: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

> > We are trying to upstream the datapath code for Intel new NoC gateway > > (please refer to intel-gwdpa.txt at the end of the patch). It consists of > > ethernet, WIFI and passive optics handling. Since the code is quite huge, we > > have broken it into parts for internal review. > > > > As we

[PATCH v2 02/23] staging: qlge: Fix CHECK: Alignment should match open parenthesis

Fix CHECK: Alignment should match open parenthesis in qlge_dbg.c, qlge_ethtool.c, qlge_main.c, and qlge_mpi.c. Also made changes to the following lines: WARNING: quoted string split across lines FILE: drivers/staging/qlge/qlge_main.c:81 WARNING: quoted string split across lines FILE: drivers/stag

[PATCH v2 03/23] staging:qlge: Fix WARNING: Missing a blank line after declarations

Fix WARNING: Missing a blank line after declarations for the follig files: qlge.h qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 1 + drivers/staging/qlge/qlge_dbg.c | 5 + drivers/staging/qlge/qlge_main.c | 13 + drivers/

[PATCH v2 07/23] staging: qlge: Fix WARNING: quoted string split across lines

Fix WARNING: quoted string split across lines in the following files: qlge_dbg.c qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 19 +-- drivers/staging/qlge/qlge_main.c | 13 ++--- 2 files changed, 15 insertions(+), 17 deletions(-) diff

[PATCH v2 05/23] staging: qlge: Fix CHECK: Blank lines aren't necessary before a close brace '}'

Fix CHECK: Blank lines aren't necessary before a close brace '}' in the following files: qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 3 --- drivers/staging/qlge/qlge_main.c | 3 --- drivers/staging/qlge/qlge_mpi.c | 2 -- 3 files change

[PATCH v2 08/23] staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header

Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header in file qlge_dbg.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c

[PATCH v2 01/23] staging: qlge: Fix CHECK extra blank lines in many files

Fix CHECK: Please don't use multiple blank lines in qlge.h, qlge_dbg.c, qlge_ethtool.c, qlge_main.c, and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 1 - drivers/staging/qlge/qlge_dbg.c | 4 drivers/staging/qlge/qlge_ethtool.c | 1 - drivers/staging

[PATCH v2 00/23] V2: Break up from one patch to multiple

I broke up the changes from one patch to many so each patch has more defined changes. I also added a few other patches for formatting issues I missed in the original patch. Scott Schafer (23): staging: qlge: Fix CHECK extra blank lines in many files staging: qlge: Fix CHECK: Alignment should

[PATCH v2 10/23] staging: qlge: Fix CHECK: blank line after function/struct/union/enum declarations

Fix CHECK: Please use a blank line after function/struct/union/enum declarations in qlge_ethtool.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c i

[PATCH v2 06/23] staging: qlge: Fix CHECK: Blank lines aren't necessary after an open brace '{'

Fix CHECK: Blank lines aren't necessary after an open brace '{' in the following files: qlge.h qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 3 --- drivers/staging/qlge/qlge_dbg.c | 1 - drivers/staging/qlge/qlge_main.c | 6 -- driver

[PATCH v2 09/23] staging: qlge: Fix CHECK: No space is necessary after a cast

Fix CHECK: No space is necessary after a cast in qlge_dbg.c and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 28 +++ drivers/staging/qlge/qlge_main.c | 38 2 files changed, 33 insertions(+), 33 deletions(-)

[PATCH v2 12/23] staging: qlge: Fix WARNING: please, no space before tabs in qlge.h

Fix WARNING: please, no space before tabs in qlge.h Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index ede767a70b10..63642cb9e6

[PATCH v2 14/23] staging: qlge: Fix WARNING: Unnecessary space before function pointer arguments

WARNING: Unnecessary space before function pointer arguments in qlge.h Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 9ab4c7ce7714..010d39b4b30d 1

[PATCH v2 13/23] staging: qlge: Fix CHECK: spaces preferred around that (ctx:VxV)

Fix CHECK: spaces preferred around that (ctx:VxV) in qlge.h and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 6 +++--- drivers/staging/qlge/qlge_main.c | 18 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ql

[PATCH v2 04/23] staging: qlge: Fix WARNING: Missing a blank line after declarations

Fix WARNING: Missing a blank line after declarations in the following files: qlge.h qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 2 +- drivers/staging/qlge/qlge_dbg.c | 10 +- drivers/staging/qlge/qlge_main.c | 26 +--

[PATCH v2 21/23] staging: qlge: Fix WARNING: suspect code indent for conditional statements

Fix indentation for conditionals in qlge_ethtool.c and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 4 ++-- drivers/staging/qlge/qlge_main.c| 18 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/qlge/ql

[PATCH v2 22/23] staging: qlge: Fix CHECK: Unbalanced braces around else statement

Fix CHECK: Unbalanced braces around else statement in file qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_mpi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index ba8ce3506a59..

[PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

Fix CHECK: braces {} should be used on all arms of this statement in qlge_ethtool.c and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 18 -- drivers/staging/qlge/qlge_mpi.c | 9 ++--- 2 files changed, 18 insertions(+), 9 deletions(-)

[PATCH v2 17/23] staging: qlge: Fix WARNING: else is not generally useful after a break or return

Fix WARNING: else is not generally useful after a break or return in, qlge_dbg.c, qlge_main.c, and qlge_mpi.c Moved everything out of the else block wothout changing any logic Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/ql

[PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay

chage udelay() to usleep_range() Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index e18aa335c899..9427386e4a1e 100644 --- a/drivers/staging

[PATCH v2 15/23] staging: qlge: Fix WARNING: please, no spaces at the start of a line

Fix WARNING: please, no spaces at the start of a line in qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 38d217

[PATCH v2 16/23] staging: qlge: Fix WARNING: Block comments use a trailing */ on a separate line

Fix WARNING: Block comments use a trailing */ on a separate line in qlge_main.c and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 3 ++- drivers/staging/qlge/qlge_mpi.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/stag

[PATCH v2 18/23] staging: qlge: Fix CHECK: Prefer using the BIT macro

Fix CHECK: Prefer using the BIT macro changed (1<<4) to BIT(4) in 2 places in qlge.h Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 010d39b4b30d.

[PATCH v2 23/23] staging: qlge: Fix WARNING: Avoid multiple line dereference

Fix WARNING: Avoid multiple line dereference in qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 102da1fe9899..7

[PATCH v2 19/23] staging: qlge: Fix WARNING: msleep < 20ms can sleep for up to 20ms

Fix WARNING: msleep < 20ms can sleep for up to 20ms by changing msleep to usleep_range() in qlge_dbg.c, qlge_ethtool.c, and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 2 +- drivers/staging/qlge/qlge_ethtool.c | 2 +- drivers/staging/qlge/qlge_main.c|

[PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency

Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe': drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `de

Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

Hi Dan, On 11/12/2019 6:58 PM, Dan Carpenter wrote: This should just be sent to netdev. I spotted a couple bugs. 1) enable/disable we flipped xgmac_set_xgmii_2500_speed() 2) retries wasn't reset in a couple places. I had a few tiny style nits as well but there is no reason to send it to stag