On 22.10.19 23:54, Dan Williams wrote:
> Hi David,
>
> Thanks for tackling this!
Thanks for having a look :)
[...]
>> I am probably a little bit too careful (but I don't want to break things).
>> In most places (besides KVM and vfio that are nuts), the
>> pfn_to_online_page() check could most
drivers/staging/comedi/drivers/dt2814.c:193:6:
warning: variable data set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/comedi/drivers/dt2814.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --gi
drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
route_table_size defined but not used [-Wunused-const-variable=]
It is never used since introduction.
Signed-off-by: YueHaibing
---
drivers/staging/comedi/drivers/ni_routes.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
On 22.10.19 19:12, David Hildenbrand wrote:
Right now, ZONE_DEVICE memory is always set PG_reserved. We want to
change that.
The pages are obtained via get_user_pages_fast(). I assume, these
could be ZONE_DEVICE pages. Let's just exclude them as well explicitly.
Cc: Rob Springer
Cc: Todd Poyno
On 22.10.19 19:12, David Hildenbrand wrote:
Right now, ZONE_DEVICE memory is always set PG_reserved. We want to
change that.
Let's make sure that the logic in the function won't change. Once we no
longer set these pages to reserved, we can rework this function to
perform separate checks for ZONE
On 23/10/2019 08:52, YueHaibing wrote:
drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
route_table_size defined but not used [-Wunused-const-variable=]
It is never used since introduction.
Signed-off-by: YueHaibing
---
drivers/staging/comedi/drivers/ni_routes.c | 2 --
1 file c
On 23/10/2019 08:48, YueHaibing wrote:
drivers/staging/comedi/drivers/dt2814.c:193:6:
warning: variable data set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/comedi/drivers/dt2814.c | 8 ++--
1 file changed
Hi Steve,
On Tue 22 Oct 2019 at 17:26, Steve Longerbeam wrote:
> Hi Laurent, Rui,
>
> Besides field type ANY, the imx7 CSI should probably be dealing with other
> field
> type conversions as well. I may be mistaken, but like the imx6, the imx7 does
> not have the ability to detect whether a captur
Cluster comments that describes parameters of functions and create one
single comment before the function in kernel doc format.
Signed-off-by: Gabriela Bittencourt
---
Changes v2:
- Add name of function at the begining of comment
- Separate each parameter in individuals lines
Here are the co
Cluster comments that describes parameters of functions and create one
single comment before the function in kernel doc format.
Signed-off-by: Gabriela Bittencourt
---
Changes v2:
- Add name of function at the begining of comment
- Separate each parameter in individuals lines
Here are the co
Cluster comments that describes parameters of functions and create one
single comment before the function in kernel doc format.
Gabriela Bittencourt (2):
staging: sm750fb: format description of parameters in accel.c
staging: sm750fb: format description of parameters in accel.h
drivers/stagin
Formatting comments in file drivers/staging/sm750fb/sm750_accel.h.
Signed-off-by: Gabriela Bittencourt
---
Changes v3:
- Apply changes in file accel.h
---
drivers/staging/sm750fb/sm750_accel.h | 75 ---
1 file changed, 46 insertions(+), 29 deletions(-)
diff --git a/dr
Formatting comments in file drivers/staging/sm750fb/sm750_accel.c.
Signed-off-by: Gabriela Bittencourt
---
Changes v2:
- Add name of function at the begining of comment
- Separate each parameter in individuals lines
Here are the commands that I used to test my documentation and the
respectiv
On 23.10.19 18:25, Kees Cook wrote:
> On Wed, Oct 23, 2019 at 10:20:14AM +0200, David Hildenbrand wrote:
>> On 22.10.19 19:12, David Hildenbrand wrote:
>>> Right now, ZONE_DEVICE memory is always set PG_reserved. We want to
>>> change that.
>>>
>>> Let's make sure that the logic in the function won
On Wed, Oct 23, 2019 at 10:20:14AM +0200, David Hildenbrand wrote:
> On 22.10.19 19:12, David Hildenbrand wrote:
> > Right now, ZONE_DEVICE memory is always set PG_reserved. We want to
> > change that.
> >
> > Let's make sure that the logic in the function won't change. Once we no
> > longer set t
On Wed, Oct 23, 2019 at 12:26 AM David Hildenbrand wrote:
>
> On 22.10.19 23:54, Dan Williams wrote:
> > Hi David,
> >
> > Thanks for tackling this!
>
> Thanks for having a look :)
>
> [...]
>
>
> >> I am probably a little bit too careful (but I don't want to break things).
> >> In most places (be
Hi,
On Tue, Oct 08, 2019 at 07:09:43AM +0300, Wambui Karuga wrote:
> Fixes checkpatch.pl warning: do not add new typedefs in
> drivers/staging/octeon/octeon-stubs.h:41
>
> Signed-off-by: Wambui Karuga
> ---
> drivers/staging/octeon/octeon-stubs.h | 6 +++---
> 1 file changed, 3 insertions(+), 3
>> I dislike this for three reasons
>>
>> a) It does not protect against any races, really, it does not improve things.
>> b) We do have the exact same problem with pfn_to_online_page(). As long as we
>>don't hold the memory hotplug lock, memory can get offlined and remove
>> any time. Racy.
>
Hi,
On Thu, Oct 10, 2019 at 07:38:15AM +0300, Wambui Karuga wrote:
> Fix the following warning generated by sparse in
> drivers/staging/octeon/ethernet-tx.c:
>
> drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in
> assignment (different base types)
> drivers/staging/octeon/e
Hi,
On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote:
> On Sat, 12 Oct 2019, Wambui Karuga wrote:
> > This patchset removes the addition of new typedefs data types in octeon,
> > along with replacing the previous uses with the new declaration format.
> >
> > v2 of the series removes th
On Wed, Oct 23, 2019 at 08:43:04PM +0300, Aaro Koskinen wrote:
> Hi,
>
> On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote:
> > On Sat, 12 Oct 2019, Wambui Karuga wrote:
> > > This patchset removes the addition of new typedefs data types in octeon,
> > > along with replacing the previou
On Wed, Oct 23, 2019 at 10:28 AM David Hildenbrand wrote:
>
> >> I dislike this for three reasons
> >>
> >> a) It does not protect against any races, really, it does not improve
> >> things.
> >> b) We do have the exact same problem with pfn_to_online_page(). As long as
> >> we
> >>don't hol
This is a task from the TODO list of qlge driver:
- some "while" loops could be rewritten with simple "for"
The change is in functions ql_wait_reg_rdy and ql_wait_cfg in qlge_main.c.
The while loops are basically count based
(they decrement on each iteration),
and it makes more sense to be a for
On 23.10.19 21:39, Dan Williams wrote:
> On Wed, Oct 23, 2019 at 10:28 AM David Hildenbrand wrote:
>>
I dislike this for three reasons
a) It does not protect against any races, really, it does not improve
things.
b) We do have the exact same problem with pfn_to_online_pag
On 10/22/2019 10:42 PM, David Hildenbrand wrote:
> Our onlining/offlining code is unnecessarily complicated. Only memory
> blocks added during boot can have holes. Hotplugged memory never has
> holes. That memory is already online.
Why hot plugged memory at runtime cannot have holes (e.g a semi
too:
https://storage.kernelci.org/next/master/next-20191023/mips/cavium_octeon_defconfig/gcc-8/build.log
If you're making significant changes to this driver, please test them
using the MIPS cavium_octeon_defconfig which is where this driver is
actually used.
This driver has broken builds a few times rece
> If you're making significant changes to this driver, please test them
> using the MIPS cavium_octeon_defconfig which is where this driver is
> actually used.
>
> This driver has broken builds a few times recently which makes me very
> tempted to ask that we stop allowing it to be built with COMPI
27 matches
Mail list logo
