Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-21 Thread Jerome Pouiller
On Saturday 19 October 2019 16:24:43 CEST Dan Carpenter wrote: > On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote: > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > > index 3355183fc86c..573216b08042 100644 > > --- a/drivers/staging/wfx/bh.c > > +++ b/drivers/stagin

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-21 Thread Joe Perches
On Mon, 2019-10-21 at 08:52 +0200, Julia Lawall wrote: > > btw2: > > > > I really dislike all the code inconsistencies and > > unnecessary code duplication with miscellaneous changes > > in the rtl staging drivers > > > > Horrid stuff. > > I'm not sure what you mean by "miscellaneous changes

[PATCH] staging: wfx: remove unnecessary void pointer

2019-10-21 Thread Jules Irenge
Remove unnecessary void pointers. Issue detected and solved by coccinelle tool. semantic use @@expression e ;@@ -(void*)(e) +e Signed-off-by: Jules Irenge --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bus_sdio.c | 2 +- drivers/staging/wfx/bus_spi.c | 2 +- drivers/staging/wfx/

[PATCH] staging: wfx: remove unnecessary void pointer

2019-10-21 Thread Jules Irenge
Remove unnecessary void pointers. Issue detected and solved by coccinelle tool. semantic use @@expression e ;@@ -(void*)(e) +e Signed-off-by: Jules Irenge --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bus_sdio.c | 2 +- drivers/staging/wfx/bus_spi.c | 2 +- drivers/staging/wfx/

Re: [PATCH] staging: wfx: remove unnecessary void pointer

2019-10-21 Thread Jerome Pouiller
On Monday 21 October 2019 14:24:49 CEST Jules Irenge wrote: > Remove unnecessary void pointers. > Issue detected and solved by coccinelle tool. > semantic use > @@expression e ;@@ > -(void*)(e) > +e > > Signed-off-by: Jules Irenge > --- > drivers/staging/wfx/bh.c | 2 +- > drivers/staging/

[PATCH 1/4] iio: adc: Add support for AD7091R5 ADC

2019-10-21 Thread Beniamin Bia
From: Paul Cercueil AD7091 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC. Datasheet: Link: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf Signed-off-by: Paul Cercueil Co-developed-by: Beniamin Bia Signed-off-by: Beniamin Bia --- drivers/iio/adc/Kconfig

[PATCH 3/4] dt-binding: iio: Add documentation for AD7091R5

2019-10-21 Thread Beniamin Bia
Documentation for AD7091R5 ADC was added. Signed-off-by: Beniamin Bia --- .../bindings/iio/adc/adi,ad7091r5.yaml| 53 +++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml diff --git a/Documentation/devicetre

[PATCH 4/4] MAINTAINERS: add entry for AD7091R5 driver

2019-10-21 Thread Beniamin Bia
Add Beniamin Bia as a maintainer for AD7091R5 ADC. Signed-off-by: Beniamin Bia --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2e01d0f0b0e5..7f1e4b88688f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -893,6 +893,14 @@ S: Supported F:

[PATCH 2/4] iio: adc: ad7091r5: Add scale and external VREF support

2019-10-21 Thread Beniamin Bia
From: Paul Cercueil The scale can now be obtained with the "in_voltage_scale" file. By default, the scale returned corresponds to the internal VREF of 2.5V. It is possible to use an external VREF (through the REFIN/REFOUT pin of the chip), by passing a regulator to the driver. The scale will the

Re: [PATCH] staging: wfx: remove unnecessary void pointer

2019-10-21 Thread Jules Irenge
On Mon, 21 Oct 2019, Jerome Pouiller wrote: > On Monday 21 October 2019 14:24:49 CEST Jules Irenge wrote: > > Remove unnecessary void pointers. > > Issue detected and solved by coccinelle tool. > > semantic use > > @@expression e ;@@ > > -(void*)(e) > > +e > > > > Signed-off-by: Jules Irenge >

Re: [PATCH 1/4] iio: adc: Add support for AD7091R5 ADC

2019-10-21 Thread Jonathan Cameron
On Mon, 21 Oct 2019 20:06:05 +0300 Beniamin Bia wrote: > From: Paul Cercueil > > AD7091 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC. > > Datasheet: > Link: > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf > > Signed-off-by: Paul Cercueil > Co-developed-b

Re: [PATCH 2/4] iio: adc: ad7091r5: Add scale and external VREF support

2019-10-21 Thread Jonathan Cameron
On Mon, 21 Oct 2019 20:06:06 +0300 Beniamin Bia wrote: > From: Paul Cercueil > > The scale can now be obtained with the "in_voltage_scale" file. > By default, the scale returned corresponds to the internal VREF of 2.5V. > > It is possible to use an external VREF (through the REFIN/REFOUT pin o

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

2019-10-21 Thread Laurent Pinchart
Hi Steve, On Tue, May 21, 2019 at 06:03:17PM -0700, Steve Longerbeam wrote: > Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, > renaming it to to imx_media_try_colorimetry(), and call it at both sink and > source pad try_fmt's. The unrelated check for uninitialized field

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

2019-10-21 Thread Steve Longerbeam
Hi Laurent, On 10/21/19 6:44 PM, Laurent Pinchart wrote: Hi Steve, On Tue, May 21, 2019 at 06:03:17PM -0700, Steve Longerbeam wrote: Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, renaming it to to imx_media_try_colorimetry(), and call it at both sink and source pad

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

2019-10-21 Thread Steve Longerbeam
On 10/21/19 8:26 PM, Steve Longerbeam wrote: Hi Laurent, On 10/21/19 6:44 PM, Laurent Pinchart wrote: Hi Steve, On Tue, May 21, 2019 at 06:03:17PM -0700, Steve Longerbeam wrote: Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, renaming it to to imx_media_try_colori