[PATCH 1/2] staging: rtl8188eu: remove braces from single statement if block

Remove braces from single statement if block to comply with kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c

[PATCH 2/2] staging: rtl8188eu: remove unnecessary conversion to bool

Comparsions evaluate to bool, explicit conversion with ternary operator is overly verbose and unnecessary, so remove it. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188

[PATCH] staging: rtl8723bs: use DIV_ROUND_UP helper macro

Use the DIV_ROUND_UP macro to replace open-coded divisor calculation to improve readability. Issue found using coccinelle: @@ expression n,d; @@ ( - ((n + d - 1) / d) + DIV_ROUND_UP(n,d) | - ((n + (d - 1)) / d) + DIV_ROUND_UP(n,d) ) Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/hal/

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: use DIV_ROUND_UP helper macro

On Sun, 13 Oct 2019, Wambui Karuga wrote: > Use the DIV_ROUND_UP macro to replace open-coded divisor calculation > to improve readability. > Issue found using coccinelle: > @@ > expression n,d; > @@ > ( > - ((n + d - 1) / d) > + DIV_ROUND_UP(n,d) > | > - ((n + (d - 1)) / d) > + DIV_ROUND_UP(n,d

[PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

Fix lines ending with open parenthesis. Issue detected by checkpatch tool. In the process, change driver functions name in the multiple files from: vchiq_mmal_port_parameter_set to vmp_prmtr_set vchiq_mmal_component_disable to vm_cmpnt_disable vchiq_mmal_port_connect_tunnel to vmp_cnnct_tunnel vchi

[PATCH 2/2] staging: vc04_services: fix lines ending with open parenthesis

Fix lines ending with open parenthesis. Issue detected by checkpatch tool. Within "controls.c", "mmal-vchiq.c" and" mmal-vchiq.h" files. Signed-off-by: Jules Irenge --- .../vc04_services/bcm2835-camera/controls.c | 208 +- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 20 +-

Re: [Outreachy kernel] [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

On Sun, 13 Oct 2019, Jules Irenge wrote: > Fix lines ending with open parenthesis. Issue detected by checkpatch tool. > In the process, change driver functions name in the multiple files from: > vchiq_mmal_port_parameter_set to vmp_prmtr_set > vchiq_mmal_component_disable to vm_cmpnt_disable >

[PATCH] staging: vc04_services: use DIV_ROUND_UP helper macro

Replace open-coded division calculation with the DIV_ROUND_UP helper macro for better readability. Issue found using coccinelle: @@ expression n,d; @@ ( - ((n + d - 1) / d) + DIV_ROUND_UP(n,d) | - ((n + (d - 1)) / d) + DIV_ROUND_UP(n,d) ) Signed-off-by: Wambui Karuga --- .../staging/vc04_service

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: use DIV_ROUND_UP helper macro

On Sun, Oct 13, 2019 at 08:06:14PM +0200, Julia Lawall wrote: > > > On Sun, 13 Oct 2019, Wambui Karuga wrote: > > > Use the DIV_ROUND_UP macro to replace open-coded divisor calculation > > to improve readability. > > Issue found using coccinelle: > > @@ > > expression n,d; > > @@ > > ( > > - ((n

Re: [Outreachy kernel] [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

On Sun, 13 Oct 2019, Julia Lawall wrote: > > > On Sun, 13 Oct 2019, Jules Irenge wrote: > > > Fix lines ending with open parenthesis. Issue detected by checkpatch tool. > > In the process, change driver functions name in the multiple files from: > > vchiq_mmal_port_parameter_set to vmp_prmtr

Re: [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

Hi Jules, Am 13.10.19 um 20:34 schrieb Jules Irenge: > Fix lines ending with open parenthesis. Issue detected by checkpatch tool. > In the process, change driver functions name in the multiple files from: > vchiq_mmal_port_parameter_set to vmp_prmtr_set > vchiq_mmal_component_disable to vm_cmpnt_d

[PATCH v2] staging: rtl8723bs: use DIV_ROUND_UP helper macro

Use the DIV_ROUND_UP macro to replace open-coded divisor calculation to improve readability. Issue found using coccinelle: @@ expression n,d; @@ ( - ((n + d - 1) / d) + DIV_ROUND_UP(n,d) | - ((n + (d - 1)) / d) + DIV_ROUND_UP(n,d) ) Signed-off-by: Wambui Karuga --- Changes in v2: - Remove comme

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: use DIV_ROUND_UP helper macro

On Sun, 13 Oct 2019, Wambui Karuga wrote: > Use the DIV_ROUND_UP macro to replace open-coded divisor calculation > to improve readability. > Issue found using coccinelle: > @@ > expression n,d; > @@ > ( > - ((n + d - 1) / d) > + DIV_ROUND_UP(n,d) > | > - ((n + (d - 1)) / d) > + DIV_ROUND_UP(n,d

[PATCH] media: imx7-mipi-csis: Add a check for devm_regulator_get

devm_regulator_get may return an error but mipi_csis_phy_init misses a check for it. This may lead to problems when regulator_set_voltage uses the unchecked pointer. This patch adds a check for devm_regulator_get to avoid potential risk. Signed-off-by: Chuhong Yuan --- drivers/staging/media/imx/

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

Hi Laurent Pinchart, please check my comment below. Thanks, Xin On Fri, Oct 11, 2019 at 03:54:18PM +0300, Laurent Pinchart wrote: > Hi Andrzej, > > On Fri, Oct 11, 2019 at 01:21:43PM +0200, Andrzej Hajda wrote: > > On 11.10.2019 04:21, Xin Ji wrote: > > > The ANX7625 is an ultra-low power 4K Mob

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

Hi Andrzej Hajda, please check my comment below. Thanks, Xin On Fri, Oct 11, 2019 at 01:21:43PM +0200, Andrzej Hajda wrote: > On 11.10.2019 04:21, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI to DisplayPort 1.3 4K.