[PATCH] staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()

2019-09-26 Thread Denis Efremov
It's incorrect to compare HighestRate with 0x0b twice in the following manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The "else if" branch is constantly false. The second comparision should be with 0x03 according to the max_rate_idx in ODM_RAInfo_Init(). Cc: Larry Finger C

CONTACT,JP Morgan Chase Bank NY USA for your funds transfer US$16.5million Dollars deposited this morning,

2019-09-26 Thread Dr.JOHN DAVIDSON Dir IMF Benin.
ATTN,DEAR CONTACT,JP Morgan Chase Bank NY USA for your funds transfer US$16.5million Dollars deposited this morning, Director, MS.Linda B. Bammann The Bank is waiting to hear from you before transfer release to your bank. This is to avoid any hitch problems. CONTACT this bank once to receive your t

[PATCH] staging: rtl8192e: clean up indentation issue

2019-09-26 Thread Colin King
From: Colin Ian King The RT_TRACE is indented incorrectly, add in the missing tabs. Signed-off-by: Colin Ian King --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/sta

Re: [PATCH] staging: rtl8188eu: fix possible null dereference

2019-09-26 Thread Connor Kuehl
On 9/25/19 5:05 PM, Larry Finger wrote: This change is a good one, but why not get the same fix at line 779? Ah yes! Thanks for pointing that out. I missed that. I will send a V2 shortly. Thank you, Connor Larry ___ devel mailing list de...@

[PATCH v2] staging: rtl8188eu: fix possible null dereference

2019-09-26 Thread Connor Kuehl
Inside a nested 'else' block at the beginning of this function is a call that assigns 'psta' to the return value of 'rtw_get_stainfo()'. If 'rtw_get_stainfo()' returns NULL and the flow of control reaches the 'else if' where 'psta' is dereferenced, then we will dereference a NULL pointer. Fix this

[PATCH 1/3] staging: wilc1000: remove unnecessary netdev validation check in del_key()

2019-09-26 Thread Ajay.Kathat
From: Ajay Singh Removed unnecessary check to compare vif interface with zeroth index element in vif array. Already the caller takes care of passing the appropriate netdev handler during the del key operation. Signed-off-by: Ajay Singh --- .../staging/wilc1000/wilc_wfi_cfgoperations.c | 33 +++

[PATCH 2/3] staging: wilc1000: move wlan_deinit_locks() in wilc_netdev_cleanup()

2019-09-26 Thread Ajay.Kathat
From: Ajay Singh Move deinitialization of lock during the module remove and the initialization of lock wilc_cfg80211_init(). This to ensure locks are available during module load and gets free during unload. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_netdev.c| 14 +

[PATCH 3/3] staging: wilc1000: use RCU list to maintain vif interfaces list

2019-09-26 Thread Ajay.Kathat
From: Ajay Singh Make use of RCU list to maintain virtual interfaces instead of an array. The update operation on 'vif' list is less compare to the read operations. Mostly the 'vif' list elements are accessed for the read operation, so RCU list is more suited for this requirement. The shifting of

[no subject]

2019-09-26 Thread Jeeeun Evans
linux-arm-ker...@lists.infradead.org, linux-ker...@vger.kernel.org Bcc: jeeeun.ev...@codethink.co.uk Subject: [PATCH] staging: media: imx: Use devm_platform_ioremap_resource(). Reply-To: This patch fixes a warning by coccicheck: drivers/staging/media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use

[PATCH] staging: media: imx: Use devm_platform_ioremap_resource().

2019-09-26 Thread Jeeeun Evans
This patch fixes a warning by coccicheck: drivers/staging/media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use devm_platform_ioremap_resource for state -> regs Use devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Jeeeun E

Re: [PATCH v2] staging: rtl8188eu: fix possible null dereference

2019-09-26 Thread Larry Finger
On 9/26/19 10:03 AM, Connor Kuehl wrote: Inside a nested 'else' block at the beginning of this function is a call that assigns 'psta' to the return value of 'rtw_get_stainfo()'. If 'rtw_get_stainfo()' returns NULL and the flow of control reaches the 'else if' where 'psta' is dereferenced, then we

Re: [PATCH] staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()

2019-09-26 Thread Larry Finger
On 9/26/19 2:31 AM, Denis Efremov wrote: It's incorrect to compare HighestRate with 0x0b twice in the following manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The "else if" branch is constantly false. The second comparision should be with 0x03 according to the max_rate_idx

Re: [PATCH] staging: media: imx: Use devm_platform_ioremap_resource().

2019-09-26 Thread Rui Miguel Silva
Hi Jeeeun, On Thu 26 Sep 2019 at 16:55, Jeeeun Evans wrote: > This patch fixes a warning by coccicheck: > drivers/staging/media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use > devm_platform_ioremap_resource for state -> regs > > Use devm_platform_ioremap_resource helper which wraps platform_get_reso

Re: [PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

2019-09-26 Thread Larry Finger
On 9/24/19 9:28 AM, Connor Kuehl wrote: The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning that the second operand is never reached and

[PATCH] staging: rtl8723bs: remove unused function write_cam_from_cache

2019-09-26 Thread Michael Straube
Function write_cam_from_cache in rtw_wlan_util.c is never used, so remove it. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 13 - drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 - 2 files changed, 14 deletions(-) diff --git a/drivers/st