[PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-09-23 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx_bridge: anx7625@58 { compatible = "analogix,anx7625"; reg = <0x58>;

[PATCH v1 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-09-23 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature. Signed-off-by: Xin Ji -

[PATCH v1 0/2] Add initial support for slimport anx7625

2019-09-23 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the first version upload, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2):

Re: [PATCH v1 2/2] drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver

2019-09-23 Thread Dan Carpenter
I wish you would think more about the error codes that you're returning. Most functions do "ret |= frob()." which ORs the error codes together, and results in a nonsense negative error code. But then some functions return 1 on error and zero on success which is sometimes a bug, sometimes confusing

Re: [PATCH] staging: rtl8723bs: core: Drop condition with no effect

2019-09-23 Thread Dan Carpenter
On Sun, Sep 22, 2019 at 08:55:56AM +0530, Saurav Girepunje wrote: > As the "else if" and "else" branch body are identical the condition > has no effect. So drop the "else if" condition > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 -- > 1 file

Re: [PATCH] staging: rtl8723bs: os_dep: Remove unused variable

2019-09-23 Thread Dan Carpenter
On Sun, Sep 22, 2019 at 06:22:00PM +0530, Saurav Girepunje wrote: > Remove unused variable ret from functions rtw_mp_ioctl_hdl, > rtw_get_ap_info, rtw_mp_efuse_set, rtw_tdls, rtw_tdls_get . > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +-

[PATCH] staging: android: ashmem: Fix zero area size return code

2019-09-23 Thread Christopher N. Hesse
The previous inline comment stated that a size of zero would make the ashmem_read_iter function return EOF, but it returned 0 instead. Looking at other functions, such as ashmem_llseek or ashmem_mmap, it appears the convention is to return -EINVAL if the region size is unset or zero. To be consis

[PATCH trivial 3/3] treewide: arch: Fix Kconfig indentation

2019-09-23 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- arch/Kconfig | 4 ++-- arch/alpha/Kconfig | 2 +- arch/arm/Kconfig

[PATCH trivial 1/3] treewide: drivers: Fix Kconfig indentation

2019-09-23 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/acpi/Kconfig | 8 +- drivers/ata/Kconfig | 12 +-- dri

[PATCH trivial 2/3] treewide: Fix Kconfig indentation

2019-09-23 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- certs/Kconfig | 14 ++--- init/Kconfig | 28 +-

[PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Connor Kuehl
The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning that the second operand is never reached and is therefore dead code. Addresses-Coveri

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Larry Finger
On 9/23/19 2:48 PM, Connor Kuehl wrote: The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning that the second operand is never reached and

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Connor Kuehl
On 9/23/19 1:38 PM, Larry Finger wrote: On 9/23/19 2:48 PM, Connor Kuehl wrote: The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning tha

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Dan Carpenter
On Mon, Sep 23, 2019 at 12:48:06PM -0700, Connor Kuehl wrote: > @@ -103,7 +102,7 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8 > ElementID, u32 CmdLen, u8 *p > adapt->HalData->LastHMEBoxNum = > (h2c_box_num+1) % RTL88E_MAX_H2C_BOX_NUMS; > > - } wh

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Dan Carpenter
On Mon, Sep 23, 2019 at 03:38:39PM -0500, Larry Finger wrote: > This patch is correct; however, the do..while loop will always be executed s/correct/harmless/. > once, thus you could remove the loop and the loop variable bcmd_down. > > @greg: If you would prefer a two-step process, then this one