Re: [PATCH v2] staging: greybus: add missing includes

2019-08-28 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2019 at 09:59:17PM +0100, Rui Miguel Silva wrote: > Before moving greybus core out of staging and moving header files to > include/linux some greybus header files were missing the necessary > includes. This would trigger compilation faillures with some example > errors logged bellow

Re: [PATCH 1/4] binder: add a mount option to show global stats

2019-08-28 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2019 at 01:41:49PM -0700, Hridya Valsaraju wrote: > Currently, all binder state and statistics live in debugfs. > We need this information even when debugfs is not mounted. > This patch adds the mount option 'stats' to enable a binderfs > instance to have binder debug information pr

[PATCH] staging: greybus: fix more header includes

2019-08-28 Thread Rui Miguel Silva
More headers needed to be fixed when moving greybus out of staging and enabling the COMPILE_TEST option. Reported-by: kbuild test robot Signed-off-by: Rui Miguel Silva --- include/linux/greybus/operation.h | 1 + include/linux/greybus/svc.h | 2 ++ 2 files changed, 3 insertions(+) diff -

Re: [PATCH] staging: greybus: fix more header includes

2019-08-28 Thread Johan Hovold
On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote: > More headers needed to be fixed when moving greybus out of staging and > enabling the COMPILE_TEST option. > > Reported-by: kbuild test robot > Signed-off-by: Rui Miguel Silva > --- > include/linux/greybus/operation.h | 1 + >

Re: [PATCH] staging: greybus: fix more header includes

2019-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2019 at 12:47:26PM +0200, Johan Hovold wrote: > On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote: > > More headers needed to be fixed when moving greybus out of staging and > > enabling the COMPILE_TEST option. > > > > Reported-by: kbuild test robot > > Signed-off-

Re: [PATCH 1/4] binder: add a mount option to show global stats

2019-08-28 Thread Christian Brauner
On Wed, Aug 28, 2019 at 11:22:37AM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 27, 2019 at 01:41:49PM -0700, Hridya Valsaraju wrote: > > Currently, all binder state and statistics live in debugfs. > > We need this information even when debugfs is not mounted. > > This patch adds the mount option

[PATCH v2] staging: greybus: fix more header declarations

2019-08-28 Thread Rui Miguel Silva
More headers needed to be fixed when moving greybus out of staging and enabling the COMPILE_TEST option. Add forward declarations for the needed structures. Reported-by: kbuild test robot Signed-off-by: Rui Miguel Silva --- v1->v2: Johan Hovold: - use forward declarations instead including al

Re: [PATCH] staging: greybus: fix more header includes

2019-08-28 Thread Rui Miguel Silva
Hi, On Wed 28 Aug 2019 at 12:42, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2019 at 12:47:26PM +0200, Johan Hovold wrote: >> On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote: >> > More headers needed to be fixed when moving greybus out of staging and >> > enabling the COMPILE_TEST

Re: [PATCH 2/4] binder: Add stats, state and transactions files

2019-08-28 Thread Christian Brauner
On Tue, Aug 27, 2019 at 01:41:50PM -0700, Hridya Valsaraju wrote: > The following binder stat files currently live in debugfs. > > /sys/kernel/debug/binder/state > /sys/kernel/debug/binder/stats > /sys/kernel/debug/binder/transactions > > This patch makes these files available in a binderfs insta

Re: [PATCH 3/4] binder: Make transaction_log available in binderfs

2019-08-28 Thread Christian Brauner
On Tue, Aug 27, 2019 at 01:41:51PM -0700, Hridya Valsaraju wrote: > Currently, the binder transaction log files 'transaction_log' > and 'failed_transaction_log' live in debugfs at the following locations: > > /sys/kernel/debug/binder/failed_transaction_log > /sys/kernel/debug/binder/transaction_lo

Re: [PATCH 4/4] binder: Add binder_proc logging to binderfs

2019-08-28 Thread Christian Brauner
On Tue, Aug 27, 2019 at 01:41:52PM -0700, Hridya Valsaraju wrote: > Currently /sys/kernel/debug/binder/proc contains > the debug data for every binder_proc instance. > This patch makes this information also available > in a binderfs instance mounted with a mount option > "stats=global" in addition

Re: [PATCH v2] staging: greybus: fix more header declarations

2019-08-28 Thread Johan Hovold
On Wed, Aug 28, 2019 at 01:48:25PM +0100, Rui Miguel Silva wrote: > More headers needed to be fixed when moving greybus out of staging and > enabling the COMPILE_TEST option. > > Add forward declarations for the needed structures. > > Reported-by: kbuild test robot > Signed-off-by: Rui Miguel Si

Re: [PATCH v2] staging: greybus: add missing includes

2019-08-28 Thread Randy Dunlap
he config. but it is right. >> >> Greg please note the new include in svc.h may need to be changed >> when moving headers to include/linux > > As a version of your first patch is already in my tree, this one will > not apply :( > > Can you just send a fix-up patch

Re: [PATCH v2] staging: greybus: add missing includes

2019-08-28 Thread Rui Miguel Silva
-by: Alex Elder >>> --- >>> >>> v1->v2: >>> lkp@intel: >>> - added greybus_protocols.h include to svc.h header >>> Alex Elder: >>> - remove extra line in operation.h >>> >>> Looks like lkp can now find missing headers that we can not :), >>> it must

Re: [PATCH v2] staging: greybus: add missing includes

2019-08-28 Thread Greg Kroah-Hartman
lex Elder > >>> --- > >>> > >>> v1->v2: > >>> lkp@intel: > >>> - added greybus_protocols.h include to svc.h header > >>> Alex Elder: > >>> - remove extra line in operation.h > >>> > >>>

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2019 at 06:08:17PM +0200, Greg Kroah-Hartman wrote: > From: Valdis Klētnieks > > The exfat code needs a lot of work to get it into "real" shape for > the fs/ part of the kernel, so put it into drivers/staging/ for now so > that it can be worked on by everyone in the community. >

Re: [PATCH v2 2/3] staging: rtl8192u: fix macro alignment in ieee80211

2019-08-28 Thread Joe Perches
On Wed, 2019-08-21 at 07:35 -0700, Stephen Brennan wrote: > Several macros display unaligned, due to mixes of tabs and spaces. These > can be fixed by making spacing consistent, do this. [] > @@ -452,18 +452,19 @@ do { if (ieee80211_debug_level & (level)) \ >printk(KERN_DEBUG "ieee80211: " fmt,

[PATCH -next] media: imx: remove unused including

2019-08-28 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/staging/media/imx/imx-media-csc-scaler.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c b/drivers/staging/media/imx/imx-media-csc-scaler.c index de599af59ffc..2b635eb

[driver-core:driver-core-testing 47/47] ERROR: "platform_get_irq_optional" [drivers/hwmon/pwm-fan.ko] undefined!

2019-08-28 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing head: 6e7e5c7fbc1c84e4ac657e0cb5bf9ca24492cc8f commit: 6e7e5c7fbc1c84e4ac657e0cb5bf9ca24492cc8f [47/47] hwmon: pwm-fan: Use platform_get_irq_optional() config: i386-allmodconfig (attache

[PATCH] binder: Use kmem_cache for binder_thread

2019-08-28 Thread Peikan Tsai
Hi, The allocated size for each binder_thread is 512 bytes by kzalloc. Because the size of binder_thread is fixed and it's only 304 bytes. It will save 208 bytes per binder_thread when use create a kmem_cache for the binder_thread. Signed-off-by: Peikan Tsai --- drivers/android/binder.c | 16 ++

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-28 Thread Christoph Hellwig
Can we please just review the damn thing and get it into the proper tree? That whole concept of staging file systems just has been one fricking disaster, including Greg just moving not fully reviewed ones over like erofs just because he feels like it. I'm getting sick and tired of this scheme. __

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2019 at 11:23:40PM -0700, Christoph Hellwig wrote: > Can we please just review the damn thing and get it into the proper > tree? That whole concept of staging file systems just has been one > fricking disaster, including Greg just moving not fully reviewed ones > over like erofs ju

Re: [PATCH] binder: Use kmem_cache for binder_thread

2019-08-28 Thread Greg KH
On Thu, Aug 29, 2019 at 01:49:53PM +0800, Peikan Tsai wrote: > Hi, No need for that in a changelog text :) > The allocated size for each binder_thread is 512 bytes by kzalloc. > Because the size of binder_thread is fixed and it's only 304 bytes. > It will save 208 bytes per binder_thread when use