[PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

Joe rightly points out that we should be using the "Obsolete" status for these two subsystems. Also I got the path name wrong for the wusbcore tree. Reported-by: Joe Perches Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete") Signed-off-by: Greg Kroah-Hartman diff -

Re: [PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > Joe rightly points out that we should be using the "Obsolete" status for > these two subsystems. Even with that change, I don't see get_maintainers.pl tell me I shouldn't be sending a patch in for this area: $ cat x.patch diff

[bug report] staging: wilc1000: added support to dynamically add/remove interfaces

Hello Ajay Singh, The patch 9bc061e88054: "staging: wilc1000: added support to dynamically add/remove interfaces" from Jun 26, 2019, leads to the following static checker warning: drivers/staging/wilc1000/wilc_wlan.c:497 wilc_wlan_handle_txq() warn: missing error code here? 'wilc_

Re: [PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote: > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > > Joe rightly points out that we should be using the "Obsolete" status for > > > these two subsyste

Re: [PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > Joe rightly points out that we should be using the "Obsolete" status for > > these two subsystems. > > Even with that change, I don't see get_maintainers.pl tell m

Re: [PATCH 07/10] staging: rtl8712: init_drv_sw(): Change return values

On Thu, Aug 08, 2019 at 12:10:09PM +0530, Nishka Dasgupta wrote: > - if (_r8712_init_sta_priv(&padapter->stapriv)) > - return _FAIL; > + ret = _r8712_init_sta_priv(&padapter->stapriv); > + if (ret) > + return ret; > padapter->stapriv.padapter = padapter; >

Re: [PATCH 10/10] staging: rtl8712: r8712_xmit_classifier(): Change return values and type

Looks good to me. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] Staging: most: fix coding style issues

Hi Gabriel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [cannot apply to v5.3-rc3 next-20190808] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] MAINTAINERS: mark wusbcore and UWB as obsolete

On Thu, 2019-08-08 at 13:23 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote: > > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote: > > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote: > > > > Joe rightly points out that

RE: [PATCH 00/34] put_user_pages(): miscellaneous call sites

> > On 8/7/19 7:36 PM, Ira Weiny wrote: > > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: > >> On Wed 07-08-19 10:37:26, Jan Kara wrote: > >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: > On 8/2/19 7:52 AM, Jan Kara wrote: > > On Fri 02-08-19 07:24:43, Matthew Wilcox wr

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > On Fri, 2 Aug 2019 19:56:02 + > > Jose Carlos Cazarin Filho wrote: > > > > > Fix checkpath error: > > > CHECK: spaces preferred around that '*' (ctx:WxV) > > > +exte

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote: > On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > > On Fri, 2 Aug 2019 19:56:02 + > > > Jose Carlos Cazarin Filho wrote: > > > > > > > Fix checkpath error

Re: [PATCH 3/6] staging: wilc1000: remove unused members

Hi Dan On 8/7/19 4:03 AM, Dan Carpenter wrote: > External E-Mail > > > On Tue, Aug 06, 2019 at 07:32:08PM +, adham.aboza...@microchip.com wrote: >> Hi Dan >> >> On 8/6/19 5:46 AM, Dan Carpenter wrote: >>> External E-Mail >>> >>> >>> On Thu, Jul 25, 2019 at 09:31:34PM +, adham.aboza...@micr

Re: [PATCH 3/6] staging: wilc1000: remove unused members

On 8/7/19 4:03 AM, Dan Carpenter wrote: > External E-Mail > > > On Tue, Aug 06, 2019 at 07:32:08PM +, adham.aboza...@microchip.com wrote: >> Hi Dan >> >> On 8/6/19 5:46 AM, Dan Carpenter wrote: >>> External E-Mail >>> >>> >>> On Thu, Jul 25, 2019 at 09:31:34PM +, adham.aboza...@microchip

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

On 8/8/19 9:25 AM, Weiny, Ira wrote: >> >> On 8/7/19 7:36 PM, Ira Weiny wrote: >>> On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: On Wed 07-08-19 10:37:26, Jan Kara wrote: > On Fri 02-08-19 12:14:09, John Hubbard wrote: >> On 8/2/19 7:52 AM, Jan Kara wrote: >>> On Fr

[PATCH] PCI: PM: Also move to D0 before calling pci_legacy_resume_early()

In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN. In pci_pm_thaw_noirq(), the state is supposed to be moved back to PCI_D0, but the current code misses the pci_legacy_resume_early() path, so the state remains in PCI_UNKNOWN in that path, and during hiberantion this causes an

[PATCH] staging: wilc1000: Don't reset WILC CPU disgracefully

From: Adham Abozaeid Send abort request to WILC from wilc_wlan_stop instead of resetting the CPU. The abort request was being sent from wilc_wlan_cleanup after the CPU was reset which wasn't the correct order. The abort request handler in the chip will take care of resetting the CPU. Signed-off-

Re: [PATCH] PCI: PM: Also move to D0 before calling pci_legacy_resume_early()

On Thu, Aug 08, 2019 at 06:46:51PM +, Dexuan Cui wrote: > > In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN. > In pci_pm_thaw_noirq(), the state is supposed to be moved back to PCI_D0, > but the current code misses the pci_legacy_resume_early() path, so the > state remai

RE: [PATCH] PCI: PM: Also move to D0 before calling pci_legacy_resume_early()

> From: Bjorn Helgaas > Sent: Thursday, August 8, 2019 12:19 PM > To: Dexuan Cui > > On Thu, Aug 08, 2019 at 06:46:51PM +, Dexuan Cui wrote: > > > > In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN. > > In pci_pm_thaw_noirq(), the state is supposed to be moved back to P

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

On Thu, 2019-08-08 at 18:40 +0200, Greg KH wrote: > On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote: > > On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > > > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > > > On Fri, 2 Aug 2019 19:56:02 + > > > > Jose Car

[PATCH v3 2/2] binder: Validate the default binderfs device names.

Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. This patch adds a check in binderfs_init() to ensure the same for the default binder devices that will be created in every binderfs instance. Co-developed-by: Christian Brauner Signed-off-by: Christian Brauner Signed-off-by: Hridy

Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()

On 8/7/19 10:42 PM, Michael Ellerman wrote: > Hi John, > > john.hubb...@gmail.com writes: >> diff --git a/arch/powerpc/mm/book3s64/iommu_api.c >> b/arch/powerpc/mm/book3s64/iommu_api.c >> index b056cae3388b..e126193ba295 100644 >> --- a/arch/powerpc/mm/book3s64/iommu_api.c >> +++ b/arch/powerpc/m

[PATCH 05/11] staging: rtl8712: r8712_free_xmitbuf(): Change return type

Change return type of r8712_free_xmitbuf from int to void (and remove its return values) as its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++--- drivers/staging/rtl8712/rtl871x_xmit.h | 4 ++-- 2 files changed, 4 insertions(+), 5 de

[PATCH 06/11] staging: rtl8712: r8712_xmit_direct(): Change return type

Change return type of r8712_xmit_direct from int to void as its return value is never used. Remove return statement accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-- drivers/staging/rtl8712/rtl871x_xmit.h | 2 +- 2 files changed, 2 insertions(+), 3 d

[PATCH 04/11] staging: rtl8712: make_wlanhdr(): Change return values and type

Change return values of make_wlanhdr from _SUCCESS/_FAIL to 0/-EINVAL. Modify call site to check for non-zero return values instead of _FAIL. Change return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 10 +- 1 file changed, 5 insertio

[PATCH 11/11] staging: rtl8712: r8712_dump_aggr_xframe(): Change type to void

Change return type of r8712_dump_aggr_xframe from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++ drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++-- 2 files changed, 4 insertions(+),

[PATCH 08/11] staging: rtl8712: r8712_construct_txaggr_cmd_hdr(): Change return type

Change return type of r8712_construct_txaggr_cmd_hdr from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/

[PATCH 02/11] staging: rtl8712: r8712_update_attrib(): Change return values and type

Change return values of r8712_update_attrib from _SUCCESS and _FAIL to 0 and -ENOMEM or -EINVAL respectively. Modify call site to check for the new failure conditions. Also modify the return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 16 +++

[PATCH 01/11] staging: rtl8712: _r8712_init_xmit_priv(): Change return values and type

Change the return values in _r8712_init_xmit_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Change return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 14 +++--- drivers/staging/rtl8712/rtl871x_xmit.h | 4 ++-- 2 files changed,

[PATCH 07/11] staging: rtl8712: r8712_construct_txaggr_cmd_desc(): Change return type

Change return type of r8712_construct_txaggr_cmd_desc from u8 to void (and remove its return statement) as it always returns _SUCCESS and its return value is never stored, checked or otherwise used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 4 +--- 1 file change

[PATCH 10/11] staging: rtl8712: r8712_xmitframe_aggr_1st(): Change return type to void

Change return type of r8712_xmitframe_aggr_1st from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++ drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++-- 2 files changed, 4 insertions(+)