On Sun, Jul 14, 2019 at 08:33:57PM -0600, Jens Axboe wrote:
> On 7/14/19 1:08 PM, Bharath Vedartham wrote:
> > diff --git a/fs/io_uring.c b/fs/io_uring.c
> > index 4ef62a4..b4a4549 100644
> > --- a/fs/io_uring.c
> > +++ b/fs/io_uring.c
> > @@ -2694,10 +2694,9 @@ static int io_sqe_buffer_register(st
On Sun, Jul 14, 2019 at 11:47:37AM -0400, Keyur Patel wrote:
> I didn't get you. I stiil need to update changelog and send more
> version or not. If you say so, I can send one more.
Please note that the person/bot you are responding to is on in my email
blacklist, and many others, so I wouldn't w
Hi!
> >> Changelog from v1:
> >> o resend the whole filesystem into a patchset suggested by Greg;
> >> o code is more cleaner, especially for decompression frontend.
> >>
> >> --8<--
> >>
> >> Hi,
> >>
> >> EROFS file system has been in Linux-staging for about a year.
> >> It has been pr
On 2019/7/15 15:56, Pavel Machek wrote:
> Hi!
>
Changelog from v1:
o resend the whole filesystem into a patchset suggested by Greg;
o code is more cleaner, especially for decompression frontend.
--8<--
Hi,
EROFS file system has been in Linu
Fixed check patch warnings: converting all 'unsigned' to 'unsigned int'
Signed-off-by: Pratik Shinde
---
drivers/staging/erofs/internal.h | 7 ---
drivers/staging/erofs/unzip_pagevec.h | 11 ++-
drivers/staging/erofs/unzip_vle.h | 8
drivers/staging/erofs/xattr.h
Hello,
I am Barr Fredrick Mbogo a business consultant i have a lucrative
business to discuss with you from the Eastern part of Africa Uganda to
be precise aimed at agreed percentage upon your acceptance of my hand
in business and friendship. Kindly respond to me if you are interested
to partner wi
On 2019/7/15 18:43, Pratik Shinde wrote:
> Fixed check patch warnings: converting all 'unsigned' to 'unsigned int'
>
> Signed-off-by: Pratik Shinde
oops, should be "staging: erofs: converting all 'unsigned' to 'unsigned int'"..
^
My fault... maybe Greg could fi
Fixed checkpatch warnings: converting all 'unsigned' to 'unsigned int'
Signed-off-by: Pratik Shinde
---
drivers/staging/erofs/internal.h | 7 ---
drivers/staging/erofs/unzip_pagevec.h | 11 ++-
drivers/staging/erofs/unzip_vle.h | 8
drivers/staging/erofs/xattr.h
On 2019/7/15 19:29, Pratik Shinde wrote:
> Fixed checkpatch warnings: converting all 'unsigned' to 'unsigned int'
>
> Signed-off-by: Pratik Shinde
Bump version number and add my reviewed-by tag if you resend again...
since no idea which version is the latest version...
Thanks,
Gao Xiang
> -
Fixed checkpatch warnings: converting all 'unsigned' to 'unsigned int'
Signed-off-by: Pratik Shinde
Reviewed-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 7 ---
drivers/staging/erofs/unzip_pagevec.h | 11 ++-
drivers/staging/erofs/unzip_vle.h | 8
drivers
From: Shailendra Verma
[ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]
Fix to avoid possible memory leak if the decoder initialization
got failed.Free the allocated memory for file handle object
before return in case decoder initialization fails.
Signed-off-by: Shailendra Verma
Si
From: Fabio Estevam
[ Upstream commit 2b393f91c651c16d5c09f5c7aa689e58a79df34e ]
Currently the return value from clk_bulk_prepare_enable() is checked,
but it is not propagate it in the case of failure.
Fix it and also move the error message to the caller of
mipi_csis_clk_enable().
Signed-off-b
From: Colin Ian King
[ Upstream commit a84e355ecd3ed9759d7aaa40170aab78e2a68a06 ]
There are three error return paths that don't kfree params causing a
memory leak. Fix this by adding an error return path that kfree's
params before returning. Also add a check to see params failed to
be allocate
From: Shailendra Verma
[ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]
Fix to avoid possible memory leak if the decoder initialization
got failed.Free the allocated memory for file handle object
before return in case decoder initialization fails.
Signed-off-by: Shailendra Verma
Si
From: Fabio Estevam
[ Upstream commit 2b393f91c651c16d5c09f5c7aa689e58a79df34e ]
Currently the return value from clk_bulk_prepare_enable() is checked,
but it is not propagate it in the case of failure.
Fix it and also move the error message to the caller of
mipi_csis_clk_enable().
Signed-off-b
From: Shailendra Verma
[ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]
Fix to avoid possible memory leak if the decoder initialization
got failed.Free the allocated memory for file handle object
before return in case decoder initialization fails.
Signed-off-by: Shailendra Verma
Si
On Thu, 2019-07-11 at 16:31 +0800, Phil Reid wrote:
> GPIO probing and reset polarity are broken.
> Fix them.
>
> Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface")
>
> Phil Reid (2):
> Staging: fbtft: Fix probing of gpio descriptor
> Staging: fbtft: Fix reset a
We actually want to set the gpio pin if it's avilable, not the other way
around.
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/fbtft/fbtft-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Shailendra Verma
[ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]
Fix to avoid possible memory leak if the decoder initialization
got failed.Free the allocated memory for file handle object
before return in case decoder initialization fails.
Signed-off-by: Shailendra Verma
Si
From: Shailendra Verma
[ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]
Fix to avoid possible memory leak if the decoder initialization
got failed.Free the allocated memory for file handle object
before return in case decoder initialization fails.
Signed-off-by: Shailendra Verma
Si
From: Shailendra Verma
[ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]
Fix to avoid possible memory leak if the decoder initialization
got failed.Free the allocated memory for file handle object
before return in case decoder initialization fails.
Signed-off-by: Shailendra Verma
Si
Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
interface") breaks GPIO handling. In several places, checks to only set
a GPIO if it was configured ended up backwards.
I have tested this fix. The fixed driver works with a ili9486
display connected to a raspberry pi via SPI.
Fix
Coincidentially, I've worked on the exact same issue this weekend. I can
confirm this change is necessary, and with this and the other two patches from
Phil Reid the driver works again. The same mistake occurred in several other
locations, though. I'll send a patch fixing all of them.
I've test
On Tue, 2019-07-16 at 00:04 +0900, Jan Sebastian Götte wrote:
> Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface") breaks GPIO handling. In several places, checks to only set
> a GPIO if it was configured ended up backwards.
> I have tested this fix. The fixed driver
From: Christian Luciano Moreno
Align code to match open parenthesis and tabs before statements.
Signed-off-by: Christian Luciano Moreno
---
drivers/staging/rtl8712/rtl871x_xmit.h | 30 +-
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rt
On Mon, Jul 15, 2019 at 12:26:54PM +0530, Bharath Vedartham wrote:
> On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote:
> > On 7/14/19 12:08 PM, Bharath Vedartham wrote:
> > > This patch converts all call sites of get_user_pages
> > > to use put_user_page*() instead of put_page*() functi
From: Christian Luciano Moreno
Fix: line over 80 characters
space unnecesary after cast
alignment match open parenthesis
comparison to NULL
Those warnings and check were reported by checkpatch.
Signed-off-by: Christian Luciano Moreno
---
drivers/staging/rtl8712/rtl871x_xmit.c |
As init_mlme_ext_priv function always returns SUCCESS , We can change
return type from int to void.
Fixes below issue identified by coccicheck
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded
variable: "res". Return "_SUCCESS" on line 492
Signed-off-by: Hariprasad Kelam
---
drive
On 7/14/19 11:56 PM, Bharath Vedartham wrote:
> On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote:
>> On 7/14/19 12:08 PM, Bharath Vedartham wrote:
[...]
>> 1. Pull down https://github.com/johnhubbard/linux/commits/gup_dma_core
>> and find missing conversions: look for any additional mis
On Mon, Jul 15, 2019 at 09:29:53AM -0700, Ira Weiny wrote:
> On Mon, Jul 15, 2019 at 12:26:54PM +0530, Bharath Vedartham wrote:
> > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote:
> > > On 7/14/19 12:08 PM, Bharath Vedartham wrote:
> > > > This patch converts all call sites of get_use
On Mon, Jul 15, 2019 at 11:10:20AM -0700, John Hubbard wrote:
> On 7/14/19 11:56 PM, Bharath Vedartham wrote:
> > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote:
> >> On 7/14/19 12:08 PM, Bharath Vedartham wrote:
> [...]
> >> 1. Pull down https://github.com/johnhubbard/linux/commits/g
On Thu, Jul 04, 2019 at 05:38:00PM +0200, Sebastian Andrzej Siewior wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
>
> Use spinlock_t for spinlock's definition.
>
> Cc: Greg Kroah-Hartman
> Cc: Christian Gromm
> Cc: de...@driverdev.osuosl.org
> Signed-
There have been issues with get_user_pages and filesystem writeback.
The issues are better described in [1].
The solution being proposed wants to keep track of gup_pinned pages which will
allow to take furthur steps to coordinate between subsystems using gup.
put_user_page() simply calls put_pag
On Mon, Jul 15, 2019 at 08:51:30AM +0200, Emanuel Bennici wrote:
> As per TODO ,remove code valid only for 5 GHz(channel > 14).
>
> Signed-off-by: Hariprasad Kelam
> Reviewed-by: Emanuel Bennici
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +-
> 1 file changed, 1 insertion(+),
On Sat, Jul 13, 2019 at 06:26:52PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Add parenthesis to Macro argument to avoid precedence issues.
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/basic_types.h | 2 +-
> 1 file changed, 1
On Sat, Jul 13, 2019 at 06:47:20PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Fix alignment check reported by checkpatch.
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/recv_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On Sat, Jul 13, 2019 at 09:20:05PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Change local variable name to avoid CamelCase.
> Align code to the open parenthesis to fix alignment issues.
That is two different things, right?
So it should be 2 patches.
thanks
On Sat, Jul 13, 2019 at 06:47:20PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Fix alignment check reported by checkpatch.
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/recv_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On Mon, Jul 15, 2019 at 02:17:04PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Fix: line over 80 characters
> space unnecesary after cast
> alignment match open parenthesis
> comparison to NULL
> Those warnings and check were reported by checkpat
On Sat, Jul 13, 2019 at 06:57:43PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 1 -
> 1 file changed, 1 deletion(-)
I can't take patches without any changelog
On 7/15/19 12:52 PM, Bharath Vedartham wrote:
> There have been issues with get_user_pages and filesystem writeback.
> The issues are better described in [1].
>
> The solution being proposed wants to keep track of gup_pinned pages which
> will allow to take furthur steps to coordinate between sub
On Mon, Jul 15, 2019 at 01:14:13PM -0700, John Hubbard wrote:
> On 7/15/19 12:52 PM, Bharath Vedartham wrote:
> > There have been issues with get_user_pages and filesystem writeback.
> > The issues are better described in [1].
> >
> > The solution being proposed wants to keep track of gup_pinned p
From: John Hubbard
Hi everyone,
This is an easy, drive-by cleanup that I did while reviewing Bharath's
changes to convert over to put_user_page(). It should make the code less
obviously non-conforming, and therefore help future reviews and cleanups.
This is on top of latest linux.git, commit fe
From: John Hubbard
This commit was created by running indent(1):
`indent -linux`
...and then applying some manual corrections and
cleanup afterward, to keep it sane. No functional changes
were made.
In addition to whitespace changes, some strings were split,
but not strings that were likely
There have been issues with get_user_pages and filesystem writeback.
The issues are better described in [1].
The solution being proposed wants to keep track of gup_pinned pages
which will allow to take furthur steps to coordinate between subsystems
using gup.
put_user_page() simply calls put_page
On 7/15/19 2:47 PM, Matt Sickler wrote:
> It looks like Outlook is going to absolutely trash this email. Hopefully it
> comes through okay.
>
...
>>
>> Because this is a common pattern, and because the code here doesn't likely
>> need to set page dirty before the dma_unmap_sg call, I think the f
It looks like Outlook is going to absolutely trash this email. Hopefully it
comes through okay.
>> There have been issues with get_user_pages and filesystem writeback.
>> The issues are better described in [1].
>>
>> The solution being proposed wants to keep track of gup_pinned pages
>which will
On 7/15/19 3:01 PM, John Hubbard wrote:
> On 7/15/19 2:47 PM, Matt Sickler wrote:
...
> I agree: the PageReserved check looks unnecessary here, from my
> outside-the-kpc_2000-team
> perspective, anyway. Assuming that your analysis above is correct, you could
> collapse that
> whole think into jus
On 7/15/19 3:21 PM, Joe Perches wrote:
> On Mon, 2019-07-15 at 14:21 -0700, john.hubb...@gmail.com wrote:
>> From: John Hubbard
>>
>> This commit was created by running indent(1):
>> `indent -linux`
>>
>> ...and then applying some manual corrections and
>> cleanup afterward, to keep it sane. N
On Mon, 2019-07-15 at 14:21 -0700, john.hubb...@gmail.com wrote:
> From: John Hubbard
>
> This commit was created by running indent(1):
> `indent -linux`
>
> ...and then applying some manual corrections and
> cleanup afterward, to keep it sane. No functional changes
> were made.
I don't fin
GPIO probing and reset polarity are broken.
Fix them.
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Changes from v2:
- Add fixes tag to "Fix reset assertion when using gpio descriptor"
- Add tested-by / reviewed-by tags
Phil Reid (2):
Staging: fbtft: Fix probi
Conversion to use gpio descriptors broke all gpio lookups as
devm_gpiod_get_index was converted to use dev->driver->name for
the gpio name lookup. Fix this by using the name param. In
addition gpiod_get post-fixes the -gpios to the name so that
shouldn't be included in the call. However this then b
Typically gpiod_set_value calls would assert the reset line and
then release it using the symantics of:
gpiod_set_value(par->gpio.reset, 0);
... delay
gpiod_set_value(par->gpio.reset, 1);
And the gpio binding would specify the polarity.
Prior to conversion to gpiod calls th
Change indentation to match parentheses. This complies with the Linux
kernel coding style and improves readability.
Signed-off-by: Benjamin Sherman
---
drivers/staging/vt6656/rxtx.c| 10 +-
drivers/staging/vt6656/usbpipe.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
d
tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
head: a0738df2bf14f1a7151465012ab48e55c317a4f6
commit: 2b24e4775e3c329bb9fdc4539a50178139d26e40 [24/55] drm: make
.debugfs_init and drm_debugfs_create_files() return void
config: arm-allmodc
Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/mt7621-pi
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in two places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
--
57 matches
Mail list logo
