On Wed, Jun 26, 2019 at 11:52:25AM -0700, Steve Longerbeam wrote:
> Fix a cut&paste error in find_pipeline_entity(). The start entity must be
> passed to media_entity_to_video_device() in find_pipeline_entity(), not
> pad->entity. The pad is only put to use later, after determining the start
> enti
> Dave
>
> PS Is linux-rpi-kernel actually behaving for other people? I didn't
> see this patch when it was submitted, and it isn't showing in the list
> archive either.
No, but it never really has for me, it's always been weird in what it
allows through by default and the admin has to approve a
The coding-styles.rst states, that multiline comments should
allways contain a leading "*" in each line.
For multiline comments in general they
/*
* should look
* like this.
*/
For multiline comments in either net/ or drivers/net/ however,
they should
/* omit
* the first
* empty line.
*/
As stated in coding-styles.rst multiline comments should be structured in a way,
that the actual comment starts on the second line of the commented portion. E.g:
/*
* Multiline comments
* should look like
* this.
*/
However, there is an exception to files in drivers/net/ and net/, where
multi
On 2019/6/27 13:31, Shobhit Kukreti wrote:
> Resolve checkpatch warning:
> Prefer kzalloc(sizeof(*ptr)...) over kzalloc(sizeof(struct ..)
>
> Signed-off-by: Shobhit Kukreti
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.
From: Yue Hu
We should consider the error returned by fill_inline_data() when filling
last page in fill_inode(). If not getting inode will be successful even
though last page is bad. That is illogical. Also change -EAGAIN to 0 in
fill_inline_data() to stand for successful filling.
Signed-off-by:
On Wed, Jun 26, 2019 at 08:23:17PM +0800, gre...@linuxfoundation.org wrote:
> On Wed, Jun 26, 2019 at 10:44:38AM +, Xin Ji wrote:
> > Move analogix chip ANX78XX bridge driver into "analogix" directory.
> >
> > Signed-off-by: Xin Ji
> > ---
> > drivers/gpu/drm/bridge/Kconfig
Hello Xin Ji,
Thank you for the patch.
On Thu, Jun 27, 2019 at 11:29:47AM +, Xin Ji wrote:
> Move analogix chip ANX78XX bridge driver into "analogix" directory.
>
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/Kconfig | 10 --
> drivers/gpu/drm/bri
Cleanup the line over 80 character warnings, reported by checkpatch
Signed-off-by: Lukas Schneider
Signed-off-by: Jannik Moritz
Cc:
---
drivers/staging/fbtft/fbtft-sysfs.c | 3 ++-
drivers/staging/fbtft/fbtft.h | 26 ++
2 files changed, 24 insertions(+), 5 deleti
Fix ERROR: Macros with complex values should be enclosed in parentheses,
reported by checkpatch.
Add a do {...} while (0) loop around the macro.
Signed-off-by: Lukas Schneider
Signed-off-by: Jannik Moritz
Cc:
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 6 --
1 file changed, 4 inse
Sorry, I don't feel like this makes it more readable.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This breaks the build. :(
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Move analogix chip ANX78XX bridge driver into "analogix" directory.
Signed-off-by: Xin Ji
---
drivers/gpu/drm/bridge/Kconfig | 10 --
drivers/gpu/drm/bridge/Makefile | 3 +--
drivers/gpu/drm/bridge/analogix/Kconfig | 10
On Thu, Jun 27, 2019 at 10:33:35AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a
> way,
> that the actual comment starts on the second line of the commented portion.
> E.g:
>
> /*
> * Multiline comments
> * should look like
> * th
On Thu, Jun 27, 2019 at 02:12:40PM +0200, Lukas Schneider wrote:
> Cleanup the line over 80 character warnings, reported by checkpatch
>
> Signed-off-by: Lukas Schneider
> Signed-off-by: Jannik Moritz
> Cc:
> ---
> drivers/staging/fbtft/fbtft-sysfs.c | 3 ++-
> drivers/staging/fbtft/fbtft.h
Hi Lukas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/l
rtw_malloc + memset(0) -> rtw_zmalloc
Signed-off-by: Fuqian Huang
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 ++--
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c| 12 +++-
2 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os
rtw_zmalloc already zeros the memory.
memset is unneeded.
Signed-off-by: Fuqian Huang
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 --
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drivers/staging/r
kmalloc + memset(0) -> kzalloc
Signed-off-by: Fuqian Huang
---
drivers/staging/rtl8712/rtl871x_io.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_io.c
b/drivers/staging/rtl8712/rtl871x_io.c
index 17dafeffd6f4..87024d6a465e 100644
--- a/dr
rtw_malloc + memset(0) -> rtw_zmalloc
Signed-off-by: Fuqian Huang
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
b/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
index 9db11b16c
Remove set but unsed variable pHalData in below functions
_InitOperationMode, SetHwReg8723BS.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/r
On Thu, Jun 27, 2019 at 09:38:35AM +0300, Dan Carpenter wrote:
> On Wed, Jun 26, 2019 at 11:14:59PM +0530, Hariprasad Kelam wrote:
> > @@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter,
> > u8 variable, u8 *val)
> > #endif
> > #endif
> >
> > - pHalData = GET_HAL_DATA(
On Thu, Jun 27, 2019 at 11:33:02PM +0530, Hariprasad Kelam wrote:
> Remove set but unsed variable pHalData in below functions
> _InitOperationMode, SetHwReg8723BS.
>
> Signed-off-by: Hariprasad Kelam
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -
> 1 file changed, 5 deletions(-)
On Thu, Jun 27, 2019 at 8:41 PM Fuqian Huang wrote:
>
> rtw_malloc + memset(0) -> rtw_zmalloc
I have a feeling that everything under os_dep folder should be
replaced with native kernel APIs.
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 ++--
> drivers/staging/rtl8723bs/os_dep/io
Remove set but unsed variable pHalData in below functions
_InitOperationMode, SetHwReg8723BS.
Signed-off-by: Hariprasad Kelam
---
v2 add clean change log
v3 remove unneeded blank lines
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/driver
Hi,
On Sat, Jun 08, 2019 at 12:55:39PM +0200, Wolfram Sang wrote:
> While preparing a refactoring series, I noticed that some drivers use a
> complicated way of determining the adapter of a client. The easy way is
> to use the intended pointer: client->adapter
>
> These drivers do:
> to_i2c
From: root
Fix following sparse warning
symbol was not declared. Should it be static?
Using plain integer as NULL pointer
Signed-off-by: Harsh Jain
---
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/kpc20
From: Dave Stevenson
H264 header come from VC with 0 timestamps, which means they get a
strange timestamp when processed with VC/kernel start times,
particularly if used with the inline header option.
Remember the last frame timestamp and use that if set, or otherwise
use the kernel start time.
From: Dave Stevenson
Fix checkpatch "Alignment should match open parenthesis"
errors.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 9
.../vc04_services/bcm2835-camera/controls.c| 25 ++
.../vc04_services/bcm2835-ca
From: Dave Stevenson
Fix checkpatch warnings over spaces around operators.
Many were around operations that can be replaced with the
BIT(x) macro, so replace with that where appropriate.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/controls.c| 32 +++--
From: Dave Stevenson
Fix checkpatch errors for missing blank lines after variable
or structure declarations.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/bcm2835
From: Dave Stevenson
Fix checkpatch errors "Avoid multiple line dereference"
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-cam
From: Dave Stevenson
The change to mapping V4L2 to MMAL buffers 1:1 didn't handle
the condition we get with raw pixel buffers (eg YUV and RGB)
direct from the camera's stills port. That sends the pixel buffer
and then an empty buffer with the EOS flag set. The EOS buffer
wasn't handled and return
From: Dave Stevenson
Fix several instances where it is easier to return
early on error conditions than handle it as an else
clause. As requested by Mauro.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 109 +++--
1 file changed, 58 insert
From: Dave Stevenson
There is an awkward situation with H264 header bytes. Currently
they are returned with a PTS of 0 because they aren't associated
with a timestamped frame to encode. These are handled by either
returning the timestamp of the last buffer to have been received,
or in the case of
From: Dave Stevenson
With the recent change to match MMAL and V4L2 buffers there
is a need to wait for all MMAL buffers to be returned during
stop_streaming.
Fixes: 938416707071 ("staging: bcm2835-camera: Remove V4L2/MMAL buffer
remapping")
Signed-off-by: Dave Stevenson
---
.../vc04_services/
From: Dave Stevenson
Forward MMAL key frame flags to the V4L2 buffers.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
b/drivers
From: Dave Stevenson
None of the listed author email addresses were valid.
Keep list of authors and the companies they represented.
Update my email address.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 9 +
drivers/staging/vc04_serv
From: Dave Stevenson
Before commit "staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping"
there was a need to ensure that there were sufficient buffers supplied from
the user to cover those being sent to the VPU (always 1).
Now the buffers are linked 1:1 between MMAL and V4L2,
therefore th
From: Dave Stevenson
When handling for V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER was added
the firmware would reject the setting if H264 hadn't already been
selected. This was fixed in the firmware at that point, but to
enable backwards compatibility the returned error was ignored.
That was Dec 2013
From: Dave Stevenson
vchi_bulk_queue_receive will queue up to a default of 4
bulk receives on a connection before blocking.
If called from the VCHI service_callback thread, then
that thread is unable to service the VCHI_CALLBACK_BULK_RECEIVED
events that would enable the queue call to succeed.
A
From: Dave Stevenson
We have numerous lines over 80 chars, or oddly split. Many
of these are due to using long enum names such as
MMAL_COMPONENT_CAMERA.
Reduce the length of these enum names.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 156 +++
From: Dave Stevenson
Fix mismatched or missing brace issues flagged by checkpatch.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 ++-
drivers/staging/vc04_services/bcm2835-camera/controls.c | 3 ++-
drivers/staging/vc04_services/bcm28
From: Dave Stevenson
Set the sequence number in vb2_v4l2_buffer mainly so the
latest v4l2-ctl reports the frame rate correctly.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 4
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.
From: Dave Stevenson
The commit "staging: bcm2835-camera: Replace open-coded idr with a struct idr."
replaced an internal implementation of an idr with the standard functions
and a spinlock. idr_alloc(GFP_KERNEL) can sleep whilst calling kmem_cache_alloc
to allocate the new node, but this is not
This is an attempt to help Dave Stevenson to get all the fixes and
improvements of the bcm2835-camera driver into mainline.
Mostly i only polished the commit logs for upstream.
The series based on the latest bugfix V2 of staging: bcm2835-camera: Restore
return behavior of ctrl_set_bitrate().
Dav
From: Dave Stevenson
Fix comment style violations in the header files.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/mmal-msg-format.h | 95 ---
.../vc04_services/bcm2835-camera/mmal-msg-port.h | 124 +--
.../vc04_services/bcm2835-camera/mmal
From: Dave Stevenson
Remove a todo which has been done.
Remove a template line that was redundant.
Make a comment clearer as to the non-obvious meaning of a field.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 11 +--
1 file changed, 1 inse
From: Dave Stevenson
mmal-common.h and mmal-msg.h didn't have the normal
ifndef FOO / define FOO / endif protection to stop it being
included multiple times. Add it.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/mmal-common.h | 3 +++
drivers/staging/vc04_servi
From: Dave Stevenson
Clear checkpatch complaints of "multiple assignments should be avoided"
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bc
From: Dave Stevenson
Fixes up all the checkpatch error "line over 80 characters" in
mmal-parameters.h
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/mmal-parameters.h | 261 +
1 file changed, 159 insertions(+), 102 deletions(-)
diff --git a/drivers/stag
From: Dave Stevenson
With V4L2_CID_COLORFX_CBCR calling ctrl_set_colfx it was incorrectly
assigning the colour values to the enable field of dev->colourfx
instead of the u and v fields.
Correct the assignments.
Reported as a Coverity issue
Detected by CoverityScan CID#1419711 ("Unused value")
From: Dave Stevenson
Controls of type MMAL_CONTROL_TYPE_STD_MENU call v4l2_ctrl_new_std_menu
with a max value and a mask. The max value is one of the defined
values for the control, however in the config array there are several
entries where raw numbers have been used instead. Replace these
with
From: Dave Stevenson
Most of the headers use ifndef FOO_H, whilst mmal-parameters.h
used ifndef __FOO_H.
Revise mmal-parameters.h to drop the underscores and make the
headers all consistent.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/mmal-parameters.h | 4 +
Fixes issues found by checkpatch:
- "WARNING: braces {} are not necessary for single statement blocks"
- "WARNING: braces {} are not necessary for any arm of this statement"
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000_spi.c | 39 ++-
1 file changed
Hi Dave,
Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit :
> From: Dave Stevenson
>
> H264 header come from VC with 0 timestamps, which means they get a
> strange timestamp when processed with VC/kernel start times,
> particularly if used with the inline header option.
> Remember the
Le jeudi 27 juin 2019 à 20:56 +0200, Stefan Wahren a écrit :
> From: Dave Stevenson
>
> There is an awkward situation with H264 header bytes. Currently
> they are returned with a PTS of 0 because they aren't associated
> with a timestamped frame to encode. These are handled by either
> returning
From: Dave Stevenson
The V4L2 control API was expanded to take 64 bit values in commit
0ba2aeb6dab (Apr 16 2014), but as this driver wasn't in the mainline
kernel at that point this was overlooked.
Update to use 64 bit values. This also fixes a couple of warnings
in 64 bit builds.
Signed-off-by
From: Dave Stevenson
Fixes a v4l2-compliance failure
v4l2-test-buffers.cpp(415): g_field() == V4L2_FIELD_ANY
The driver only ever produces progresive frames, so field should
always be set to V4L2_FIELD_NONE.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm283
From: Dave Stevenson
RGB3/BGR3 end up being 3 bytes per pixel, which meant that
the alignment code ended up trying to align using bitmasking
with a mask of 96.
That doesn't work, so switch to an arithmetic alignment for
those formats.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835
From: Dave Stevenson
Fixes a v4l2-compliance failure when passed a buffer that is
too small.
queue_setup wasn't handling the case where !(*nplanes), as
used from CREATE_BUFS and requiring the driver to sanity
check the provided buffer parameters. It was assuming that
it was always being used in t
From: Dave Stevenson
Fixes up a checkpatch error "Avoid using bool structure members
because of possible alignment issues".
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 12 ++--
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h |
On Mon, 17 Jun 2019, Dmitry Safonov wrote:
> @@ -196,7 +196,16 @@ void set_hv_tscchange_cb(void (*cb)(void))
> /* Make sure callback is registered before we write to MSRs */
> wmb();
>
> + /*
> + * As reenlightenment vector is global, there is no difference which
> + * C
On Thu, Jun 27, 2019 at 07:57:05PM +0800, Laurent Pinchart wrote:
> Hello Xin Ji,
>
> Thank you for the patch.
>
> On Thu, Jun 27, 2019 at 11:29:47AM +, Xin Ji wrote:
> > Move analogix chip ANX78XX bridge driver into "analogix" directory.
> >
> > Signed-off-by: Xin Ji
> > ---
> > drivers/g
rtw_zmalloc already zeroes the memory,
so memset is unneeded.
Signed-off-by: Fuqian Huang
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 --
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drivers/stagi
Use zeroing allocator rather than allocator followed with memset 0.
Signed-off-by: Fuqian Huang
---
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 3 +--
drivers/staging/rtl8712/rtl871x_io.c | 4 +---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 ++--
drivers/st
From: Yue Hu
Currently, we will check if inode layout is compression or inline if
the inode is special in fill_inode(). Also set ->i_mapping->a_ops for
it. That is pointless since the both modes won't be set for special
inode when creating EROFS filesystem image. So, let's avoid it.
Signed-off-b
Hi Yue,
On 2019/6/28 11:42, Yue Hu wrote:
> From: Yue Hu
>
> Currently, we will check if inode layout is compression or inline if
> the inode is special in fill_inode(). Also set ->i_mapping->a_ops for
> it. That is pointless since the both modes won't be set for special
> inode when creating ER
On Fri, 28 Jun 2019 11:50:21 +0800
Gao Xiang wrote:
> Hi Yue,
>
> On 2019/6/28 11:42, Yue Hu wrote:
> > From: Yue Hu
> >
> > Currently, we will check if inode layout is compression or inline if
> > the inode is special in fill_inode(). Also set ->i_mapping->a_ops for
> > it. That is pointless
Move analogix chip ANX78XX bridge driver into "analogix" directory.
Signed-off-by: Xin Ji
---
drivers/gpu/drm/bridge/Kconfig | 10 --
drivers/gpu/drm/bridge/Makefile | 3 +--
drivers/gpu/drm/bridge/analogix/Kconfig | 10
On Fri, 28 Jun 2019, Fuqian Huang wrote:
> Use zeroing allocator rather than allocator followed with memset 0.
Maybe it would be better to just change these to the appropriate kmalloc
and kzalloc calls.
You will need to check on whether locks are held to know whether the secon
argument should
71 matches
Mail list logo
