On Mon, 17 Jun 2019 11:40:34 +0300
Dan Carpenter wrote:
> On Sun, Jun 16, 2019 at 11:15:16AM +0100, Jonathan Cameron wrote:
> > On Fri, 14 Jun 2019 13:50:59 -0300
> > Melissa Wen wrote:
> >
> > > Remove idiom and use ternary operator for consistently trigger 0/1 value
> > > on variable declar
Cleanup checkpatch issues in usb_halinit.c.
CHECK: Lines should not end with a '('
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
Function hal_init_macaddr() just calls rtw_hal_set_hwreg().
Use rtw_hal_set_hwreg() directly and remove hal_init_macaddr().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 6 --
drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 ++-
drivers/staging/rtl8188eu/in
This patchset modifies two function return types to void.
The return values of the function are never checked and they always return
success.
This resolves coccicheck Unneeded variable warnings
PATCH[1/2] : This patch modifies return type of function loadparam() to void.
PATCH[2/2] : This patch
The function rtw_reset_drv_sw() return value is set to _SUCCESS.
The return value is never checked when the function is called.
Modified the return value to void to remove "Unneeded Variable warning
of coccicheck.
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/include/osdep_intf.h
The function static uint loadparam(struct adapter *padapter, _nic_hdl
pnetdev) return type is modified to void.
The initial return value was always returning _SUCCESS and the return value
is never checked when the function is called.
This resolves coccicheck warnings of unneeded variables.
Signed
Changed return type of function rtw_suspend_wow() to void.
The function always return _SUCCESS and the value is never
checked in the calling function.
Resolves coccicheck Unneeded variable "ret" warning.
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
dr
This patchset modifies function return types to void.
The return values of the function are never checked and
they always return success.
This resolves coccicheck Unneeded variable warnings.
PATCH[1/3]: This patch changes return type of rtw_suspend_normal() to
void
PATCH[2/3]: This patch change
rtw_init_default_value() func always returns a value (u8)_SUCCESS.
Modified return type to void to resolve coccicheck warnings
of unneeded variable.
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --
Coccicheck issues Unneeded variable "ret" warning.
The return value of function rtw_suspend_normal() is set to _SUCCESS.
The return value is never never checked by the calling function.
Modified return type to void to remove the coccicheck warning..
Signed-off-by: Shobhit Kukreti
---
drivers/sta
On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 21/6/19 4:15 pm, Sergio Paracuellos wrote:
> > This patch series properly handle minor issues in this driver. These are:
> > * Disable pcie port clock on pci dirver instead of doing it in the phy
> >driver. The pci drive
Hi Brett,
On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote:
>
> On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote:
> >
> > Hi Sergio,
> >
> > On 21/6/19 4:15 pm, Sergio Paracuellos wrote:
> > > This patch series properly handle minor issues in this driver. These are:
> > > * Disable pcie po
12 matches
Mail list logo