The current way isn't safe for chained sgl, so use sg helper to
operate sgl.
Cc: de...@driverdev.osuosl.org
Cc: Greg Kroah-Hartman
Signed-off-by: Ming Lei
---
drivers/staging/unisys/visorhba/visorhba_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/sta
On 13/06/19 12:15 PM, Dan Carpenter wrote:
On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote:
Remove unused function eeprom_read_sz.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
This is great but you need to remove the declaration from the .h file
as well. I not
There are some backward incompatible features pending
for months, mainly due to on-disk format expensions.
However, we should ensure that it cannot be mounted with
old kernels. Otherwise, it will causes unexpected behaviors.
Fixes: ba2b77a82022 ("staging: erofs: add super block operations")
Cc:
On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote:
> On 13/06/19 12:15 PM, Dan Carpenter wrote:
> > On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote:
> > > Remove unused function eeprom_read_sz.
> > > Issue found with Coccinelle.
> > >
> > > Signed-off-by: Nishka Dasgu
On 13/06/19 2:05 PM, Dan Carpenter wrote:
On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote:
On 13/06/19 12:15 PM, Dan Carpenter wrote:
On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote:
Remove unused function eeprom_read_sz.
Issue found with Coccinelle.
Signed-off
On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> The DMA driver has call-backs for doing asynchronous I/O which are
> protected by a CONFIG_ macro which is not defined. Added a Kconfig
> stanza to define it.
>
> Cc: Matt Sickler
> Signed-off-by: Jeremy Sowden
> ---
> drivers/st
On 2019-06-13, at 10:45:31 +0200, Greg KH wrote:
> On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> > The DMA driver has call-backs for doing asynchronous I/O which are
> > protected by a CONFIG_ macro which is not defined. Added a Kconfig
> > stanza to define it.
> >
> > Cc: Matt
Hi Colin,
On Wed, Jun 12, 2019 at 4:42 PM Colin King wrote:
>
> From: Colin Ian King
>
> The pointer mpeg12 is being initialized however that value is never
> read and mpeg12 is being re-assigned almost immediately afterwards.
> Remove the redundant initialization.
>
> Addresses-Coverity: ("Unuse
On Thu, Jun 13, 2019 at 10:13:06AM +0100, Jeremy Sowden wrote:
> On 2019-06-13, at 10:45:31 +0200, Greg KH wrote:
> > On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> > > The DMA driver has call-backs for doing asynchronous I/O which are
> > > protected by a CONFIG_ macro which is n
The existing implementation for doing DMA via asynchronous IO didn't
work and there was no longer a use-case for it. Removed it.
Fixed a few checkpatch warnings about too-long lines and extraneous
braces in the process.
Reported-by: Matt Sickler
Signed-off-by: Jeremy Sowden
---
drivers/stagin
On Wed, Jun 12, 2019 at 07:59:57AM +0530, Hariprasad Kelam wrote:
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
>
> Signed-off-by: Hariprasad Kelam
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16
> 1 file changed, 8
On Wed, Jun 12, 2019 at 08:00:19AM +0530, Hariprasad Kelam wrote:
> CHECK: spaces preferred around that '+' (ctx:VxV)
> CHECK: spaces preferred around that '<<' (ctx:VxV)
> CHECK: spaces preferred around that '|' (ctx:VxV)
>
> Signed-off-by: Hariprasad Kelam
> ---
> drivers/staging/rtl8723bs/hal
On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> The current way isn't safe for chained sgl, so use sg helper to
> operate sgl.
I can not make any sense out of this changelog.
What "isn't safe"? What is a "sgl"?
Can this be applied "out of order"?
confused,
greg k-h
___
On Sat, Jun 08, 2019 at 12:56:10PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Please apply to your subsystem tree.
>
> drivers/staging/
On Sat, Jun 08, 2019 at 12:56:12PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Please apply to your subsystem tree.
>
> drivers/staging/
On Sat, Jun 08, 2019 at 12:56:11PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Please apply to your subsystem tree.
>
> drivers/staging/
On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > The current way isn't safe for chained sgl, so use sg helper to
> > operate sgl.
>
> I can not make any sense out of this changelog.
>
> What "isn't safe"? What is
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > The current way isn't safe for chained sgl, so use sg helper to
> > > operate sgl.
> >
> > I can not m
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > The current way isn't safe for chained sgl, so use sg helper to
> > > operate sgl.
> >
> > I can not m
Fixes checkpatch warning: "Consider removing the code enclosed by
this #if 0 and its #endif".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000/core.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
b/drivers/staging/kpc2000/kpc20
Hello,
I am Mr. Abdulahi Issa, from Burkina Faso in West African region. I
work with the Bank of Africa here Which i am the audit manager . Can
you safe Guard these amount( $13.5 Million USD) for me in your Country??
Further Details will be given to you if you show Interest.
Regards
Mr. Abdulah
This patch makes the modules net and video deregister its config subsystems
when the modules are removed from the kernel.
Signed-off-by: Christian Gromm
---
drivers/staging/most/net/net.c | 1 +
drivers/staging/most/video/video.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/
On Thu, 2019-06-13 at 12:16 +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> > On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > > The current way isn't safe for cha
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
head: 9831e93ace88fcb51c013ceca0b097133c8efb5f
commit: 9831e93ace88fcb51c013ceca0b097133c8efb5f [129/129] drm: huge cleanup...
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi
On Wed, 12 Jun 2019, Vitaly Kuznetsov wrote:
> Dmitry Safonov writes:
> > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> > index 1608050e9df9..0bdd79ecbff8 100644
> > --- a/arch/x86/hyperv/hv_init.c
> > +++ b/arch/x86/hyperv/hv_init.c
> > @@ -91,7 +91,7 @@ EXPORT_SYMBOL_GPL(h
Hello,
syzbot found the following crash on:
HEAD commit:d1fdb6d8 Linux 5.2-rc4
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15e5ce1ea0
kernel config: https://syzkaller.appspot.com/x/.config?x=cb38d33cd06d8d48
dashboard link: https://syzkaller.appspo
Cleaned up the code from the following files to get rid of
check patch error "that open brace { should be on the previous line"
drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/s
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one isn't
enough for the whole request.
Reviewed by: Ewan D. Milne
Signed-
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Reviewed-by: Ewan D. Milne
Signed-
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Reviewed-by: Ewan D. Milne
Signed-
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
Hi,
Scsi MQ makes a large static allocation for the first scatter gather
list chunk for the driver to use. This is a performance headache we'd
like to fix by reducing the size of the allocation to a 2 element
array. Doing this will break the current guarantee that any driver
using SG_ALL doesn't
Use the scatterlist iterators and remove direct indexing of the scatterlist
array.
This way allows us to pre-allocate one small scatterlist, which can be chained
with one runtime allocated scatterlist if the pre-allocated one isn't enough
for the whole request.
Reviewed-by: Ewan D. Milne
Signed-
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam
changes in v2: send proper patch without corruption
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18 +++
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Cc: de...@driverdev.osuosl.org
Cc:
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Cc: Oliver Neukum
Cc: Greg Kroah-H
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Cc: Steffen Maier
Cc: Benjamin Blo
From: Finn Thain
My understanding is that support for chained scatterlists is to
become mandatory for LLDs.
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocate
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
Use the scatterlist iterators and remove direct indexing of the
scatterlist array.
This way allows us to pre-allocate one small scatterlist, which can be
chained with one runtime allocated scatterlist if the pre-allocated one
isn't enough for the whole request.
Signed-off-by: Ming Lei
---
drive
This patch fixes below issues reported by checkpatch
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '<<' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Hariprasad Kelam
--
changes in v2: Send proper patch without corruption
This patch fixes below issue reported by checkpatch
CHECK: Comparison to NULL could be written "psta"
CHECK: Comparison to NULL could be written "psta"
Signed-off-by: Hariprasad Kelam
-
changes in v2: Send proper patch with out corruption
---
drivers/staging/rtl8723bs/hal/sdio_halinit.
Hi Ming,
On Fri, 14 Jun 2019, Ming Lei wrote:
> Use the scatterlist iterators and remove direct indexing of the
> scatterlist array.
>
> This way allows us to pre-allocate one small scatterlist, which can be
> chained with one runtime allocated scatterlist if the pre-allocated one
> isn't enough
On Fri, 14 Jun 2019, Ming Lei wrote:
> Use the scatterlist iterators and remove direct indexing of the
> scatterlist array.
>
> This way allows us to pre-allocate one small scatterlist, which can be
> chained with one runtime allocated scatterlist if the pre-allocated one
> isn't enough for the w
On Fri, Jun 14, 2019 at 10:53:09AM +0800, Ming Lei wrote:
> Use the scatterlist iterators and remove direct indexing of the
> scatterlist array.
>
> This way allows us to pre-allocate one small scatterlist, which can be
> chained with one runtime allocated scatterlist if the pre-allocated one
> is
On Fri, Jun 14, 2019 at 03:39:10PM +1000, Finn Thain wrote:
> On Fri, 14 Jun 2019, Ming Lei wrote:
>
> > Use the scatterlist iterators and remove direct indexing of the
> > scatterlist array.
> >
> > This way allows us to pre-allocate one small scatterlist, which can be
> > chained with one runti
50 matches
Mail list logo