[PATCH 1/2] staging: kpc2000: kpc2000_i2c: void* -> void *

2019-06-08 Thread Hao Xu
modify void* to void * for #define inb_p(a) readq((void*)a) and #define outb_p(d,a) writeq(d,(void*)a) Signed-off-by: Hao Xu --- drivers/staging/kpc2000/kpc2000_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/

[PATCH 2/2] staging: kpc2000: kpc2000_i2c: add space after ,

2019-06-08 Thread Hao Xu
add space after , for #define outb_p(d,a) writeq(d,(void *)a) Signed-off-by: Hao Xu --- drivers/staging/kpc2000/kpc2000_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c index de3a0c8..69e8773

[PATCH] staging: erofs: fix warning Comparison to bool

2019-06-08 Thread Hariprasad Kelam
fix below warnings reported by coccicheck drivers/staging/erofs/unzip_vle.c:332:11-18: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/erofs/unzip_vle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drive

[PATCH] staging: erofs: make use of DBG_BUGON

2019-06-08 Thread Hariprasad Kelam
DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. replace BUG_ON with DBG_BUGON. Signed-off-by: Hariprasad Kelam --- drivers/staging/erofs/unzip_vle.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/er

[PATCH 00/34] treewide: simplify getting the adapter of an I2C client

2019-06-08 Thread Wolfram Sang
While preparing a refactoring series, I noticed that some drivers use a complicated way of determining the adapter of a client. The easy way is to use the intended pointer: client->adapter These drivers do: to_i2c_adapter(client->dev.parent); The I2C core populates the parent pointer as:

[PATCH 33/34] staging: media: soc_camera: soc_mt9v022: simplify getting the adapter of a client

2019-06-08 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/st

[PATCH 31/34] staging: media: soc_camera: imx074: simplify getting the adapter of a client

2019-06-08 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/imx074.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 32/34] staging: media: soc_camera: mt9t031: simplify getting the adapter of a client

2019-06-08 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/mt9t031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagin

Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding

2019-06-08 Thread Jonathan Cameron
On Thu, 6 Jun 2019 16:52:14 +0100 Jonathan Cameron wrote: > On Thu, 6 Jun 2019 11:13:52 + > "Ardelean, Alexandru" wrote: > > > On Wed, 2019-06-05 at 17:35 -0300, Renato Lui Geh wrote: > > > [External] > > > > > > > > > On 05/26, Jonathan Cameron wrote: > > > > On Fri, 24 May 2019 22

Re: [PATCH v2 2/2] MAINTAINERS: add entry for ad7780 adc driver

2019-06-08 Thread Jonathan Cameron
On Fri, 24 May 2019 22:26:55 -0300 Renato Lui Geh wrote: > This patch adds a MAINTAINERS entry for the AD7780 ADC driver. > > Signed-off-by: Renato Lui Geh Applied to the togreg branch of iio.git and pushed out as testing to be completely ignored by the autobuilders. Thanks, Jonathan > --- >

Re: [PATCH v2 1/4] iio: adc: ad7606: Move oversampling and scale options to chip info

2019-06-08 Thread Jonathan Cameron
On Mon, 27 May 2019 15:56:47 +0300 Beniamin Bia wrote: > The device dependent options which are going to be different for devices > which will be supported in the future by this driver, > were moved in chip info for a more generic driver. This patch allows > supporting more devices by the driver

[PATCH] staging: davinci: fix memory leaks and check for allocation failure

2019-06-08 Thread Colin King
From: Colin Ian King There are three error return paths that don't kfree params causing a memory leak. Fix this by adding an error return path that kfree's params before returning. Also add a check to see params failed to be allocated. Addresses-Coverity: ("Resource leak") Fixes: da43b6ccadcf

Re: [PATCH v2 2/4] iio: adc: ad7606: Add software configuration

2019-06-08 Thread Jonathan Cameron
On Mon, 27 May 2019 15:56:48 +0300 Beniamin Bia wrote: > Because this driver will support multiple configurations for software, > the software configuration was made generic. > > Signed-off-by: Beniamin Bia > Acked-by: Jonathan Cameron Applied to the togreg branch of iio.git and pushed out as

Re: [PATCH v2 3/4] iio: adc: ad7606: Add support for software mode for ad7616

2019-06-08 Thread Jonathan Cameron
On Mon, 27 May 2019 15:56:49 +0300 Beniamin Bia wrote: > Support for ad7616 running in software was added. In order > to activate the software mode, HW_RNGSEL pins must be pulled low. > Oversampling and input ranges are now configured in corresponding > registers. Ad7616 has multiple scale option

Re: [PATCH v2 4/4] iio: adc: ad7606: Add debug mode for ad7616

2019-06-08 Thread Jonathan Cameron
On Mon, 27 May 2019 15:56:50 +0300 Beniamin Bia wrote: > Support for register access was added for spi devices. > > Signed-off-by: Beniamin Bia > Acked-by: Jonathan Cameron Applied. Thanks, Jonathan > --- > Changes in v2: > -nothing changed > > drivers/iio/adc/ad7606.c | 25 ++

[PATCH AUTOSEL 5.1 07/70] staging: wilc1000: Fix some double unlock bugs in wilc_wlan_cleanup()

2019-06-08 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit fea69916360468e364a4988db25a5afa835f3406 ] If ->hif_read_reg() or ->hif_write_reg() fail then the code unlocks and keeps executing. It should just return. Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by: Dan Carpenter S

[PATCH AUTOSEL 5.1 05/70] staging: erofs: set sb->s_root to NULL when failing from __getname()

2019-06-08 Thread Sasha Levin
From: Chengguang Xu [ Upstream commit f2dcb8841e6b155da098edae09125859ef7e853d ] Set sb->s_root to NULL when failing from __getname(), so that we can avoid double dput and unnecessary operations in generic_shutdown_super(). Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Reviewed-by: Gao Xi

[PATCH AUTOSEL 5.1 06/70] Staging: vc04_services: Fix a couple error codes

2019-06-08 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit ca4e4efbefbbdde0a7bb3023ea08d491f4daf9b9 ] These are accidentally returning positive EINVAL instead of negative -EINVAL. Some of the callers treat positive values as success. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.

[PATCH AUTOSEL 4.19 03/49] Staging: vc04_services: Fix a couple error codes

2019-06-08 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit ca4e4efbefbbdde0a7bb3023ea08d491f4daf9b9 ] These are accidentally returning positive EINVAL instead of negative -EINVAL. Some of the callers treat positive values as success. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.

[PATCH AUTOSEL 4.14 01/31] Staging: vc04_services: Fix a couple error codes

2019-06-08 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit ca4e4efbefbbdde0a7bb3023ea08d491f4daf9b9 ] These are accidentally returning positive EINVAL instead of negative -EINVAL. Some of the callers treat positive values as success. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.

[PATCH] staging: fsl-dpaa2/ethsw: fix memory leak of switchdev_work

2019-06-08 Thread Colin King
From: Colin Ian King In the default event case switchdev_work is being leaked because nothing is queued for work. Fix this by kfree'ing switchdev_work before returning NOTIFY_DONE. Addresses-Coverity: ("Resource leak") Fixes: 44baaa43d7cc ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet

Re: [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

2019-06-08 Thread Jonathan Cameron
On Wed, 5 Jun 2019 20:24:09 -0700 Randy Dunlap wrote: > On 6/5/19 7:05 PM, Fabio Estevam wrote: > > On x86_64 when GPIOLIB is not set the following build errors > > are seen: > > > > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of > > function 'gpiod_set_value' [-Werro

Re: [PATCH] staging: erofs: fix warning Comparison to bool

2019-06-08 Thread Gao Xiang
On 2019/6/8 ??5:39, Hariprasad Kelam wrote: > fix below warnings reported by coccicheck > > drivers/staging/erofs/unzip_vle.c:332:11-18: WARNING: Comparison to bool > > Signed-off-by: Hariprasad Kelam Reviewed-by: Gao Xiang Thanks, Gao Xiang > --- > drivers/staging/erofs/unzip_vle.c

Re: [PATCH] staging: erofs: make use of DBG_BUGON

2019-06-08 Thread Gao Xiang
On 2019/6/8 ??5:49, Hariprasad Kelam wrote: > DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG > (EROFS developping feature) is on. > replace BUG_ON with DBG_BUGON. > > Signed-off-by: Hariprasad Kelam Reviewed-by: Gao Xiang Thanks, Gao Xiang > --- > drivers/staging/e

Re: [PATCH 1/2] staging: kpc2000: kpc2000_i2c: void* -> void *

2019-06-08 Thread Geordan Neukum
On Sat, Jun 08, 2019 at 03:27:46PM +0800, Hao Xu wrote: > modify void* to void * for #define inb_p(a) readq((void*)a) > and #define outb_p(d,a) writeq(d,(void*)a) > > Signed-off-by: Hao Xu > --- > drivers/staging/kpc2000/kpc2000_i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

[PATCH] Staging: rts5208: fixed brace coding style issue

2019-06-08 Thread xabi1500
From: Xabier Etxezarreta Fixed a coding style issue checked with checkpatch.pl Signed-off-by: Xabier Etxezarreta --- drivers/staging/rts5208/rtsx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index fa59

Re: [PATCH] Staging: rts5208: fixed brace coding style issue

2019-06-08 Thread Greg KH
On Sat, Jun 08, 2019 at 03:53:35PM +0200, xabi1...@gmail.com wrote: > From: Xabier Etxezarreta > > Fixed a coding style issue checked with checkpatch.pl > > Signed-off-by: Xabier Etxezarreta > --- > drivers/staging/rts5208/rtsx.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > >

[PATCH] staging: isdn: To make hysdn_proc_entry static.

2019-06-08 Thread Rishiraj Manwatkar
Made hysdn_proc_entry static as suggested by Sparse tool. Signed-off-by: Rishiraj Manwatkar --- drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/isdn/hysdn/hysdn_procconf.c b/drivers/staging/isdn/hysdn/hysdn_

[PATCH] staging: rtl8723bs: fix indentation issues

2019-06-08 Thread Hariprasad Kelam
fix below issues reported by checkpatch CHECK: Please don't use multiple blank lines WARNING: space prohibited between function name and open parenthesis '(' +void _rtw_open_pktfile (_pkt *pktptr, struct pkt_file *pfile) WARNING: space prohibited before semicolon WARNING: space prohibited between