[PATCH] staging: rtl8723bs: core: rtw_mlme_ext.c: Remove unused variables

Remove variables that are declared and assigned values but not otherwise used. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH] staging: rtl8723bs: hal: rtl8723b_cmd.c: Remove variables

Remove variables that are declared and initialised but never used. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging

[PATCH] staging: rtl8723bs: core: Remove variable priority

Remove local variable change_priority, as it takes the value of the argument priority; as both of these variables are of type u8, priority can be modified without changing the value of its copy at the call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8

[PATCH] staging: rtl8723bs: hal: hal_btcoex.c: Remove variable

Remove variable and use the values directly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl

[PATCH] staging: rtl8723bs: hal: sdio_halinit.c: Remove variables

Remove the variables RegRATR and RegRRSR as they are never used after initialisation and assignment. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl872

[PATCH 2/2] staging: rtl8723bs: rtw_os_recvbuf_resource_free(): Change type

Change return type of function rtw_os_recvbuf_resource_free to void as its return value is never stored, checked or otherwise used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 +- 2 files changed

[PATCH 1/2] staging: rtl8723bs: rtw_os_recv_resource_alloc(): Change type

Remove assignment of the return value of rtw_os_recv_resource_alloc as this assignment at the call site is never used. Remove return statement from rtw_os_recv_resource_alloc() as its return variable is never used. Change the type of the function to void. Signed-off-by: Nishka Dasgupta --- drive

[PATCH] staging: rtl8723bs: os_dep: ioctl_linux.c: Remove return variables

Remove return variables and return the values directly, as the functions all return 0 in all cases. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/driv

Re: [PATCH] staging: rtl8723bs: Fix Unneeded variable: "ret". Return "0"

On Thu, 2019-06-06 at 20:10 -0700, Shobhit Kukreti wrote: > coccicheck reported Unneeded variable ret at > rtl8723bs/core/rtw_ap.c:1400. > Function "rtw_acl_remove_sta" always returns 0. Modified return type > of the > function to void. > > Signed-off-by: Shobhit Kukreti Looks good, thanks. Rev

[PATCH 2/2] staging: rtl8712: r8712_createbss_cmd(): Change

Change return values of r8712_createbss_cmd from _SUCCESS and _FAIL to 0 and -ENOMEM respectively. Change return type of the function from unsigned to int to reflect this. Change call site to check for 0 instead of _SUCCESS. (Instead of !=0, simply passing the function output to the conditional wil

[PATCH 1/2] staging: rtl8712: r8712_setdatarate_cmd(): Change

Change the return values of function r8712_setdatarate_cmd from _SUCCESS and _FAIL to 0 and -ENOMEM respectively. Change the return type of the function from u8 to int to reflect this. Change the call site of the function to check for 0 instead of _SUCCESS. (Checking that the return value != 0 is n

[PATCH v2] staging: rtl8188eu: core: Replace function rtw_free_network_nolock()

Remove function rtw_free_network_nolock, as all it does is call _rtw_free_network_nolock, and rename _rtw_free_network_nolock to rtw_free_network_nolock. Keep the new rtw_free_network_nolock a static function and remove the old version from the header file. Signed-off-by: Nishka Dasgupta --- dri

Re: [PATCH 1/2] staging: rtl8712: r8712_setdatarate_cmd(): Change

Probably you sent this patch unintentionally. The subject doesn't make any sort of sense. :P On Fri, Jun 07, 2019 at 07:36:57PM +0530, Nishka Dasgupta wrote: > Change the return values of function r8712_setdatarate_cmd from _SUCCESS > and _FAIL to 0 and -ENOMEM respectively. > Change the return

Re: [PATCH 2/2] staging: rtl8712: r8712_createbss_cmd(): Change

Fix the subject. On Fri, Jun 07, 2019 at 07:36:58PM +0530, Nishka Dasgupta wrote: > Change return values of r8712_createbss_cmd from _SUCCESS and _FAIL to 0 > and -ENOMEM respectively. > Change return type of the function from unsigned to int to reflect this. > Change call site to check for 0 inst

[PATCH v3 16/20] docs: fix broken documentation links

Mostly due to x86 and acpi conversion, several documentation links are still pointing to the old file. Fix them. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Wolfram Sang Reviewed-by: Sven Van Asbroeck Reviewed-by: Bhupesh Sharma Acked-by: Mark Brown --- Documentation/acpi/dsd/leds.txt