Modify return statement and remove the respective assignment.
Issue found by coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-ca
Hi Vatsala,
Am 29.04.2019 um 09:36 schrieb Vatsala Narang:
Modify return statement and remove the respective assignment.
Issue found by coccinelle.
i didn't check other occurences of the same issue since your last patch
(27.04.2019).
Could you please verify this is the last one of this type
On Mi, 2019-04-24 at 20:50 +0200, Eugeniu Rosca wrote:
> External E-Mail
>
>
> Hi Christian,
>
> On Tue, 08 May 2018 02:46:44 -0700, Christian Gromm wrote:
> >
> > This patch is needed as function snd_card_new needs a valid
> > parent device. Passing a NULL pointer leads to kernel Ooops
On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire wrote:
>
> wait_for_completion_timeout() returns unsigned long (0 on timeout or
> remaining jiffies) not int - so this type error allows for a
> theoretically int overflow - though not in this case where TIMEOUT is
> only HZ*2). To fix this type in
On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire wrote:
>
> V2: As requested by Sven Van Asbroeck make the
> impact of the patch clear in the commit message.
Thank you, but did you miss my comment about creating a local variable
instead? See:
https://lkml.org/lkml/2019/4/28/97
_
This patch resolves coding style brace warning and constant on right warning.
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Comparison to NULL could be written "!pbuf"
Signed-off-by: Vandana BN
Dear Sir,
MY NAME IS MR.UMARU YAR ADUA A CITIZEN OF NIGERIA NORTHERN PART.
I AM INTERESTED TO INVEST IN YOUR COUNTRY WITH SUM OF $25.6MILLION AND THE
MONEY BELONG TO MY LATE FATHER YAR ADUA.
HERE IN NIGERIA THE ECONOMY IS NOT ENCOURAGINGHOWEVER I WILL LIKE YOU TO TELL
ME HOW IS YOUR COUNTRY ECO
ACK. However, that part isn't the only part of that function that uses
"return rv" though.
There's another part that does "rv = get_user_pages(...)" and get_user_pages()
returns a long.
Does this same kind of change need to happen for that case?
>-Original Message-
>From: Nicholas Mc G
This patch solves the following checkpatch.pl message:
CHECK: Alignment should match open parenthesis.
This makes the file more compliant with the preferred coding style for
the Linux kernel.
Signed-off-by: João Seckler
---
drivers/staging/iio/addac/adt7316.c | 2 +-
1 file changed, 1 insertion(
On Mon, Apr 29, 2019 at 10:03:36AM -0400, Sven Van Asbroeck wrote:
> On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire wrote:
> >
> > V2: As requested by Sven Van Asbroeck make the
> > impact of the patch clear in the commit message.
>
> Thank you, but did you miss my comment about creating
On Tue, Apr 30, 2019 at 04:22:38AM +0200, Nicholas Mc Guire wrote:
> On Mon, Apr 29, 2019 at 10:03:36AM -0400, Sven Van Asbroeck wrote:
> > On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire wrote:
> > >
> > > V2: As requested by Sven Van Asbroeck make the
> > > impact of the patch clear in th
On Tue, Apr 30, 2019 at 04:02:23AM +0100, Al Viro wrote:
> On Tue, Apr 30, 2019 at 04:22:38AM +0200, Nicholas Mc Guire wrote:
> > On Mon, Apr 29, 2019 at 10:03:36AM -0400, Sven Van Asbroeck wrote:
> > > On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire
> > > wrote:
> > > >
> > > > V2: As requeste
On Tue, Apr 30, 2019 at 05:33:10AM +0200, Nicholas Mc Guire wrote:
> ok - my bad thn - I had assumed that using __force is reasonable
> if the handling is correct and its a localized conversoin only
> like var = be16_to_cpu(var) which evaded introducing additinal
> variables just to have differen
13 matches
Mail list logo
