Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding style error

On Sun, 2019-03-31 at 01:20 -0500, Alex Elder wrote: > On 3/31/19 1:04 AM, Joe Perches wrote: > > Blind adherence to 80 column limits leads to poor looking > > code. Especially with longish identifier lengths. > I agree. If it were me, I'd use a local variable. For example: > > struct gre

[PATCH] mips: ralink: allow to choose function which belongs with multiple groups

This allows the signals which can be assigned from multiple GPIO pins to be really assigned as expected. That one case is "refclk" signal in MT76x8. It was forcibily assigned to the pin matched by signal name at first. Eventually it always appears as GPIO #37. We cannot use refclk with the other

[PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h

Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Signed-off-by: Ojaswin Mujoo --- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/d

Re: [PATCH v3 1/5] staging: iio: adc: ad7280a: Tab alignment

On Sun, 24 Mar 2019 18:23:09 +0100 Cristian Sicilia wrote: > Aligned some parameters. > > Signed-off-by: Cristian Sicilia Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 36 ++-- >

Re: [PATCH v3 2/5] staging: iio: adc: ad7192: Converted bool to bitfield format

On Sun, 24 Mar 2019 18:23:11 +0100 Cristian Sicilia wrote: > Changed bool format to bitfield format to save space. > > Signed-off-by: Cristian Sicilia This driver is undergoing active rework to move out of staging and in the meantime these fields have been dropped. So not applied as no longer

Re: [PATCH v3 3/5] staging: iio: adc: ad7280a: Avoid precedence issues in macro

On Sun, 24 Mar 2019 18:23:12 +0100 Cristian Sicilia wrote: > Enclosing parameter with parenthesis due to avoid > possible precedence issue. > > Signed-off-by: Cristian Sicilia I've already applied this one. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 7 --- > 1 file cha

Re: [PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability

On Sun, 24 Mar 2019 18:23:14 +0100 Cristian Sicilia wrote: > Creating a temporary variable to improve readability > > Signed-off-by: Cristian Sicilia I have already applied this one. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 55 > ++- >

Re: [PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability

On Sun, 24 Mar 2019 18:23:14 +0100 Cristian Sicilia wrote: > Creating a temporary variable to improve readability > > Signed-off-by: Cristian Sicilia Already applied this one as well. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 55 > ++-

Re: [PATCH v3 5/5] staging: iio: adc: ad7280a: Remove CamelCase notation

On Sun, 24 Mar 2019 18:23:16 +0100 Cristian Sicilia wrote: > Fix CamelCase naming. > > Signed-off-by: Cristian Sicilia Already applied this one as well. So whole set has been applied. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 11 +-- > 1 file changed, 5 insertion

Hello Beautiful

Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think my

Re: [PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h

On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote: Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Above line should be after ---. Signed-off-by: Ojaswin Mujoo Although, it looks ok to me. but this is spread through out the tree and

Re: [PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h

On 3/31/2019 5:49 PM, Mukesh Ojha wrote: On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote: Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Above line should be after ---. Signed-off-by: Ojaswin Mujoo Although, it looks ok to me. b

Re: [PATCH] Staging: greybus: usb: Fixed a coding style error

On Sun, 2019-03-31 at 01:30 -0400, Will Cunningham wrote: > Line was >80 characters. [] > diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c [] > @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, > return -ENOMEM; > > connectio

Hello Dear

Hello dear, i hope this letter meets you well? my name is Jack, I know this may seem inappropriate so i ask for your forgiveness, i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am currently looking for a

[PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

Removed unnecessary parentheses.` Signed-off-by: Will Cunningham --- drivers/staging/comedi/drivers/pcl818.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index 0af5315d4357..da5d53a2

Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

On Sun, Mar 31, 2019 at 06:53:36PM -0400, Will Cunningham wrote: > Removed unnecessary parentheses.` Odd trailing character :( > > Signed-off-by: Will Cunningham > --- > drivers/staging/comedi/drivers/pcl818.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dr