Re: [PATCH v4] staging: ralink-gdma: Use u32 over uint32_t

On Sat, Mar 23, 2019 at 09:16:48PM +0530, Bharath Vedartham wrote: > Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" > > Signed-off-by: Bharath Vedartham > --- > Changes since v3 > - Fixed allignment issues. > - Submitted a seperate patch to change unsigned > to unsi

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > Signed-off-by: Bharath Vedartham > --- > drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch a

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote: > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > > > Signed-off-by: Bharath Vedartham > > --- > > drivers/staging/ralink-gdma/ralink-gdma.c

Re: [PATCH v4] staging: ralink-gdma: Use u32 over uint32_t

On Sun, Mar 24, 2019 at 09:58:33AM +0100, Greg KH wrote: > On Sat, Mar 23, 2019 at 09:16:48PM +0530, Bharath Vedartham wrote: > > Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" > > > > Signed-off-by: Bharath Vedartham > > --- > > Changes since v3 > > - Fixed allignment issues. >

[PATCH v2] staging: ralink-gdma: Change unsigned to unsigned int

This fixes the checkpatch.pl warning: "Prefer unsigned to unsigned int" Signed-off-by: Bharath Vedartham --- Changes since v1 - Based this patch of the staging branch and not linus's branch unlike the last patch. --- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file chan

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote: > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > > > Signed-off-by: Bharath Vedartham > > --- > > drivers/staging/ralink-gdma/ralink-gdma.c

[PATCH] staging: ralink-gdma: Remove space after cast

This fixes the checkpatch.pl check: "No space is necessary after the cast". Signed-off-by: Bharath Vedartham --- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/

Re: [PATCH v5 01/11] staging: iio: ad7780: add gain & filter gpio support

On Sat, 16 Mar 2019 17:46:40 + Jonathan Cameron wrote: > On Fri, 15 Mar 2019 23:12:27 -0300 > Renato Lui Geh wrote: > > > Previously, the AD7780 driver only supported gpio for the 'powerdown' > > pin. This commit adds suppport for the 'gain' and 'filter' pin. > > > > Signed-off-by: Renato

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

On Sun, Mar 24, 2019 at 03:07:48PM +0530, Bharath Vedartham wrote: > On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote: > > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > > > > > Signed-off-b

[RFC/PATCH] staging: olpc_dcon: Use WARN_ON instead of BUG_ON

This is with respect to a checkpatch.pl CHECK: "Avoid crashing the kernel. Use WARN_ON instead of BUG_ON". But I maybe wrong here. Is a kernel crash desired if olpc_board_at_least(olpc_board(0xc2)) fails, will there be inconsistent results if execution continues? Signed-off-by: Bharath Vedartham

Re: [RFC/PATCH] staging: olpc_dcon: Use WARN_ON instead of BUG_ON

On Sun, Mar 24, 2019 at 05:42:08PM +0530, Bharath Vedartham wrote: > This is with respect to a checkpatch.pl CHECK: "Avoid crashing the > kernel. Use WARN_ON instead of BUG_ON". But I maybe wrong here. Is a > kernel crash desired if olpc_board_at_least(olpc_board(0xc2)) fails, > will there be incon

Re: [PATCH v2 2/5] staging: iio: adc: Converted bool to bitfield format

On Sat, 23 Mar 2019 20:21:39 +0100 Cristian Sicilia wrote: > Changed bool format to bitfield format to save space. > > Signed-off-by: Cristian Sicilia > > --- > The strange thing is that this struct seems not populated > using a DTS binding function. Indeed and that should have definitely been

Re: [PATCH v2 1/5] staging: iio: adc: Tab alignment

On Sat, 23 Mar 2019 20:21:36 +0100 Cristian Sicilia wrote: > Aligned some parameters. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/iio/adc/ad7280a.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/staging/i

Re: [PATCH v2 3/5] staging: iio: adc: Avoid precedence issues in macro

On Sat, 23 Mar 2019 20:21:42 +0100 Cristian Sicilia wrote: > Enclosing parameter with parenthesis due to avoid > possible precedence issue. > > Signed-off-by: Cristian Sicilia Applied to the togreg branch of iio.git which will get first pushed out as testing for the autobuilders to play with it

Re: [PATCH v2 4/5] staging: iio: adc: Adding temp var to improve readability

On Sat, 23 Mar 2019 20:21:45 +0100 Cristian Sicilia wrote: > Creating a temporary variable to improve readability > > Signed-off-by: Cristian Sicilia Indeed makes it a little more readable, so fair enough. Applied Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 55 >

[PATCH 01/01] staging: vt6655: Modify comment style of SPDX License Identifier

From: Ganesh Biradar Fix the comment style of SPDX license identifier based on header file type Signed-off-by: Ganesh Biradar --- drivers/staging/vt6655/channel.h| 2 +- drivers/staging/vt6655/desc.h | 2 +- drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_cf

Re: pidfd design

On Wed, Mar 20, 2019 at 12:29:31PM -0700, Daniel Colascione wrote: > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner > wrote: > > I really want to see Joel's pidfd_wait() patchset and have more people > > review the actual code. > > Sure. But it's also unpleasant to have people write code and

[PATCH] staging: pi433: remove unnecessary calling rf69_set_mode()

Remove unnecessary rf69_set_mode() function call when rx is waiting for a telegram. There is waste to call rf69_set_mode() twice for becoming standby mode. Signed-off-by: Sidong Yang --- drivers/staging/pi433/pi433_if.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --g

Re: [PATCH v2 5/5] staging: iio: adc: Remove CamelCase notation

On Sat, 23 Mar 2019 20:21:49 +0100 Cristian Sicilia wrote: > Fix CamelCase naming. > > Signed-off-by: Cristian Sicilia Applied. Note that I added the part number to the titles of all these patches so that people can readily see what they are actually changing. Directory isn't very helpful when

Re: [PATCH v2 1/2] staging: iio: ad7280a: Add parentheses to macros

On Fri, 22 Mar 2019 00:15:27 +0300 Vladimir Petrigo wrote: > - Fix CHECK Macro argument 'c' may be better as '(c)' to avoid precedence > issues > - Fix CHECK Macro argument 'd' may be better as '(d)' to avoid precedence > issues > > Signed-off-by: Vladimir Petrigo Sorry, I ended up taking Cri

Re: [PATCH v2 2/2] staging: iio: ad7780: Add parentheses to macros

On Fri, 22 Mar 2019 00:15:28 +0300 Vladimir Petrigo wrote: > - Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid > precedence issues > > Signed-off-by: Vladimir Petrigo Hi Vladimir, This particular driver has recently moved out of staging and gained support for some

Re: Help on testing ad5933 driver

On Fri, 22 Mar 2019 22:34:21 +0200 Alexandru Ardelean wrote: > On Thu, Mar 21, 2019 at 9:39 PM Marcelo Schmitt > wrote: > > > > Hello, would anyone mind helping me test ad5933 driver on actual > > hardware? I went through this > > (https://oslongjourney.github.io/linux-kernel/experiment-one-iio

Re: [PATCH v2 1/5] staging: iio: adc: Tab alignment

On Sun, Mar 24, 2019 at 12:35:52PM +, Jonathan Cameron wrote: > On Sat, 23 Mar 2019 20:21:36 +0100 > Cristian Sicilia wrote: > > > Aligned some parameters. > > > > Signed-off-by: Cristian Sicilia > > --- > > drivers/staging/iio/adc/ad7280a.c | 36 ++-- > > 1 f

Re: [PATCH v2 2/5] staging: iio: adc: Converted bool to bitfield format

On Sun, Mar 24, 2019 at 12:34:52PM +, Jonathan Cameron wrote: > On Sat, 23 Mar 2019 20:21:39 +0100 > Cristian Sicilia wrote: > > > Changed bool format to bitfield format to save space. > > > > Signed-off-by: Cristian Sicilia > > > > --- > > The strange thing is that this struct seems not

Re: [PATCH v5 1/2] staging: iio: ad5933: change attributes to match ABI

On Thu, 21 Mar 2019 15:42:13 -0300 Marcelo Schmitt wrote: > Change device attributes' names to match ABI documentation. Names were > chosen such that they tend to be similar to existing ABI so it should > be easier to standardize them when necessary. > > Signed-off-by: Marcelo Schmitt > --- Cha

Re: [PATCH v5 2/2] staging: iio: ad5933: move out of staging

On Thu, 21 Mar 2019 15:42:37 -0300 Marcelo Schmitt wrote: > Move ad5933 impedance-analyzer driver from staging to mainline. The > ad5933 is a high precision impedance converter system solution that > combines an on-board frequency generator with an analog-to-digital > converter (ADC). This driver

[PATCH] staging: vc04_services: add missing __user annotations

This patch fixes the following sparse warnings by adding missing __user annotations. It also cleans up two related unnecessary casts by reuseing casts already made a few lines up. Remaining sparse warnings are of a different type. vchiq_arm.c:1606:14: warning: incorrect type in assignment (differe

[PATCH] staging: rtl8188eu: cleanup long line in odm.c

Align a comment to clear a line over 80 characters checkpatch warning. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index ba3c3

[PATCH v3 1/5] staging: iio: adc: ad7280a: Tab alignment

Aligned some parameters. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index d9df126..571535d

[PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability

Creating a temporary variable to improve readability Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 55 ++- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad

[PATCH v3 5/5] staging: iio: adc: ad7280a: Remove CamelCase notation

Fix CamelCase naming. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 4ff28f1..229dcad 100644 --- a/drivers/staging/i

[PATCH v3 2/5] staging: iio: adc: ad7192: Converted bool to bitfield format

Changed bool format to bitfield format to save space. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7192.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/adc/ad7192.h b/drivers/staging/iio/adc/ad7192.h index 7433a43..9c1d223

[PATCH v2 0/5] staging: iio: adc: Code refactoring and bool to bitfield change

Some source refactoring, parameters alignment and camel case clearing. Replacement of bool to bitfield in a struct, but not found the population to check if it is done correctly. Cristian Sicilia (5): staging: iio: adc: ad7280a: Tab alignment staging: iio: adc: ad7192: Converted bool to bitfi

[PATCH v3 3/5] staging: iio: adc: ad7280a: Avoid precedence issues in macro

Enclosing parameter with parenthesis due to avoid possible precedence issue. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c ind

[PATCH] drivers/staging: fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h

Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h Signed-off-by: ojaswin --- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/desc.h | 2 +- drivers/sta

[PATCH] staging: vt6655: Fix interrupt race condition on device start up.

It appears on some slower systems that the driver can find its way out of the workqueue while the interrupt is disabled by continuous polling by it. Move MACvIntEnable to vnt_interrupt_work so that it is always enabled on all routes out of vnt_interrupt_process. Move MACvIntDisable so that the de

[PATCH] staging: ralink-gdma: ralink-gdma.c fixed line width

Fix checkpatch issue: line over 80 characters Signed-off-by: Dominik Adamski --- drivers/staging/ralink-gdma/ralink-gdma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c index dfdc42555

Re: [PATCH] drivers/staging: fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h

On Sun, Mar 24, 2019 at 11:17:22PM +0530, ojaswin wrote: > Fix checkpatch.pl styling error related to SPDX-License-Identifier comment > in vt6656/*.h > > Signed-off-by: ojaswin We need a "real name" here, please see the kernel documentation about this for the details. thanks, greg k-h ___

[PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference

When kzalloc fails, "platform_state->inited = 1" is a NULL pointer dereference. The fix returns VCHIQ_ERROR in case it failed to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v5 2/2] staging: iio: ad5933: move out of staging

On Sun, 2019-03-24 at 16:38 +, Jonathan Cameron wrote: > > diff --git a/drivers/iio/impedance-analyzer/ad5933.c > > b/drivers/iio/impedance-analyzer/ad5933.c trivial note: > > +static void ad5933_calc_out_ranges(struct ad5933_state *st) > > +{ > > + int i; > > + unsigned int normalized_3

Re: [PATCH 1/3] staging: erofs: fix error handling when failed to read compresssed data

On 2019/3/19 21:54, Gao Xiang wrote: > Complete read error handling paths for all three kinds of > compressed pages: > > 1) For cache-managed pages, PG_uptodate will be checked since > read_endio will unlock and SetPageUptodate for these pages; > > 2) For inplaced pages, read_endio cannot S

Re: [PATCH 2/3] staging: erofs: introduce erofs_page_is_managed()

On 2019/3/19 21:55, Gao Xiang wrote: > 1) In order to clean up unnecessary >page->mapping == MNGD_MAPPING(sbi) wrapped by #ifdefs; > > 2) Needed by "staging: erofs: support IO read error injection". > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH 3/3] staging: erofs: support IO read error injection

On 2019/3/19 21:55, Gao Xiang wrote: > Used to simulate disk IO read error for testing fatal > error tolerance. > > Here are the details, > 1) use bio->bi_private to indicate super_block >for non-compressed bios since some (mainly meta) >pages can be of the corresponding bdev inode; > 2) g

Re: [PATCH 3/3] staging: erofs: support IO read error injection

Hi Chao, On 2019/3/25 9:47, Chao Yu wrote: > On 2019/3/19 21:55, Gao Xiang wrote: >> Used to simulate disk IO read error for testing fatal >> error tolerance. >> >> Here are the details, >> 1) use bio->bi_private to indicate super_block >>for non-compressed bios since some (mainly meta) >>

Re: [PATCH 1/3] staging: erofs: fix error handling when failed to read compresssed data

On 2019/3/22 11:25, Gao Xiang wrote: > ping? > > Hi Chao, > could you take some time looking into this series? Done, sorry for the delay. Thanks, > > Thanks, > Gao Xiang > > On 2019/3/19 21:54, Gao Xiang wrote: >> Complete read error handling paths for all three kinds of >> compressed pages:

Re: [PATCH 1/3] staging: erofs: fix error handling when failed to read compresssed data

Hi Chao, On 2019/3/25 10:05, Chao Yu wrote: > On 2019/3/22 11:25, Gao Xiang wrote: >> ping? >> >> Hi Chao, >> could you take some time looking into this series? > > Done, sorry for the delay. It doesn't matter. It is helpful for our kernel upgrade since it keeps up with the latest community code

[PATCH v2 2/3] staging: erofs: introduce erofs_page_is_managed()

1) In order to clean up unnecessary page->mapping == MNGD_MAPPING(sbi) wrapped by #ifdefs; 2) Needed by "staging: erofs: support IO read error injection". Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 7 +++ drivers/staging/erofs/unzip_vle.c | 31

[PATCH v2 1/3] staging: erofs: fix error handling when failed to read compresssed data

Complete read error handling paths for all three kinds of compressed pages: 1) For cache-managed pages, PG_uptodate will be checked since read_endio will unlock and SetPageUptodate for these pages; 2) For inplaced pages, read_endio cannot SetPageUptodate directly since it should be used

[PATCH v2 3/3] staging: erofs: support IO read error injection

Used to simulate disk IO read error for testing fatal error tolerance. Here are the details, 1) use bio->bi_private to indicate super_block for non-compressed bios since some (mainly meta) pages can be of the corresponding bdev inode; 2) get super_block dynamically for compressed bios, th

Re: [PATCH v2 3/3] staging: erofs: support IO read error injection

On 2019/3/25 11:40, Gao Xiang wrote: > Used to simulate disk IO read error for testing fatal > error tolerance. > > Here are the details, > 1) use bio->bi_private to indicate super_block >for non-compressed bios since some (mainly meta) >pages can be of the corresponding bdev inode; > 2) g