Running clang-format on mtk-hsdma.c I noticed that few lines would not
need to be wrapped, since they fit 80 columns. This change changes such
lines to better fit the style-guide.
Signed-off-by: Armando Miraglia
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++
1 file changed, 2 insertions(
On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> Signed-off-by: Emanuel Bennici
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> 1 file changed, 1 insertion(+)
I can not take patches without any changelog information, sorry.
_
syzbot has bisected this bug to:
commit f1e3e92135202ff3d95195393ee62808c109208c
Author: Malcolm Priestley
Date: Wed Jul 22 18:16:42 2015 +
staging: vt6655: fix tagSRxDesc -> next_desc type
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=111856cf20
start commit: f1
On Sun, Mar 17, 2019 at 03:43:01AM -0700, syzbot wrote:
> syzbot has bisected this bug to:
>
> commit f1e3e92135202ff3d95195393ee62808c109208c
> Author: Malcolm Priestley
> Date: Wed Jul 22 18:16:42 2015 +
>
> staging: vt6655: fix tagSRxDesc -> next_desc type
>
> bisection log: https
On Sat, Mar 09, 2019 at 03:30:42PM -0300, Guilherme Tadashi Maeoka wrote:
> Fix space around operators, pointer definition, constant on the right
> side, assignment outside of if condition and else to follow close brace
> at staging: rtl8723bs: os_dep.
>
> Guilherme Tadashi Maeoka (5):
> Staging
On Wed, Mar 13, 2019 at 02:36:40AM +0530, Arshad Hussain wrote:
> This patch adds functions comment for file erofs/super.c in
> sphinx format.
>
> Signed-off-by: Arshad Hussain
> ---
> drivers/staging/erofs/super.c | 135
> --
> 1 file changed, 131 insert
On Sat, Mar 16, 2019 at 04:59:58PM +0530, Bharath Vedartham wrote:
> Fix the checkpatch.pl warning to add a whitespace after declaration
> statements.
>
> Signed-off-by: Bharath Vedartham
> ---
> Changes since v2
> - Mutt was giving me a few problems. I apologise for the
> previous
On Wed, Mar 13, 2019 at 11:29:12AM -0500, Aditya Pakki wrote:
> skb allocated via dev_alloc_skb can fail and return a NULL pointer.
> This patch avoids such a scenario and returns, consistent with other
> invocations.
>
> Signed-off-by: Aditya Pakki
> ---
> drivers/staging/rtlwifi/rtl8822be/fw.c
On Sat, Mar 09, 2019 at 02:56:14PM -0300, Ignacio Losiggio wrote:
> This patch modifies the alignment and linebreaks in gdm_mux in order to make
> the code more concise.
"concise"?
For some of these, there is no real change needed, it's all up to the
author's "taste", so they are not needed.
>
On Sat, Mar 09, 2019 at 03:08:11PM -0300, Ariel Torti wrote:
> From: Ariel Torti
>
> Header and function comment style fixed.
> Remove commented code.
> Fix lines longer than 80 characters.
You are doing multiple things in the same patch. Please break this up
into a patch series, each one only
On Sat, Mar 09, 2019 at 11:26:00AM +0800, Mao Wenan wrote:
> Using is_zero_ether_addr() instead of directly use
> memcmp() to determine if the ethernet address is all
> zeros.
>
> Signed-off-by: Mao Wenan
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +--
> 1 file changed, 1 insertion(+)
On Wed, Mar 13, 2019 at 02:09:15PM +, manuel.ram...@protonmail.com wrote:
> Hello,
>
> this is my very first patch, very simple and check it, so it compiles
> properly and also go no errors on the checkpatch script.
> From c8a66a3bee14fe89ad2a03545a76953bc880b9e6 Mon Sep 17 00:00:00 2001
> F
On Thu, Mar 14, 2019 at 05:31:55PM +0900, Sergey Senozhatsky wrote:
> A trivial patch.
No need to put this in the changelog text at all.
Please fix up and resend.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.li
On Sun, Mar 17, 2019 at 02:59:05AM +0100, Emanuel Bennici wrote:
> Fix Check from the checkpatch.pl Script
> `CHECK: spaces preferred around that`
> in vchi.h
You also did something else here :(
Please fix up and resend.
thanks,
greg k-h
___
devel mai
On Mon, Mar 04, 2019 at 06:06:36PM +0100, Dominik Adamski wrote:
> Fix checkpatch issue:
> Comparison to NULL could be written "!bundle->state"
>
> Signed-off-by: Dominik Adamski
> ---
> drivers/staging/greybus/bundle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dr
On Sat, Mar 09, 2019 at 03:30:43PM -0300, Guilherme Tadashi Maeoka wrote:
> Fix an assignment in if condition.
>
> Signed-off-by: Guilherme Tadashi Maeoka
> ---
> drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Not all of these could b
On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fernandes wrote:
> On Sat, Mar 16, 2019 at 12:37:18PM -0700, Suren Baghdasaryan wrote:
> > On Sat, Mar 16, 2019 at 11:57 AM Christian Brauner
> > wrote:
> > >
> > > On Sat, Mar 16, 2019 at 11:00:10AM -0700, Daniel Colascione wrote:
> > > > On Sat, Ma
On (03/17/19 12:28), Greg Kroah-Hartman wrote:
> On Thu, Mar 14, 2019 at 05:31:55PM +0900, Sergey Senozhatsky wrote:
> > A trivial patch.
>
> No need to put this in the changelog text at all.
>
> Please fix up and resend.
OK.
-ss
___
devel mai
From: Sergey Senozhatsky
cpu_to_le16() is capable enough to detect __builtin_constant_p()
and to use an appropriate compile time ___constant_swahbXX()
function.
So we can use cpu_to_le16() instead of __constant_cpu_to_le16().
Signed-off-by: Sergey Senozhatsky
---
drivers/staging/rtl8723bs/inc
Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
>> Signed-off-by: Emanuel Bennici
>> ---
>> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
>> 1 file changed, 1 insertion(+)
> I can not take patches without any change
On Sun, Mar 17, 2019 at 08:48:03PM +0900, Sergey Senozhatsky wrote:
> From: Sergey Senozhatsky
Why ".work"?
>
> cpu_to_le16() is capable enough to detect __builtin_constant_p()
> and to use an appropriate compile time ___constant_swahbXX()
> function.
>
> So we can use cpu_to_le16() instead of
On Sun, Mar 17, 2019 at 01:14:26PM +0100, Emanuel Bennici wrote:
>
> Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> > On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> >> Signed-off-by: Emanuel Bennici
> >> ---
> >> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
head: 772e1d2b5b6691e4b10f693a4eef4652f01c9078
commit: 27defed1d399bb11895fd92da516ed535b40098d [50/57] ceph: fix changelog
config: x86_64-randconfig-x000-201911 (attached as .config)
compiler: gcc-7 (
On (03/17/19 13:16), Greg Kroah-Hartman wrote:
> On Sun, Mar 17, 2019 at 08:48:03PM +0900, Sergey Senozhatsky wrote:
> > From: Sergey Senozhatsky
>
> Why ".work"?
Aha, good question. There is not so much of a difference between .work and
!.work. (if any at all).
> > cpu_to_le16() is capable eno
This patch fixes various indentation and coding style issues in
EMXX UDC device controller driver.
---
Task 10 of the Eudyptula challenge.
drivers/staging/emxx_udc/emxx_udc.c | 636 ++--
1 file changed, 315 insertions(+), 321 deletions(-)
diff --git a/drivers/staging/em
cpu_to_le16() is capable enough to detect __builtin_constant_p()
and to use an appropriate compile time ___constant_swahbXX()
function.
So we can use cpu_to_le16() instead of __constant_cpu_to_le16().
Signed-off-by: Sergey Senozhatsky
---
drivers/staging/rtl8723bs/include/wifi.h | 4 ++--
1 fil
On Sun, Mar 17, 2019 at 10:49:11PM +0800, kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> debugfs_cleanup
> head: 772e1d2b5b6691e4b10f693a4eef4652f01c9078
> commit: 27defed1d399bb11895fd92da516ed535b40098d [50/57] ceph: fix changelog
On Mon, Mar 18, 2019 at 12:20:14AM +0900, Sergey Senozhatsky wrote:
> cpu_to_le16() is capable enough to detect __builtin_constant_p()
> and to use an appropriate compile time ___constant_swahbXX()
> function.
>
> So we can use cpu_to_le16() instead of __constant_cpu_to_le16().
>
> Signed-off-by:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
head: 772e1d2b5b6691e4b10f693a4eef4652f01c9078
commit: 27defed1d399bb11895fd92da516ed535b40098d [50/57] ceph: fix changelog
config: x86_64-randconfig-l0-201911 (attached as .config)
compiler: gcc-5 (De
On Sun, Mar 17, 2019 at 12:42:40PM +0100, Christian Brauner wrote:
> On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fernandes wrote:
> > On Sat, Mar 16, 2019 at 12:37:18PM -0700, Suren Baghdasaryan wrote:
> > > On Sat, Mar 16, 2019 at 11:57 AM Christian Brauner
> > > wrote:
> > > >
> > > > On Sat
On Sun, Mar 17, 2019 at 10:11:10AM -0700, Daniel Colascione wrote:
> On Sun, Mar 17, 2019 at 9:35 AM Serge E. Hallyn wrote:
> >
> > On Sun, Mar 17, 2019 at 12:42:40PM +0100, Christian Brauner wrote:
> > > On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fernandes wrote:
> > > > On Sat, Mar 16, 2019
On Sun, Mar 17, 2019 at 1:45 AM Armando Miraglia wrote:
>
> Running clang-format on mtk-hsdma.c I noticed that few lines would not
> need to be wrapped, since they fit 80 columns. This change changes such
> lines to better fit the style-guide.
>
> Signed-off-by: Armando Miraglia
> ---
> drivers/
Signed-off-by: Vladimir Petrigo
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index acdbc07..7c632cf 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/i
- Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid
precedence issues
- Fix CHECK Macro argument reuse 'bits' - possible side-effects?
Signed-off-by: Vladimir Petrigo
---
drivers/staging/iio/adc/ad7780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix CHECK Macro argument 'c' may be better as '(c)' to
avoid precedence issues
Signed-off-by: Vladimir Petrigo
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c index d9df126..98cf876
100644 --- a/drivers/staging/iio/adc/ad7280a.c +++
b/drivers/staging/iio/adc/ad
Introduce small code formatting cleaning up in the staging AD drivers
Vladimir Petrigo (3):
staging: iio: ad7192: Fix style issue
staging: iio: ad7280a: Add parentheses to macros
staging: iio: ad7780: Add parentheses to macros
drivers/staging/iio/adc/ad7192.c | 2 +-
drivers/staging/iio/a
Fix various warnings and checks issued by checkpatch.pl.
Signed-off-by: Emiliano Ingrassia
---
Changes since v1:
- add missed signed-off
Task 10 of the Eudyptula challenge.
drivers/staging/emxx_udc/emxx_udc.c | 636 ++--
1 file changed, 315 insertions(+), 321 deletio
On Sun, Mar 17, 2019 at 08:40:19AM -0700, Daniel Colascione wrote:
> On Sun, Mar 17, 2019 at 4:42 AM Christian Brauner
> wrote:
> >
> > On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fernandes wrote:
> > > On Sat, Mar 16, 2019 at 12:37:18PM -0700, Suren Baghdasaryan wrote:
> > > > On Sat, Mar 16,
El dom, 17 de mar 2019 a las 8:23 AM, Greg KH
escribió:
For some of these, there is no real change needed, it's all up to the
author's "taste", so they are not needed.
Thanks for the feedback! I will send a revised version.
___
devel mailing list
d
On (03/17/19 16:35), Greg Kroah-Hartman wrote:
> On Mon, Mar 18, 2019 at 12:20:14AM +0900, Sergey Senozhatsky wrote:
> > cpu_to_le16() is capable enough to detect __builtin_constant_p()
> > and to use an appropriate compile time ___constant_swahbXX()
> > function.
> >
> > So we can use cpu_to_le16
Signed-off-by: Ignacio Losiggio
---
drivers/staging/gdm724x/gdm_mux.c | 28 ++--
1 file changed, 6 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index e2a050ba6fbb..fa8585ea1572 100644
--- a/drivers/stag
When the entire expression can be shown in the same line breaking it
makes it more difficult to read.
Signed-off-by: Ignacio Losiggio
---
drivers/staging/gdm724x/gdm_mux.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/stag
On 18/03/2019 4:53 am, Vladimir Petrigo wrote:
Signed-off-by: Vladimir Petrigo
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index acdbc07..7c632cf 100644
--- a/drive
On Sun, Mar 17, 2019 at 10:15:34PM -0300, Ignacio Losiggio wrote:
> Signed-off-by: Ignacio Losiggio
> ---
> drivers/staging/gdm724x/gdm_mux.c | 28 ++--
> 1 file changed, 6 insertions(+), 22 deletions(-)
I can not take patches without any changelog text, sorry.
greg k-h
On Sun, Mar 17, 2019 at 10:58:45PM +0100, Emiliano Ingrassia wrote:
> Fix various warnings and checks issued by checkpatch.pl.
>
> Signed-off-by: Emiliano Ingrassia
> ---
> Changes since v1:
> - add missed signed-off
>
> Task 10 of the Eudyptula challenge.
>
> drivers/staging/emxx_udc/emxx_
On Wed, Mar 13, 2019 at 06:57:17PM +, Ian Abbott wrote:
> On 04/03/2019 14:33, Ian Abbott wrote:
> > `ni_cdio_cmdtest()` validates Comedi asynchronous commands for the DIO
> > subdevice (subdevice 2) of supported National Instruments M-series
> > cards. It is called when handling the `COMEDI_C
46 matches
Mail list logo
