Re: Staging status of speakup

2019-03-16 Thread Samuel Thibault
Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit: > Okash Khawaja writes: > > Finally there is an issue where text in output buffer sometimes gets > > garbled on SMP systems, but we can continue working on it after the > > driver is moved out of staging, if that's okay. Basically we nee

Re: Staging status of speakup

2019-03-16 Thread Okash Khawaja
Hi, On Fri, 15 Mar 2019 18:19:39 -0700 Chris Brannon wrote: > Okash Khawaja writes: > > > Finally there is an issue where text in output buffer sometimes gets > > garbled on SMP systems, but we can continue working on it after the > > driver is moved out of staging, if that's okay. Basically w

Re: Staging status of speakup

2019-03-16 Thread Okash Khawaja
On Fri, 15 Mar 2019 20:18:31 -0700 Greg Kroah-Hartman wrote: > On Fri, Mar 15, 2019 at 01:01:27PM +, Okash Khawaja wrote: > > Hi, > > > > We have made progress on the items in TODO file of speakup driver in > > staging directory and wanted to get some clarity on the remaining > > items. Belo

Re: Staging status of speakup

2019-03-16 Thread Samuel Thibault
Hello, Please keep the lists in Cc, so that not only I have the information (in particular since I will probably *not* have the time to investigate myself). Samuel Thibault, le sam. 16 mars 2019 10:35:43 +0100, a ecrit: > The problem is that neither Okash nor I are even casual users of > speakup,

[no subject]

2019-03-16 Thread Bharath Vedartham
linux-ker...@vger.kernel.org Bcc: Subject: [PATCH] staging: erofs: Add whitespace after declaration Reply-To: Fix the checkpatch.pl warning to add a whitespace after declaration statements. Signed-off-by: Bharath Vedartham --- drivers/staging/erofs/inode.c | 3 +-- 1 file changed, 1 insertio

[PATCH] staging: erofs: Add whitespace after declaration

2019-03-16 Thread Bharath Vedartham
linux-ker...@vger.kernel.org Bcc: Subject: [PATCH] staging: erofs: Add whitespace after declaration Reply-To: Fix the checkpatch.pl warning to add a whitespace after declaration statements. Signed-off-by: Bharath Vedartham --- drivers/staging/erofs/inode.c | 3 +-- 1 file changed, 1 insertio

[PATCH v2] staging: erofs: Add whitespace after declaration

2019-03-16 Thread Bharath Vedartham
Fix the checkpatch.pl warning to add a whitespace after declaration statements. Signed-off-by: Bharath Vedartham --- Changes since v2 - Mutt was giving me a few problems. I apologise for the previous poor patches. --- drivers/staging/erofs/inode.c | 3 +-- 1 file changed, 1 ins

Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

2019-03-16 Thread Jonathan Cameron
On Mon, 11 Mar 2019 11:31:59 +0300 Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote: > > On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio > > wrote: > > > > > > Add spaces around minus operator to fix readibility. > > > > > > Signed-off-by: Karen Palacio

Re: [PATCH] staging: erofs: Add function comment for erofs/inode.c

2019-03-16 Thread Randy Dunlap
On 3/15/19 11:16 PM, Arshad Hussain wrote: > This patch adds functions comment for file erofs/inode.c in > sphinx format. > > Signed-off-by: Arshad Hussain > --- > drivers/staging/erofs/inode.c | 67 > +-- > 1 file changed, 64 insertions(+), 3 deletions(-

Re: [PATCH v5 01/11] staging: iio: ad7780: add gain & filter gpio support

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:12:27 -0300 Renato Lui Geh wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. > > Signed-off-by: Renato Lui Geh > Signed-off-by: Giuliano Belinassi > Co-developed-by: Giuliano B

Re: [PATCH v5 02/11] staging: iio: ad7780: add missing switch default case

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:12:53 -0300 Renato Lui Geh wrote: > This patch simply adds a missing switch default case in read_raw. > > Signed-off-by: Renato Lui Geh Applied, Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7780.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drive

Re: [PATCH v5 03/11] staging: iio: ad7780: add gain reading to ad778x

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:13:13 -0300 Renato Lui Geh wrote: > This patch adds a new functionality of reading gain values from the > ad778x chips. This value is stored in the chip's state struct and is > updated whenever a read or write call is performed on the driver. > > Signed-off-by: Renato Lui

Re: [PATCH v5 04/11] staging: iio: ad7780: add filter reading to ad778x

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:13:42 -0300 Renato Lui Geh wrote: > This patch adds the new feature of reading the filter odr value for > ad778x chips. This value is stored in the chip's state struct whenever a > read or write call is performed on the chip's driver. > > This feature requires sharing SAMP

Re: [PATCH v5 05/11] staging: iio: ad7780: set pattern values and masks directly

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:14:14 -0300 Renato Lui Geh wrote: > The AD7780 driver contains status pattern bits designed for checking > whether serial transfers have been correctly performed. Pattern macros > were previously generated through bit fields. This patch sets good > pattern values directly a

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-16 Thread Daniel Colascione
On Sat, Mar 16, 2019 at 10:31 AM Suren Baghdasaryan wrote: > > On Fri, Mar 15, 2019 at 11:49 AM Joel Fernandes > wrote: > > > > On Fri, Mar 15, 2019 at 07:24:28PM +0100, Christian Brauner wrote: > > [..] > > > > why do we want to add a new syscall (pidfd_wait) though? Why not just > > > > use >

Re: [PATCH v5 06/11] staging:iio:ad7780: add chip ID values and mask

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:14:27 -0300 Renato Lui Geh wrote: > The ad7780 supports both the ad778x and ad717x families. Each chip has > a corresponding ID. This patch provides a mask for extracting ID values > from the status bits and also macros for the correct values for the > ad7170, ad7171, ad778

Re: [PATCH v5 07/11] staging: iio: ad7780: move regulator to after GPIO init

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:14:59 -0300 Renato Lui Geh wrote: > To maintain consistency between ad7780_probe and ad7780_remove orders, > regulator initialization has been moved to after GPIO initializations. > > Signed-off-by: Renato Lui Geh Applied, Thanks, Jonathan > --- > drivers/staging/iio/

Re: [PATCH v5 08/11] staging: iio: ad7780: add SPDX identifier

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:15:13 -0300 Renato Lui Geh wrote: > Add SPDX identifier (GPL-2.0) to the AD7780 driver. > > Signed-off-by: Renato Lui Geh Applied > --- > drivers/staging/iio/adc/ad7780.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/adc

Re: [PATCH v5 09/11] staging: iio: ad7780: add new copyright holder

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:15:26 -0300 Renato Lui Geh wrote: > This patch adds a new copyright holder to the ad7780 driver. > > Signed-off-by: Renato Lui Geh Applied thanks Jonathan > --- > drivers/staging/iio/adc/ad7780.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging

Re: [PATCH v5 10/11] staging: iio: ad7780: moving ad7780 out of staging

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:15:55 -0300 Renato Lui Geh wrote: > Move ad7780 ADC driver out of staging and into the mainline. > > The ad7780 is a sigma-delta analog to digital converter. This driver provides > reading voltage values and status bits from both the ad778x and ad717x series. > Its interfa

Re: [PATCH v5 11/11] staging: iio: ad7780: add device tree binding

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 23:16:13 -0300 Renato Lui Geh wrote: > Adds a device tree binding for the ad7780 driver. > > Signed-off-by: Renato Lui Geh Seems like a straight forward binding so applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks

Re: [PATCH v5 10/11] staging: iio: ad7780: moving ad7780 out of staging

2019-03-16 Thread Renato Lui Geh
On 03/16, Jonathan Cameron wrote: On Fri, 15 Mar 2019 23:15:55 -0300 Renato Lui Geh wrote: Move ad7780 ADC driver out of staging and into the mainline. The ad7780 is a sigma-delta analog to digital converter. This driver provides reading voltage values and status bits from both the ad778x and

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-16 Thread Christian Brauner
On Sat, Mar 16, 2019 at 11:00:10AM -0700, Daniel Colascione wrote: > On Sat, Mar 16, 2019 at 10:31 AM Suren Baghdasaryan wrote: > > > > On Fri, Mar 15, 2019 at 11:49 AM Joel Fernandes > > wrote: > > > > > > On Fri, Mar 15, 2019 at 07:24:28PM +0100, Christian Brauner wrote: > > > [..] > > > > > w

[PATCH] staging: rtl8723bs: remove unused code

2019-03-16 Thread Colin King
From: Colin Ian King There are two final hunks of code that are only built if SDIO_DYNAMIC_ALLOC_MEM is defined however this is never defined and if it was the code would lead to dereferencing an uninitialized pointer oldmem. It appears that a previous commit 1babeb0c3e59 ("Staging: rtl8723bs: R

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-16 Thread Joel Fernandes
On Sat, Mar 16, 2019 at 12:37:18PM -0700, Suren Baghdasaryan wrote: > On Sat, Mar 16, 2019 at 11:57 AM Christian Brauner > wrote: > > > > On Sat, Mar 16, 2019 at 11:00:10AM -0700, Daniel Colascione wrote: > > > On Sat, Mar 16, 2019 at 10:31 AM Suren Baghdasaryan > > > wrote: > > > > > > > > On

[PATCH 1/2] staging: vc04_services: Add spaces around Operators

2019-03-16 Thread Emanuel Bennici
Fix Check from the checkpatch.pl Script `CHECK: spaces preferred around that` in vchi.h Signed-off-by: Emanuel Bennici --- drivers/staging/vc04_services/interface/vchi/vchi.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/interface/

[PATCH 2/2] staging: vc04_services: Add blank line after struct declaration

2019-03-16 Thread Emanuel Bennici
Signed-off-by: Emanuel Bennici --- drivers/staging/vc04_services/interface/vchi/vchi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h index 7b13cb04c119..43eaf7703777 100644 --- a/drive