[PATCH] staging: erofs: add a new line after variable declaration

2019-03-09 Thread Julio Bianco
Add a new line after variable declaration Signed-off-by: Julio Bianco --- drivers/staging/erofs/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c index 924b8dfc7a8f..1cf1afe2d73a 100644 --- a/drivers/staging/erofs/inode.c ++

Re: [PATCH v3 2/3] staging: iio: frequency: ad9834: Move phase and scale to standard iio attribute

2019-03-09 Thread Jonathan Cameron
On Sun, 3 Mar 2019 15:33:47 + Beniamin Bia wrote: > Thank you for reviewing my patch. > > I'm gonna document the current state of driver in an ABI and than > propose in another patch modifications from current form. What do you > think about this approach? The problem here is that it is har

Re: [PATCH v4 4/9] staging:iio:ad7780: add chip ID values and mask

2019-03-09 Thread Jonathan Cameron
On Fri, 8 Mar 2019 21:19:29 -0300 Renato Lui Geh wrote: > On 03/04, Ardelean, Alexandru wrote: > >On Sun, 2019-03-03 at 14:53 +, Jonathan Cameron wrote: > >> [External] > >> > >> > >> On Sun, 3 Mar 2019 11:01:09 -0300 > >> Renato Lui Geh wrote: > >> > >> > On 03/01, Ardelean, Alexandru w

[PATCH] staging: gdm724x: Fix alignment in gdm_mux

2019-03-09 Thread Ignacio Losiggio
This patch modifies the alignment and linebreaks in gdm_mux in order to make the code more concise. Signed-off-by: Ignacio Losiggio --- drivers/staging/gdm724x/gdm_mux.c | 35 ++- drivers/staging/gdm724x/gdm_mux.h | 2 +- 2 files changed, 17 insertions(+), 20 deletio

[PATCH] staging: octeon-usb octeon-hcd: Fix several typos.

2019-03-09 Thread Laura Lazzati
I found that the comments had several typos such as "aenable", "internaly" and some others. I fixed them all. Signed-off-by: Laura Lazzati --- drivers/staging/octeon-usb/octeon-hcd.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon

[PATCH 5/5] Staging: rtl8723bs: os_dep: Set constant on right side

2019-03-09 Thread Guilherme Tadashi Maeoka
Place a constant on the right side of the test. Signed-off-by: Guilherme Tadashi Maeoka --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_de

[PATCH 0/5] Fix several coding style errors

2019-03-09 Thread Guilherme Tadashi Maeoka
Fix space around operators, pointer definition, constant on the right side, assignment outside of if condition and else to follow close brace at staging: rtl8723bs: os_dep. Guilherme Tadashi Maeoka (5): Staging: rtl8723bs: os_dep: Fix assignment in if condition Staging: rtl8723bs: os_dep: Fix

[PATCH 2/5] Staging: rtl8723bs: os_dep: Fix space required coding style

2019-03-09 Thread Guilherme Tadashi Maeoka
Fix multiple space required coding style. Signed-off-by: Guilherme Tadashi Maeoka --- .../staging/rtl8723bs/os_dep/osdep_service.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl872

[PATCH 1/5] Staging: rtl8723bs: os_dep: Fix assignment in if condition

2019-03-09 Thread Guilherme Tadashi Maeoka
Fix an assignment in if condition. Signed-off-by: Guilherme Tadashi Maeoka --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_servic

[PATCH 3/5] Staging: rtl8723bs: os_dep: Fix else to follow close brace

2019-03-09 Thread Guilherme Tadashi Maeoka
Fix else not following close brace '}'. Signed-off-by: Guilherme Tadashi Maeoka --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osde

[PATCH 4/5] Staging: rtl8723bs: os_dep: Fix space in pointer definition

2019-03-09 Thread Guilherme Tadashi Maeoka
Pointer definition "foo * bar" should be "foo *bar". Signed-off-by: Guilherme Tadashi Maeoka --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_d

[PATCH] staging: rtl8723bs: Clean up comments and code

2019-03-09 Thread Ariel Torti
From: Ariel Torti Header and function comment style fixed. Remove commented code. Fix lines longer than 80 characters. Signed-off-by: Ariel Torti --- drivers/staging/rtl8723bs/core/rtw_io.c | 77 - 1 file changed, 37 insertions(+), 40 deletions(-) diff --git a/

Re: [PATCH 1/5] Staging: rtl8723bs: os_dep: Fix assignment in if condition

2019-03-09 Thread Guilherme T Maeoka
Thank you for the review Joe. I'll have that in mind in the next patch. On 3/9/19, Joe Perches wrote: > On Sat, 2019-03-09 at 15:30 -0300, Guilherme Tadashi Maeoka wrote: >> Fix an assignment in if condition. >> >> Signed-off-by: Guilherme Tadashi Maeoka >> --- >> drivers/staging/rtl8723bs/os_d

Re: [PATCH 1/5] Staging: rtl8723bs: os_dep: Fix assignment in if condition

2019-03-09 Thread Joe Perches
On Sat, 2019-03-09 at 15:30 -0300, Guilherme Tadashi Maeoka wrote: > Fix an assignment in if condition. > > Signed-off-by: Guilherme Tadashi Maeoka > --- > drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/stagin

[PATCH] FBTFT: fbtft-bus: Fix code style problems

2019-03-09 Thread Dante Paz
From: Dante Paz Style and coding function issues were corrected, by avoiding macro functions with a conflicting coding style. Signed-off-by: Dante Paz --- drivers/staging/fbtft/fbtft-bus.c | 440 +- 1 file changed, 254 insertions(+), 186 deletions(-) diff -

Re: [PATCH] staging: erofs: add a new line after variable declaration

2019-03-09 Thread Gao Xiang
Hi Julio, On 2019/3/10 1:08, Julio Bianco wrote: > Add a new line after variable declaration > > Signed-off-by: Julio Bianco There is the only place in erofs for this issue? Could you check and please fix them all if you have some time? Thanks, Gao Xiang > --- > drivers/staging/erofs/inode.c