On Thu, Dec 20, 2018 at 01:57:01AM -0600, Kangjie Lu wrote:
> ms_send_cmd() may fail. The fix checks the return value of it, and if it
> fails, returns the error "STATUS_FAIL" upstream.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/staging/rts5208/ms.c | 4 +++-
> 1 file changed, 3 insertions(+)
I think maybe this is the first kernel patch I have recieved from you.
When you're adding error handling there are a couple ways to go wrong
and this is what I look at when I review error handling patches:
1) The error handling is not required.
2) The error handling is not complete.
I have messed
On 30.11.18 18:59, David Hildenbrand wrote:
> This is the second approach, introducing more meaningful memory block
> types and not changing online behavior in the kernel. It is based on
> latest linux-next.
>
> As we found out during dicussion, user space should always handle onlining
> of memory
On Thu 20-12-18 13:58:16, David Hildenbrand wrote:
> On 30.11.18 18:59, David Hildenbrand wrote:
> > This is the second approach, introducing more meaningful memory block
> > types and not changing online behavior in the kernel. It is based on
> > latest linux-next.
> >
> > As we found out during
On 20.12.18 14:08, Michal Hocko wrote:
> On Thu 20-12-18 13:58:16, David Hildenbrand wrote:
>> On 30.11.18 18:59, David Hildenbrand wrote:
>>> This is the second approach, introducing more meaningful memory block
>>> types and not changing online behavior in the kernel. It is based on
>>> latest li
On Wed, Dec 19, 2018 at 05:07:06PM +0100, Jona Crasselt wrote:
> Issue reported by checkpatch.pl.
> Replace printk() with pr_debug() to include facility level.
>
> Signed-off-by: Jona Crasselt
> Signed-off-by: Felix Windsheimer
> ---
> drivers/staging/mt7621-mmc/sd.c | 8
> 1 file chan
On Wed, Dec 19, 2018 at 05:07:07PM +0100, Jona Crasselt wrote:
> Signed-off-by: Jona Crasselt
> Signed-off-by: Felix Windsheimer
> ---
> drivers/staging/mt7621-mmc/sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I can't take patches without any changelog comments at all :(
On Wed, Dec 19, 2018 at 05:07:01PM +0100, Jona Crasselt wrote:
> Fix some comment-related issues reported by checkpatch.pl:
> - Block comments use * on subsequent lines
> - Block comments use a trailing */ on a separate line
>
> Signed-off-by: Jona Crasselt
> Signed-off-by: Felix Windsheimer
> -
Changed "avaiable" to "available" and "interupt" to "interrupt".
Signed-off-by: Jona Crasselt
Signed-off-by: Felix Windsheimer
---
drivers/staging/mt7621-mmc/sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc
On Thu, Dec 20, 2018 at 05:57:37PM +0100, Jona Crasselt wrote:
> Changed "avaiable" to "available" and "interupt" to "interrupt".
>
> Signed-off-by: Jona Crasselt
> Signed-off-by: Felix Windsheimer
> ---
> drivers/staging/mt7621-mmc/sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
Use the correct comment style for SPDX identifiers in header files.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 2 +-
drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 2 +-
drivers/staging/fsl-dpaa2/ethsw/ethsw.h| 2 +-
3 files changed,
Hi Kangjie,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.20-rc7 next-20181220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Hi Stefan,
I love your patch! Yet something to improve:
[auto build test ERROR on iio/togreg]
[cannot apply to v4.20-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Stefan-Popa/staging-iio-
When ms_read_extra_data fails, the data read in "extra" buffer is
just incorrect and thus should be used. However, "extra" is used
in multiple places no matter ms_read_extra_data() fails or not.
The fix checks the status of ms_read_extra_data() and returns with
an error code upon its failure.
Sign
LGTM.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 12/16/18 2:46 AM, Alexey Skidanov wrote:
Chunk heap instantiation should be supported for device tree platforms and
non device tree platforms. For device tree platforms, it's a platform
specific code responsibility to retrieve the heap configuration data
and to call the appropriate API for hea
On 12/19/18 5:39 PM, Zengtao (B) wrote:
Hi laura:
-Original Message-
From: Laura Abbott [mailto:labb...@redhat.com]
Sent: Thursday, December 20, 2018 2:10 AM
To: Zengtao (B) ; sumit.sem...@linaro.org
Cc: Greg Kroah-Hartman ; Arve Hjønnevåg
; Todd Kjos ; Martijn Coenen
; Joel Fernandes ;
Hi Yangtao,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.20-rc7 next-20181220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
On 12/20/18 10:36 PM, Laura Abbott wrote:
> On 12/16/18 2:46 AM, Alexey Skidanov wrote:
>> Chunk heap instantiation should be supported for device tree platforms
>> and
>> non device tree platforms. For device tree platforms, it's a platform
>> specific code responsibility to retrieve the heap co
From: Sergio Paracuellos
Date: Wed, 19 Dec 2018 20:46:26 +0100
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Sergio Paracuellos
I am assuming the devicetree folks will take this into their tree or
similar.
If I
20 matches
Mail list logo
