Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-12-01 Thread Jonathan Cameron
On Thu, 29 Nov 2018 12:19:08 + "Ardelean, Alexandru" wrote: > On Tue, 2018-11-27 at 06:11 -0500, Popa, Stefan Serban wrote: > > On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote: > > Hi, please see bellow > > > > One note from me here. > > > > Hi, thank you for the review > > >

Re: [PATCH v3 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt

2018-12-01 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:07 -0200 Matheus Tavares wrote: > The ad2s90 driver currently sets some spi settings (max_speed_hz and > mode) at ad2s90_probe. Since the maximum frequency is a required element > in DT binding for spi slave devices and because the spi mode for the > device can be either

Re: [PATCH v3 1/7] staging:iio:ad2s90: Add device tree support

2018-12-01 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:06 -0200 Matheus Tavares wrote: > This patch adds device tree support to ad2s90 with standard > device tree id table. > > Signed-off-by: Matheus Tavares Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jo

Re: [PATCH v3 3/7] staging:iio:ad2s90: Add max frequency check at probe

2018-12-01 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:08 -0200 Matheus Tavares wrote: > From: Alexandru Ardelean > > This patch adds a max frequency check at the beginning of ad2s90_probe > function so that when it is set to a value above 0.83Mhz, dev_err is > called with an appropriate message and -EINVAL is returned. >

Re: [PATCH v3 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-12-01 Thread Jonathan Cameron
On Mon, 26 Nov 2018 19:52:27 -0600 Rob Herring wrote: > On Fri, 23 Nov 2018 22:23:09 -0200, Matheus Tavares wrote: > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > Signed-off-by: Matheus Tavares > > --- > > Changes in v3: > > -

Re: [PATCH v3 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier

2018-12-01 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:10 -0200 Matheus Tavares wrote: > This patch removes the license boilerplate text at the top of ad2s90.c > and, instead, adds the SPDX GPL-2.0 license identifier, which solves the > checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in li

Re: [PATCH v3 6/7] staging:iio:ad2s90: Add comment to device state mutex

2018-12-01 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:11 -0200 Matheus Tavares wrote: > From: Victor Colombo > > Fix the checkpatch.pl issue: > "CHECK: struct mutex definition without comment". > > Signed-off-by: Victor Colombo > Signed-off-by: Matheus Tavares Applied, thanks Jonathan > --- > Changes in v3: > - none

Re: [PATCH v3 7/7] staging:iio:ad2s90: Move out of staging

2018-12-01 Thread Jonathan Cameron
On Mon, 26 Nov 2018 07:34:35 + "Ardelean, Alexandru" wrote: > On Fri, 2018-11-23 at 22:23 -0200, Matheus Tavares wrote: > > Move ad2s90 resolver driver out of staging to the main tree. > > > > Acked-by: Alexandru Ardelean Hi Alexandru, I took that to apply to the whole series, hope you

Re: [PATCH V2] staging: iio: adc: ad7280a: check for devm_kasprint() failure

2018-12-01 Thread Jonathan Cameron
On Tue, 27 Nov 2018 18:05:04 +0100 Nicholas Mc Guire wrote: > devm_kasprintf() may return NULL on failure of internal allocation thus > the assignments to attr.name are not safe if not checked. On error > ad7280_attr_init() returns a negative return so -ENOMEM should be > OK here (passed on as

Re: [PATCH 2/2] staging: iio: ad7780: Moving ad7780 out of staging

2018-12-01 Thread Jonathan Cameron
On Wed, 28 Nov 2018 16:16:34 -0200 Giuliano Belinassi wrote: > Move ad7780 sigma-delta adc out of staging to the main tree Please add a few details here on what the device is and what interfaces are provided. It's nice for anyone whose first encounter with this driver is this patch (as they don'

Re: [PATCH 1/2] staging: iio: ad7780: Add gain & filter gpio support

2018-12-01 Thread Jonathan Cameron
On Thu, 29 Nov 2018 11:02:46 -0200 Giuliano Augusto Faulin Belinassi wrote: > Hi A few follow ups from me having read the result in patch 2. Jonathan > > On Thu, Nov 29, 2018 at 9:18 AM Popa, Stefan Serban > wrote: > > > > On Mi, 2018-11-28 at 16:15 -0200, Giuliano Belinassi wrote: > > > Pr

Re: [PATCH v3 1/2] staging: iio: ad7606: Move out of staging

2018-12-01 Thread Jonathan Cameron
On Thu, 29 Nov 2018 18:56:39 +0200 Stefan Popa wrote: > Move ad7606 ADC driver out of staging and into the mainline. > > Signed-off-by: Stefan Popa Hi Stefan, This has fallen into the usual trap that if I take 'just one last look' at something I always find just one more thing (well 2 here) t

Reply

2018-12-01 Thread Tony Fisher
Good Day, I have a Mutual/Beneficial Business Project for you worth Millions of Dollars. My name is Tony Fisher. I am a senior staff and an Int'l Purchasing Manager with Channel Island Fuels Ltd here in UK. I over-invoiced a contract to the tune of US$8.5 Million. All arrangements have been c

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-12-01 Thread gre...@linuxfoundation.org
On Fri, Nov 30, 2018 at 06:09:54PM +, Dexuan Cui wrote: > > From: KY Srinivasan > > Sent: Friday, November 30, 2018 9:31 AM > > > From: Dexuan Cui > > > Sent: Thursday, November 29, 2018 12:17 AM > > > To: gre...@linuxfoundation.org > > > Cc: KY Srinivasan ; Haiyang Zhang > > > ; Stephen Hemm