[PATCH] staging: rtl8712: Fix possible buffer overrun

2018-11-28 Thread Yang Xiao
From: Young Xiao In commit 8b7a13c3f404 ("staging: r8712u: Fix possible buffer overrun") we fix a potential off by one by making the limit smaller. The better fix is to make the buffer larger. This makes it match up with the similar code in other drivers. Signed-off-by: Young Xiao --- drivers

Re: [PATCH] staging: rtl8712: Fix possible buffer overrun

2018-11-28 Thread Dan Carpenter
Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

2018-11-28 Thread Brian Starkey
Hi Liam, On Tue, Nov 27, 2018 at 10:46:07PM -0800, Liam Mark wrote: > On Tue, 27 Nov 2018, Brian Starkey wrote: > > > Hi Liam, > > > > On Mon, Nov 26, 2018 at 08:59:44PM -0800, Liam Mark wrote: > > > On Tue, 20 Nov 2018, Brian Starkey wrote: > > > > > > > Hi Liam, > > > > > > > > I'm missing a

[PATCH] staging: rtl8188eu: fix spelling mistake "inferface" -> "interface"

2018-11-28 Thread Colin King
From: Colin Ian King Fix spelling mistake in module description text. Signed-off-by: Colin Ian King --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_de

HELLO GOOD FRIEND.

2018-11-28 Thread Funds Advisory Services Ltd
Attention To driverdev-devel@linuxdriverproject.org We found your email driverdev-devel@linuxdriverproject.org in our Investment Database Hence we are contacting you for Investment Purposes. Please pardon me for this unsolicited communique. I do have the trusteeship of a PRIVATE investor with

[PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

2018-11-28 Thread Colin King
From: Colin Ian King There is a spelling mistake in array speakup_default_msgs at index MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this. Signed-off-by: Colin Ian King --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i

Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

2018-11-28 Thread Samuel Thibault
Hello, Colin King, le mer. 28 nov. 2018 16:12:32 +, a ecrit: > - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly", > + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically", Mmm, clearly an english typo. Speakup people, do you think there might be any down

[PATCH 5/6] staging: rtl8188eu: cleanup alignment issues in hal8188e_rate_adaptive.c

2018-11-28 Thread Michael Straube
Cleanup alignment issues reported by checkpatch. CHECK: Alignment should match open parenthesis Signed-off-by: Michael Straube --- .../rtl8188eu/hal/hal8188e_rate_adaptive.c| 37 +-- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 3/6] staging: rtl8188eu: add spaces around operators in hal8188e_rate_adaptive.c

2018-11-28 Thread Michael Straube
Add spaces around operators to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- .../rtl8188eu/hal/hal8188e_rate_adaptive.c| 54 ++- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal8188e_rat

[PATCH 6/6] staging: rtl8188eu: cleanup comment in hal8188e_rate_adaptive.c

2018-11-28 Thread Michael Straube
Cleanup comment in hal8188e_rate_adaptive.c. Clears checkpatch warnings. WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Michael Straube --- .../rtl8188eu/hal/hal8188e_rate_adaptive.c | 17 +++-- 1 fi

[PATCH 2/6] staging: rtl8188eu: remove parentheses in hal8188e_rate_adaptive.c

2018-11-28 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c b/drivers/staging/r

[PATCH 1/6] staging: rtl8188eu: use __func__ in hal8188e_rate_adaptive.c

2018-11-28 Thread Michael Straube
Use __func__ instead of hardcoded function names. Reported by checkpatch. Signed-off-by: Michael Straube --- .../rtl8188eu/hal/hal8188e_rate_adaptive.c| 36 ++- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptiv

[PATCH 4/6] staging: rtl8188eu: cleanup lines ending with '('

2018-11-28 Thread Michael Straube
Cleanup lines ending with '(' in hal8188e_rate_adaptive.c. Reported by checkpatch. Signed-off-by: Michael Straube --- .../rtl8188eu/hal/hal8188e_rate_adaptive.c| 20 ++- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal8188e_rate

[PATCH 0/2] staging: iio: ad7780: move out of staging

2018-11-28 Thread Giuliano Belinassi
This series of patches add user input to ad7780 'gain' & 'filter' gpio pins. Also, it moves the ad7780 out of staging to the main tree. Giuliano Belinassi (2): staging: iio: ad7780: Add gain & filter gpio support staging: iio: ad7780: Moving ad7780 out of staging drivers/iio/adc/Kconfig

[PATCH 1/2] staging: iio: ad7780: Add gain & filter gpio support

2018-11-28 Thread Giuliano Belinassi
Previously, the AD7780 driver only supported gpio for the 'powerdown' pin. This commit adds suppport for the 'gain' and 'filter' pin. Signed-off-by: Giuliano Belinassi --- Changes in v2: - Now this patch is part of the patchset that aims to remove ad7780 out of staging. https://marc.info/?l=l

[PATCH 2/2] staging: iio: ad7780: Moving ad7780 out of staging

2018-11-28 Thread Giuliano Belinassi
Move ad7780 sigma-delta adc out of staging to the main tree Signed-off-by: Giuliano Belinassi Signed-off-by: Renato Lui Geh --- drivers/iio/adc/Kconfig | 13 ++ drivers/iio/adc/Makefile | 1 + drivers/iio/adc/ad7780.c | 347 +++ drivers/st

[PATCH] staging: wilc1000: correct inconsistent indenting

2018-11-28 Thread Michael Straube
Correct inconsistent indenting reported by smatch. Signed-off-by: Michael Straube --- drivers/staging/wilc1000/wilc_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c index 35ff432587fe..6d1eb82d1df

Re: [PATCH 1/6] staging: rtl8188eu: use __func__ in hal8188e_rate_adaptive.c

2018-11-28 Thread Dan Carpenter
On Wed, Nov 28, 2018 at 06:29:01PM +0100, Michael Straube wrote: > Use __func__ instead of hardcoded function names. > Reported by checkpatch. > > Signed-off-by: Michael Straube > --- > .../rtl8188eu/hal/hal8188e_rate_adaptive.c| 36 ++- > 1 file changed, 20 insertions(+), 16

[PATCH] staging: vchiq_arm: add __user pointer annotations

2018-11-28 Thread Szilveszter Székely
Add __user to pointers based on context and suggestions by sparse. Other sparse warnings still remain, in cases where more change would be required apart from adding __user. Signed-off-by: Szilveszter Székely --- .../interface/vchiq_arm/vchiq_arm.c | 28 +-- .../interf

Re: [PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

2018-11-28 Thread Martin K. Petersen
Cathy, > Currently pvscsi_remove calls free_irq more than once as > pvscsi_release_resources and __pvscsi_shutdown both call > pvscsi_shutdown_intr. This results in a 'Trying to free > already-free IRQ' warning and stack trace. To solve the problem > pvscsi_shutdown_intr has been moved out of pv

Re: [PATCH] staging: android: ion: Add chunk heap initialization

2018-11-28 Thread Laura Abbott
On 11/27/18 12:07 PM, Alexey Skidanov wrote: On 11/27/18 9:20 PM, Laura Abbott wrote: On 11/26/18 10:43 AM, Alexey Skidanov wrote: On 11/26/18 6:39 PM, Laura Abbott wrote: On 11/25/18 2:02 PM, Alexey Skidanov wrote: On 11/25/18 11:40 PM, Laura Abbott wrote: On 11/25/18 1:22 PM, Alexey

Re: [PATCH] scsi: storvsc: Fix a race in sub-channel creation that can cause panic

2018-11-28 Thread Martin K. Petersen
KY, > From: Dexuan Cui > > We can concurrently try to open the same sub-channel from 2 paths: > > path #1: vmbus_onoffer() -> vmbus_process_offer() -> handle_sc_creation(). > path #2: storvsc_probe() -> storvsc_connect_to_vsp() -> >-> storvsc_channel_init() -> handle_multichannel_storag

[PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-11-28 Thread Dexuan Cui
vmbus_process_offer() mustn't call channel->sc_creation_callback() directly for sub-channels, because sc_creation_callback() -> vmbus_open() may never get the host's response to the OPEN_CHANNEL message (the host may rescind a channel at any time, e.g. in the case of hot removing a NIC), and vmbu

Re: [PATCH] staging: android: ion: Add chunk heap initialization

2018-11-28 Thread Alexey Skidanov
On 11/29/18 3:30 AM, Laura Abbott wrote: > On 11/27/18 12:07 PM, Alexey Skidanov wrote: >> >> >> On 11/27/18 9:20 PM, Laura Abbott wrote: >>> On 11/26/18 10:43 AM, Alexey Skidanov wrote: On 11/26/18 6:39 PM, Laura Abbott wrote: > On 11/25/18 2:02 PM, Alexey Skidanov wrote:

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

2018-11-28 Thread Liam Mark
On Wed, 28 Nov 2018, Brian Starkey wrote: > Hi Liam, > > On Tue, Nov 27, 2018 at 10:46:07PM -0800, Liam Mark wrote: > > On Tue, 27 Nov 2018, Brian Starkey wrote: > > > > > Hi Liam, > > > > > > On Mon, Nov 26, 2018 at 08:59:44PM -0800, Liam Mark wrote: > > > > On Tue, 20 Nov 2018, Brian Starkey

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-11-28 Thread gre...@linuxfoundation.org
On Thu, Nov 29, 2018 at 04:36:43AM +, Dexuan Cui wrote: > > vmbus_process_offer() mustn't call channel->sc_creation_callback() > directly for sub-channels, because sc_creation_callback() -> > vmbus_open() may never get the host's response to the > OPEN_CHANNEL message (the host may rescind a c