The original code is OK.
On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote:
> From: Young_X
>
> The error at line 3267 was the result of an off-by-one error in
> a for loop in line 3253.
> If condition in line 3254 never satisfies, then the value of
> pstat->aid is NUM_ST
Hi!
On Fri, Nov 23, 2018 at 02:02:09PM +0100, Paul Kocialkowski wrote:
> This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
> both uni-directional and bi-directional prediction modes supported.
>
> Field-coded (interlaced) pictures, custom quantization matrices and
> 10-bit out
Hi,
See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an
off-by-one mistake in core/rtw_mlme_ext.c") for detail.
I don't know how can you make sure that line 3254 can be true in the for
loop. If the condition never satisfies, then there is an off-by-one
access in line 3267
On Tue, Nov 27, 2018 at 08:29:05AM +, Yang Xiao wrote:
> Hi,
>
> See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an
> off-by-one mistake in core/rtw_mlme_ext.c") for detail.
>
> I don't know how can you make sure that line 3254 can be true in the for
> loop. If the co
Okay. I can send a patch to revert ef9209b642f.
But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid
- 1] == NULL)" can satisfies in the for loop?
Young
On 2018/11/27 16:34, Dan Carpenter wrote:
> On Tue, Nov 27, 2018 at 08:29:05AM +, Yang Xiao wrote:
>> Hi,
>>
>> See co
On Tue, Nov 27, 2018 at 08:41:53AM +, Yang Xiao wrote:
> Okay. I can send a patch to revert ef9209b642f.
>
> But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid
> - 1] == NULL)" can satisfies in the for loop?
->max_num_sta is either set in _rtw_init_sta_priv() or rtw_set
Yes, you are right.
I will send a patch to revert ef9209b642f.
Young
On 2018/11/27 16:49, Dan Carpenter wrote:
> On Tue, Nov 27, 2018 at 08:41:53AM +, Yang Xiao wrote:
>> Okay. I can send a patch to revert ef9209b642f.
>>
>> But, can you make sure that the condition "(pstapriv->sta_aid[pstat
From: Young Xiao
pstapriv->max_num_sta is always <= NUM_STA, since max_num_sta is either
set in _rtw_init_sta_priv() or rtw_set_beacon().
Signed-off-by: Young Xiao
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stag
On Mon, Nov 26, 2018 at 08:36:33PM +0100, Stefan Wahren wrote:
> > Nicolas Saenz Julienne hat am 20. November 2018 um
> > 15:53 geschrieben:
> >
> >
> > Hi All,
> >
> > This series was written in parallel with reading and understanding the
> > vchiq code. So excuse me for the lack of logic in
On Tue, Nov 27, 2018 at 07:20:56AM +0100, Greg KH wrote:
> On Mon, Nov 26, 2018 at 08:56:50PM +, Michael Kelley wrote:
> > From: Greg KH Monday, November 26, 2018 11:57
> > AM
> >
> > > > > You created "null" hooks that do nothing, for no one in this patch
> > > > > series, why?
> > > > >
>
Gentile Ping...
On Thu, Nov 8, 2018 at 10:43 PM wrote:
>
> From: Lan Tianyu
>
> Sorry. Some patches was blocked and I try to resend via another account.
>
> For nested memory virtualization, Hyper-v doesn't set write-protect
> L1 hypervisor EPT page directory and page table node to track changes
On Tue, Nov 27, 2018 at 07:59:22PM +0800, Tianyu Lan wrote:
> Gentile Ping...
>
> On Thu, Nov 8, 2018 at 10:43 PM wrote:
> >
> > From: Lan Tianyu
> >
> > Sorry. Some patches was blocked and I try to resend via another account.
The patches were still blocked? They didn't show up on driver-devel
Thanks!
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Nov 27, 2018 at 8:12 PM Dan Carpenter wrote:
>
> On Tue, Nov 27, 2018 at 07:59:22PM +0800, Tianyu Lan wrote:
> > Gentile Ping...
> >
> > On Thu, Nov 8, 2018 at 10:43 PM wrote:
> > >
> > > From: Lan Tianyu
> > >
> > > Sorry. Some patches was blocked and I try to resend via another account
Hi Liam,
On Mon, Nov 26, 2018 at 08:59:44PM -0800, Liam Mark wrote:
> On Tue, 20 Nov 2018, Brian Starkey wrote:
>
> > Hi Liam,
> >
> > I'm missing a bit of context here, but I did read the v1 thread.
> > Please accept my apologies if I'm re-treading trodden ground.
> >
> > I do know we're chasi
From: Colin Ian King
There is a spelling mistake in message text in the call to unittest,
fix this.
Signed-off-by: Colin Ian King
---
drivers/staging/comedi/drivers/tests/ni_routes_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/tests/n
From: Colin Ian King
There is a spelling mistake in an ODM_RT_TRACE message, fix it.
Signed-off-by: Colin Ian King
---
drivers/staging/rtlwifi/phydm/phydm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm.c
b/drivers/staging/rtlwifi/phyd
On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
Hi, please see bellow
> Hi, thank you for the review
>
> >
> > On Thu, 22 Nov 2018 11:01:00 +
> > "Popa, Stefan Serban" wrote:
> > >
> > > I think that instead of setting the gain directly, we should use
> > > the IIO_CHAN_INFO_SC
On Mon, 26 Nov 2018 16:59:14 +0100
David Hildenbrand wrote:
> On 26.11.18 15:20, Michal Suchánek wrote:
> > On Mon, 26 Nov 2018 14:33:29 +0100
> > David Hildenbrand wrote:
> >
> >> On 26.11.18 13:30, David Hildenbrand wrote:
> >>> On 23.11.18 19:06, Michal Suchánek wrote:
> >
>
On 27/11/2018 14:23, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in message text in the call to unittest,
fix this.
Signed-off-by: Colin Ian King
---
drivers/staging/comedi/drivers/tests/ni_routes_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
> Linux marks pages that are logically offline via a page flag (map count).
> Such pages e.g. include pages infated as part of a balloon driver or
> pages that were not actually onlined when onlining the whole section.
>
> While the hypervisor usually allows to read such inflated memory, we
> basi
On 27.11.18 17:32, Michal Suchánek wrote:
> On Mon, 26 Nov 2018 16:59:14 +0100
> David Hildenbrand wrote:
>
>> On 26.11.18 15:20, Michal Suchánek wrote:
>>> On Mon, 26 Nov 2018 14:33:29 +0100
>>> David Hildenbrand wrote:
>>>
On 26.11.18 13:30, David Hildenbrand wrote:
> On 23.11.18
sed by Dan Carpenter
Problem located with an experimental coccinelle script
Patch was compile tested with: x86_64_defconfig + STAGING=y
SPI=y, IIO=y, AD7280=m
Patch is against 4.20-rc4 (localversion-next is next-20181127)
drivers/staging/iio/adc/ad7280a.c | 43 +++-
On 11/26/18 10:43 AM, Alexey Skidanov wrote:
On 11/26/18 6:39 PM, Laura Abbott wrote:
On 11/25/18 2:02 PM, Alexey Skidanov wrote:
On 11/25/18 11:40 PM, Laura Abbott wrote:
On 11/25/18 1:22 PM, Alexey Skidanov wrote:
On 11/25/18 10:51 PM, Laura Abbott wrote:
On 11/11/18 11:29 AM, Alexey
Currently pvscsi_remove calls free_irq more than once as
pvscsi_release_resources and __pvscsi_shutdown both call
pvscsi_shutdown_intr. This results in a 'Trying to free
already-free IRQ' warning and stack trace. To solve the problem
pvscsi_shutdown_intr has been moved out of pvscsi_release_resourc
On 11/27/18 9:20 PM, Laura Abbott wrote:
> On 11/26/18 10:43 AM, Alexey Skidanov wrote:
>>
>>
>> On 11/26/18 6:39 PM, Laura Abbott wrote:
>>> On 11/25/18 2:02 PM, Alexey Skidanov wrote:
On 11/25/18 11:40 PM, Laura Abbott wrote:
> On 11/25/18 1:22 PM, Alexey Skidanov wrote:
On Tue, Nov 27, 2018 at 02:28:53PM -0500, Cathy Avery wrote:
> Currently pvscsi_remove calls free_irq more than once as
> pvscsi_release_resources and __pvscsi_shutdown both call
> pvscsi_shutdown_intr. This results in a 'Trying to free
> already-free IRQ' warning and stack trace. To solve the prob
In the first patch there is a fix of some parenthesis that terminate
on end of line and some parameters that are not aligned with
previous parenthesis.
The second patch is a proposal that avoid the long line refactoring
code removing cast pointer.
Cristian Sicilia (2):
staging: emxx_udc: Align
Align parameters with parenthesis and removed
open parenthesis at the end of line.
Signed-off-by: Cristian Sicilia
---
drivers/staging/emxx_udc/emxx_udc.c | 270 ++--
1 file changed, 107 insertions(+), 163 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_
Remove the cast from IO_ADDRESS and use a single line.
Signed-off-by: Cristian Sicilia
---
As suggested by Dan we can just remove the cast and use an
unique line.
drivers/staging/emxx_udc/emxx_udc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging
From: Young Xiao
In routine rtw_report_sec_ie(), the code could set the length
of the buffer to 256; however, that value is one larger than the
corresponding memory allocation.
See commit 8b7a13c3f404 ("staging: r8712u: Fix possible
buffer overrun") for detail.
Signed-off-by: Young Xiao
---
d
On Tue, 27 Nov 2018, Brian Starkey wrote:
> Hi Liam,
>
> On Mon, Nov 26, 2018 at 08:59:44PM -0800, Liam Mark wrote:
> > On Tue, 20 Nov 2018, Brian Starkey wrote:
> >
> > > Hi Liam,
> > >
> > > I'm missing a bit of context here, but I did read the v1 thread.
> > > Please accept my apologies if I
The original code is OK.
On Wed, Nov 28, 2018 at 02:22:31AM +, Yang Xiao wrote:
> From: Young Xiao
>
> In routine rtw_report_sec_ie(), the code could set the length
> of the buffer to 256; however, that value is one larger than the
> corresponding memory allocation.
>
> See commit 8b7a13c3f
Yes, you are right. I will send a new patch.
Young
On 2018/11/28 14:51, Dan Carpenter wrote:
> The original code is OK.
>
> On Wed, Nov 28, 2018 at 02:22:31AM +, Yang Xiao wrote:
>> From: Young Xiao
>>
>> In routine rtw_report_sec_ie(), the code could set the length
>> of the buffer to 256;
34 matches
Mail list logo
