Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
Hi David, > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Kairui Song > Cc: Vitaly Kuznetsov > Cc: Andrew Morton > Cc: Matthew Wilcox

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread David Hildenbrand
On 20.11.18 09:45, Pankaj Gupta wrote: > > Hi David, > >> >> Mark inflated and never onlined pages PG_offline, to tell the world that >> the content is stale and should not be dumped. >> >> Cc: "K. Y. Srinivasan" >> Cc: Haiyang Zhang >> Cc: Stephen Hemminger >> Cc: Kairui Song >> Cc: Vitaly K

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
> >> --- > >> drivers/hv/hv_balloon.c | 14 -- > >> 1 file changed, 12 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > >> index 211f3fe3a038..47719862e57f 100644 > >> --- a/drivers/hv/hv_balloon.c > >> +++ b/drivers/hv/hv_ballo

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-20 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? http://daringfireball.net

Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

2018-11-20 Thread Greg Kroah-Hartman
On Sat, Nov 17, 2018 at 04:40:27PM +0100, Johan Hovold wrote: > On Sat, Nov 17, 2018 at 12:41:11PM +0530, Nishad Kamdar wrote: > > On Fri, Nov 16, 2018 at 05:06:22PM +0100, Johan Hovold wrote: > > > On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > > > > Use the gpiod interface inste

Re: [PATCH] staging: rtl8188eu: core: coding style check

2018-11-20 Thread Greg Kroah-Hartman
On Tue, Nov 13, 2018 at 10:06:13PM +0800, Kevin Dou wrote: > follow the linux coding style, rename the variable > shortGIrate to short_gi_rate. > > Signed-off-by: Kevin Dou > --- > drivers/staging/rtl8188eu/core/rtw_ap.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Hi, This

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

2018-11-20 Thread Greg Kroah-Hartman
On Tue, Nov 13, 2018 at 11:32:51AM +0800, wahahab wrote: > > > On 12 Nov 2018, at 8:40 PM, Greg Kroah-Hartman wrote: > > > > On Mon, Nov 12, 2018 at 04:49:30PM +0800, wahahab wrote: > >> > >>> On 10 Nov 2018, at 1:15 AM, Dan Carpenter >>> > wrote: > >>> > >>>

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-20 Thread Greg KH
On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > Hi Nicolas, > > > Nicolas Saenz Julienne hat am 14. November 2018 um > > 13:59 geschrieben: > > > > > > Hi All, > > > > This series was written in parallel with reading and understanding the > > vchiq code. So excuse me for the

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-20 Thread Nicolas Saenz Julienne
On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote: > On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > > Hi Nicolas, > > > > > Nicolas Saenz Julienne hat am 14. > > > November 2018 um 13:59 geschrieben: > > > > > > > > > Hi All, > > > > > > This series was written in parallel wit

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-20 Thread Stefan Wahren
Am 20.11.18 um 11:04 schrieb Nicolas Saenz Julienne: > On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote: >> On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: >>> Hi Nicolas, >>> >>> >>> without a changelog i won't start a review. >> What do you mean by this? The individual patches hav

[PATCH] media: davinci_vpfe: bail out if kmalloc failed

2018-11-20 Thread Nicholas Mc Guire
(localversion-next is next-20181120) drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 3d910b8..0150aed 100644 --- a/drivers/

[PATCH net-next 3/4] benet: use skb_vlan_tag_get_prio()

2018-11-20 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 80b2bd3747ce..245abf0d19c0 100644 --- a/drivers/net/e

[PATCH net-next 4/4] mlx5: use skb_vlan_tag_get_prio()

2018-11-20 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c index 6dacaeba2fbf..9afdf955f2bc 100644 --- a/d

[PATCH net-next 2/4] net/hyperv: use skb_vlan_tag_*() helpers

2018-11-20 Thread Michał Mirosław
Replace open-coded bitfield manipulation with skb_vlan_tag_*() helpers. This also enables correctly passing of VLAN.CFI bit. Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/netvsc_d

[PATCH net-next 1/4] net/vlan: introduce skb_vlan_tag_get_cfi() helper

2018-11-20 Thread Michał Mirosław
Abstract CFI/DEI bit access consistently with other VLAN tag fields. Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 7a541eadf78e..4cca4da7a6de 100644 --- a/in

[PATCH net-next 0/4] VLAN tag handling cleanup

2018-11-20 Thread Michał Mirosław
This is a cleanup set after VLAN_TAG_PRESENT removal. The CFI bit handling is made similar to how other tag fields are used. Michał Mirosław (4): net/vlan: introduce skb_vlan_tag_get_cfi() helper net/hyperv: use skb_vlan_tag_*() helpers benet: use skb_vlan_tag_get_prio() mlx5: use skb_vlan

[PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

2018-11-20 Thread Gao Xiang
When the managed cache is enabled, the last reference count of a workgroup must be used for its workstation. Otherwise, it could lead to incorrect (un)freezes in the reclaim path, and it would be harmful. A typical race as follows: Thread 1 (In the reclaim path) Thread 2 workgroup_freeze(grp, 1

[PATCH 00/10] staging: erofs: decompression stability enhancement

2018-11-20 Thread Gao Xiang
Hi, This patchset mainly focuses on erofs decompression stability, most of them are found in the internal beta test. Some patches which are still in testing or reviewing aren't included in this patchset and will be sent after carefully testing. Thanks, Gao Xiang Gao Xiang (10): staging: erofs:

[PATCH 01/10] staging: erofs: fix `trace_erofs_readpage' position

2018-11-20 Thread Gao Xiang
`trace_erofs_readpage' should be placed in .readpage() rather than in the internal `z_erofs_do_read_page'. Fixes: 284db12cfda3 ("staging: erofs: add trace points for reading zipped data") Reviewed-by: Chen Gong Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- drivers/staging/erofs/unzip_vle.

[PATCH 03/10] staging: erofs: atomic_cond_read_relaxed on ref-locked workgroup

2018-11-20 Thread Gao Xiang
It's better to use atomic_cond_read_relaxed, which is implemented in hardware instructions to monitor a variable changes currently for ARM64, instead of open-coded busy waiting. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 30 ++---

[PATCH 05/10] staging: erofs: add a full barrier in erofs_workgroup_unfreeze

2018-11-20 Thread Gao Xiang
Just like other generic locks, insert a full barrier in case of memory reorder. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/erofs/internal.h b/drivers/staging/erofs/internal.h index 2e0ef9

[PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

2018-11-20 Thread Gao Xiang
There are two minor issues in the current freeze interface: 1) Freeze interfaces have not related with CONFIG_DEBUG_SPINLOCK, therefore fix the incorrect conditions; 2) For SMP platforms, it should also disable preemption before doing atomic_cmpxchg in case that some high priori

[PATCH 06/10] staging: erofs: fix the definition of DBG_BUGON

2018-11-20 Thread Gao Xiang
It's better not to positively BUG_ON the kernel, however developers need a way to locate issues as soon as possible. DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. It is helpful for developers to find and solve bugs quickly. Previously, DBG_

[PATCH 07/10] staging: erofs: separate into init_once / always

2018-11-20 Thread Gao Xiang
`z_erofs_vle_workgroup' is heavily generated in the decompression, for example, it resets 32 bytes redundantly for 64-bit platforms even through Z_EROFS_VLE_INLINE_PAGEVECS + Z_EROFS_CLUSTER_MAX_PAGES, default 4, pages are stored in `z_erofs_vle_workgroup'. As an another example, `struct mutex' ta

[PATCH 10/10] staging: erofs: rename strange variable names in z_erofs_vle_frontend

2018-11-20 Thread Gao Xiang
Previously, 2 members called `initial' and `cachedzone_la' are used for applying caching policy (whether the workgroup is at either end), which are hard to understand, rename them to `backmost' and `headoffset'. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- drivers/staging/erofs/unzip_vle.c

[PATCH 08/10] staging: erofs: locked before registering for all new workgroups

2018-11-20 Thread Gao Xiang
Let's make sure that the one registering a workgroup will also take the primary work lock at first for two reasons: 1) There's no need to introduce such a race window (and consequently overhead) between registering and locking, other tasks could break in by chance, and the race seems un

[PATCH 09/10] staging: erofs: decompress asynchronously if PG_readahead page at first

2018-11-20 Thread Gao Xiang
For the case of nr_to_read == lookahead_size, it is better to decompress asynchronously as well since no page will be needed immediately. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- drivers/staging/erofs/unzip_vle.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH 01/16] staging: vchiq_core: rework vchiq_get_config

2018-11-20 Thread Nicolas Saenz Julienne
The function is overly complicated for what it's ultimately achieving. It's simply filling up a structure. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 12 .../interface/vchiq_arm/vchiq_core.c | 30 +-- .../interface/

[PATCH 05/16] staging: vchiq_arm: get rid of vchi_mh.h

2018-11-20 Thread Nicolas Saenz Julienne
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and was meant to be used with bulk transfers. After a quick look in vchiq_core.c it is pretty clear that it actually accomplishes nothing nor alters the bulk transfers in any way. Signed-off-by: Nicolas Saenz Julienne --- .../vc0

[PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-20 Thread Nicolas Saenz Julienne
Hi All, This series was written in parallel with reading and understanding the vchiq code. So excuse me for the lack of logic in the sequence of patches. The main focus was to delete as much code as possible, I've counted around 550 lines, which is not bad. Apart from that there are some patches

[PATCH 04/16] staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list

2018-11-20 Thread Nicolas Saenz Julienne
The resulting code is way more readeable and intuitive compared to plain list_for_each. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 52 ++- 1 file changed, 16 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vc04_services/

[PATCH 09/16] staging: vchiq_core: do not initialize semaphores twice

2018-11-20 Thread Nicolas Saenz Julienne
vchiq_init_state() initialises a series of semaphores to then call remote_event_create() on the same semaphores, which initializes them again. We get rid of the second initialization. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_core.c| 11 +--

[PATCH 12/16] staging: vchiq_util: get rid of unneeded memory barriers

2018-11-20 Thread Nicolas Saenz Julienne
All the memory operations featured in this file modify/access memory that is only accessed by the CPU. So we can assume that all the memory barrier handling done by the completion routines is good enough for us. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_util.c

[PATCH 14/16] staging: vchiq_arm: rework probe and init functions

2018-11-20 Thread Nicolas Saenz Julienne
Moves the allocation of a chardev region and class creation to the init function of the driver since those functions are meant to be run on a per driver basis, as opposed to the code run in the probe function which is run in a per device basis. Signed-off-by: Nicolas Saenz Julienne --- .../inter

[PATCH 08/16] staging: vchiq_core: remove unnecessary safety checks in vchiq_init_state

2018-11-20 Thread Nicolas Saenz Julienne
vchiq_init_state() checks the initial contents of slot_zero are correct. These are set in vchiq_init_slots(), using the same hard-coded defaults as the checks. Both functions are called sequentially and Video Core isn't yet aware of the slot's address. There is no way the contents of slot_zero chan

[PATCH 07/16] staging: vchiq-core: get rid of is_master distinction

2018-11-20 Thread Nicolas Saenz Julienne
VCHIQ bulk transfers are what most people call DMA transfers. The CPU sends a list of physical addresses to the VideoCore which then access the memory directly without the need for CPU interaction. With this setup we call the CPU the "slave" and the VideoCore the "master". There seems to be an op

[PATCH 13/16] staging: vchiq_core: fix logic redundancy in parse_open

2018-11-20 Thread Nicolas Saenz Julienne
We update sync to reflect that the firmware version is compatible with that option. We don't need to check both of them again further down the code. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 02/16] staging: vchiq_arm: rework close/remove_service IOCTLS

2018-11-20 Thread Nicolas Saenz Julienne
The implementation of both IOCTLS was the same except for one function call. This joins both implementations and updates the code to avoid unneeded indentations. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 66 +++ 1 file changed, 24 i

[PATCH 06/16] staging: vchiq_arm: rework vchiq_ioc_copy_element_data

2018-11-20 Thread Nicolas Saenz Julienne
The function is passed to vchiq_core.c for it to go trough all the transfer elements (an array of pointers to data) and copy them into the actual transfer memory (contiguous memory). The logic in the function was "copy an element and return, except when the element is empty, in which case look for

[PATCH 10/16] staging: vchiq_core: don't add a wmb() before remote_event_signal()

2018-11-20 Thread Nicolas Saenz Julienne
It's the first thing remote_event_signal() does. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_s

[PATCH 11/16] staging: vchiq: use completions instead of semaphores

2018-11-20 Thread Nicolas Saenz Julienne
It is preferred in the kernel to avoid using semaphores to wait for events, as they are optimised for the opposite situation; where the common case is that they are available and may block only occasionally. FYI see this thread: https://lkml.org/lkml/2008/4/11/323. Also completions are semanticall

[PATCH 03/16] staging: vchiq_shim: delete vchi_service_create

2018-11-20 Thread Nicolas Saenz Julienne
No one is using the API neither in the actual staging tree nor in the downstream tree (https://github.com/raspberrypi/linux). Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchi/vchi.h | 5 --- .../interface/vchiq_arm/vchiq_shim.c | 32 ---

[PATCH 16/16] staging: vchiq: add more tasks to the TODO list

2018-11-20 Thread Nicolas Saenz Julienne
The TODO list was missing some tasks needed before upstreaming the device. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchi/TODO | 42 +++ 1 file changed, 42 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers

[PATCH 15/16] staging: vchiq_arm: fix open/release cdev functions

2018-11-20 Thread Nicolas Saenz Julienne
Both functions checked the minor number of the cdev prior running the code. This was useless since the number of devices is already limited by alloc_chrdev_region. This removes the check and reindents the code where relevant. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vch

[PATCH v2 0/5] Remove platform data and introduce DT bindings

2018-11-20 Thread Shreeya Patel
This patchset introduces device tree bindings for adt7316 driver and removes the usage of platform data from it. Also, it sets the data field to it's appropriate value in the i2c read function which was nowhere being set before. Changes in v2: - Make the commit message of patch *[1/5] appropriat

[PATCH v2 1/5] Staging: iio: adt7316: Add of_device_id table

2018-11-20 Thread Shreeya Patel
When the kernel starts up, it kicks off compiled-in drivers that match “compatible” entries it finds in the device tree. At a later stage (when /lib/modules is available), all kernel modules that match “compatible” entries in the device tree are loaded. But if there is no dt table then there shoul

[PATCH v2 2/5] Staging: iio: adt7316: Use device tree data to set ldac_pin

2018-11-20 Thread Shreeya Patel
Make the driver use device tree instead of the platform data. Hence, use devm_gpiod_get_optional function to get the data from device tree for ldac-pin and accordingly make the needed changes in the driver. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 14 ++

[PATCH v2 3/5] Staging: iio: adt7316: Switch irq_flags to a local variable

2018-11-20 Thread Shreeya Patel
There is no need to store irq_flags into the structure as it is always set to the same thing. Hence switch irq_flags to a local variable. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 1 - drivers/staging/iio/addac/adt7316-spi.c | 1 - drivers/staging/iio/addac/adt73

[PATCH v2 4/5] Staging: iio: adt7316: Change the name from irq_flags to irq_type

2018-11-20 Thread Shreeya Patel
Most of the drivers in IIO uses irq_type as the name for storing the interrupt type and hence change the name from irq_flags to irq_type for maintaining the consistency. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 8 1 file changed, 4 insertions(+), 4 deletion

[PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

2018-11-20 Thread Shreeya Patel
ADT7316 driver no more uses platform data and hence use device tree data instead of platform data for assigning irq_type field. Switch case figures out the type of irq and if it's the default case then assign the default value to the irq_type i.e. irq_type = IRQF_TRIGGER_LOW Signed-off-by: Shreeya

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

2018-11-20 Thread Brian Starkey
Hi Liam, I'm missing a bit of context here, but I did read the v1 thread. Please accept my apologies if I'm re-treading trodden ground. I do know we're chasing nebulous ion "problems" on our end, which certainly seem to be related to what you're trying to fix here. On Thu, Nov 01, 2018 at 03:15:

Re: Patch "x86/hyper-v: Enable PIT shutdown quirk" has been added to the 4.19-stable tree

2018-11-20 Thread kbuild test robot
Hi gregkh, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [cannot apply to v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/gregkh

[PATCH v2 1/2] staging: iio: ad7606: Move out of staging

2018-11-20 Thread Stefan Popa
Move ad7606 ADC driver out of staging and into the mainline. Signed-off-by: Stefan Popa --- Changes in v2: - Simplified the Kconfig menu. - Added SPDX-License-Identifier. - Ordered the includes alphabetically. - Used a threaded interrupt. - Replaced ad7606_

Re: [PATCH v1 8/8] PM / Hibernate: exclude all PageOffline() pages

2018-11-20 Thread Rafael J. Wysocki
On Monday, November 19, 2018 11:16:16 AM CET David Hildenbrand wrote: > The content of pages that are marked PG_offline is not of interest > (e.g. inflated by a balloon driver), let's skip these pages. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown > Cc: Andrew Morton > Cc: Mat

Re: [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page()

2018-11-20 Thread Rafael J. Wysocki
On Monday, November 19, 2018 11:16:15 AM CET David Hildenbrand wrote: > Let's use pfn_to_online_page() instead of pfn_to_page() when checking > for saveable pages to not save/restore offline memory sections. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown > Cc: Andrew Morton > C

RE: [PATCH net-next 2/4] net/hyperv: use skb_vlan_tag_*() helpers

2018-11-20 Thread Haiyang Zhang
> -Original Message- > From: Michał Mirosław > Sent: Tuesday, November 20, 2018 7:21 AM > To: net...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; Ajit Khaparde > ; Leon Romanovsky ; > linux-r...@vger.kernel.org; Saeed Mahamee

Re: [PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-20 Thread Matheus Tavares Bernardino
On Mon, Nov 19, 2018 at 6:22 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > One minor comment inline. > > > Signed-off-by: Matheus Tavare

Re: [PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

2018-11-20 Thread Matheus Tavares Bernardino
On Mon, Nov 19, 2018 at 6:09 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds device tree support to ad2s90 with standard > > device tree id table. > > > > Hey, > > Comment inline > > > Signed-off-by: Matheus Tavares > > --- > > Chang

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
> > >> --- > > >> drivers/hv/hv_balloon.c | 14 -- > > >> 1 file changed, 12 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > > >> index 211f3fe3a038..47719862e57f 100644 > > >> --- a/drivers/hv/hv_balloon.c > > >> +++ b/dri

Re: [PATCH v1 1/8] mm: balloon: update comment about isolation/migration/compaction

2018-11-20 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:16:09AM +0100, David Hildenbrand wrote: > Commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page > feature") reworked balloon handling to make use of the general > non-lru movable page feature. The big comment block in > balloon_compaction.h contains quite so

Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-20 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:16:10AM +0100, David Hildenbrand wrote: > PG_balloon was introduced to implement page migration/compaction for pages > inflated in virtio-balloon. Nowadays, it is only a marker that a page is > part of virtio-balloon and therefore logically offline. > > We also want to m

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:16:11AM +0100, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see xe

Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-20 Thread Pankaj Gupta
> > PG_balloon was introduced to implement page migration/compaction for pages > inflated in virtio-balloon. Nowadays, it is only a marker that a page is > part of virtio-balloon and therefore logically offline. > > We also want to make use of this flag in other balloon drivers - for > inflated

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Dave Young
On 11/19/18 at 11:16am, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see xen_oldmem_pfn_is_ra

Re: [PATCH v1 6/8] vmw_balloon: mark inflated pages PG_offline

2018-11-20 Thread Nadav Amit
Thanks for this patch! > On Nov 19, 2018, at 2:16 AM, David Hildenbrand wrote: > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Xavier Deguillard > Cc: Nadav Amit > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Baoquan He
On 11/19/18 at 11:16am, David Hildenbrand wrote: > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 933cb3e45b98..093c9f917ed0 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -464,6 +464,8 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_NUM