Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

On Sat, Nov 17, 2018 at 12:41:11PM +0530, Nishad Kamdar wrote: > On Fri, Nov 16, 2018 at 05:06:22PM +0100, Johan Hovold wrote: > > On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated > > > old non-descriptor interface. > > > > > >

Re: [PATCH v2 02/17] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings

On Fri, 16 Nov 2018 17:23:48 +0100, Lubomir Rintel wrote: > The OLPC XO-1.75 Embedded Controller is a SPI master that uses extra > signals for handshaking. It needs to know when is the slave (Linux) > side's TX FIFO ready for transfer (the ready-gpio signal on the SPI > controller node) and when do

Re: [PATCH 1/7] Staging: iio: adt7316: Set the data field

On Sat, 17 Nov 2018 04:19:07 +0530 Shreeya Patel wrote: > adt7316_i2c_read function nowhere sets the data field. > It is necessary to have an appropriate value for it. > Hence, assign the value stored in 'ret' variable to data field. > > Signed-off-by: Shreeya Patel I have amended the descripti

Re: [PATCH 2/7] Staging: iio: adt7316: Add an extra check for 'ret' equals to 0

On Sat, 17 Nov 2018 04:21:32 +0530 Shreeya Patel wrote: > ret = 0 indicates a case of no error but no data read from > the bus which is an invalid case. This case doesn't ever happen > in reality. It should perhaps be handled for correctness though. > > Signed-off-by: Shreeya Patel Applied to t

Re: [PATCH 3/7] Staging: iio: adt7316: Add of_device_id table

On Sat, 17 Nov 2018 04:25:37 +0530 Shreeya Patel wrote: > When the kernel starts up, it kicks off compiled-in drivers > that match “compatible” entries it finds in the device tree. > At a later stage (when /lib/modules is available), all kernel modules > that match “compatible” entries in the dev

Re: [PATCH 4/7] Staging: iio: adt7316: Use device tree data to set ldac_pin

On Sat, 17 Nov 2018 04:27:32 +0530 Shreeya Patel wrote: > Make the driver use device tree instead of the platform data. > Hence, use devm_gpiod_get_optional function to get the data from > device tree for ldac-pin and accordingly make the needed changes > in the driver. > > Signed-off-by: Shreey

Re: [PATCH 7/7] Staging: iio: adt7316: Use device tree data to assign irq_type

On Sat, 17 Nov 2018 04:34:55 +0530 Shreeya Patel wrote: > ADT7316 driver no more uses platform data and hence use device tree > data instead of platform data for assigning irq_type field. > Switch case figures out the type of irq and if it's the default case > then assign the default value to the

Re: [PATCH 1/2] staging: emxx_udc: Split line and fix eol parenthesis

On Sat, 2018-11-17 at 00:46 +0100, Cristian Sicilia wrote: > Fix some parenthesis opened at end of line. It looks like this is all guarded by #ifdef UDC_DEBUG_DUMP which is not ever set and this probably would not compile if it was. It's probably better to remove all the blocks guarded by that fl

Re: [PATCH v6 1/3] staging: mt7621-mmc: Remove #if 0 blocks in sd.c

On Thu, Oct 04 2018, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of > functions defined in the #if 0 blocks in sd.c. > > Signed-off-by: Nishad Kamdar Hi Nishad, thanks for this patch (and others) and apologies for not reviewing/testing it earlier. Unfortunately ther

[PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

This patch adds the device tree binding documentation for the ad2s90 resolver-to-digital converter. Signed-off-by: Matheus Tavares --- Changes in v2: - Rewritten 'spi-cpol and spi-cpha' item to say that the device can work in either mode (0,0) or (1,1) and explain how they should be specified

[PATCH v2 7/7] staging:iio:ad2s90: Move out of staging

Move ad2s90 resolver driver out of staging to the main tree. Signed-off-by: Matheus Tavares Signed-off-by: Victor Colombo --- Changes in v2: - Disabled git move detection, to see the whole code, as Jonathan suggested drivers/iio/resolver/Kconfig | 10 ++ drivers/iio/resolver/Makefi

[PATCH v2 0/7] staging:iio:ad2s90: Add dt support and move out of staging

This series adds device tree support to ad2s90, adds the respective dt-binding documentation, solves all remaining codestyle problems in the driver code and move it out of staging.

[PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

This patch adds device tree support to ad2s90 with standard device tree id table. Signed-off-by: Matheus Tavares --- Changes in v2: - none drivers/staging/iio/resolver/ad2s90.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/i

[PATCH v2 6/7] staging:iio:ad2s90: Add comment to device state mutex

From: Victor Colombo Fix the checkpatch.pl issue: "CHECK: struct mutex definition without comment". Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- Changes in v2: - Patch added in v2 drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier

This patch removes the license boilerplate text at the top of ad2s90.c and, instead, adds the SPDX GPL-2.0 license identifier, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Matheus Tavares --- Changes in v2: - Change

[PATCH v2 3/7] staging:iio:ad2s90: Add max frequency check at probe

From: Alexandru Ardelean This patch adds a max frequency check at the beginning of ad2s90_probe function so that when it is set to a value above 0.83Mhz, dev_err is called with an appropriate message and -EINVAL is returned. The defined limit is 0.83Mhz instead of 2Mhz, which is the chip's max f

[PATCH v2 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt

The ad2s90 driver currently sets some spi settings (max_speed_hz and mode) at ad2s90_probe. Since the maximum frequency is a required element in DT binding for spi slave devices and because the spi mode for the device can be either (0,0) or (1,1), these settings should be handled via device tree, n