There is actually no need at all to d_rehash() for the root dentry
as Al pointed out, fix it.
Reported-by: Al Viro
Cc: Al Viro
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/super.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/erofs/super.c b/drivers/staging/ero
On Fri, 2 Nov 2018 10:49:59 -0300
Matheus Tavares wrote:
> On 10/28/18 1:40 PM, Jonathan Cameron wrote:
> > On Fri, 26 Oct 2018 23:00:00 -0300
> > Matheus Tavares wrote:
> >
> >> Previously, when spi_read returned an error code inside ad2s90_read_raw,
> >> the code was ignored and IIO_VAL_INT
On Fri, 2 Nov 2018 10:59:06 -0300
Matheus Tavares wrote:
> On 10/28/18 1:43 PM, Jonathan Cameron wrote:
> > On Fri, 26 Oct 2018 23:00:01 -0300
> > Matheus Tavares wrote:
> >
> >> Previously, ad2s90_probe ignored the return code from spi_setup, not
> >> handling its possible failure. This patch
Use the gpiod interface instead of the deprecated old non-descriptor
interface in olpc_dcon_xo_1.c.
---
Changes in v2:
- Resolve a few compilation errors.
- Add a level of indirection to read and write gpios.
Signed-off-by: Nishad Kamdar
---
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 89 +
On Thu, 1 Nov 2018 21:05:09 +0530
Himanshu Jha wrote:
> On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote:
> > Add device tree table for matching vendor ID.
> >
> > Signed-off-by: Nishad Kamdar
> > ---
> > drivers/staging/iio/resolver/ad2s1210.c | 7 +++
> > 1 file changed, 7 i
On Wed, 31 Oct 2018 21:28:52 +0530
Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
It would have been less 'noisy' to do these in the reverse order (drop
the flag and support first, then do the gpiod conve
On Wed, 31 Oct 2018 21:29:53 +0530
Nishad Kamdar wrote:
> Drop gpioin flag which decides how the GPIOs
> are controlled as the GPIOs must be outputs
> for the host as per the datasheet.
>
> Signed-off-by: Nishad Kamdar
Whilst this does the right thing, it doesn't take advantage
of opportunities
On Thu, 1 Nov 2018 15:02:32 +
"Ardelean, Alexandru" wrote:
> Good catch.
>
> Acked-by: Alexandru Ardelean
On the basis this has been broken for a long time, and you are clearly
doing other nearby not fix work, I'm going to take this through the togreg
tree rather than via the quicker fix pa
On Thu, 1 Nov 2018 15:20:55 +
"Ardelean, Alexandru" wrote:
> On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> > The ad7780 driver previously did not read the correct device output, as
> > it read an outdated value set at initialization. It now updates its
> > voltage on read.
> >
>
On Sat, 3 Nov 2018 12:39:27 +
Jonathan Cameron wrote:
> On Thu, 1 Nov 2018 21:05:09 +0530
> Himanshu Jha wrote:
>
> > On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote:
> > > Add device tree table for matching vendor ID.
> > >
> > > Signed-off-by: Nishad Kamdar
> > > ---
> >
On Thu, 1 Nov 2018 15:28:19 +
"Ardelean, Alexandru" wrote:
> On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> > This patch removes the unnecessary field int_vref_mv in ad7780_state
> > referring to the device's voltage.
> >
> > Signed-off-by: Renato Lui Geh
> > ---
> > Changes in
On Sat, 3 Nov 2018 12:45:09 +
Jonathan Cameron wrote:
> On Wed, 31 Oct 2018 21:28:52 +0530
> Nishad Kamdar wrote:
>
> > Use the gpiod interface instead of the deprecated old non-descriptor
> > interface.
> >
> > Signed-off-by: Nishad Kamdar
> It would have been less 'noisy' to do these
Hi,
On Thu, 1 Nov 2018 15:02:32 +
"Ardelean, Alexandru" wrote:
Good catch.
That was actually Jonathan's catch. :)
Acked-by: Alexandru Ardelean
I read up on Acked-by on the kernel docs, as I didn't know exactly what
it meant, but I'm not so sure on how to proceed once the patch has
On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote:
>
> On Fri, 26 Oct 2018 23:00:04 -0300
> Matheus Tavares wrote:
>
> > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
> > implements the relative read behavior at ad2s90_read_raw.
> >
> > Signed-off-by: Victor Colombo
> > Si
On Thu, 1 Nov 2018 15:20:55 +
"Ardelean, Alexandru" wrote:
This looks wrong.
I admit this was done in the same way in the probe function, but that looks
a bit wrong as well.
Typically, the return value of `regulator_get_voltage()` would get checked
with:
ret = regulator_get_voltage(st->re
On Sat, 3 Nov 2018 13:06:19 -0300
Renato Lui Geh wrote:
> On Thu, 1 Nov 2018 15:20:55 +
> "Ardelean, Alexandru" wrote:
> >
> > This looks wrong.
> > I admit this was done in the same way in the probe function, but that looks
> > a bit wrong as well.
> >
> > Typically, the return value of `re
On Sat, 3 Nov 2018 12:59:16 -0300
Renato Lui Geh wrote:
> Hi,
>
> >On Thu, 1 Nov 2018 15:02:32 +
> >"Ardelean, Alexandru" wrote:
> >
> >> Good catch.
>
> That was actually Jonathan's catch. :)
>
> >> Acked-by: Alexandru Ardelean
>
> I read up on Acked-by on the kernel docs, as I d
On Sat, 3 Nov 2018 13:04:04 -0300
Matheus Tavares Bernardino wrote:
> On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote:
> >
> > On Fri, 26 Oct 2018 23:00:04 -0300
> > Matheus Tavares wrote:
> >
> > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
> > > implements the re
This patch set adds scale info to ad2s90's single channel, improve
error handling in it's functions and fix a possible race condition
issue.
The goal with this patch set is to address the points discussed in the
mailing list in an effort to move ad2s90.c out of staging.
Changes in v3:
- Removed
Previously, ad2s90_probe ignored the return code from spi_setup, not
handling its possible failure. This patch makes ad2s90_probe check if
the code is an error code and, if so, do the following:
- Call dev_err with an appropriate error message.
- Return the spi_setup's error code.
Note: The 'retu
Previously, devm_iio_device_register was being called before the
spi_setup call and the spi_device's max_speed_hz and mode assignments.
This could lead to a race condition since the driver was still being
set up after it was already made ready to use. To fix it, this patch
moves the device registra
Previously, when spi_read returned an error code inside ad2s90_read_raw,
the code was ignored and IIO_VAL_INT was returned. This patch makes the
function return the error code returned by spi_read when it fails.
Signed-off-by: Matheus Tavares
---
drivers/staging/iio/resolver/ad2s90.c | 7 ---
This patch removes an initial assignment to the variable ret at probe,
that was always overwritten.
Signed-off-by: Matheus Tavares
---
drivers/staging/iio/resolver/ad2s90.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/resolver/ad2s90.c
b/drivers/stagin
This patch adds a channel type check at the beginning of the
ad2s90_read_raw function. Since ad2s90 has only one channel, it just
checks if the given channel is the expected one and if not, return
-EINVAL.
Signed-off-by: Matheus Tavares
---
drivers/staging/iio/resolver/ad2s90.c | 3 +++
1 file c
This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
implements the relative read behavior at ad2s90_read_raw.
Signed-off-by: Victor Colombo
Signed-off-by: Matheus Tavares
---
drivers/staging/iio/resolver/ad2s90.c | 30 +++
1 file changed, 21 insertions(+), 9
The compatibility ioctl wrapper for VCHIQ_IOC_AWAIT_COMPLETION assumes that
the native ioctl always uses a message buffer and decrements msgbufcount.
Certain message types do not use a message buffer and in this case
msgbufcount is not decremented, and completion->header for the message is
NULL. Be
Hi Nishad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/
Add support for platforms where pit_shutdown() doesn't work because
of a quirk in the PIT emulation. On these platforms setting the
counter register to zero causes the PIT to start running again,
negating the shutdown. Provide a global variable that controls
whether the counter register is zero'ed,
pit_shutdown() doesn't work on Hyper-V because of a quirk in the
PIT emulation. This problem exists in all versions of Hyper-V and
had not been noticed previously. When the counter register is set
to zero, the emulated PIT continues to interrupt @18.2 HZ.
Account for this quirk by adding a global
Hyper-V emulation of the PIT has a quirk such that the normal
PIT shutdown path doesn't work. Enable the PIT code that
handles this quirk.
Signed-off-by: Michael Kelley
---
arch/x86/kernel/cpu/mshyperv.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/x86/kernel/cpu/mshyper
Hi Nishad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/
Dear Sir, Madam,
A Strictly Confidential Business Proposal
I am Mr.John Woods, a Consultant with the Department of Power and Steel here in
Spain . I have been contracted by a wealthy individual and serving government
official from somewhere in Africa who is interested in engaging your service
32 matches
Mail list logo