Re: [PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

2018-10-31 Thread Ian Abbott
On 30/10/18 22:27, Spencer Olson wrote: On Tue, Oct 30, 2018 at 6:21 AM Ian Abbott wrote: On 25/10/18 02:36, Spencer E. Olson wrote: Changes do_insn*_ioctl functions to allow for data lengths for each comedi_insn of up to 2^16. This patch also changes these functions to only allocate as much

Re: [PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

2018-10-31 Thread Ian Abbott
On 25/10/18 02:36, Spencer E. Olson wrote: Changes do_insn*_ioctl functions to allow for data lengths for each comedi_insn of up to 2^16. This patch also changes these functions to only allocate as much memory as is necessary for each comedi_insn, rather than allocating a fixed-sized scratch spa

[PATCH] staging: comedi: addi_apci_3501: Use insn->n in EEPROM insn_read handler

2018-10-31 Thread Ian Abbott
The `insn_read` handler for the EEPROM subdevice (`apci3501_eeprom_insn_read()`) currently ignores `insn->n` (the number of samples to be read) and assumes a single sample is to be read. But `insn->n` could be 0, meaning no samples should be read, in which case `data[0]` ought not to be written.

[PATCH v3] staging: vboxvideo: Remove unnecessary parentheses

2018-10-31 Thread Shayenne da Luz Moura
Remove unneeded parentheses around the arguments of ||. This reduces clutter and code behave in the same way. Change suggested by checkpatch.pl. vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < crtc->x' Signed-off-by: Shayenne da Luz Moura --- Changes in v2: - Make the com

Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-31 Thread Shayenne Moura
On 10/30, Sasha Levin wrote: > On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote: > > On 10/30, Greg Kroah-Hartman wrote: > > > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > > > > Remove unneeded parentheses around the arguments of ||. This reduces > > > > cl

Re: [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses

2018-10-31 Thread Hans de Goede
Hi, On 31-10-18 16:03, Shayenne da Luz Moura wrote: Remove unneeded parentheses around the arguments of ||. This reduces clutter and code behave in the same way. Change suggested by checkpatch.pl. vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < crtc->x' Signed-off-by: Sha

[PATCH v7 0/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface.

2018-10-31 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor Changes in v7: - Adds a level of indirection to read and write the gpio_desc to make the code simpler. - Drop gpioin flag which decides how the GPIOs are controlled as the GPIOs must be outputs for the host as per the

[PATCH v7 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-31 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 106 ++-- drivers/staging/iio/resolver/ad2s1210.h | 3 - 2 files changed, 62 insertions(+), 47 deletions(-) diff --git

[PATCH v7 2/3] staging: iio: ad2s1210: Drop the gpioin flag.

2018-10-31 Thread Nishad Kamdar
Drop gpioin flag which decides how the GPIOs are controlled as the GPIOs must be outputs for the host as per the datasheet. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 45 - drivers/staging/iio/resolver/ad2s1210.h | 17 -- 2 files ch

[PATCH v7 3/3] staging: iio: ad2s1210: Add device tree table.

2018-10-31 Thread Nishad Kamdar
Add device tree table for matching vendor ID. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index d3e7d5aad2c8..7c50def91a2b 10

[PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2018-10-31 Thread Nishad Kamdar
Convert the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of reimplementing the same. Signed-off-by: Nishad Kamdar --- drivers/staging/greybus/Kconfig | 1 + drivers/staging/greybus/gpio.c | 123 ++-- 2 files changed, 21 insertions(+), 103 del

[PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

2018-10-31 Thread Nishad Kamdar
Convert the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of reimplementing the same. Signed-off-by: Nishad Kamdar --- drivers/staging/greybus/Kconfig | 1 + drivers/staging/greybus/gpio.c | 123 ++-- 2 files changed, 21 insertions(+), 103 del

Re: [PATCH] staging: vt6656: clean up few indentation issues

2018-10-31 Thread Joe Perches
On Tue, 2018-10-30 at 11:13 +, Colin King wrote: > From: Colin Ian King > > Trivial fix to clean up indentation issues [] > diff --git a/drivers/staging/vt6656/main_usb.c > b/drivers/staging/vt6656/main_usb.c > index ccafcc2c87ac..b613a1d113bb 100644 > --- a/drivers/staging/vt6656/main_usb.c

RE: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-10-31 Thread Dexuan Cui
> From: Michael Kelley > Sent: Wednesday, October 24, 2018 08:38 > From: k...@linuxonhyperv.com Sent: Wednesday, > October 17, 2018 10:10 PM > > From: Dexuan Cui > > > > In kvp_send_key(), we do need call process_ib_ipinfo() if > > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it tu