Hi Kirill. Thanks for your comments.
> On 22 Oct 2018, at 23:25, Kirill Marinushkin wrote:
>
> AFAIU, this patch is wrong. Please correct me, maybe I misunderstand
> something.
>
>> The problem that this patch seeks to resolve is that when userland asks for
>> the delay
>
> The userspace asks
Hi Kiberly,
Thanks for adding all the emails in CC.
I would encourage you for your next patch to distinguish between CC and TO.
You should send your patch TO important maintainers in the get_maintainers.pl
list (as default, to all of them). If there is someone you really want to look
into the patc
gb_loopback_device::list_op_async is never used except for the
LIST_INIT. The ::list field appears to have a few more uses, but on
closer inspection the linked list of struct gb_loopbacks that it heads
is never used for anything, so there's no reason to maintain it, much
less to keep it sorted.
Re
On Wed, Oct 24, 2018 at 12:45:44PM +0200, Matthias Brugger wrote:
> Hi Kiberly,
>
> Thanks for adding all the emails in CC.
> I would encourage you for your next patch to distinguish between CC and TO.
> You should send your patch TO important maintainers in the get_maintainers.pl
> list (as defau
On Wed, Oct 24, 2018 at 12:45:44PM +0200, Matthias Brugger wrote:
> Hi Kiberly,
>
> Thanks for adding all the emails in CC.
> I would encourage you for your next patch to distinguish between CC and TO.
> You should send your patch TO important maintainers in the get_maintainers.pl
> list (as defau
On Wed, 24 Oct 2018, Russell King - ARM Linux wrote:
> On Wed, Oct 24, 2018 at 12:45:44PM +0200, Matthias Brugger wrote:
> > Hi Kiberly,
> >
> > Thanks for adding all the emails in CC.
> > I would encourage you for your next patch to distinguish between CC and TO.
> > You should send your patch
On Wed, Oct 24, 2018 at 02:06:18PM +0100, Julia Lawall wrote:
>
>
> On Wed, 24 Oct 2018, Russell King - ARM Linux wrote:
>
> > On Wed, Oct 24, 2018 at 12:45:44PM +0200, Matthias Brugger wrote:
> > > Hi Kiberly,
> > >
> > > Thanks for adding all the emails in CC.
> > > I would encourage you for y
Changes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
ni_mio devices to scale the result by the number of channels being used.
The user is already required to indicate which channels (and how many
obviously) are intended to be used. There is no point of not using this
information--t
On Wed, Oct 24, 2018 at 08:52:49AM +0200, Slawomir Stepien wrote:
> On paź 24, 2018 00:34, Nishad Kamdar wrote:
> > Use the gpiod interface instead of the deprecated old non-descriptor
> > interface.
>
> Hi Nishad
>
> Few more comments from me below.
>
> > Signed-off-by: Nishad Kamdar
> > ---
>
On Wed, Oct 24, 2018 at 07:59:45AM -0600, Spencer E. Olson wrote:
> Changes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
> ni_mio devices to scale the result by the number of channels being used.
I really can't understand this statement at all. What changes the
implementation?
>
On Wed, Oct 24, 2018 at 8:18 AM Dan Carpenter wrote:
>
> On Wed, Oct 24, 2018 at 07:59:45AM -0600, Spencer E. Olson wrote:
> > Changes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
> > ni_mio devices to scale the result by the number of channels being used.
>
> I really can't unders
Uses a single macro to define multiple macros that represent a series of
terminals for NI devices. This patch also redefines NI_MAX_COUNTERS as the
maximum number of counters possible on NI devices (instead of the maximum
index of the counters). This was a little confusing and caused a bug in
com
Fixes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
ni_mio devices. The previous patch should have used the channel
information passed in to scale the result by the number of channels being
used.
Fixes: 51fd36738383 ("staging: comedi: ni_mio_common: implement
INSN_CONFIG_GET_CMD_T
On Wed, Oct 24, 2018 at 08:26:51AM -0600, Spencer Olson wrote:
> On Wed, Oct 24, 2018 at 8:18 AM Dan Carpenter
> wrote:
> >
> > On Wed, Oct 24, 2018 at 07:59:45AM -0600, Spencer E. Olson wrote:
> > > Changes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
> > > ni_mio devices to scal
Use the gpiod interface instead of the deprecated old non-descriptor
interface.
Signed-off-by: Nishad Kamdar
---
Changes in v4:
- Add spaces after { and before } in gpios[]
initialization.
- Check the correct pointer for error.
- Align the dev_err msg to existing format in the code.
Changes
That works. Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
+(write_timeout >= 0) ? msecs_to_jiffies(write_timeout)
:
Signed-off-by: Aleksa Zdravkovic
---
drivers/staging/axis-fifo/axis-fifo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: k...@linuxonhyperv.com Sent: Wednesday, October
17, 2018 10:09 PM
>
> Currently we are replicating state in struct hv_context that is unnecessary -
> this state can be retrieved from the hypervisor. Furthermore, this is a
> per-cpu
> state that is being maintained as a global state in st
From: k...@linuxonhyperv.com Sent: Wednesday, October
17, 2018 10:10 PM
> From: Dexuan Cui
>
> In kvp_send_key(), we do need call process_ib_ipinfo() if
> message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out
> the userland hv_kvp_daemon needs the info of operation, adapter_id
On Mon, Oct 22, 2018 at 11:22:15PM +0530, Shreeya Patel wrote:
> On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote:
> > Use the gpiod interface instead of the deprecated old non-descriptor
> > interface for ldac_pin.
> >
> > Signed-off-by: Nishad Kamdar
> > ---
>
> Hi Nishad,
>
> I have be
On 24/10/18 15:33, Spencer E. Olson wrote:
Uses a single macro to define multiple macros that represent a series of
terminals for NI devices. This patch also redefines NI_MAX_COUNTERS as the
maximum number of counters possible on NI devices (instead of the maximum
index of the counters). This w
On Wed, Oct 24, 2018 at 10:39 AM Ian Abbott wrote:
>
> On 24/10/18 15:33, Spencer E. Olson wrote:
> > Uses a single macro to define multiple macros that represent a series of
> > terminals for NI devices. This patch also redefines NI_MAX_COUNTERS as the
> > maximum number of counters possible on
On 24/10/18 15:46, Spencer E. Olson wrote:
Fixes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
ni_mio devices. The previous patch should have used the channel
information passed in to scale the result by the number of channels being
used.
Fixes: 51fd36738383 ("staging: comedi: ni
Hello Mike,
On 10/24/18 10:20, Mike Brady wrote:
> Hi Kirill. Thanks for your comments.
>
>> On 22 Oct 2018, at 23:25, Kirill Marinushkin wrote:
>>
>> AFAIU, this patch is wrong. Please correct me, maybe I misunderstand
>> something.
>>
>>> The problem that this patch seeks to resolve is that w
Hi Kirill. Thanks again for your comments.
> On 24 Oct 2018, at 19:06, Kirill Marinushkin wrote:
>
> Hello Mike,
>
> On 10/24/18 10:20, Mike Brady wrote:
>> Hi Kirill. Thanks for your comments.
>>
>>> On 22 Oct 2018, at 23:25, Kirill Marinushkin
>>> wrote:
>>>
>>> AFAIU, this patch is wrong
Hello Mike,
We are not on the same page. What you hear is not what I tell you.
Either you don't understand what happens in your commit, or I don't understand
what happens in the driver.
Hopefully somebody in the community can comment here.
On 10/24/18 21:54, Mike Brady wrote:
You modify the
Changes do_insn*_ioctl functions to allow for data lengths for each
comedi_insn of up to 2^16. This patch also changes these functions to only
allocate as much memory as is necessary for each comedi_insn, rather than
allocating a fixed-sized scratch space.
In testing some user-space code for the
On Wed, Oct 24, 2018 at 05:05:53PM +0200, Aleksa Zdravkovic wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: line over 80 characters
> + (write_timeout >= 0) ? msecs_to_jiffies(write_timeout)
> :
>
> Signed-off-by: Aleksa Zdravkovic
> ---
> drivers/staging
On paź 24, 2018 20:20, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v4:
> - Add spaces after { and before } in gpios[]
>initialization.
> - Check the correct pointer for error.
>
29 matches
Mail list logo
