Re: [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks

On Fri, 5 Oct 2018 22:24:26 -0300 Matheus Tavares Bernardino wrote: > This patch fixes all "Assignment operator '=' should be on the previous > line" checks found in ad2s1210.c by checkpatch.pl. > > Signed-off-by: Matheus Tavares Hi Matheus, Good change, but unfortunately your email client as

Re: [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks

On Fri, Oct 05, 2018 at 10:24:26PM -0300, Matheus Tavares Bernardino wrote: > This patch fixes all "Assignment operator '=' should be on the previous > line" checks found in ad2s1210.c by checkpatch.pl. > > Signed-off-by: Matheus Tavares > --- As already pointed out tabs -> whitespace issue. I

Re: [PATCH v2 1/2] staging: iio: cdc: ad7150: use value copy to shorten the line length

On Fri, 5 Oct 2018 10:04:44 +0200 Slawomir Stepien wrote: > By using the copy of channel attribute, we can now make the lines short > enough to eliminate the checkpatch.pl problem: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Slawomir Stepien Applied to the togreg

Re: [PATCH v2 2/2] staging: iio: cdc: ad7150: fix misaligned lines

On Fri, 5 Oct 2018 10:05:15 +0200 Slawomir Stepien wrote: > These lines were misaligned, but the checkpatch.pl didn't indicate them > as such. > > Signed-off-by: Slawomir Stepien Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jo

Re: [PATCH] staging: iio: adt7316: fix parenthesis alignment

On Thu, 4 Oct 2018 20:06:55 -0300 Renato Lui Geh wrote: > This patch fixes all "Alignment should match open parenthesis" check > warnings found by checkpatch.pl in the addac/adt7316 driver. > > Signed-off-by: Renato Lui Geh Hi, Mostly good, but alignment doesn't override other considerations s

[PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style

Add the missing SPDX-License-Identifier tag to file to clear the checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH 02/11] staging:rtl8192u: Removed commented out include - Style

Remove commented out #include directive. Additionally shorted a block comment to clear the checkpatch issue with line length. These are coding style changes which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_modu

[PATCH 05/11] staging:rtl8192u: Add spaces around + operator - Style

Add spaces around '+' operator to clear the checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 11/11] staging:rtl8192u: Correct comparison with NULL - Style

Correct code to remote comparison with NULL, this clears the resulting checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 07/11] staging:rtl8192u: Correct code indentation - Style

Rewrite code block to correct the indentation of code. This clears the resulting checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++--- 1 file changed, 3 i

[PATCH 03/11] staging:rtl8192u: Clear error with line ending ( - Style

Rewrite function call to clear the checkpatch issue with lines ending with a '(' character. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++--- 1 file changed, 3 i

[PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style

Rewrite a test for NULL to comply with the coding style and clear the checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 00/11] staging:rtl8192u: Coding Style changes

Just a number of simple coding style changes in the file ieee80211_module.c John Whitmore (11): staging:rtl8192u: Add missing SPDX-License-Identifier - Style staging:rtl8192u: Removed commented out include - Style staging:rtl8192u: Clear error with line ending ( - Style staging:rtl8192u: R

[PATCH 04/11] staging:rtl8192u: Remove extra blank lines - Style

Remove the extra blank lines to clear checkpatch issue. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driver

[PATCH 08/11] staging:rtl8192u: Add missing blank lines - Style

Add missing blank lines after declarations. This clears the resulting checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 ++ 1 file changed, 2 insertion

[PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation - Style

Remove the unnecessary line continuation character to clear checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- 1 file changed, 1 insertion(+), 2 de

[PATCH 10/11] staging:rtl8192u: Correct code alignment - Style

Correct the alignment of a function, this clears checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/

Hi Andrew, Sorry for late. Just come back from holiday. Hi Ioana, Could you generate an additional patch for dpaa2_eth to address Andrew's comments? There was also a warning when checked patch. FSL_DPAA2_ETH needed more description. WARNING: please write a paragraph that describes the config

[PATCH v2] staging: iio: ad2s1210: fix 'assignment operator' style checks

This patch fixes all "Assignment operator '=' should be on the previous line" checks found in ad2s1210.c with checkpatch.pl. Signed-off-by: Matheus Tavares --- Changes in v2: In v1, tabs were accidentally converted to whitespaces. Now, tabs were preserved. drivers/staging/iio/resolver/ad2s1210.