Re: [PATCH] staging: vc04_services: Remove unused vchiq_genversion script

2018-09-22 Thread Stefan Wahren
> Tuomas Tynkkynen hat am 21. September 2018 um 21:56 > geschrieben: > > > As far as I can tell, this has never been used. > > Signed-off-by: Tuomas Tynkkynen Acked-by: Stefan Wahren ___ devel mailing list de...@linuxdriverproject.org http://dri

Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-22 Thread Grygorii Strashko
On 09/20/2018 07:32 AM, YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. > May

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

2018-09-22 Thread Dan Carpenter
The subject needs a subsystem prefix. It's also slightly long. [PATCH] Staging: rtlwifi: remove unnecessary NULL check regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

2018-09-22 Thread Karthik Nishanth
Do I submit a new patch with the modified subject? On Sat, Sep 22, 2018 at 03:44:32PM +0300, Dan Carpenter wrote: >The subject needs a subsystem prefix. It's also slightly long. > >[PATCH] Staging: rtlwifi: remove unnecessary NULL check > >regards, >dan carpenter > Karthik Nishanth

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

2018-09-22 Thread Dan Carpenter
On Sat, Sep 22, 2018 at 01:40:19PM +, Karthik Nishanth wrote: > Do I submit a new patch with the modified subject? > Yeah. Put [PATCH v2] in the subject and then at the end of the patch description put: Signed-off-by: Your Name --- v2: changed the subject. regards, dan carpenter

[PATCH v2] Staging: rtlwifi: remove unnecessary NULL check

2018-09-22 Thread Karthik Nishanth
The member regd of the struct rtl_priv is true in a boolean context. drivers/staging/rtlwifi/regd.c:413:27: warning: address of 'rtlpriv->regd' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!wiphy || !&rtlpriv->regd) ~ ~^~~~ 1 warning g

Re: [PATCH v2] Staging: rtlwifi: remove unnecessary NULL check

2018-09-22 Thread Dan Carpenter
Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next,v2,0/3] hv_netvsc: Support LRO/RSC in the vSwitch

2018-09-22 Thread David Miller
From: Haiyang Zhang Date: Fri, 21 Sep 2018 18:20:34 + > From: Haiyang Zhang > > The patch adds support for LRO/RSC in the vSwitch feature. It reduces > the per packet processing overhead by coalescing multiple TCP segments > when possible. The feature is enabled by default on VMs running on

Re: [PATCH v1 0/6] mm: online/offline_pages called w.o. mem_hotplug_lock

2018-09-22 Thread Balbir Singh
On Wed, Sep 19, 2018 at 09:35:07AM +0200, David Hildenbrand wrote: > Am 19.09.18 um 03:22 schrieb Balbir Singh: > > On Tue, Sep 18, 2018 at 01:48:16PM +0200, David Hildenbrand wrote: > >> Reading through the code and studying how mem_hotplug_lock is to be used, > >> I noticed that there are two pla

[PATCH v2] staging: rtlwifi: Use proper enumerated types for Wi-Fi only interface

2018-09-22 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:1264:34: warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]

Re: [PATCH] staging: rtlwifi: Use proper enumerated types for Wi-Fi only interface

2018-09-22 Thread Nathan Chancellor
On Fri, Sep 21, 2018 at 03:12:02PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:1264:34: warning: > implicit conversion from enumeration type 'enum btc_chip_interface' to > different