[PATCH 2/4] staging: vboxvideo: Skip currrent crtc when updating crtcs

2018-09-11 Thread Hans de Goede
In vbox_crtc_set_base_and_mode() we update all the crtcs when the single_framebuffer setting changes, including the one on which vbox_crtc_set_base_and_mode() was called, so we end up doing vbox_do_modeset() on it twice. This commit skips the crtc on which we are updating in the loop to update the

[PATCH 4/4] staging: vboxvideo: Drop vbox_bo_unref() helper

2018-09-11 Thread Hans de Goede
Drop the unnecessary vbox_bo_unref() helper and directly call ttm_bo_put() at the single call site. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_main.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/vboxvideo/vbox_main.c b/d

[PATCH 1/4] staging: vboxvideo: Fix modeset / page_flip error handling

2018-09-11 Thread Hans de Goede
The default settings for Linux vms created in VirtualBox allocate only 16M of videomem. When running fullscreen on a 1920x1080 (or bigger) monitor this is not a lot. When using GNOME3 on Wayland we have already been seeing out of video memory errors for a while now. After commit 2408898e3b6c ("sta

[PATCH 3/4] staging: vboxvideo: Remove vboxfb_create_object() wrapper

2018-09-11 Thread Hans de Goede
The vboxfb_create_object() wrapper really does nothing more then just call vbox_gem_create(), so this commit drops it, replacing it with a direct call to vbox_gem_create(). Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_fb.c | 22 +- 1 file changed, 1 inserti

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Dan Carpenter
On Tue, Sep 11, 2018 at 06:48:27AM +, Nicholas Mc Guire wrote: > On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > > Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > > drm_dev_register.") replaced the obsolere drm_get_pci_dev() with > > normal pci probe and remove

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Nicholas Mc Guire
On Tue, Sep 11, 2018 at 08:53:35AM +0200, Hans de Goede wrote: > Hi, > > On 11-09-18 08:48, Nicholas Mc Guire wrote: > >On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > >>Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > >>drm_dev_register.") replaced the obsolere dr

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Dan Carpenter
On Tue, Sep 11, 2018 at 07:41:10AM +, Nicholas Mc Guire wrote: > On Tue, Sep 11, 2018 at 08:53:35AM +0200, Hans de Goede wrote: > > Hi, > > > > On 11-09-18 08:48, Nicholas Mc Guire wrote: > > >On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > > >>Commit 1daddbc8dec5 ("staging: v

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Nicholas Mc Guire
On Tue, Sep 11, 2018 at 10:20:41AM +0300, Dan Carpenter wrote: > On Tue, Sep 11, 2018 at 06:48:27AM +, Nicholas Mc Guire wrote: > > On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > > > Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > > > drm_dev_register.") repla

Re: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()

2018-09-11 Thread Sebastian Andrzej Siewior
On 2018-09-10 21:08:38 [+], KY Srinivasan wrote: > It is in my queue; will submit it soon. thank you for letting me know. > K. Y Sebastian ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/

[PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Alexey Skidanov
Heap statistics have been removed and currently even basics statistics are missing. This patch creates per heap debugfs directory /sys/kernel/debug/ and adds the following counters: - the number of allocated buffers; - the number of allocated bytes; - the number of allocated bytes watermark. Sign

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-09-11 Thread gregkh
On Mon, Sep 10, 2018 at 04:08:36PM +0530, Ajay Singh wrote: > Hi Greg, > > On Tue, 14 Aug 2018 10:43:35 +0200 > gregkh wrote: > > > On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > > > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh > > > wrote: > > > > > > > > Hi Arnd, > > > > > > >

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-09-11 Thread Ajay Singh
On Tue, 11 Sep 2018 10:21:10 +0200 gregkh wrote: > On Mon, Sep 10, 2018 at 04:08:36PM +0530, Ajay Singh wrote: > > Hi Greg, > > > > On Tue, 14 Aug 2018 10:43:35 +0200 > > gregkh wrote: > > > > > On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > > > > On Tue, Aug 14, 2018 at

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Dan Carpenter
On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: > @@ -546,6 +556,38 @@ void ion_device_add_heap(struct ion_heap *heap) > } > > heap->dev = dev; > + heap->num_of_buffers = 0; > + heap->num_of_alloc_bytes = 0; > + heap->alloc_bytes_wm = 0; > + > + /* Cre

Re: [PATCH v9 0/9] Cedrus driver for the Allwinner Video Engine, using media requests

2018-09-11 Thread Maxime Ripard
On Fri, Sep 07, 2018 at 12:24:33AM +0200, Paul Kocialkowski wrote: > This is the ninth iteration of the updated Cedrus driver, > that supports the Video Engine found on most Allwinner SoCs, starting > with the A10. It was tested on the A13, A20, A33 and H3. > > The initial version of this driver[0

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Greg KH
On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: > On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: > > @@ -546,6 +556,38 @@ void ion_device_add_heap(struct ion_heap *heap) > > } > > > > heap->dev = dev; > > + heap->num_of_buffers = 0; > > + heap->num_of_

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Alexey Skidanov
On 09/11/2018 11:59 AM, Greg KH wrote: > On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: >> On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: >>> @@ -546,6 +556,38 @@ void ion_device_add_heap(struct ion_heap *heap) >>> } >>> >>> heap->dev = dev; >>> + he

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Dan Carpenter
On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote: > > > On 09/11/2018 11:59 AM, Greg KH wrote: > > On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: > >> On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: > >>> @@ -546,6 +556,38 @@ void ion_device_add_hea

Re: [PATCH v2 25/26] staging: wilc1000: refactor wilc_netdev_init() to handle memory free in error path

2018-09-11 Thread Claudiu Beznea
On 04.09.2018 09:39, Ajay Singh wrote: > Refactor the wilc_netdev_init() to cleanup the memory for error > scenario and remove unnecessary 'dev' pointer check. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/linux_wlan.c | 36 > --- > drivers/st

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Alexey Skidanov
On 09/11/2018 12:15 PM, Dan Carpenter wrote: > On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote: >> >> >> On 09/11/2018 11:59 AM, Greg KH wrote: >>> On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote:

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Greg KH
On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote: > > > On 09/11/2018 11:59 AM, Greg KH wrote: > > On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: > >> On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: > >>> @@ -546,6 +556,38 @@ void ion_device_add_hea

Re: [PATCH v2] staging: android: ion: Add per-heap counters

2018-09-11 Thread Alexey Skidanov
On 09/11/2018 12:31 PM, Greg KH wrote: > On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote: >> >> >> On 09/11/2018 11:59 AM, Greg KH wrote: >>> On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote: On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote: >

Re: [PATCH v2 25/26] staging: wilc1000: refactor wilc_netdev_init() to handle memory free in error path

2018-09-11 Thread Ajay Singh
Hi Claudiu, On Tue, 11 Sep 2018 12:21:13 +0300 Claudiu Beznea wrote: > On 04.09.2018 09:39, Ajay Singh wrote: > > Refactor the wilc_netdev_init() to cleanup the memory for error > > scenario and remove unnecessary 'dev' pointer check. > > > > Signed-off-by: Ajay Singh > > --- > > drivers/stag

[PATCH] erofs: option validation in remount

2018-09-11 Thread Chengguang Xu
Add option validation in remount. After this patch, remount can change recognized options, and for unknown options remount will fail and report error. Signed-off-by: Chengguang Xu --- drivers/staging/erofs/super.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/sta

Re: [PATCH] erofs: option validation in remount

2018-09-11 Thread Gao Xiang
Hi Chengguang, Thanks for your patch. The patch title should be "staging: erofs: " since erofs is still in staging. The same as your previous patch "erofs: surround fault_injection ralted option parsing using CONFIG_EROFS_FAULT_INJECTION". On 2018/9/11 18:51, Chengguang Xu wrote: > Add option v

[PATCH v3] staging: android: ion: Add per-heap counters

2018-09-11 Thread Alexey Skidanov
Heap statistics have been removed and currently even basics statistics are missing. This patch creates per heap debugfs directory /sys/kernel/debug/ and adds the following counters: - the number of allocated buffers; - the number of allocated bytes; - the number of allocated bytes watermark. Sign

[staging:staging-next 118/220] drivers/staging/erofs/unzip_vle.c:1003:1-7: preceding lock on line 839 (fwd)

2018-09-11 Thread Julia Lawall
I don't know if there is a problem here. Please check the lines mentiond below, ie lines 839 and 1003. julia -- Forwarded message -- Date: Tue, 11 Sep 2018 17:17:15 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [staging:staging-next 118/220] driv

Re: [staging:staging-next 118/220] drivers/staging/erofs/unzip_vle.c:1003:1-7: preceding lock on line 839 (fwd)

2018-09-11 Thread Gao Xiang
Hi Julia, There were lkp logs reporting that before, but I have no idea why it is reported. z_pagemap_global_lock is taken iff (pages = z_pagemap_global), and it is unlocked at > 3883a79a Gao Xiang 2018-07-26 987 if (pages == z_pagemap_global) > 3883a79a Gao Xiang 2018-07-26 988

Re: [staging:staging-next 118/220] drivers/staging/erofs/unzip_vle.c:1003:1-7: preceding lock on line 839 (fwd)

2018-09-11 Thread Julia Lawall
On Tue, 11 Sep 2018, Gao Xiang wrote: > Hi Julia, > > There were lkp logs reporting that before, but I have no idea why it is > reported. > z_pagemap_global_lock is taken iff (pages = z_pagemap_global), and it is > unlocked at > > > 3883a79a Gao Xiang 2018-07-26 987 if (pages == z_p

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-11 Thread Mauro Carvalho Chehab
Em Fri, 7 Sep 2018 00:24:38 +0200 Paul Kocialkowski escreveu: > From: Paul Kocialkowski > > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a V4L2 M2M decoder device and a media device (used for medi

Re: [PATCH] erofs: option validation in remount

2018-09-11 Thread cgxu519
On 09/11/2018 07:08 PM, Gao Xiang wrote: Hi Chengguang, Thanks for your patch. The patch title should be "staging: erofs: " since erofs is still in staging. Hi Xiang, Thanks for your review. I'll add the tag from next version. The same as your previous patch "erofs: surround fault_injectio

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-11 Thread Mauro Carvalho Chehab
Em Fri, 7 Sep 2018 00:24:38 +0200 Paul Kocialkowski escreveu: > From: Paul Kocialkowski > > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a V4L2 M2M decoder device and a media device (used for medi

Re: [PATCH] erofs: option validation in remount

2018-09-11 Thread Gao Xiang
Hi Chengguang, On 2018/9/11 23:37, cgxu519 wrote: > On 09/11/2018 07:08 PM, Gao Xiang wrote: >> Hi Chengguang, >> >> Thanks for your patch. >> >> The patch title should be "staging: erofs: " since erofs is still in staging. > Hi Xiang, > > Thanks for your review. I'll add the tag from next versio

Re: [PATCH v4] staging: erofs: use explicit unsigned int type

2018-09-11 Thread Chao Yu
On 2018/9/11 3:41, Thomas Weißschuh wrote: > Hi Chao, > > On Mon, 2018-09-10T23:59+0800, Chao Yu wrote: >> [...] > I was not aware of this tree and worked off of staging / next. A patch is attached to this message that adds the tree to the MAINTAINERS file. >>> >>> Hi Chao, >>> >>

Re: [PATCH v2] erofs: surround fault_injection ralted option parsing using CONFIG_EROFS_FAULT_INJECTION

2018-09-11 Thread Chao Yu
On 2018/9/11 7:51, Chengguang Xu wrote: > It's a little bit strange when fault_injection related > option fail with -EINVAL which was already disabled > from config, so surround all fault_injection related option > parsing code using CONFIG_EROFS_FAULT_INJECTION. Meanwhile, > slightly change warnin

[PATCH] staging: wilc1000: fix null checks on wilc

2018-09-11 Thread Colin King
From: Colin Ian King Currently the pointer wilc is being null checked several times and yet not checked for the final workqueue flush and destroy (which can lead to a null pointer dereference if wilc is null); these missing null checks were overlooked in an earlier core refactoring commit. Clean

Re: [PATCH 1/4] staging: vboxvideo: Fix modeset / page_flip error handling

2018-09-11 Thread Greg Kroah-Hartman
On Tue, Sep 11, 2018 at 09:15:41AM +0200, Hans de Goede wrote: > The default settings for Linux vms created in VirtualBox allocate only > 16M of videomem. When running fullscreen on a 1920x1080 (or bigger) monitor > this is not a lot. > > When using GNOME3 on Wayland we have already been seeing ou

Investment opportunity

2018-09-11 Thread Yi Tan
Greetings, I am contacting you for a proffer to invest in any profitable business in your country. We offer a quick loan at low interest rate. E-mail: yitanh...@gmail.com Sincerely: Yi Tan This email was sent by the shareware version of Post

Re: [PATCH 1/1] staging:rtl8192u: Rename dot11d_init to fix name clash

2018-09-11 Thread John Whitmore
On Mon, Sep 10, 2018 at 10:19:29AM +0200, Greg KH wrote: > On Tue, Sep 04, 2018 at 11:56:23AM +0100, John Whitmore wrote: > > The function dot11d_init() was previously renamed to clear a style > > issue. Unfortunately the new name used, dot11d_init(), clashes with > > a sybmol which is exported wit

Re: [PATCH 20/20] staging:rtl8192u: Rename OWN - Style

2018-09-11 Thread John Whitmore
On Mon, Sep 10, 2018 at 05:09:27PM +0200, Greg KH wrote: > On Sat, Sep 01, 2018 at 12:02:50AM +0100, John Whitmore wrote: > > Rename the member variable 'OWN' to 'own', this is to comply with the > > coding standard, where variables are named in lowercase. > > > > This is a simple coding style cha

Re: [PATCH] staging: rtl8188eu: change array type to u8

2018-09-11 Thread Joe Perches
On Mon, 2018-09-10 at 22:38 +0200, Michael Straube wrote: > The the last two parameters of write_cam() have type u8. > Change the type of the passed arrays from unsigned char to u8. > Clears a line over 80 characters checkpatch warning. > > Signed-off-by: Michael Straube > --- > drivers/staging/

RE: [PATCH 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support

2018-09-11 Thread Michael Kelley (EOSG)
From: Tianyu Lan Sent: Monday, September 10, 2018 1:39 AM > + > +int hyperv_flush_guest_mapping_range(u64 as, struct kvm_tlb_range *range) I'm really concerned about defining the Hyper-V function to flush guest mappings in terms of a KVM struct definition. Your patch puts this function in arch/x

[PATCH -next] staging: mt7621-pci: Use PTR_ERR_OR_ZERO in mt7621_pcie_parse_dt()

2018-09-11 Thread YueHaibing
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- drivers/staging/mt7621-pci/pci-mt7621.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index ba1f117

[PATCH 1/7] staging: erofs: code cleanup for erofs_kmalloc()

2018-09-11 Thread Chengguang Xu
Define a dummy function of time_to_inject(), so that we don't have to check macro CONFIG_EROFS_FAULT_INJECTION in calling place. Base on above adjustment, do proper code cleanup for erofs_kmalloc(). Signed-off-by: Chengguang Xu --- drivers/staging/erofs/internal.h | 16 ++-- 1 file c

[PATCH 0/7] staging: erofs: option validation for remount and some code cleanups

2018-09-11 Thread Chengguang Xu
This patch set mainly does option validation for remount and at the same time does related code cleanups. Currently when we call fault injection related code we have to surround it with macro CONFIG_EROFS_FAULT_INJECTION in every calling place, after this patch set we don't have to that, so the cod

[PATCH 4/7] staging: erofs: return -EINVAL when specifying fault rate to 0

2018-09-11 Thread Chengguang Xu
Set fault rate to 0 is useless and confusable, so add check to avoid it. Signed-off-by: Chengguang Xu --- drivers/staging/erofs/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c index d2dbc1fd3abb..8df680aee55a 100644 ---

[PATCH 3/7] staging: erofs: introduce a new helper __erofs_build_fault_attr()

2018-09-11 Thread Chengguang Xu
Introduce a new helper __erofs_build_fault_attr() to handle set/clear erofs_fault_info, we need this funciton for internal use case. for example, reset fault_injection option in remount. Signed-off-by: Chengguang Xu --- drivers/staging/erofs/super.c | 26 ++ 1 file change

[PATCH 6/7] staging: erofs: code cleanup for erofs_show_options()

2018-09-11 Thread Chengguang Xu
Call erofs_get_fault_rate() to get fault rate instead of directly getting it from sbi, so we can remove the macro check surrounding it. Signed-off-by: Chengguang Xu --- drivers/staging/erofs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/erofs/supe

[PATCH 5/7] staging: erofs: introduce a new helper erofs_get_fault_rate()

2018-09-11 Thread Chengguang Xu
Introduce a new helper for getting fault rate, so that we don't have to check macro in calling place. Signed-off-by: Chengguang Xu --- drivers/staging/erofs/super.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c index

[PATCH 7/7] staging: erofs: option validation in remount

2018-09-11 Thread Chengguang Xu
Add option validation in remount. After this patch, remount can change recognized options, and for unknown options remount will fail and report error. Signed-off-by: Chengguang Xu --- drivers/staging/erofs/super.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/staging

[PATCH 2/7] staging: erofs: code cleanup for option parsing of fault_injection

2018-09-11 Thread Chengguang Xu
Define a dummpy function of erofs_build_fault_attr() when macro CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to check the macro in calling place. Based on above adjustment, do proper code cleanup for option parsing of fault_injection. Signed-off-by: Chengguang Xu --- drivers/s

Re: [PATCH -next] staging: mt7621-pci: Use PTR_ERR_OR_ZERO in mt7621_pcie_parse_dt()

2018-09-11 Thread Sergio Paracuellos
On Wed, Sep 12, 2018 at 02:50:08AM +, YueHaibing wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Signed-off-by: YueHaibing > --- > drivers/staging/mt7621-pci/pci-mt7621.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/mt76

Re: [PATCH v4] staging: erofs: use explicit unsigned int type

2018-09-11 Thread Gao Xiang
Hi Thomas, On 2018/9/11 3:41, Thomas Weißschuh wrote: > Hi Chao, > > On Mon, 2018-09-10T23:59+0800, Chao Yu wrote: >> [...] I was not aware of this tree and worked off of staging / next. A patch is attached to this message that adds the tree to the MAINTAINERS file. >>> Hi Chao, >