Re: [PATCH 12/24] staging: wilc1000: move static variable 'terminated_handle' to wilc_vif struct

2018-08-24 Thread Claudiu Beznea
On 23.08.2018 17:36, Ajay Singh wrote: > On Thu, 23 Aug 2018 11:11:18 +0300 > Claudiu Beznea wrote: > >> On 14.08.2018 09:50, Ajay Singh wrote: >>> Remove the use of static variable 'terminated_handle' and instead >>> move in wilc_vif struct. >>> After moving this variable to wilc_vif struct i

Re: [PATCH 11/24] staging: wilc1000: move hif specific static variables to 'wilc' structure

2018-08-24 Thread Claudiu Beznea
On 23.08.2018 13:09, Ajay Singh wrote: > On Thu, 23 Aug 2018 11:11:09 +0300 > Claudiu Beznea wrote: > >> On 14.08.2018 09:50, Ajay Singh wrote: >>> Avoid use of static variable and move it in 'wilc' structure >>> related to hif and added NULL before accessing hif_workqueue in >>> wilc_enqueue_

Re: [PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

2018-08-24 Thread Claudiu Beznea
On 23.08.2018 12:43, Ajay Singh wrote: > The idea was to keep private data related to 'wiphy priv' > in 'wilc_priv' struct and 'netdev priv' related data in 'wilc_vif' > struct. OK, I see, agree! ___ devel mailing list de...@linuxdriverproject.org htt

Re: [PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

2018-08-24 Thread Claudiu Beznea
On 23.08.2018 13:00, Ajay Singh wrote: > Unless ndo_set_rx_mode() gets called quickly I don't think there is any > issue here. I don't agree with this. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailma

Re: [PATCH 20/24] staging: wilc1000: avoid line over 80 chars in tcp_process()

2018-08-24 Thread Claudiu Beznea
On 23.08.2018 13:33, Ajay Singh wrote: > On Thu, 23 Aug 2018 11:12:08 +0300 > Claudiu Beznea wrote: > >> On 14.08.2018 09:50, Ajay Singh wrote: >>> Cleanup patch to avoid line over 80 chars issue reported by >>> checkpatch.pl script. >>> >>> Signed-off-by: Ajay Singh >>> --- >>> drivers/stag

Re: [PATCH] staging: greybus: Fix null pointer dereference

2018-08-24 Thread Ding Xiang
Hi, Johan     sorry, it's my fault. On 8/24/2018 2:29 PM, Johan Hovold wrote: On Fri, Aug 24, 2018 at 12:07:11AM -0400, Ding Xiang wrote: If fw is null then fw->size will trigger null pointer dereference Signed-off-by: Ding Xiang --- drivers/staging/greybus/bootrom.c | 2 +- 1 file chang

Re: [PATCH] staging: greybus: Fix null pointer dereference

2018-08-24 Thread Dan Carpenter
On Fri, Aug 24, 2018 at 12:07:11AM -0400, Ding Xiang wrote: > If fw is null then fw->size will trigger null pointer dereference > > Signed-off-by: Ding Xiang > --- > drivers/staging/greybus/bootrom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybu

[PATCH] staging: comedi: drivers: dt3000: Fixes warning on multiline dereference.

2018-08-24 Thread Sven Luthi
Checkpatch complains about a pointer dereference on line 442-444 being split across multiple lines. Merged the pointer dereference into one line and moved it along with the other function call parameters onto the following line so it would fit without exceeding the 80 character line limit. Signed

[PATCH] staging: comedi: drivers: adl_pci9118: Fixes format of line 1283.

2018-08-24 Thread Sven Luthi
Checkpatch repored "Lines should not end with a '('" for line 1283. Moved opening parenthesis of function on line 1283 onto next line. Signed-off-by: Sven Luthi --- drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue

2018-08-24 Thread GuyLuz
From: Guy Luz Fixed a Lines should not end with a '(' issue. Signed-off-by: Guy Luz --- drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pci

Re: [PATCH 09/24] staging: wilc1000: move static variable clients_count to 'wilc' structure

2018-08-24 Thread Adham Abozaeid
On Thu, 23 Aug 2018 11:09:56 +0300 Claudiu Beznea wrote: > > > On 14.08.2018 09:50, Ajay Singh wrote: > > Avoid use of static variable 'clients_count' and move it part of 'wilc' > > structure. > > > > Signed-off-by: Ajay Singh > > --- > > drivers/staging/wilc1000/host_interface.c | 9 +++

Re: [PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

2018-08-24 Thread Adham Abozaeid
On Fri, 24 Aug 2018 11:47:14 +0300 Claudiu Beznea wrote: > > > On 23.08.2018 13:00, Ajay Singh wrote: > > Unless ndo_set_rx_mode() gets called quickly I don't think there is any > > issue here. > > I don't agree with this. It would be safer that the mcast list be passed to wilc_setup_multica