linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289: dead code block ?

Hello there, linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:282] -> [linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289]: (warning) Opposite inner 'if' condition leads to a dead code block. Source code is for (i = 0; i < num_records; i++) { if (memcmp(key, record[i].key, key_size))

Re: [PATCH 0/2] staging: vboxvideo: Add page-flip support

On Fri, Jul 20, 2018 at 10:17:29AM -0700, Steve Longerbeam wrote: > Adds crtc page-flip support by passing the new requested framebuffer > to vbox_crtc_do_set_base(). > > There is no attempt to support vblank interrupts, so this page-flip > implementation does not try to sync the page-flip to vert

Re: [PATCH] staging/vc04_services: Fix alignment of function arguments

Hi, Am 06.08.2018 um 06:07 schrieb Greg Gallagher: Fix warning generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only. Signed-off-by: Greg Gallagher --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- 1 file changed, 1 i

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

On Mon, Aug 06, 2018 at 09:49:01AM +0800, Jheng-Jhong Wu wrote: > So should I change this into a revert patch, or you will revert commit > 6efb21d6d0e7 ("staging:mt29f_spinand: MT29F2G failing as only 16 bits > used for addressing.") by yourself? > Thanks. > Are you asking me? I'm not going to r

Re: [PATCH v6 0/8] Cedrus driver for the Allwinner Video Engine, using media requests

Hi, On Sat, 2018-08-04 at 14:43 +0200, Hans Verkuil wrote: > On 07/25/2018 12:02 PM, Paul Kocialkowski wrote: > > This is the sixth iteration of the updated Cedrus driver, > > that supports the Video Engine found in most Allwinner SoCs, starting > > with the A10. It was tested on the A13, A20, A33

[PATCH] staging: most: do not show interface dependent attrs by default in sysfs

The channel attribute dbr_size is only relevant for the DIM2 interface. So is the packets_per_xact for USB. Currently, all attrs are shown by default in sysfs for any channel. To get a clean content of a channel directory, this patch makes the attributes show up only on the channel they belong to.

[PATCH] staging: comedi: ni_mio_common: fix subdevice flags for PFI subdevice

The PFI subdevice flags indicate that the subdevice is readable and writeable, but that is only true for the supported "M-series" boards, not the older "E-series" boards. Only set the SDF_READABLE and SDF_WRITABLE subdevice flags for the M-series boards. These two flags are mainly for information

Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

On Wednesday, July 25, 2018 8:01:47 PM CEST Kees Cook wrote: > On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote: > > On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> removes the discouraged use of AHASH_REQUEST

Re: [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range

Hi Greg, On Sun, 5 Aug 2018 16:11:17 +0200 Greg KH wrote: > On Fri, Aug 03, 2018 at 01:58:51PM +0530, Ajay Singh wrote: > > Hi Greg, > > > > On Thu, 2 Aug 2018 09:34:15 +0200 > > Greg KH wrote: > > > > > On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote: > > > > Cleanup patch to

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

Hi Dan, On Wed, 1 Aug 2018 15:05:51 +0300 Dan Carpenter wrote: > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > > are necessary to address the correct page. The driver sets the address for > > more

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

On Mon, Aug 06, 2018 at 01:46:48PM +0200, Boris Brezillon wrote: > Hi Dan, > > On Wed, 1 Aug 2018 15:05:51 +0300 > Dan Carpenter wrote: > > > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > > > are

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

On Mon, 6 Aug 2018 15:01:37 +0300 Dan Carpenter wrote: > On Mon, Aug 06, 2018 at 01:46:48PM +0200, Boris Brezillon wrote: > > Hi Dan, > > > > On Wed, 1 Aug 2018 15:05:51 +0300 > > Dan Carpenter wrote: > > > > > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > > > For NAN

Re: [PATCH] staging/vc04_services: Fix alignment of function arguments

Hi, On Mon, Aug 6, 2018 at 4:34 AM, Stefan Wahren wrote: > Hi, > > Am 06.08.2018 um 06:07 schrieb Greg Gallagher: >> >> Fix warning generated by checkpatch.pl for alignment should match open >> parenthesis. This is a coding style change only. >> >> Signed-off-by: Greg Gallagher >> --- >> driv

[PATCH] staging: rtl8188eu: remove unused array dB_Invert_Table

From: Colin Ian King Array dB_Invert_Table is declared but not used, hence it is redundant and can be removed. Cleans up clang warning: warning: ‘dB_Invert_Table’ defined but not used [-Wunused-const-variable=] Signed-off-by: Colin Ian King --- drivers/staging/rtl8188eu/hal/odm.c | 10 ---

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

Hi Hans and thanks for the review! On Sat, 2018-08-04 at 14:18 +0200, Hans Verkuil wrote: > Hi Paul, > > See below for my review comments. Mostly small fry, the main issue I found is > that there is no support for VIDIOC_DECODER_CMD. That's the proper way of > stopping a decoder. Don't rely on th

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

Hi Paul, On Mon, Aug 6, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Hi Hans and thanks for the review! > > On Sat, 2018-08-04 at 14:18 +0200, Hans Verkuil wrote: > > Hi Paul, > > > > See below for my review comments. Mostly small fry, the main issue I found > > is > > that there is no support

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

Hi, On Fri, 2018-08-03 at 17:49 -0300, Ezequiel Garcia wrote: > On Wed, 2018-07-25 at 12:02 +0200, Paul Kocialkowski wrote: > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented through > > a v4l2 m2m decoder devi

RE: linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289: dead code block ?

> -Original Message- > From: David Binderman > Sent: Monday, August 6, 2018 1:08 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subject: linux-4.18-rc8/tools/hv/hv_kvp_daemon.c:289: dead code block ? > >

[PATCH] Staging: One Laptop Per Child: fix SPDX-License-Identifier issue

Add SPDX-License-Identifier to the source files Signed-off-by: Arkadiusz Lis --- drivers/staging/olpc_dcon/olpc_dcon.c| 1 + drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 1 + drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/stag

[PATCH v2] Staging: One Laptop Per Child: fix SPDX-License-Identifier issue

Add SPDX-License-Identifier to the source files. Remove redundant, old license. Signed-off-by: Arkadiusz Lis --- drivers/staging/olpc_dcon/olpc_dcon.c| 5 + drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 5 + drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 5 + 3 files changed

[PATCH 00/11] Style Fixes on fbtft

I did some style fixes on staging/fbtft using scripts/checkpatch.pl. Please feel free to suggest any changes. Leonardo Brás (11): staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues - Style

[PATCH 02/11] staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_hx8347d.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 2 +- drivers/staging/fbtft/fb_ili9320.c | 2 +- drivers/staging/fbtft/fb_ili9325.c | 2 +- drivers/staging/fbtft/fb_ili9341.c | 2 +- drivers/staging/fbtft/fb_s6d1121.c

[PATCH 01/11] staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fbtft/fb_upd161704.c | 19 +-- drivers/staging/fbtft/fb_watterott.c | 4 ++-- 5 f

[PATCH 04/11] staging: fbtft: Adjust some empty-line problems - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_s6d02a1.c | 1 - drivers/staging/fbtft/fb_s6d1121.c | 1 + drivers/staging/fbtft/fb_ssd1289.c | 1 + drivers/staging/fbtft/fbtft_device.c | 2 -- 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb

[PATCH 03/11] staging: fbtft: Fixes some alignment and line > 80 char issues - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_ssd1289.c | 6 +-- drivers/staging/fbtft/fb_ssd1306.c | 3 +- drivers/staging/fbtft/fb_ssd1331.c | 9 - drivers/staging/fbtft/fb_ssd1351.c | 43 + drivers/staging/fbtft/fb_st7735r.c | 19 +++--- dri

[PATCH 07/11] staging: fbtft: Includes description to mutex and spinlock - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index d8e7204a8d74..3f3dcd96f9a7 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging/fb

[PATCH 09/11] staging: fbtft: Corrects long index line - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 8327f8f26ab1..99c8c9a636b5 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.

[PATCH 08/11] staging: fbtft: Add spaces around / - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index a9ee586ee6ba..4c71106d3b71 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/d

[PATCH 06/11] staging: fbtft: Fixes some defines styles - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 10 ++ drivers/staging/fbtft/fbtft-core.c | 6 -- drivers/staging/fbtft/fbtft.h | 4 ++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/f

[PATCH 05/11] staging: fbtft: Erases some repetitive usage of function name - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_sh1106.c | 2 +- drivers/staging/fbtft/fb_ssd1306.c | 2 +- drivers/staging/fbtft/fb_ssd1325.c | 2 +- drivers/staging/fbtft/fb_ssd1331.c | 2 +- drivers/staging/fbtft/fb_uc1611.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)

[PATCH 10/11] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 3f3dcd96f9a7..41ac00239aa3 100644 --- a/drivers/staging/fbtf

[PATCH 11/11] staging: fbtft: Includes parenthesis around macro parameters and avoids multiple usage of macro parameter - Style

Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 41ac00239aa3..eb2bdc4870be 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/dr

Re: [PATCH 01/11] staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style

We need a commit message here. On Tue, Aug 07, 2018 at 01:04:56AM -0300, Leonardo Brás wrote: > Signed-off-by: Leonardo Brás > --- > drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- > drivers/staging/fbtft/fb_ra8875.c | 4 ++-- > drivers/staging/fbtft/fb_tinylcd.c | 2 +- > drivers/s