Re: [PATCH V2 2/5] KVM: Add tlb remote flush callback in kvm_x86_ops.

2018-07-18 Thread Paolo Bonzini
On 09/07/2018 11:02, Tianyu Lan wrote: > + > + /* > + * Call kvm_arch_hv_tlb_remote first and go back old way when > + * return failure. > + */ Please call it "kvm_arch_flush_remote_tlbs", since Hyper-V should not be mentioned in the generic code. Paolo

Re: [PATCH V2 3/5] KVM/VMX: Add identical ept table pointer check

2018-07-18 Thread Paolo Bonzini
On 09/07/2018 11:02, Tianyu Lan wrote: > +static void check_ept_pointer(struct kvm_vcpu *vcpu, u64 eptp) > +{ > + struct kvm *kvm = vcpu->kvm; > + u64 tmp_eptp = INVALID_PAGE; > + int i; > + > + if (!kvm_x86_ops->tlb_remote_flush) > + return; > + > + spin_lock(&to_kv

Re: [PATCH V2 2/5] KVM: Add tlb remote flush callback in kvm_x86_ops.

2018-07-18 Thread Paolo Bonzini
On 09/07/2018 11:02, Tianyu Lan wrote: > + /* > + * Call kvm_arch_hv_tlb_remote first and go back old way when > + * return failure. > + */ > + if (!kvm_arch_hv_flush_remote_tlb(kvm)) > + return; > + > /* >* Read tlbs_dirty before setting KVM_REQ_TLB

Re: [PATCH V2 3/5] KVM/VMX: Add identical ept table pointer check

2018-07-18 Thread Tianyu Lan
On 7/18/2018 7:59 PM, Paolo Bonzini wrote: > On 09/07/2018 11:02, Tianyu Lan wrote: >> +static void check_ept_pointer(struct kvm_vcpu *vcpu, u64 eptp) >> +{ >> +struct kvm *kvm = vcpu->kvm; >> +u64 tmp_eptp = INVALID_PAGE; >> +int i; >> + >> +if (!kvm_x86_ops->tlb_remote_flush) >> +

Re: [PATCH V2 2/5] KVM: Add tlb remote flush callback in kvm_x86_ops.

2018-07-18 Thread Tianyu Lan
Hi Paolo: Thanks for review. On 7/18/2018 8:01 PM, Paolo Bonzini wrote: > On 09/07/2018 11:02, Tianyu Lan wrote: >> +/* >> + * Call kvm_arch_hv_tlb_remote first and go back old way when >> + * return failure. >> + */ >> +if (!kvm_arch_hv_flush_remote_tlb(kvm)) >> +

Re: [PATCH v7 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public

2018-07-18 Thread Andy Shevchenko
On Wed, Jul 18, 2018 at 5:49 AM, Baoquan He wrote: > reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c > and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c > so that it's shared. Some minor stuff. > +/** > + * reparent_resources - reparent resource childre

Re: [PATCH v7 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public

2018-07-18 Thread Andy Shevchenko
On Wed, Jul 18, 2018 at 7:36 PM, Andy Shevchenko wrote: > On Wed, Jul 18, 2018 at 5:49 AM, Baoquan He wrote: >> reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c >> and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c >> so that it's shared. >> + * Returns 0

Re: [PATCH net,v2] hv_netvsc: Fix napi reschedule while receive completion is busy

2018-07-18 Thread David Miller
From: Haiyang Zhang Date: Tue, 17 Jul 2018 17:11:13 + > From: Haiyang Zhang > > If out ring is full temporarily and receive completion cannot go out, > we may still need to reschedule napi if certain conditions are met. > Otherwise the napi poll might be stopped forever, and cause network >

Re: [PATCH v7 4/4] kexec_file: Load kernel at top of system RAM if required

2018-07-18 Thread Andrew Morton
On Wed, 18 Jul 2018 10:49:44 +0800 Baoquan He wrote: > For kexec_file loading, if kexec_buf.top_down is 'true', the memory which > is used to load kernel/initrd/purgatory is supposed to be allocated from > top to down. This is what we have been doing all along in the old kexec > loading interface

RE: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-18 Thread Leo Li
> -Original Message- > From: Roy Pledge > Sent: Monday, July 9, 2018 10:24 AM > To: Laurentiu Tudor ; > de...@driverdev.osuosl.org; linux-arm-ker...@lists.infradead.org; > gre...@linuxfoundation.org; Leo Li > Cc: Ioana Ciocoi Radulescu ; Horia Geanta > ; linux-ker...@vger.kernel.org; a.

Re: [PATCH resend] staging: gasket: remove X86 Kconfig restriction

2018-07-18 Thread kbuild test robot
Hi Todd, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20180718] [cannot apply to v4.18-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-18 Thread Jacob Feder
I hope I did the Makefile/Kconfig corretly :) Thanks for all the feedback. Cheers, Jacob This IP core has read and write AXI-Stream FIFOs, the contents of which can be accessed from the AXI4 memory-mapped interface. This is useful for transferring data from a processor into the FPGA fabric. The

Re: [PATCH resend] staging: gasket: remove X86 Kconfig restriction

2018-07-18 Thread Todd Poynor
On Wed, Jul 18, 2018 at 6:18 PM, kbuild test robot wrote: > Hi Todd, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on next-20180718] > [cannot apply to v4.18-rc5] > [if your patch is

Re: [PATCH 01/32] staging: gasket: remove X86 Kconfig restriction

2018-07-18 Thread kbuild test robot
Hi Todd, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20180718] [cannot apply to v4.18-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH 02/23] staging: wilc1000: remove enum connect_status instead use ieee80211_statuscode

2018-07-18 Thread Ajay Singh
Cleanup patch to remove the use of enum 'connect_status' and instead use predefined 'ieee80211_statuscode' for error code values. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 4 +++- drivers/staging/wilc1000/coreconfigurator.h | 20

[PATCH 01/23] staging: wilc1000: remove unused enum declaration

2018-07-18 Thread Ajay Singh
Cleanup patch to remove unused enums. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 8 drivers/staging/wilc1000/host_interface.h | 6 -- drivers/staging/wilc1000/wilc_wlan_if.h | 26 -- 3 files changed, 40 deletions(-) d

[PATCH 03/23] staging: wilc1000: remove extra enum defined for data rates

2018-07-18 Thread Ajay Singh
Cleanup patch to remove extra enum defined to handle data rates. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 16 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/staging/wilc1000/l

[PATCH 04/23] staging: wilc1000: remove extra enums defined for ieee80211_eid

2018-07-18 Thread Ajay Singh
Cleanup patch to make use of existing enum 'ieee80211_eid' instead of adding new enum in WILC for element ID's. The below mapping is same to remove extra enum in WILC. SUPP_RATES_IE -> WLAN_EID_SUPP_RATES EXT_SUPP_RATES_IE -> WLAN_EID_EXT_SUPP_RATES HT_CAPABILITY_IE-> WLAN

[PATCH 07/23] staging: wilc1000: rename enum SITESURVEY to use lowercase

2018-07-18 Thread Ajay Singh
Cleanup patch to have enum in lowercase as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 00/23] staging: wilc1000: cleanup patch to follow linux coding style

2018-07-18 Thread Ajay Singh
This patch series contains modification to follow Linux coding style & cleanup change to remove unused variables and enums. Few patches also contain changes to remove unnecessary typecast. Ajay Singh (23): staging: wilc1000: remove unused enum declaration staging: wilc1000: remove enum connect

[PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

2018-07-18 Thread Ajay Singh
Cleanup patch to avoid use of leading '_' in goto label name. Also used proper string for lable names. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 2 files changed, 6 insertions(+), 6 del

[PATCH 11/23] staging: wilc1000: removed unused element from wilc_cfg_frame struct

2018-07-18 Thread Ajay Singh
Cleanup up patch to remove the unused structure elements in 'wilc_cfg_frame' struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wlan.h index dbdebf0

[PATCH 15/23] staging: wilc1000: use single space before opening brances '{'

2018-07-18 Thread Ajay Singh
Cleanup patch to use single space instead of multiple space before the '{'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- drivers/stag

[PATCH 14/23] staging: wilc1000: remove unnecessary blank line between variable declaration

2018-07-18 Thread Ajay Singh
Cleanup patch to remove the unnecessary blank line between variables declaration inside the function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 1 - drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 10/23] staging: wilc1000: remove unnecessary elements from 'wilc_priv' struct

2018-07-18 Thread Ajay Singh
Remove unused elements from 'wilc_priv' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 7 --- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperatio

[PATCH 17/23] staging: wilc1000: avoid forward declaration for handle_scan_done()

2018-07-18 Thread Ajay Singh
Reorder the function position in host interface to avoid forward declaration of handle_scan_done(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 77 +++ 1 file changed, 38 insertions(+), 39 deletions(-) diff --git a/drivers/staging/wilc10

[PATCH 08/23] staging: wilc1000: rename enum AUTHTYPE to use lowercase

2018-07-18 Thread Ajay Singh
Cleanup patch to rename enum AUTHTYPE to lowercase. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- drivers/staging/wilc1000/wilc_

[PATCH 18/23] staging: wilc1000: avoid host_int_get_assoc_res_info() forward declaration

2018-07-18 Thread Ajay Singh
Reorder the function position in host interface to avoid forward declaration of host_int_get_assoc_res_info(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 47 ++- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/drivers/sta

[PATCH 12/23] staging: wilc1000: remove the mutliple #define used for same macro

2018-07-18 Thread Ajay Singh
Moved the same #define in common header file instead of having their declartion in different files. Below macros are moved to header file: TCP_ACK_FILTER_LINK_SPEED_THRESH DEFAULT_LINK_SPEED GET_PKT_OFFSET Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 3 ---

[PATCH 16/23] staging: wilc1000: remove unnecessary type used for wid id

2018-07-18 Thread Ajay Singh
Cleanup patch to remove unnecessary typecast used while assigning the WID ID. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 84 +++ 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 09/23] staging: wilc1000: remove unused elements in 'wilc' struct

2018-07-18 Thread Ajay Singh
Cleanup patch to remove unused elements from 'wilc' struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 drivers/staging/wilc1000/wilc_wlan.c | 6 -- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h

[PATCH 06/23] staging: wilc1000: rename enum CURRENT_TXRATE to use lowercase

2018-07-18 Thread Ajay Singh
Cleanup patch to rename enums in lowercase to follow linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/hos

[PATCH 19/23] staging: wilc1000: avoid forward declaration of host_int_parse_join_bss_param()

2018-07-18 Thread Ajay Singh
Reorder the functions position in host interface to avoid forward declaration of host_int_parse_join_bss_param(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 333 +++--- 1 file changed, 166 insertions(+), 167 deletions(-) diff --git a/driver

[PATCH 13/23] staging: wilc1000: use lowercase for 'IFC_UP' struct element name

2018-07-18 Thread Ajay Singh
Cleanup patch to use lowercase for structure element name to follow linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--

[PATCH 22/23] staging: wilc1000: remove unnecessary 'NULL' check from cfg80211_ops callbacks

2018-07-18 Thread Ajay Singh
Cleanup patch to remove the unnecessary 'NULL' check used in 'cfg80211_ops' callback functions. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b

[PATCH 20/23] staging: wilc1000: avoid setting default value for variable at declaration

2018-07-18 Thread Ajay Singh
Cleanup patch to avoid setting default value for local variables and also clubbed similar variables together. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 25 ++--- drivers/staging/wilc1000/host_interface.c | 122 +++--- drivers/stagi

[PATCH 23/23] staging: wilc1000: move variable assignment along with its declaration

2018-07-18 Thread Ajay Singh
Cleanup patch to club the variable assignment along with the variable declaration especially for private data. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 7 +- drivers/staging/wilc1000/linux_wlan.c | 113 +++ drivers/staging/wilc1000/w

[PATCH 21/23] staging: wilc1000: use 'int' inplace of 's32' date type

2018-07-18 Thread Ajay Singh
Cleanup patch to use 'int' instead of 's32' to have the same data type based on its usage. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 48 +++ drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 28 ++--- 2 files changed, 38 inser